56122 2011-03-10 10:40:03 -0800 Remove unnecessary function WebPlugin::getBackingTextureId 2011-03-15 10:14:42 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 alokp alokp commit-queue dglazkov jamesr piman vangelis oldest_to_newest 365301 0 alokp 2011-03-10 10:40:03 -0800 WebPlugin::getBackingTextureId is not required anymore. We use WebPluginContainer::setBackingTextureId now. 365307 1 85349 alokp 2011-03-10 10:47:40 -0800 Created attachment 85349 proposed patch 365312 2 piman 2011-03-10 10:55:20 -0800 LGTM FWIW 367195 3 alokp 2011-03-14 13:50:41 -0700 ping! 367685 4 alokp 2011-03-15 09:00:43 -0700 Hi James: Please review. 367718 5 85349 jamesr 2011-03-15 09:48:46 -0700 Comment on attachment 85349 proposed patch FYI getters in WebKit should not have a "get"prefix (it should be "textureId()", not getTextureId(). 367741 6 85349 commit-queue 2011-03-15 10:14:38 -0700 Comment on attachment 85349 proposed patch Clearing flags on attachment: 85349 Committed r81143: <http://trac.webkit.org/changeset/81143> 367742 7 commit-queue 2011-03-15 10:14:42 -0700 All reviewed patches have been landed. Closing bug. 85349 2011-03-10 10:47:40 -0800 2011-03-15 10:14:37 -0700 proposed patch texture.txt text/plain 2357 alokp SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gODA3MzYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMTAgIEFsb2sg cHJpeWFkYXJzaGkgIDxhbG9rcEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHVubmVjZXNzYXJ5IGZ1bmN0aW9uIFdl YlBsdWdpbjo6Z2V0QmFja2luZ1RleHR1cmVJZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTYxMjIKKworICAgICAgICBJdCB3aWxsIGJlIHRlc3RlZCBi eSBQZXBwZXIyRCBhbmQgUGVwcGVyM0QgbGF5b3V0L3Ntb2tlIHRlc3RzCisgICAgICAgIG9uIHRo ZSBDaHJvbWl1bSBzaWRlLgorCisgICAgICAgICogcHVibGljL1dlYlBsdWdpbi5oOgorICAgICAg ICAqIHNyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi UGx1Z2luQ29udGFpbmVySW1wbDo6cGxhdGZvcm1MYXllcik6CisKIDIwMTEtMDMtMTAgIEFuZHJl eSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZ dXJ5IFNlbWlraGF0c2t5LgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQbHVnaW4u aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdpbi5oCShyZXZp c2lvbiA4MDYzMSkKKysrIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUGx1Z2luLmgJKHdvcmtp bmcgY29weSkKQEAgLTY0LDEwICs2NCw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgdXBk YXRlR2VvbWV0cnkoCiAgICAgICAgIGNvbnN0IFdlYlJlY3QmIGZyYW1lUmVjdCwgY29uc3QgV2Vi UmVjdCYgY2xpcFJlY3QsCiAgICAgICAgIGNvbnN0IFdlYlZlY3RvcjxXZWJSZWN0PiYgY3V0T3V0 c1JlY3RzLCBib29sIGlzVmlzaWJsZSkgPSAwOwotICAgIAotICAgIC8vIElmIHRoZSBwbHVnaW4g aW5zdGFuY2UgaXMgYmFja2VkIGJ5IGFuIE9wZW5HTCB0ZXh0dXJlLCByZXR1cm4gaXRzIElEIGlu IHRoZQotICAgIC8vIGNvbXBvc2l0b3JzIG5hbWVzcGFjZS4gT3RoZXJ3aXNlIHJldHVybiAwLiBS ZXR1cm5zIDAgYnkgZGVmYXVsdC4KLSAgICB2aXJ0dWFsIHVuc2lnbmVkIGdldEJhY2tpbmdUZXh0 dXJlSWQoKSB7IHJldHVybiAwOyB9CiAKICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlRm9jdXMoYm9v bCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVWaXNpYmlsaXR5KGJvb2wpID0gMDsKSW5k ZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcAko cmV2aXNpb24gODA2MzEpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5l ckltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NDMsMTUgKzQ0Myw3IEBAIHZvaWQgV2ViUGx1 Z2luQ29udGFpbmVySW1wbDo6d2lsbERlc3Ryb3kKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9T SVRJTkcpCiBXZWJDb3JlOjpMYXllckNocm9taXVtKiBXZWJQbHVnaW5Db250YWluZXJJbXBsOjpw bGF0Zm9ybUxheWVyKCkgY29uc3QKIHsKLSAgICAvLyBGSVhNRTogSW4gdGhlIGV2ZW50IG9mIGEg Y29udGV4dCBsb3N0LCB0aGUgdGV4dHVyZSBuZWVkcyB0byBiZSByZWNyZWF0ZWQgb24gdGhlIGNv bXBvc2l0b3IncwotICAgIC8vIGNvbnRleHQgYW5kIHJlYm91bmQgdG8gdGhlIHBsYXRmb3JtIGxh eWVyIGhlcmUuCi0gICAgdW5zaWduZWQgYmFja2luZ1RleHR1cmVJZCA9IG1fd2ViUGx1Z2luLT5n ZXRCYWNraW5nVGV4dHVyZUlkKCk7Ci0gICAgaWYgKCFiYWNraW5nVGV4dHVyZUlkKQotICAgICAg ICByZXR1cm4gMDsKLQotICAgIG1fcGxhdGZvcm1MYXllci0+c2V0VGV4dHVyZUlkKGJhY2tpbmdU ZXh0dXJlSWQpOwotCi0gICAgcmV0dXJuIG1fcGxhdGZvcm1MYXllci5nZXQoKTsKKyAgICByZXR1 cm4gbV9wbGF0Zm9ybUxheWVyLT5nZXRUZXh0dXJlSWQoKSA/IG1fcGxhdGZvcm1MYXllci5nZXQo KSA6IDA7CiB9CiAjZW5kaWYKIAo=