56098 2011-03-10 07:12:58 -0800 [Qt] MSVC Build Error - need to link advapi32.lib for jsc.exe 2011-03-25 08:29:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Windows 7 RESOLVED FIXED Qt, QtTriaged P1 Critical --- 0 jarred webkit-unassigned benjamin commit-queue jturcotte menard oldest_to_newest 365147 0 jarred 2011-03-10 07:12:58 -0800 OSRandomnSource.cpp utilizes the Crypto API found in advapi32. Linker error when linking jsc.exe (against jscore.lib), needs to include advapi32.lib in jsc.pro. 365151 1 85321 jarred 2011-03-10 07:18:00 -0800 Created attachment 85321 Proposed patch 365349 2 menard 2011-03-10 11:31:48 -0800 I wonder why it does not happen on my windows XP. 365358 3 jarred 2011-03-10 11:34:39 -0800 (In reply to comment #2) > I wonder why it does not happen on my windows XP. You are building the Qt port? "perl build-webkit --qt --release" VC++ 9 reports unresolved symbols when linking jsc.exe, requiring an explicit addition of advapi32.lib on the link command line. `#pragma comment(lib, "advapi32")` works as well. 365365 4 menard 2011-03-10 11:43:05 -0800 (In reply to comment #3) > (In reply to comment #2) > > I wonder why it does not happen on my windows XP. > > You are building the Qt port? :) Yep. > > "perl build-webkit --qt --release" > > VC++ 9 reports unresolved symbols when linking jsc.exe, requiring an explicit addition of advapi32.lib on the link command line. `#pragma comment(lib, "advapi32")` works as well. VC++ 9 is the one included with Visual Studio 2010 express right? Because I'm building with the one in Visual Studio 2008. Perhaps that explain. 365383 5 jarred 2011-03-10 11:52:59 -0800 (In reply to comment #4) > > VC++ 9 reports unresolved symbols when linking jsc.exe, requiring an explicit addition of advapi32.lib on the link command line. `#pragma comment(lib, "advapi32")` works as well. > > VC++ 9 is the one included with Visual Studio 2010 express right? Because I'm building with the one in Visual Studio 2008. Perhaps that explain. Interestingly enough, no :) VC9 is 2008, VC10 is 2010. So we're using the same version of Express. 367181 6 85321 ariya.hidayat 2011-03-14 13:33:41 -0700 Comment on attachment 85321 Proposed patch LGTM. re=me 367392 7 85321 commit-queue 2011-03-14 17:54:52 -0700 Comment on attachment 85321 Proposed patch Rejecting attachment 85321 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1 Last 500 characters of output: rm/gtk/Skipped M LayoutTests/platform/win/Skipped M LayoutTests/platform/mac/Skipped A LayoutTests/fast/forms/interactive-validation-select-crash-expected.txt A LayoutTests/fast/forms/interactive-validation-select-crash.html M LayoutTests/ChangeLog M Source/WebCore/ChangeLog M Source/WebCore/rendering/RenderBlock.cpp r81088 = 32441d26af2feea641046d75af74f9441dbcbe92 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8175430 367413 8 jarred 2011-03-14 18:25:59 -0700 I was cavalier with the patch and didn't leave an Unreviewed line. Can this get committed manually? Otherwise I'll reupload tomorrow. 373528 9 benjamin 2011-03-25 08:29:10 -0700 Committed r81963: <http://trac.webkit.org/changeset/81963> 85321 2011-03-10 07:18:00 -0800 2011-03-14 17:54:52 -0700 Proposed patch msvc-osrandom-build-error.patch text/plain 980 jarred ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGUzMGVkYjQuLjJlYmYxYTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTAzLTEwICBKYXJyZWQgTmljaG9s bHMgIDxqYXJyZWRAc2VuY2hhLmNvbT4KKworICAgICAgICBbUXRdIE1TVkMgQnVpbGQgRXJyb3Ig LSBuZWVkIHRvIGxpbmsgYWR2YXBpMzIubGliIGZvciBqc2MuZXhlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjA5OAorCisgICAgICAgIE5lZWQgdG8g bGluayBhZHZhcGkzMi5saWIgZm9yIGpzYy5leGUgc2luY2Ugd3RmL09TUmFuZG9tU291cmNlLmNw cCB1c2VzIHRoZSBXaW4zMiBDcnlwdG8gQVBJCisKKyAgICAgICAgKiBqc2MucHJvOgorCiAyMDEx LTAzLTA5ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAcmltLmNvbT4KIAogICAgICAgICBBdHRlbXB0 IHRvIGZpeCB0aGUgV2luQ0UgYnVpbGQgYWZ0ZXIgY2hhbmdlc2V0IDgwNjg0IDxodHRwOi8vdHJh Yy53ZWJraXQub3JnL2NoYW5nZXNldC84MDY4ND4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qc2MucHJvIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5wcm8KaW5kZXggYTU1 MGM0OC4uNGExMTg2OCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5wcm8K KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5wcm8KQEAgLTI3LDYgKzI3LDEwIEBAIG1h YyB7CiAgICAgTElCU19QUklWQVRFICs9IC1mcmFtZXdvcmsgQXBwS2l0CiB9CiAKK3dpbiogewor ICAgIExJQlMgKz0gYWR2YXBpMzIubGliCit9CisKIHdpbmNlKiB7CiAgICAgTElCUyArPSBtbXRp bWVyLmxpYgogfQo=