56089 2011-03-10 04:12:42 -0800 [GTK] run-gtk-tests doesn't fail if a test crashes 2011-03-10 07:12:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned abarth eric gustavo webkit.review.bot oldest_to_newest 365093 0 pnormand 2011-03-10 04:12:42 -0800 One test crashing for a week and a green "unittests" box in the waterfall... See also https://bugs.webkit.org/show_bug.cgi?id=56083 365097 1 85307 pnormand 2011-03-10 04:18:58 -0800 Created attachment 85307 proposed patch 365113 2 85307 gustavo 2011-03-10 05:50:44 -0800 Comment on attachment 85307 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=85307&action=review > Tools/Scripts/run-gtk-tests:41 > + if (!$exitStatus && $?) { > + $exitStatus = $?; No need to check whether exitstatus is already set, I think, just check that $? is non-zero and assign unconditionally. 365125 3 pnormand 2011-03-10 06:14:21 -0800 Committed r80712: <http://trac.webkit.org/changeset/80712> 365144 4 webkit.review.bot 2011-03-10 07:07:51 -0800 http://trac.webkit.org/changeset/80712 might have broken GTK Linux 64-bit Debug 365146 5 pnormand 2011-03-10 07:12:57 -0800 (In reply to comment #4) > http://trac.webkit.org/changeset/80712 might have broken GTK Linux 64-bit Debug It was broken already before, this patch just unveiled previously undetected redness. 85307 2011-03-10 04:18:58 -0800 2011-03-10 05:50:44 -0800 proposed patch proposed-patch.patch text/plain 1634 pnormand RnJvbSAzNGQ2ODU5MWViMDEwMDg1NjQ0NjRiOTM4NTE2MWRhNGZlNTRlYzBmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDEwIE1hciAyMDExIDEzOjIwOjA5ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgIHwgICAxMiAr KysrKysrKysrKysKIFRvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cyB8ICAgMTUgKysrKysrKysr KysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDg4 NWRkZTcuLmI4NWVmZTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMy0xMCAgUGhpbGlwcGUgTm9ybWFuZCAg PHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW0dUS10gcnVuLWd0ay10ZXN0cyBkb2Vzbid0IGZhaWwgaWYgYSB0ZXN0 IGNyYXNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU2MDg5CisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1ndGstdGVzdHM6IGd0ZXN0ZXIgLWsgZXhp dHMgd2l0aCBhIDAgZXhpdCBzdGF0dXMKKyAgICAgICAgZXZlbiBpZiBhIHRlc3QgY3Jhc2hlcy4g U28gcnVuIHRoZSB0ZXN0cyBpbmRpdmlkdWFsbHkgYW5kIGlmIGEKKyAgICAgICAgdGVzdCBmYWls cyByZW1lbWJlciBpdHMgZXhpdCBjb2RlIHNvIHJ1bi1ndGstdGVzdCBmYWlscyB0b28sIGlmCisg ICAgICAgIHJlcXVpcmVkLgorCiAyMDExLTAxLTI2ICBKb2huIEtub3R0ZW5iZWx0ICA8amtub3R0 ZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERtaXRyeSBUaXRvdi4KZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVu LWd0ay10ZXN0cwppbmRleCA5YTU3MzE5Li45ZjJlOTU3IDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3J1bi1ndGstdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCkBAIC0z Miw0ICszMiwxNyBAQCBteSBAdW5pdFRlc3RzID0gZ2xvYiAgJHByb2R1Y3REaXIgLiAiL1Byb2dy YW1zL3VuaXR0ZXN0cy8qIjsKIGlmICgkI3VuaXRUZXN0cyA8IDEpIHsKICAgICBkaWUgIkVSUk9S OiB0ZXN0cyBub3QgZm91bmQgaW4gJHByb2R1Y3REaXIuXG4iOwogfQotc3lzdGVtICJndGVzdGVy IC1rIEB1bml0VGVzdHMiCisKK215ICRleGl0U3RhdHVzID0gMDsKK2ZvcmVhY2ggbXkgJHVuaXRU ZXN0IChAdW5pdFRlc3RzKQoreworICAgIHN5c3RlbSAiZ3Rlc3RlciAkdW5pdFRlc3QiOworICAg IGlmICghJGV4aXRTdGF0dXMgJiYgJD8pIHsKKyAgICAgICAgJGV4aXRTdGF0dXMgPSAkPzsKKyAg ICB9Cit9CisKK2lmICgkZXhpdFN0YXR1cykgeworICAgIHByaW50ICJUZXN0cyBmYWlsZWRcbiI7 CisgICAgZXhpdCAkZXhpdFN0YXR1czsKK30KLS0gCjEuNy40LjE=