56083 2011-03-10 02:14:50 -0800 [GTK] unittests/testapplicationcache crashes 2011-04-24 00:41:02 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned l.slachciak mrobinson xan.lopez oldest_to_newest 365056 0 pnormand 2011-03-10 02:14:50 -0800 #0 0x00007fe8e57d4916 in WebCore::ApplicationCacheStorage::setCacheDirectory (this=0x1dc8230, cacheDirectory=...) at ../../Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:359 359 ASSERT(m_cacheDirectory.isNull()); Thread 1 (Thread 7535): #0 0x00007fe8e57d4916 in WebCore::ApplicationCacheStorage::setCacheDirectory (this=0x1dc8230, cacheDirectory=...) at ../../Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:359 #1 0x00007fe8e5203411 in webkit_application_cache_set_database_directory_path (path=0x1e6e430 "/home/slave/.local/share/webkit/databases") at ../../Source/WebKit/gtk/webkit/webkitapplicationcache.cpp:118 #2 0x0000000000400ed9 in test_application_cache_database_directory_path () at ../../Source/WebKit/gtk/tests/testapplicationcache.c:46 #3 0x00007fe8e19d48e3 in test_case_run (suite=0x1d99ba0, path=0x7fe8e1a21c5e "") at /tmp/buildd/glib2.0-2.27.91/./glib/gtestutils.c:1174 #4 g_test_run_suite_internal (suite=0x1d99ba0, path=0x7fe8e1a21c5e "") at /tmp/buildd/glib2.0-2.27.91/./glib/gtestutils.c:1223 #5 0x00007fe8e19d4a56 in g_test_run_suite_internal (suite=<value optimized out>, path=0x7fe8e1a21c5e "") at /tmp/buildd/glib2.0-2.27.91/./glib/gtestutils.c:1233 #6 0x00007fe8e19d4a56 in g_test_run_suite_internal (suite=<value optimized out>, path=0x7fe8e1a21c5e "") at /tmp/buildd/glib2.0-2.27.91/./glib/gtestutils.c:1233 #7 0x00007fe8e19d4d3b in g_test_run_suite (suite=0x1d99b20) at /tmp/buildd/glib2.0-2.27.91/./glib/gtestutils.c:1282 #8 0x0000000000400ff0 in main (argc=1, argv=0x7fff53873978) at ../../Source/WebKit/gtk/tests/testapplicationcache.c:70 365058 1 pnormand 2011-03-10 02:17:10 -0800 First failed build: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/20138 http://trac.webkit.org/changeset/80561 365059 2 pnormand 2011-03-10 02:21:39 -0800 Sorry Christian, doesn't seem to be your patch. 365063 3 pnormand 2011-03-10 02:43:23 -0800 Lukasz, the testapplicationcache has been crashing since its checkin in r80225. Did it ever run fine for you? in Debug build? 365076 4 pnormand 2011-03-10 03:23:06 -0800 webkit_application_cache_set_database_directory_path() is called twice, once in webkitInit() and once in the test itself. To avoid the ASSERT the test should probably clear the path before setting it again. Or it could be done directly in webkit_application_cache_set_database_directory_path(). 365080 5 pnormand 2011-03-10 03:38:48 -0800 The mac port calls cacheStorage().setCacheDirectory() once only in all application life-time and I think we should do the same and not expose an API to modify the cache directory as there's no API to clear m_cacheDirectory in ApplicationCacheStorage. 365082 6 pnormand 2011-03-10 03:39:53 -0800 CCing Xan as he reviewed the original patch. 365132 7 85316 pnormand 2011-03-10 06:46:56 -0800 Created attachment 85316 proposed patch 365135 8 85316 xan.lopez 2011-03-10 06:48:25 -0800 Comment on attachment 85316 proposed patch Thank you. 365138 9 pnormand 2011-03-10 06:52:38 -0800 Committed r80715: <http://trac.webkit.org/changeset/80715> 391566 10 l.slachciak 2011-04-24 00:41:02 -0700 Thx Philippe for fix. I was testing it on the release build and everything seemed OK. I'm sorry for problems. 85316 2011-03-10 06:46:56 -0800 2011-03-10 06:48:24 -0800 proposed patch proposed-patch.patch text/plain 5962 pnormand RnJvbSA1ZWYxNjAzMTY2ODJiZjJhYjY1OTc0OGYxMDUwYWQ4NTUzY2VkNDc2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDEwIE1hciAyMDExIDE1OjQ3OjIxICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDE5ICsrKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQvZ3RrL3Rl c3RzL3Rlc3RhcHBsaWNhdGlvbmNhY2hlLmMgICAgIHwgICAyMSAtLS0tLS0tLS0tLS0tLS0KIC4u Li9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRhcHBsaWNhdGlvbmNhY2hlLmNwcCAgIHwgICAyOCAr LS0tLS0tLS0tLS0tLS0tLS0tLQogU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGFwcGxp Y2F0aW9uY2FjaGUuaCAgfCAgICAzIC0tCiBTb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 Z2xvYmFscy5jcHAgICAgICAgICB8ICAgIDIgKy0KIDUgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0 aW9ucygrKSwgNTIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDQwOGRhYjUuLmFk MWMwYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMS0wMy0xMCAgUGhp bGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gdW5pdHRlc3RzL3Rlc3RhcHBsaWNh dGlvbmNhY2hlIGNyYXNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU2MDgzCisKKyAgICAgICAgUmVtb3ZlZCB0aGUgd2Via2l0X2FwcGxpY2F0aW9u X2NhY2hlX2dldF9kYXRhYmFzZV9kaXJlY3RvcnlfcGF0aAorICAgICAgICBBUEkgYXMgdGhlIHVu ZGVybHlpbmcgQXBwbGljYXRpb25DYWNoZVN0b3JhZ2UgZG9lc24ndCBhbGxvdworICAgICAgICBz ZXR0aW5nIHRoZSBjYWNoZSBwYXRoIG11bHRpcGxlIHRpbWVzLgorCisgICAgICAgICogdGVzdHMv dGVzdGFwcGxpY2F0aW9uY2FjaGUuYzoKKyAgICAgICAgKG1haW4pOgorICAgICAgICAqIHdlYmtp dC93ZWJraXRhcHBsaWNhdGlvbmNhY2hlLmNwcDoKKyAgICAgICAgKHdlYmtpdF9hcHBsaWNhdGlv bl9jYWNoZV9nZXRfZGF0YWJhc2VfZGlyZWN0b3J5X3BhdGgpOgorICAgICAgICAqIHdlYmtpdC93 ZWJraXRhcHBsaWNhdGlvbmNhY2hlLmg6CisgICAgICAgICogd2Via2l0L3dlYmtpdGdsb2JhbHMu Y3BwOgorICAgICAgICAod2Via2l0SW5pdCk6CisKIDIwMTEtMDMtMDkgIFBldGVyIEthc3Rpbmcg IDxwa2FzdGluZ0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1paGFpIFBhcnBh cml0YS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RhcHBsaWNhdGlv bmNhY2hlLmMgYi9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0YXBwbGljYXRpb25jYWNoZS5j CmluZGV4IDU1ZTM2MGMuLjJiMDIyZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3Rl c3RzL3Rlc3RhcHBsaWNhdGlvbmNhY2hlLmMKKysrIGIvU291cmNlL1dlYktpdC9ndGsvdGVzdHMv dGVzdGFwcGxpY2F0aW9uY2FjaGUuYwpAQCAtMzcsMjUgKzM3LDYgQEAgc3RhdGljIHZvaWQgdGVz dF9hcHBsaWNhdGlvbl9jYWNoZV9tYXhpbXVtX3NpemUoKQogICAgIGdfYXNzZXJ0KG1heFNpemUg PT0gd2Via2l0X2FwcGxpY2F0aW9uX2NhY2hlX2dldF9tYXhpbXVtX3NpemUoKSk7CiB9CiAKLXN0 YXRpYyB2b2lkIHRlc3RfYXBwbGljYXRpb25fY2FjaGVfZGF0YWJhc2VfZGlyZWN0b3J5X3BhdGgo KQotewotICAgIHVuc2lnbmVkIGxvbmcgbG9uZyBtYXhTaXplID0gODE5MjsKLSAgICB3ZWJraXRf YXBwbGljYXRpb25fY2FjaGVfc2V0X21heGltdW1fc2l6ZShtYXhTaXplKTsKLQotICAgIGdjaGFy KiBkYXRhYmFzZURpcmVjdG9yeVNldCA9IGdfYnVpbGRfZmlsZW5hbWUoZ19nZXRfdXNlcl9kYXRh X2RpcigpLCAid2Via2l0IiwgImRhdGFiYXNlcyIsIE5VTEwpOwotICAgIHdlYmtpdF9hcHBsaWNh dGlvbl9jYWNoZV9zZXRfZGF0YWJhc2VfZGlyZWN0b3J5X3BhdGgoZGF0YWJhc2VEaXJlY3RvcnlT ZXQpOwotCi0gICAgLy8gQ3JlYXRpbmcgYSBXZWJWaWV3IC0gbWFrZSBzdXJlIHRoYXQgaXQgZGlk bid0IGNoYW5nZSBhbnl0aGluZwotICAgIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcgPSBXRUJLSVRf V0VCX1ZJRVcod2Via2l0X3dlYl92aWV3X25ldygpKTsKLSAgICBnX29iamVjdF9yZWZfc2luayh3 ZWJWaWV3KTsKLSAgICBnX29iamVjdF91bnJlZih3ZWJWaWV3KTsKLQotICAgIGNvbnN0IGdjaGFy KiBkYXRhYmFzZURpcmVjdG9yeUdldCA9IHdlYmtpdF9hcHBsaWNhdGlvbl9jYWNoZV9nZXRfZGF0 YWJhc2VfZGlyZWN0b3J5X3BhdGgoKTsKLSAgICBnX2Fzc2VydF9jbXBzdHIoZGF0YWJhc2VEaXJl Y3RvcnlTZXQsID09LCBkYXRhYmFzZURpcmVjdG9yeUdldCk7Ci0KLSAgICBnX2ZyZWUoZGF0YWJh c2VEaXJlY3RvcnlTZXQpOwotfQotCiBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiB7 CiAgICAgZ190aHJlYWRfaW5pdChOVUxMKTsKQEAgLTY0LDggKzQ1LDYgQEAgaW50IG1haW4oaW50 IGFyZ2MsIGNoYXIqKiBhcmd2KQogICAgIGdfdGVzdF9idWdfYmFzZSgiaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvIik7CiAgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L2FwcGxpY2F0aW9uX2Nh Y2hlL21heGltdW1fc2l6ZSIsCiAgICAgICAgICAgICAgICAgICAgIHRlc3RfYXBwbGljYXRpb25f Y2FjaGVfbWF4aW11bV9zaXplKTsKLSAgICBnX3Rlc3RfYWRkX2Z1bmMoIi93ZWJraXQvYXBwbGlj YXRpb25fY2FjaGUvZGF0YWJhc2VfZGlyZWN0b3J5X3BhdGgiLAotICAgICAgICAgICAgICAgICAg ICB0ZXN0X2FwcGxpY2F0aW9uX2NhY2hlX2RhdGFiYXNlX2RpcmVjdG9yeV9wYXRoKTsKIAogICAg IHJldHVybiBnX3Rlc3RfcnVuKCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93 ZWJraXQvd2Via2l0YXBwbGljYXRpb25jYWNoZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0YXBwbGljYXRpb25jYWNoZS5jcHAKaW5kZXggYWIxNzliNS4uMGI2NWQwNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGFwcGxpY2F0aW9uY2FjaGUu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRhcHBsaWNhdGlvbmNhY2hl LmNwcApAQCAtMjYsOCArMjYsNiBAQAogI2luY2x1ZGUgPHd0Zi9VbnVzZWRQYXJhbS5oPgogI2lu Y2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAotLy8ga2VlcHMgY3VycmVudCBkaXJlY3Rvcnkg cGF0aCB0byBvZmZsaW5lIHdlYiBhcHBsaWNhdGlvbnMgY2FjaGUgZGF0YWJhc2UKLXN0YXRpYyBX VEY6OkNTdHJpbmcgY2FjaGVEaXJlY3RvcnlQYXRoID0gIiI7CiAvLyB3ZWIgYXBwbGljYXRpb24g Y2FjaGUgbWF4aW11bSBzdG9yYWdlIHNpemUKIHN0YXRpYyB1bnNpZ25lZCBsb25nIGxvbmcgY2Fj aGVNYXhTaXplID0gVUlOVF9NQVg7CiAKQEAgLTg5LDMzICs4Nyw5IEBAIEdfQ09OU1RfUkVUVVJO IGdjaGFyKiB3ZWJraXRfYXBwbGljYXRpb25fY2FjaGVfZ2V0X2RhdGFiYXNlX2RpcmVjdG9yeV9w YXRoKCkKIHsKICNpZiBFTkFCTEUoT0ZGTElORV9XRUJfQVBQTElDQVRJT05TKQogICAgIENTdHJp bmcgcGF0aCA9IFdlYkNvcmU6OmZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihXZWJDb3JlOjpjYWNo ZVN0b3JhZ2UoKS5jYWNoZURpcmVjdG9yeSgpKTsKLQotICAgIGlmIChwYXRoICE9IGNhY2hlRGly ZWN0b3J5UGF0aCkKLSAgICAgICAgY2FjaGVEaXJlY3RvcnlQYXRoID0gcGF0aDsKLQotICAgIHJl dHVybiBjYWNoZURpcmVjdG9yeVBhdGguZGF0YSgpOworICAgIHJldHVybiBwYXRoLmRhdGEoKTsK ICNlbHNlCiAgICAgcmV0dXJuICIiOwogI2VuZGlmCiB9CiAKLS8qKgotICogd2Via2l0X2FwcGxp Y2F0aW9uX2NhY2hlX3NldF9kYXRhYmFzZV9kaXJlY3RvcnlfcGF0aDoKLSAqIEBwYXRoOiB0aGUg bmV3IHdlYiBhcHBsaWNhdGlvbiBjYWNoZSBkYXRhYmFzZSBwYXRoCi0gKgotICogU2V0cyB0aGUg Y3VycmVudCBwYXRoIHRvIHRoZSBkaXJlY3RvcnkgV2ViS2l0IHdpbGwgd3JpdGUgd2ViIGFwbGlj YXRpb24gY2FjaGUKLSAqIGRhdGFiYXNlcy4KLSAqCi0gKiBTaW5jZTogMS4zLjEzCi0gKiovCi12 b2lkIHdlYmtpdF9hcHBsaWNhdGlvbl9jYWNoZV9zZXRfZGF0YWJhc2VfZGlyZWN0b3J5X3BhdGgo Y29uc3QgZ2NoYXIqIHBhdGgpCi17Ci0jaWYgRU5BQkxFKE9GRkxJTkVfV0VCX0FQUExJQ0FUSU9O UykKLSAgICBXVEY6OkNTdHJpbmcgcGF0aFN0cmluZyhwYXRoKTsKLSAgICBpZiAocGF0aFN0cmlu ZyAhPSBjYWNoZURpcmVjdG9yeVBhdGgpCi0gICAgICAgIGNhY2hlRGlyZWN0b3J5UGF0aCA9IHBh dGhTdHJpbmc7Ci0KLSAgICBXZWJDb3JlOjpjYWNoZVN0b3JhZ2UoKS5zZXRDYWNoZURpcmVjdG9y eShXZWJDb3JlOjpmaWxlbmFtZVRvU3RyaW5nKGNhY2hlRGlyZWN0b3J5UGF0aC5kYXRhKCkpKTsK LSNlbmRpZgotfQotCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 YXBwbGljYXRpb25jYWNoZS5oIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGFwcGxp Y2F0aW9uY2FjaGUuaAppbmRleCA4MTBhNWQ2Li45M2RkZTQ0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0YXBwbGljYXRpb25jYWNoZS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRhcHBsaWNhdGlvbmNhY2hlLmgKQEAgLTMzLDkgKzMzLDYg QEAgd2Via2l0X2FwcGxpY2F0aW9uX2NhY2hlX3NldF9tYXhpbXVtX3NpemUodW5zaWduZWQgbG9u ZyBsb25nIHNpemUpOwogV0VCS0lUX0FQSSBHX0NPTlNUX1JFVFVSTiBnY2hhcioKIHdlYmtpdF9h cHBsaWNhdGlvbl9jYWNoZV9nZXRfZGF0YWJhc2VfZGlyZWN0b3J5X3BhdGggICh2b2lkKTsKIAot V0VCS0lUX0FQSSB2b2lkCi13ZWJraXRfYXBwbGljYXRpb25fY2FjaGVfc2V0X2RhdGFiYXNlX2Rp cmVjdG9yeV9wYXRoICAoY29uc3QgZ2NoYXIqIHBhdGgpOwotCiBHX0VORF9ERUNMUwogCiAjZW5k aWYgLyogd2Via2l0YXBwbGljYXRpb25jYWNoZV9oICovCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0Z2xvYmFscy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0Z2xvYmFscy5jcHAKaW5kZXggYTM5MmFlOS4uYjhkOGIxZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGdsb2JhbHMuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRnbG9iYWxzLmNwcApAQCAtMjY1LDcgKzI2NSw3IEBAIHZv aWQgd2Via2l0SW5pdCgpCiAKICAgICBnY2hhciogZGF0YWJhc2VEaXJlY3RvcnkgPSBnX2J1aWxk X2ZpbGVuYW1lKGdfZ2V0X3VzZXJfZGF0YV9kaXIoKSwgIndlYmtpdCIsICJkYXRhYmFzZXMiLCBO VUxMKTsKICAgICB3ZWJraXRfc2V0X3dlYl9kYXRhYmFzZV9kaXJlY3RvcnlfcGF0aChkYXRhYmFz ZURpcmVjdG9yeSk7Ci0gICAgd2Via2l0X2FwcGxpY2F0aW9uX2NhY2hlX3NldF9kYXRhYmFzZV9k aXJlY3RvcnlfcGF0aChkYXRhYmFzZURpcmVjdG9yeSk7CisgICAgV2ViQ29yZTo6Y2FjaGVTdG9y YWdlKCkuc2V0Q2FjaGVEaXJlY3RvcnkoZGF0YWJhc2VEaXJlY3RvcnkpOwogCiAgICAgZ19mcmVl KGRhdGFiYXNlRGlyZWN0b3J5KTsKIAotLSAKMS43LjQuMQ==