56061 2011-03-09 16:33:36 -0800 selectionStart reports wrong caret position when the last characters are newlines 2011-03-09 17:46:58 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 rniwa rniwa adele ap darin enrica ojan tkent oldest_to_newest 364874 0 rniwa 2011-03-09 16:33:36 -0800 http://crbug.com/56971 What steps will reproduce the problem? 1. Put some newlines in an empty textarea. 2. Read its selectionStart property via Javascript. What is the expected result? It should return the a number equal to the number of newlines. What happens instead? It always returns 1. It may be a bug in Webkit, since Safari fails too. I did a reduction that shows the problem very easily: http://martinml.com/textarea.html This is especially annoying in a phpBB forum editor, since if you want to put some newlines and then click the button to insert a bbcode tag, it's inserted just after the last text, and not after the newlines. 364892 1 85260 rniwa 2011-03-09 17:02:58 -0800 Created attachment 85260 demo This is a failed attempt to write a layout out for this bug. It seems like the bug can be reproduced only if we ran it manually. 364898 2 85262 rniwa 2011-03-09 17:15:11 -0800 Created attachment 85262 fixes the bug 364905 3 85262 tkent 2011-03-09 17:24:41 -0800 Comment on attachment 85262 fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=85262&action=review > Source/WebCore/editing/SelectionController.cpp:171 > + // See https://bugs.webkit.org/show_bug.cgi?id=56061 nit: I feel the bug entry doesn't have additional information and ChangeLog is enough. 364910 4 rniwa 2011-03-09 17:34:31 -0800 (In reply to comment #3) > (From update of attachment 85262 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85262&action=review > > > Source/WebCore/editing/SelectionController.cpp:171 > > + // See https://bugs.webkit.org/show_bug.cgi?id=56061 > > nit: I feel the bug entry doesn't have additional information and ChangeLog is enough. Ok. Do you think I can also get rid of the line above where I say "// Even if selection was not changed, selection offset may have been changed." ? 364914 5 tkent 2011-03-09 17:36:17 -0800 (In reply to comment #4) > Do you think I can also get rid of the line above where I say "// Even if selection was not changed, selection offset may have been changed." ? No. This line looks helpful. 364918 6 rniwa 2011-03-09 17:43:57 -0800 (In reply to comment #5) > (In reply to comment #4) > > Do you think I can also get rid of the line above where I say "// Even if selection was not changed, selection offset may have been changed." ? > > No. This line looks helpful. Ok. Thanks for the review. Landing it now. 364920 7 rniwa 2011-03-09 17:46:58 -0800 Committed r80679: <http://trac.webkit.org/changeset/80679> 85260 2011-03-09 17:02:58 -0800 2011-03-09 17:02:58 -0800 demo selection-start-after-inserting-line-break-in-textarea.html text/html 1296 rniwa PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8Ym9keT4KPHA+VGhpcyB0ZXN0cyBzZWxlY3Rpb25TdGFy dCBpcyB1cGRhdGVkIHByb3Blcmx5IHdoZW4gaW5zZXJ0aW5nIExGIGludG8gdGV4dGFyZWEuIFRv IG1hbnVhbGx5IHRlc3QsIHByZXNzIEVudGVyIHNldmVyYWwgdGltZXMgaW5zaWRlIHRleHRhcmVh IGFuZCBjbGljayB0aGUgbG9nIGJ1dHRvbi48L3A+Cjx0ZXh0YXJlYSBjb2xzPSIyMCIgcm93cz0i MjAiPjwvdGV4dGFyZWE+CjxidXR0b24gaWQ9ImJ1dHRvbiIgb25jbGljaz0idmVyaWZ5KCkiPnZl cmlmeTwvYnV0dG9uPgo8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KPHNjcmlwdD4KCmZ1bmN0aW9u IHZlcmlmeSgpIHsKICAgIHZhciBjb25zb2xlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2Nv bnNvbGUnKTsKICAgIGlmICh0ZXh0YXJlYS52YWx1ZS5tYXRjaCgvW15cbl0vKSkKICAgICAgICBj b25zb2xlLmlubmVySFRNTCA9ICd0ZXh0YXJlYSBjb250YWlucyB1bmV4cGVjdGVkIGNoYXJhY3Rl ci4gWW91IGNhbiBvbmx5IHR5cGUgTEYgaW4gdGhpcyB0ZXN0Lic7CiAgICBlbHNlIGlmICh0ZXh0 YXJlYS5zZWxlY3Rpb25TdGFydCAhPSB0ZXh0YXJlYS52YWx1ZS5sZW5ndGgpCiAgICAgICAgY29u c29sZS5pbm5lckhUTUwgPSAnRkFJTDogZXhwZWN0ZWQgJyArIHRleHRhcmVhLnZhbHVlLmxlbmd0 aCArICcgYnV0IGdvdCAnICsgdGV4dGFyZWEuc2VsZWN0aW9uU3RhcnQ7CiAgICBlbHNlCiAgICAg ICAgY29uc29sZS5pbm5lckhUTUwgPSAnUEFTUyc7Cn0KCnZhciB0ZXh0YXJlYSA9IGRvY3VtZW50 LmdldEVsZW1lbnRzQnlUYWdOYW1lKCd0ZXh0YXJlYScpWzBdOwp0ZXh0YXJlYS5mb2N1cygpOwoK aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgaWYgKCF3aW5kb3cuZXZlbnRT ZW5kZXIgfHwgZXZlbnRTZW5kZXIua2V5RG93bikKICAgICAgICBkb2N1bWVudC53cml0ZWxuKCdU aGlzIHRlc3QgcmVxdWlyZXMgZXZlbnRTZW5kZXInKTsKICAgIGVsc2UgewogICAgICAgIGV2ZW50 U2VuZGVyLmtleURvd24oJ1xuJywgW10pOwogICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oJ1xu JywgW10pOwogICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oJ1xuJywgW10pOwogICAgICAgIHZl cmlmeSgpOwogICAgfQp9CgovKmRvY3VtZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRQYXJhZ3JhcGgn LCBmYWxzZSwgbnVsbCk7CmRvY3VtZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRQYXJhZ3JhcGgnLCBm YWxzZSwgbnVsbCk7Ki8KCjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K 85262 2011-03-09 17:15:11 -0800 2011-03-09 17:24:41 -0800 fixes the bug bug-56061-20110309171510.patch text/plain 3690 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwNjc3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDMtMDkgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgc2VsZWN0aW9uU3RhcnQgcmVwb3J0cyB3cm9uZyBjYXJldCBwb3Np dGlvbiB3aGVuIHRoZSBsYXN0IGNoYXJhY3RlcnMgYXJlIG5ld2xpbmVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjA2MQorCisgICAgICAgIFRoZSBi dWcgd2FzIGNhdXNlZCBieSBTZWxlY3Rpb25Db250cm9sbGVyOjpzZXRTZWxlY3Rpb24ncyBub3Qg Y2FsbGluZworICAgICAgICBub3RpZnlSZW5kZXJlck9mU2VsZWN0aW9uQ2hhbmdlIHdoZW4gb2xk IHNlbGVjdGlvbiB3YXMgZXF1YWwgdG8gbmV3IHNlbGVjdGlvbi4KKworICAgICAgICBCZWNhdXNl IEluc2VydExpbmVCcmVha0NvbW1hbmQgaW5zZXJ0cyBhIHRleHQgbm9kZSB3aXRoIGEgc2luZ2xl IExGIGJlZm9yZSB0aGUgY2FyZXQsCisgICAgICAgIHRoaXMgY29uZGl0aW9uIGhvbGRzIGFmdGVy IHRoZSBjb21tYW5kIGlzIGV4ZWN1dGVkLiBIb3dldmVyLCB0aGUgdmFsdWVzIG9mCisgICAgICAg IHNlbGVjdGlvblN0YXJ0IGFuZCBzZWxlY3Rpb25FbmQgc3RpbGwgbmVlZCB0byBiZSB1cGRhdGVk IGluIHRoaXMgY2FzZSBiZWNhdXNlCisgICAgICAgIHRoZSBvZmZzZXRzIGNvdW50ZWQgZnJvbSB0 aGUgYmVnaW5uaW5nIG9mIHRleHRhcmVhIGhhdmUgYmVlbiBpbmNyZWFzZWQgYnkgMS4KKworICAg ICAgICAqIGVkaXRpbmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTZWxlY3Rpb25Db250cm9sbGVyOjpzZXRTZWxlY3Rpb24pOiBDYWxsIG5vdGlmeVJlbmRlcmVy T2ZTZWxlY3Rpb25DaGFuZ2UKKyAgICAgICAgd2hlbiBtX3NlbGVjdGlvbiA9IHMuCisgICAgICAg ICogbWFudWFsLXRlc3RzL3NlbGVjdGlvbi1zdGFydC1hZnRlci1pbnNlcnRpbmctbGluZS1icmVh ay1pbi10ZXh0YXJlYS5odG1sOiBBZGRlZC4KKwogMjAxMS0wMy0wOSAgQW5keSBFc3RlcyAgPGFl c3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNwcAkocmV2 aXNpb24gODA2NTgpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1NlbGVjdGlvbkNvbnRyb2xs ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjUsMTkgKzE2NSwyMyBAQCB2b2lkIFNlbGVjdGlv bkNvbnRyb2xsZXI6OnNldFNlbGVjdGlvbihjCiAKICAgICBpZiAoc2hvdWxkQ2xlYXJUeXBpbmdT dHlsZSkKICAgICAgICAgY2xlYXJUeXBpbmdTdHlsZSgpOwotICAgICAgICAKLSAgICBpZiAobV9z ZWxlY3Rpb24gPT0gcykKKworICAgIGlmIChtX3NlbGVjdGlvbiA9PSBzKSB7CisgICAgICAgIC8v IEV2ZW4gaWYgc2VsZWN0aW9uIHdhcyBub3QgY2hhbmdlZCwgc2VsZWN0aW9uIG9mZnNldCBtYXkg aGF2ZSBiZWVuIGNoYW5nZWQuCisgICAgICAgIC8vIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTYwNjEKKyAgICAgICAgbm90aWZ5UmVuZGVyZXJPZlNlbGVjdGlv bkNoYW5nZSh1c2VyVHJpZ2dlcmVkKTsKICAgICAgICAgcmV0dXJuOwotICAgIAorICAgIH0KKwog ICAgIFZpc2libGVTZWxlY3Rpb24gb2xkU2VsZWN0aW9uID0gbV9zZWxlY3Rpb247CiAKICAgICBt X3NlbGVjdGlvbiA9IHM7Ci0gICAgCisKICAgICBtX2NhcmV0UmVjdE5lZWRzVXBkYXRlID0gdHJ1 ZTsKLSAgICAKKwogICAgIGlmICghcy5pc05vbmUoKSkKICAgICAgICAgc2V0Rm9jdXNlZE5vZGVJ Zk5lZWRlZCgpOwotICAgIAorCiAgICAgdXBkYXRlQXBwZWFyYW5jZSgpOwogCiAgICAgLy8gQWx3 YXlzIGNsZWFyIHRoZSB4IHBvc2l0aW9uIHVzZWQgZm9yIHZlcnRpY2FsIGFycm93IG5hdmlnYXRp b24uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvc2VsZWN0aW9uLXN0YXJ0LWFm dGVyLWluc2VydGluZy1saW5lLWJyZWFrLWluLXRleHRhcmVhLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvbWFudWFsLXRlc3RzL3NlbGVjdGlvbi1zdGFydC1hZnRlci1pbnNlcnRp bmctbGluZS1icmVhay1pbi10ZXh0YXJlYS5odG1sCShyZXZpc2lvbiAwKQorKysgU291cmNlL1dl YkNvcmUvbWFudWFsLXRlc3RzL3NlbGVjdGlvbi1zdGFydC1hZnRlci1pbnNlcnRpbmctbGluZS1i cmVhay1pbi10ZXh0YXJlYS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI1IEBACis8IURP Q1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8cD5UaGlzIHRlc3RzIHNlbGVjdGlvblN0YXJ0 IGlzIHVwZGF0ZWQgcHJvcGVybHkgd2hlbiBpbnNlcnRpbmcgTEYgaW50byB0ZXh0YXJlYS4gVG8g dGVzdCwgcHJlc3MgRW50ZXIgc2V2ZXJhbCB0aW1lcyBpbnNpZGUgdGV4dGFyZWEgYW5kIGNsaWNr IHRoZSBsb2cgYnV0dG9uLiBUaGlzIGJ1ZyBkb2VzIG5vdCByZXByb2R1Y2Ugd2hlbiBuZXcgbGlu ZXMgYXJlIGFkZGVkIGJ5IGV4ZWNDb21tYW5kIG9yIGV2ZW50U2VuZGVyLjwvcD4KKzx0ZXh0YXJl YSBjb2xzPSIyMCIgcm93cz0iMjAiPjwvdGV4dGFyZWE+Cis8YnV0dG9uIGlkPSJidXR0b24iIG9u Y2xpY2s9InZlcmlmeSgpIj52ZXJpZnk8L2J1dHRvbj4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2 PgorPHNjcmlwdD4KKworZnVuY3Rpb24gdmVyaWZ5KCkgeworICAgIHZhciBjb25zb2xlID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnNvbGUnKTsKKyAgICBpZiAodGV4dGFyZWEudmFsdWUu bWF0Y2goL1teXG5dLykpCisgICAgICAgIGNvbnNvbGUuaW5uZXJIVE1MID0gJ3RleHRhcmVhIGNv bnRhaW5zIHVuZXhwZWN0ZWQgY2hhcmFjdGVyLiBZb3UgY2FuIG9ubHkgdHlwZSBMRiBpbiB0aGlz IHRlc3QuJzsKKyAgICBlbHNlIGlmICh0ZXh0YXJlYS5zZWxlY3Rpb25TdGFydCAhPSB0ZXh0YXJl YS52YWx1ZS5sZW5ndGgpCisgICAgICAgIGNvbnNvbGUuaW5uZXJIVE1MID0gJ0ZBSUw6IGV4cGVj dGVkICcgKyB0ZXh0YXJlYS52YWx1ZS5sZW5ndGggKyAnIGJ1dCBnb3QgJyArIHRleHRhcmVhLnNl bGVjdGlvblN0YXJ0OworICAgIGVsc2UKKyAgICAgICAgY29uc29sZS5pbm5lckhUTUwgPSAnUEFT UzogJyArIHRleHRhcmVhLnZhbHVlLmxlbmd0aCArICcgTEZzJzsKK30KKwordmFyIHRleHRhcmVh ID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3RleHRhcmVhJylbMF07Cit0ZXh0YXJl YS5mb2N1cygpOworCis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K