56059 2011-03-09 16:12:27 -0800 REGRESSION(r76147): A slider thumb that is styled cannot be programmatically moved 2011-03-16 11:21:30 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED InRadar, Regression P1 Normal --- 52464 1 piet dglazkov adele commit-queue dglazkov tkent oldest_to_newest 364862 0 piet 2011-03-09 16:12:27 -0800 This is a regression that I noticed after Chrome upgraded from 9 to 10. I'm developing an application that displays videos using the <video> element and custom controls. After upgrading to Chrome 10, the slider that shows the current playback position and allows to do some fast scrubbing is no longer being updated when the movie is playing. The bug is related to the styling of the thumb. If the thumb is not styled, it is correctly updated when the value is changed by script. If the thumb is styled, it does not move anymore when the value is changed. To reproduce: - Go to http://www.w3schools.com/html5/tryit.asp?filename=tryhtml5_form_range - Enter the code below in the left frame - Click "Edit and Click Me >>" ==> BUG: The custom-styled thumb does not move every second as it should. - Then remove the style rule that matches the thumb ("input[type="range"]::-webkit-slider-thumb") - Click "Edit and Click Me >>" ==> OK: The native-looking thumb moves when the value is updated by script. - Restore the style rule and re-activate the commented code that toggles between "inline-block" and "inline" - Click "Edit and Click Me >>" ==> WORKAROUND: The custom-styled thumb now moves correctly (but that's quite an ugly workaround) CCd dglazkov who recently refactored the slider. Here is the code: ======== <!DOCTYPE HTML> <html> <style> input[type="range"] { -webkit-appearance: none; height: 10px; border-radius: 4px; background: -webkit-gradient(linear, 0% 0%, 0% 100%, from(#444), color-stop(0.4, #888), color-stop(0.6, #888), to(#444)); } input[type="range"]::-webkit-slider-thumb { -webkit-appearance: none; width: 10px; height: 28px; border-radius: 4px; background: -webkit-gradient(linear, 0% 0%, 100% 0%, from(#222), color-stop(0.4, #888), color-stop(0.6, #888), to(#222)); } </style> <body> Points: <input id="slider" type="range" min="0" max="10" /> <input type="submit" /> <script> var slider = document.getElementById('slider'); slider.value = 0; setTimeout("test()", 1000); function test() { var slider = document.getElementById('slider'); slider.value++; //if (!(slider.value % 2)) //setTimeout("slider.style.display = 'inline-block'", 1); //else //setTimeout("slider.style.display = 'inline'", 1); if (slider.value < 9) setTimeout("test()", 1000); } </script> </body> </html> 365326 1 ap 2011-03-10 11:09:20 -0800 Confirmed as a regression from Safari 5 using a local build of r80599. 365327 2 ap 2011-03-10 11:09:38 -0800 <rdar://problem/9115880> 365329 3 85351 ap 2011-03-10 11:11:05 -0800 Created attachment 85351 test case Same test as an attachment. 365449 4 dglazkov 2011-03-10 12:50:45 -0800 Fixing... 367351 5 dglazkov 2011-03-14 16:48:38 -0700 This is more complex than I anticipated... 367999 6 85865 dglazkov 2011-03-15 15:37:28 -0700 Created attachment 85865 Patch 368102 7 85865 tkent 2011-03-15 17:55:32 -0700 Comment on attachment 85865 Patch ok 368169 8 commit-queue 2011-03-15 21:09:55 -0700 The commit-queue encountered the following flaky tests while processing attachment 85865: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 368170 9 85865 commit-queue 2011-03-15 21:14:06 -0700 Comment on attachment 85865 Patch Clearing flags on attachment: 85865 Committed r81216: <http://trac.webkit.org/changeset/81216> 368171 10 commit-queue 2011-03-15 21:14:10 -0700 All reviewed patches have been landed. Closing bug. 368385 11 piet 2011-03-16 10:52:48 -0700 If I may make a minor comment... I think that the bulk of SliderThumbElement::setPositionFromPoint() should be moved into a method called ::setValueFromPoint() and at the very end of the function, it should call ::setPositionFromValue() instead of calling directly renderer()->setNeedsLayout(true). So it should look something like: void SliderThumbElement::setPositionFromPoint(const IntPoint& point) { HTMLInputElement* input = static_cast<HTMLInputElement*>(shadowHost()); ASSERT(input); if (!input->renderer() || !renderer()) return; setValueFromPoint(point); setPositionFromValue(); input->dispatchFormControlChangeEvent(); } It describes better what happens. Reopen if you like. 368412 12 dglazkov 2011-03-16 11:21:30 -0700 (In reply to comment #11) > If I may make a minor comment... I think that the bulk of SliderThumbElement::setPositionFromPoint() should be moved into a method called ::setValueFromPoint() and at the very end of the function, it should call ::setPositionFromValue() instead of calling directly renderer()->setNeedsLayout(true). > > So it should look something like: > > void SliderThumbElement::setPositionFromPoint(const IntPoint& point) > { > HTMLInputElement* input = static_cast<HTMLInputElement*>(shadowHost()); > ASSERT(input); > > if (!input->renderer() || !renderer()) > return; > > setValueFromPoint(point); > setPositionFromValue(); > input->dispatchFormControlChangeEvent(); > } > > It describes better what happens. Reopen if you like. Sounds like a great first patch! :) 85351 2011-03-10 11:11:05 -0800 2011-03-10 11:11:05 -0800 test case slider.html text/html 1031 ap PCFET0NUWVBFIEhUTUw+CjxodG1sPgo8c3R5bGU+CgppbnB1dFt0eXBlPSJyYW5nZSJdIHsKICAg IC13ZWJraXQtYXBwZWFyYW5jZTogbm9uZTsKICAgIGhlaWdodDogMTBweDsKICAgIGJvcmRlci1y YWRpdXM6IDRweDsKICAgIGJhY2tncm91bmQ6IC13ZWJraXQtZ3JhZGllbnQobGluZWFyLCAwJSAw JSwgMCUgMTAwJSwgZnJvbSgjNDQ0KSwgY29sb3Itc3RvcCgwLjQsICM4ODgpLCBjb2xvci1zdG9w KDAuNiwgIzg4OCksIHRvKCM0NDQpKTsKfQoKaW5wdXRbdHlwZT0icmFuZ2UiXTo6LXdlYmtpdC1z bGlkZXItdGh1bWIgewogICAgLXdlYmtpdC1hcHBlYXJhbmNlOiBub25lOwogICAgd2lkdGg6IDEw cHg7CiAgICBoZWlnaHQ6IDI4cHg7CiAgICBib3JkZXItcmFkaXVzOiA0cHg7CiAgICBiYWNrZ3Jv dW5kOiAtd2Via2l0LWdyYWRpZW50KGxpbmVhciwgMCUgMCUsIDEwMCUgMCUsIGZyb20oIzIyMiks IGNvbG9yLXN0b3AoMC40LCAjODg4KSwgY29sb3Itc3RvcCgwLjYsICM4ODgpLCB0bygjMjIyKSk7 Cn0KCjwvc3R5bGU+Cjxib2R5PgoKUG9pbnRzOiA8aW5wdXQgaWQ9InNsaWRlciIgdHlwZT0icmFu Z2UiIG1pbj0iMCIgbWF4PSIxMCIgLz4KPGlucHV0IHR5cGU9InN1Ym1pdCIgLz4KCjxzY3JpcHQ+ CnZhciBzbGlkZXIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnc2xpZGVyJyk7CnNsaWRlci52 YWx1ZSA9IDA7CnNldFRpbWVvdXQoInRlc3QoKSIsIDEwMDApOwoKZnVuY3Rpb24gdGVzdCgpIHsK dmFyIHNsaWRlciA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdzbGlkZXInKTsKc2xpZGVyLnZh bHVlKys7Ci8vaWYgKCEoc2xpZGVyLnZhbHVlICUgMikpCi8vc2V0VGltZW91dCgic2xpZGVyLnN0 eWxlLmRpc3BsYXkgPSAnaW5saW5lLWJsb2NrJyIsIDEpOwovL2Vsc2UKLy9zZXRUaW1lb3V0KCJz bGlkZXIuc3R5bGUuZGlzcGxheSA9ICdpbmxpbmUnIiwgMSk7CmlmIChzbGlkZXIudmFsdWUgPCA5 KQogICAgc2V0VGltZW91dCgidGVzdCgpIiwgMTAwMCk7Cn0KPC9zY3JpcHQ+CjwvYm9keT4KPC9o dG1sPgo= 85865 2011-03-15 15:37:28 -0700 2011-03-15 21:14:06 -0700 Patch bug-56059-20110315153727.patch text/plain 10015 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogODEwNjIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3M2VhZDVjYzljMTc1NDY1MjBiMDZk ZGJkZTcxZDFlOTM5YjMwNGZlLi5jMTVkYWE1MjM0MjY0M2ZkMDMxY2JkMzNjNDJlYmZjOTQxZGVk M2NlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDMtMTUgIERpbWl0cmkgR2xhemtvdiAg PGRnbGF6a292QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OKHI3NjE0Nyk6IEEgc2xpZGVyIHRodW1iIHRoYXQg aXMgc3R5bGVkIGNhbm5vdCBiZSBwcm9ncmFtbWF0aWNhbGx5IG1vdmVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjA1OQorCisgICAgICAgIE5vdGU6 IHRoZSB0ZXN0IHNob3VsZCBwYXNzIG9uIGFsbCBwbGF0Zm9ybXMsIGJlY2F1c2UgaXQgd2FzIGRl c2lnbmVkIHRvIG5vdCB1c2UKKyAgICAgICAgcGxhdGZvcm0tc3BlY2lmaWMgbWV0cmljcy4KKwor ICAgICAgICAqIGZhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQvaW5wdXQtc2xpZGVyLXVwZGF0ZS1z dHlsZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9p bnB1dC1zbGlkZXItdXBkYXRlLXN0eWxlZC1leHBlY3RlZC5jaGVja3N1bTogQWRkZWQuCisgICAg ICAgICogZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9pbnB1dC1zbGlkZXItdXBkYXRlLXN0eWxl ZC1leHBlY3RlZC5wbmc6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL0hUTUxJbnB1dEVsZW1l bnQvaW5wdXQtc2xpZGVyLXVwZGF0ZS1zdHlsZWQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAx MS0wMy0xNCAgTHVpeiBBZ29zdGluaSAgPGx1aXouYWdvc3RpbmlAb3BlbmJvc3NhLm9yZz4KIAog ICAgICAgICBBZGp1c3RpbmcgU25vdyBMZW9wYXJkIGV4cGVjdGVkIHJlc3VsdHMgYWZ0ZXIgcjgx MDM1LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9p bnB1dC1zbGlkZXItdXBkYXRlLXN0eWxlZC1leHBlY3RlZC5jaGVja3N1bSBiL0xheW91dFRlc3Rz L2Zhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQvaW5wdXQtc2xpZGVyLXVwZGF0ZS1zdHlsZWQtZXhw ZWN0ZWQuY2hlY2tzdW0KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDdjZmRjNmVmZjI1NWE1ZWE5NDlhZjcwNzA0M2Ux YjM2ZWM4MzdmMgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxJ bnB1dEVsZW1lbnQvaW5wdXQtc2xpZGVyLXVwZGF0ZS1zdHlsZWQtZXhwZWN0ZWQuY2hlY2tzdW0K QEAgLTAsMCArMSBAQAorMTFjOGRiY2VjNDkzNmM5YjQzMzNmYzhkNTFkMmFkODgKXCBObyBuZXds aW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1M SW5wdXRFbGVtZW50L2lucHV0LXNsaWRlci11cGRhdGUtc3R5bGVkLWV4cGVjdGVkLnBuZyBiL0xh eW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQvaW5wdXQtc2xpZGVyLXVwZGF0ZS1z dHlsZWQtZXhwZWN0ZWQucG5nCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjlhNjFiZTkzOWY3MDcwOGUwNzQ5YjBhMzgw Nzk2MDA2NjRhNDMzNGUKR0lUIGJpbmFyeSBwYXRjaApsaXRlcmFsIDExMTEyCnpjbWVBU0BOPyhv bEh5YHVWQnEhaWEweX55VXsrdllWMmE+aTFCJVFsWWJwUzgtZW8jRjJZNU89RCtDbmZyKUIxKAp6 R0I4dnl3dVlSfjdJcVoqWE9fM31mKVlubUhzN1gtMn0rKWt0MjExJG5FZSRAJUkzSyh6cys/Kmlt flVsSmhSdkQKeilWNDB8Yz1HNj8pOy1zXjMpJWxTJFc/dHYoZjRZTmFARHhFU3xlJHB4YkRaWmN8 T35nekIrS08/KDtxS19xRitECnpfWmZKTEV9NDk3VjBwck9KWk88JVc9QFMkKX1JY0J6RDFtbENh UiZnLX10R3BJV2B5bnRiVHJAaW9ZPkI+flF0KAp6QD1mSnlYSTxKaGlAb0txIXZwdE9IPz1tcjdj YjxCNmtfVkl4eFl+SmNuUWItJDJVSGA+OV9RJnRUPyFwVSklT2IKenEqOUg4c3FWUlkteU9rY1JX Q2E8ZHNzflFTe1AoRT1YJj4pPiQyPmJkMT1RXjI8LUtydXgkNjRjZExeWSZoaClrCnpIKH5HR0ZM aSNLQDdXenZKajUteio0fU1MQDRULSlTTTQ3cUszd3diTlNtI1VnejErYjM4TEdqUntrKE9Cb1om Kwp6dEcrMHRAVE1OYCN+SkpYaEpFc0NEd3RxI0RrWlVASUxnRVN4PS1HWlVHMSMzWVMpRj1LUG5G a2R8MjVwb1BPYGgKei1TQDd5bkFSS2MkP3swPyU7TlAzNU84SGxvVXRMbXEwTDZoJn0zN1F6NEJA ez5CLWVicjdCc3dPT2prUkkjISRBCnp2RTNmSDxnVSM+NFcrXjwmUmFQcXtjLSVLd2Y/MDQpNUBR eFY+YTlmYCN4cHU+eytgJEorTUNkYm1tU2V4JEJvdAp6SlRDVCl0Q0BQR1k7dzUhdl5BQWdkdUZ8 bnZWUmprLVNBbkhZNSRTcDRabEM/IyFvI25VOSg1ej07UDRPdWVAN0kKenFZVGFPJihFcDF3dGJ7 YFVUXkVROzxjVUs9MyVwXnJ+bDNKYDJCOXhwMl5RYmZCTUlMe3JEJlM/MitWMG51Y20rCnpVQyRM ZXJ5dGUoSU8mRz5ZVkpufnh5TCE/UEhvZT9sc29hNCVHSEV+UyRuP2YkSiQzJT5+Klc+YDVISnle MzBgPgp6JmhQYnl2e0Zwdz8mUW49KXFuZj1BTXEjT3lQblYyVkE5V2RhQU19Sit+QzZaMHQtYEA8 YHU3RjY1b0haX1FTVGsKej84UzghZV4/QEhSKlM2LUdNJXJtaGYkYGl5LU16ZD04VmhKcmslQTZZ Uyk9UmREcUtSTmtMfTxaYVc3QlUwMSFICno+TWdjO1dAeXNPdkt1b20lalVAfXZ+PkRAV1Z1KUI8 WGBKUTNVMnRqQT9XQU5IOTxHKXtHX2ZtUFhDcEVWOSNJSQp6MH5PdCEzPTlla28tVTNkNl53ODFJ XzYwYGlafnpDSUkoeGA/OSt8QDNNbSlZOHx0aTJFdlBGcllaMHMzYH5VQ1gKelB3b3YyajclJlgw dHlaZDQye2Y4YH10RWtLdW5tfWYmSz1ATjNLWEI0YHd0bDdXRzY0eiFVJmd2VVFYckcleiRLCnpH cUlnOCV5Tlg5Mn5zRGFhMVRqMk9DUDYlIXRvV1hmKFRPKzhZPFchUDVgVTNQKWxmI1N1RXkpRiFq THZlJEtlewp6e3IwYiN8TGNHRl81MEBrZWYkNDN7N256Q2JBX29YbkIwKT5rZTc5TUd1UzYhVj04 dHVGbjs+YkcjQkI7MldwSlcKelBuTWI0YUtvTGAqdj43WHpee0whNjUtckRBcF9iT2Jsfn5ebVZl KCktJlZpSmRQO3B0RCVgT2xPIzJ2REs2eHF4Cno0LSpMeTB8eiRtYXdDTEd5JCYjcHN1JkZxWG80 UzJBRVVXcHZ+KztnUkhNMEpHJmhYcWhTQSZyWH52R1dsdHg+UQp6cWIrR3pyKjFTaWpPSz5YKyVU Rk9LJStkUD9jfnZSQEBQQUd3NEZUS1A5N31fTjg1Iz8/WlZNXjtiXjtYdnxZJjEKekk5ZTh0bVc5 S3RFYVlSR1YjdlYycCRTP0dGZ2otbG5wWXBxPCliU0tNcHN6Qzd5RkZYZDgyalNGc3QpTT5wOE9Q CmN4Z1Ryeyo/ZW0pQ20jXzd1QXBWYGJvRnl0PWFrUnswTWwtKVlYQVRNCgpsaXRlcmFsIDAKSGNt Vj9kMDAwMDEKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MSW5wdXRFbGVt ZW50L2lucHV0LXNsaWRlci11cGRhdGUtc3R5bGVkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2Zhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQvaW5wdXQtc2xpZGVyLXVwZGF0ZS1zdHlsZWQtZXhw ZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjU0OTExYjA4ODU1YTM5ZjBmMGUxODg3YjU3YzgxZDExZWUz OTk0ZDcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MSW5wdXRF bGVtZW50L2lucHV0LXNsaWRlci11cGRhdGUtc3R5bGVkLWV4cGVjdGVkLnR4dApAQCAtMCwwICsx LDggQEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJWaWV3IGF0ICgwLDAp IHNpemUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlckJsb2Nr IHtIVE1MfSBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAo OCw4KSBzaXplIDc4NHg1ODQKKyAgICAgIFJlbmRlclNsaWRlciB7SU5QVVR9IGF0ICgyLDIpIHNp emUgMTAweDEwIFtiZ2NvbG9yPSNGRjAwMDBdCisgICAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0 ICg5MCwwKSBzaXplIDEweDEwIFtiZ2NvbG9yPSMwMDgwMDBdCisgICAgICBSZW5kZXJUZXh0IHsj dGV4dH0gYXQgKDAsMCkgc2l6ZSAweDAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9t L0hUTUxJbnB1dEVsZW1lbnQvaW5wdXQtc2xpZGVyLXVwZGF0ZS1zdHlsZWQuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQvaW5wdXQtc2xpZGVyLXVwZGF0ZS1zdHls ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi5mY2FmNWNmZDk0OTI1OWQwYWYxZmIwZmY3NjFkNGI2YTgzNWY1 NzEwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTElucHV0RWxl bWVudC9pbnB1dC1zbGlkZXItdXBkYXRlLXN0eWxlZC5odG1sCkBAIC0wLDAgKzEsNDcgQEAKKzxo dG1sPgorPGhlYWQ+Cis8c3R5bGU+CisKK2lucHV0IHsKKyAgICAtd2Via2l0LWFwcGVhcmFuY2U6 IG5vbmU7CisgICAgYmFja2dyb3VuZC1jb2xvcjogUmVkOworICAgIGhlaWdodDogMTBweDsKKyAg ICB3aWR0aDogMTAwcHg7Cit9CisKK2lucHV0Ojotd2Via2l0LXNsaWRlci10aHVtYiB7CisgICAg LXdlYmtpdC1hcHBlYXJhbmNlOiBub25lOworICAgIGJhY2tncm91bmQtY29sb3I6IEdyZWVuOwor ICAgIHdpZHRoOiAxMHB4OworICAgIGhlaWdodDogMTBweDsKK30KKworPC9zdHlsZT4KKzxzY3Jp cHQ+CisKKy8qCisKK1Rlc3RzIHdoZXRoZXIgc3R5bGUgc2xpZGVyIHRodW1iIG1vdmVzIHRvIHRo ZSBuZXcgcG9zaXRpb24gd2hlbiBpbnB1dCBlbGVtZW50J3MKK3ZhbHVlIGlzIHVwZGF0ZWQuCisK KyovCisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworCitmdW5jdGlvbiBydW5UZXN0KCkKK3sKKyAgICBz ZXRUaW1lb3V0KGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdzbGlkZXInKS52YWx1ZSA9IDEwMDsKKyAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlcikKKyAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUo KTsKKyAgICB9LCAwKTsKK30KKworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1 blRlc3QoKSI+Cis8aW5wdXQgaWQ9InNsaWRlciIgdHlwZT0icmFuZ2UiIHZhbHVlPSIwIj4KKzwv Ym9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkYmRlYjE0ZTQ3MWI1OTdkNGQ3NTk3ZmI4YzVj MzE2MGUyYWUxOWFmLi5kMmNlMGZhOGI4ZTU3NmVhMDE4ZDc2ZWQxMGRkZGRkZGMzMWU5NGI0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDMtMTUgIERpbWl0cmkgR2xhemtvdiAg PGRnbGF6a292QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OKHI3NjE0Nyk6IEEgc2xpZGVyIHRodW1iIHRoYXQg aXMgc3R5bGVkIGNhbm5vdCBiZSBwcm9ncmFtbWF0aWNhbGx5IG1vdmVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjA1OQorCisgICAgICAgIFRlc3Q6 IGZhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQvaW5wdXQtc2xpZGVyLXVwZGF0ZS1zdHlsZWQuaHRt bAorCisgICAgICAgICogaHRtbC9SYW5nZUlucHV0VHlwZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSYW5nZUlucHV0VHlwZTo6dmFsdWVDaGFuZ2VkKTogQ2hhbmdlZCB0byB1c2Ugc2V0UG9zaXRp b25Gcm9tVmFsdWUuCisgICAgICAgICogaHRtbC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNsaWRlclRodW1iRWxlbWVudDo6c2V0UG9zaXRpb25Gcm9t VmFsdWUpOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlNsaWRlclRodW1iRWxlbWVudDo6ZHJh Z0Zyb20pOiBDaGFuZ2VkIHRvIHVzZSBzZXRQb3NpdGlvbkZyb21Qb2ludC4KKyAgICAgICAgKFdl YkNvcmU6OlNsaWRlclRodW1iRWxlbWVudDo6c2V0UG9zaXRpb25Gcm9tUG9pbnQpOiBEaXR0by4K KyAgICAgICAgKFdlYkNvcmU6OlNsaWRlclRodW1iRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxl cik6IERpdHRvLgorICAgICAgICAqIGh0bWwvc2hhZG93L1NsaWRlclRodW1iRWxlbWVudC5oOiBB ZGRlZCBkZWNscy4KKwogMjAxMS0wMy0xNCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9SYW5nZUlucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL1JhbmdlSW5wdXRUeXBlLmNwcAppbmRleCBmMzQyODY5MzljMWEzYzVlMTQwMGVkYmYwOTIw YTFkMTZhZTM2MzE3Li5mN2VlNjc0NzRkMzJiOTQ2ODk5NjUyOGM1MWExZmE3NWFiZmY3ZWZlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1JhbmdlSW5wdXRUeXBlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL1JhbmdlSW5wdXRUeXBlLmNwcApAQCAtMjQxLDcgKzI0MSw3IEBA IHZvaWQgUmFuZ2VJbnB1dFR5cGU6Om1pbk9yTWF4QXR0cmlidXRlQ2hhbmdlZCgpCiAKIHZvaWQg UmFuZ2VJbnB1dFR5cGU6OnZhbHVlQ2hhbmdlZCgpCiB7Ci0gICAgZWxlbWVudCgpLT5zaGFkb3dS b290KCktPnNldE5lZWRzU3R5bGVSZWNhbGMoKTsKKyAgICB0b1NsaWRlclRodW1iRWxlbWVudChl bGVtZW50KCktPnNoYWRvd1Jvb3QoKSktPnNldFBvc2l0aW9uRnJvbVZhbHVlKCk7CiB9CiAKIFN0 cmluZyBSYW5nZUlucHV0VHlwZTo6ZmFsbGJhY2tWYWx1ZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNv cmUvaHRtbC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVtZW50LmNwcAppbmRleCA2ZWZkMTkxODYyNzFl MTllMGJlYjMyNzdiNzgzMmU5M2RlZDg4MGQxLi42MzUzMjU5MzMyMjEyZGYwN2FlMWY3OGJlODc0 MGJkNDI5MzZiN2ZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9TbGlk ZXJUaHVtYkVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1NsaWRl clRodW1iRWxlbWVudC5jcHAKQEAgLTUxLDYgKzUxLDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog Y2xhc3MgUmVuZGVyU2xpZGVyVGh1bWIgOiBwdWJsaWMgUmVuZGVyQmxvY2sgewogcHVibGljOgog ICAgIFJlbmRlclNsaWRlclRodW1iKE5vZGUqKTsKKworcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZv aWQgbGF5b3V0KCk7CiB9OwogCkBAIC04MCw2ICs4MiwxNiBAQCB2b2lkIFJlbmRlclNsaWRlclRo dW1iOjpsYXlvdXQoKQogICAgIFJlbmRlckJsb2NrOjpsYXlvdXQoKTsKIH0KIAordm9pZCBTbGlk ZXJUaHVtYkVsZW1lbnQ6OnNldFBvc2l0aW9uRnJvbVZhbHVlKCkKK3sKKyAgICAvLyBTaW5jZSB0 b2RheSB0aGUgY29kZSB0byBjYWxjdWxhdGUgcG9zaXRpb24gaXMgaW4gdGhlIFJlbmRlclNsaWRl ciBsYXlvdXQKKyAgICAvLyBwYXRoLCB3ZSBkb24ndCBhY3R1YWxseSB1cGRhdGUgdGhlIHZhbHVl IGhlcmUuIEluc3RlYWQsIHdlIHBva2UgYXQgdGhlCisgICAgLy8gcmVuZGVyZXIgZGlyZWN0bHkg dG8gdHJpZ2dlciBsYXlvdXQuCisgICAgLy8gRklYTUU6IE1vdmUgdGhlIGxvZ2ljIG9mIHBvc2l0 aW9uaW5nIHRoZSB0aHVtYiBoZXJlLgorICAgIGlmIChyZW5kZXJlcigpKQorICAgICAgICByZW5k ZXJlcigpLT5zZXROZWVkc0xheW91dCh0cnVlKTsKK30KKwogUmVuZGVyT2JqZWN0KiBTbGlkZXJU aHVtYkVsZW1lbnQ6OmNyZWF0ZVJlbmRlcmVyKFJlbmRlckFyZW5hKiBhcmVuYSwgUmVuZGVyU3R5 bGUqKQogewogICAgIHJldHVybiBuZXcgKGFyZW5hKSBSZW5kZXJTbGlkZXJUaHVtYih0aGlzKTsK QEAgLTg3LDExICs5OSwxMSBAQCBSZW5kZXJPYmplY3QqIFNsaWRlclRodW1iRWxlbWVudDo6Y3Jl YXRlUmVuZGVyZXIoUmVuZGVyQXJlbmEqIGFyZW5hLCBSZW5kZXJTdHlsZQogCiB2b2lkIFNsaWRl clRodW1iRWxlbWVudDo6ZHJhZ0Zyb20oY29uc3QgSW50UG9pbnQmIHBvaW50KQogewotICAgIHNl dFBvc2l0aW9uKHBvaW50KTsKKyAgICBzZXRQb3NpdGlvbkZyb21Qb2ludChwb2ludCk7CiAgICAg c3RhcnREcmFnZ2luZygpOwogfQogCi12b2lkIFNsaWRlclRodW1iRWxlbWVudDo6c2V0UG9zaXRp b24oY29uc3QgSW50UG9pbnQmIHBvaW50KQordm9pZCBTbGlkZXJUaHVtYkVsZW1lbnQ6OnNldFBv c2l0aW9uRnJvbVBvaW50KGNvbnN0IEludFBvaW50JiBwb2ludCkKIHsKICAgICBIVE1MSW5wdXRF bGVtZW50KiBpbnB1dCA9IHN0YXRpY19jYXN0PEhUTUxJbnB1dEVsZW1lbnQqPihzaGFkb3dIb3N0 KCkpOwogICAgIEFTU0VSVChpbnB1dCk7CkBAIC0xNzAsNyArMTgyLDcgQEAgdm9pZCBTbGlkZXJU aHVtYkVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqIGV2ZW50KQogICAgICAgICBy ZXR1cm47CiAgICAgfSBlbHNlIGlmIChldmVudFR5cGUgPT0gZXZlbnROYW1lcygpLm1vdXNlbW92 ZUV2ZW50KSB7CiAgICAgICAgIGlmIChtX2luRHJhZ01vZGUpCi0gICAgICAgICAgICBzZXRQb3Np dGlvbihtb3VzZUV2ZW50LT5hYnNvbHV0ZUxvY2F0aW9uKCkpOworICAgICAgICAgICAgc2V0UG9z aXRpb25Gcm9tUG9pbnQobW91c2VFdmVudC0+YWJzb2x1dGVMb2NhdGlvbigpKTsKICAgICAgICAg cmV0dXJuOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cv U2xpZGVyVGh1bWJFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9TbGlkZXJU aHVtYkVsZW1lbnQuaAppbmRleCA3YzRjMTc5YTYwNzcwODk1NmYzYWI0ZmQyZDAzNjM4MGYyZTMy ZWY0Li45NDE0YWM0OGE2OTFlMDhhYWNjZDQyODU3MWJiNWVhZmEzYTlhYmQ5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQuaApAQCAtNDksNiAr NDksNyBAQCBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8U2xpZGVyVGh1bWJFbGVtZW50 PiBjcmVhdGUoRG9jdW1lbnQqKTsKIAogICAgIGJvb2wgaW5EcmFnTW9kZSgpIGNvbnN0IHsgcmV0 dXJuIG1faW5EcmFnTW9kZTsgfQorICAgIHZvaWQgc2V0UG9zaXRpb25Gcm9tVmFsdWUoKTsKIAog ICAgIHZvaWQgZHJhZ0Zyb20oY29uc3QgSW50UG9pbnQmKTsKICAgICB2aXJ0dWFsIHZvaWQgZGVm YXVsdEV2ZW50SGFuZGxlcihFdmVudCopOwpAQCAtNjAsNyArNjEsNyBAQCBwcml2YXRlOgogICAg IHZpcnR1YWwgUmVuZGVyT2JqZWN0KiBjcmVhdGVSZW5kZXJlcihSZW5kZXJBcmVuYSosIFJlbmRl clN0eWxlKik7CiAgICAgdm9pZCBzdGFydERyYWdnaW5nKCk7CiAgICAgdm9pZCBzdG9wRHJhZ2dp bmcoKTsKLSAgICB2b2lkIHNldFBvc2l0aW9uKGNvbnN0IEludFBvaW50Jik7CisgICAgdm9pZCBz ZXRQb3NpdGlvbkZyb21Qb2ludChjb25zdCBJbnRQb2ludCYpOwogCiAgICAgRmxvYXRQb2ludCBt X29mZnNldFRvVGh1bWI7CiAgICAgYm9vbCBtX2luRHJhZ01vZGU7Cg==