56053 2011-03-09 14:43:27 -0800 Deleting content directly following a button inserts an unnecessary placeholder 2011-03-14 14:19:46 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 leviw leviw enrica garryb jparent kalman leviw rniwa oldest_to_newest 364789 0 leviw 2011-03-09 14:43:27 -0800 See attachment. Deleting any content directly following a button adds a br "placeholder" to the DOM, which is unexpected. Simply place the caret after the space following the button and hit backspace to repro. 364857 1 85253 leviw 2011-03-09 16:08:29 -0800 Created attachment 85253 Patch 367090 2 85253 rniwa 2011-03-14 11:31:12 -0700 Comment on attachment 85253 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85253&action=review looks sane to me. > LayoutTests/editing/deleting/delete-inserts-br-after-button.html:9 > +target = document.getElementById("container"); Nit: Missing "var". > LayoutTests/editing/deleting/delete-inserts-br-after-button.html:11 > +window.getSelection().modify("move", "Right", "character"); Nit: Capitalize / de-capitalize all words here (make them consistent). 367134 3 leviw 2011-03-14 12:35:55 -0700 (In reply to comment #2) > (From update of attachment 85253 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85253&action=review > > looks sane to me. > > > LayoutTests/editing/deleting/delete-inserts-br-after-button.html:9 > > +target = document.getElementById("container"); > > Nit: Missing "var". > > > LayoutTests/editing/deleting/delete-inserts-br-after-button.html:11 > > +window.getSelection().modify("move", "Right", "character"); > > Nit: Capitalize / de-capitalize all words here (make them consistent). Thanks for the review! I'll fix those and land :) 367227 4 leviw 2011-03-14 14:19:46 -0700 Committed r81056: <http://trac.webkit.org/changeset/81056> 85253 2011-03-09 16:08:29 -0800 2011-03-14 11:31:12 -0700 Patch bug-56053-20110309160827.patch text/plain 4340 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwNjY3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDMtMDkgIExldmkgV2Vp bnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIERlbGV0aW5nIGNvbnRlbnQgZGlyZWN0bHkgZm9sbG93aW5n IGEgYnV0dG9uIGluc2VydHMgYW4gdW5uZWNlc3NhcnkgcGxhY2Vob2xkZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2MDUzCisKKyAgICAgICAgRml4 aW5nIGEgdXNlIG9mIE5vZGUncyBlbmNsb3NpbmdCbG9ja0Zsb3dFbGVtZW50IHdpdGggZW5jbG9z aW5nQmxvY2sgaHRtbGVkaXRpbmcncworICAgICAgICBlbmNsb3NpbmdCbG9jaywgYXMgZW5jbG9z aW5nQmxvY2tGbG93RWxlbWVudCB3b3VsZCByZXR1cm4gaW5saW5lLWJsb2NrIGVsZW1lbnRzIGRl c3BpdGUKKyAgICAgICAgRGVsZXRlU2VsZWN0aW9uQ29tbWFuZCB0cmVhdGluZyB0aGVtIGFzIGJs b2NrZmxvdy4KKworICAgICAgICBUZXN0OiBlZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1pbnNlcnRz LWJyLWFmdGVyLWJ1dHRvbi5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL0RlbGV0ZVNlbGVjdGlv bkNvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGVsZXRlU2VsZWN0aW9uQ29tbWFuZDo6 bWVyZ2VQYXJhZ3JhcGhzKToKKwogMjAxMS0wMy0wOSAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJy YWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0RlbGV0ZVNlbGVjdGlvbkNvbW1hbmQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRGVsZXRlU2VsZWN0aW9uQ29tbWFu ZC5jcHAJKHJldmlzaW9uIDgwNjExKQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVT ZWxlY3Rpb25Db21tYW5kLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTkyLDcgKzU5Miw3IEBAIHZv aWQgRGVsZXRlU2VsZWN0aW9uQ29tbWFuZDo6bWVyZ2VQYXJhZ3IKICAgICB9CiAgICAgCiAgICAg Ly8gV2UgbmVlZCB0byBtZXJnZSBpbnRvIG1fdXBzdHJlYW1TdGFydCdzIGJsb2NrLCBidXQgaXQn cyBiZWVuIGVtcHRpZWQgb3V0IGFuZCBjb2xsYXBzZWQgYnkgZGVsZXRpb24uCi0gICAgaWYgKCFt ZXJnZURlc3RpbmF0aW9uLmRlZXBFcXVpdmFsZW50KCkuZGVwcmVjYXRlZE5vZGUoKSB8fCAhbWVy Z2VEZXN0aW5hdGlvbi5kZWVwRXF1aXZhbGVudCgpLmRlcHJlY2F0ZWROb2RlKCktPmlzRGVzY2Vu ZGFudE9mKG1fdXBzdHJlYW1TdGFydC5kZXByZWNhdGVkTm9kZSgpLT5lbmNsb3NpbmdCbG9ja0Zs b3dFbGVtZW50KCkpIHx8IG1fc3RhcnRzQXRFbXB0eUxpbmUpIHsKKyAgICBpZiAoIW1lcmdlRGVz dGluYXRpb24uZGVlcEVxdWl2YWxlbnQoKS5kZXByZWNhdGVkTm9kZSgpIHx8ICFtZXJnZURlc3Rp bmF0aW9uLmRlZXBFcXVpdmFsZW50KCkuZGVwcmVjYXRlZE5vZGUoKS0+aXNEZXNjZW5kYW50T2Yo ZW5jbG9zaW5nQmxvY2sobV91cHN0cmVhbVN0YXJ0LmNvbnRhaW5lck5vZGUoKSkpIHx8IG1fc3Rh cnRzQXRFbXB0eUxpbmUpIHsKICAgICAgICAgaW5zZXJ0Tm9kZUF0KGNyZWF0ZUJyZWFrRWxlbWVu dChkb2N1bWVudCgpKS5nZXQoKSwgbV91cHN0cmVhbVN0YXJ0KTsKICAgICAgICAgbWVyZ2VEZXN0 aW5hdGlvbiA9IFZpc2libGVQb3NpdGlvbihtX3Vwc3RyZWFtU3RhcnQpOwogICAgIH0KSW5kZXg6 IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHJldmlzaW9uIDgwNjY3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMDkgIExldmkgV2VpbnRyYXViICA8bGV2aXdA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIERlbGV0aW5nIGNvbnRlbnQgZGlyZWN0bHkgZm9sbG93aW5nIGEgYnV0dG9uIGluc2Vy dHMgYW4gdW5uZWNlc3NhcnkgcGxhY2Vob2xkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU2MDUzCisKKyAgICAgICAgVGVzdCB0byBlbnN1cmUgdW5u ZWNlc3NhcnkgcGxhY2Vob2xkZXJzIGFyZW4ndCBpbnNlcnRlZCBhZnRlciBidXR0b25zIHdoZW4g ZGVsZXRlIGlzIHByZXNzZWQuCisKKyAgICAgICAgKiBlZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1p bnNlcnRzLWJyLWFmdGVyLWJ1dHRvbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVk aXRpbmcvZGVsZXRpbmcvZGVsZXRlLWluc2VydHMtYnItYWZ0ZXItYnV0dG9uLmh0bWw6IEFkZGVk LgorCiAyMDExLTAzLTA5ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3Rz L2VkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWluc2VydHMtYnItYWZ0ZXItYnV0dG9uLWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1p bnNlcnRzLWJyLWFmdGVyLWJ1dHRvbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9lZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1pbnNlcnRzLWJyLWFmdGVyLWJ1dHRvbi1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMyBAQAorVGhpcyB0ZXN0cyB0byBz ZWUgaWYgYSBsaW5lIGJyZWFrIGlzIGluY29ycmVjdGx5IGluc2VydGVkIHdoZW4geW91IGRlbGV0 ZSB0aGUgY29udGVudCBkaXJlY3RseSBmb2xsb3dpbmcgYSBidXR0b24uCitidXR0b250aGlzIHRl eHQgc2hvdWxkIGJlIG9uIHRoZSBzYW1lIGxpbmUgYXMgdGhlIGJ1dHRvbgorUEFTUwpJbmRleDog TGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9kZWxldGUtaW5zZXJ0cy1ici1hZnRlci1idXR0 b24uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2RlbGV0aW5nL2RlbGV0 ZS1pbnNlcnRzLWJyLWFmdGVyLWJ1dHRvbi5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvZWRpdGluZy9kZWxldGluZy9kZWxldGUtaW5zZXJ0cy1ici1hZnRlci1idXR0b24uaHRtbAko cmV2aXNpb24gMCkKQEAgLTAsMCArMSwxOCBAQAorPCFET0NUWVBFIGh0bWw+IAorPGh0bWw+Cis8 Ym9keT4KKzxkaXY+VGhpcyB0ZXN0cyB0byBzZWUgaWYgYSBsaW5lIGJyZWFrIGlzIGluY29ycmVj dGx5IGluc2VydGVkIHdoZW4geW91IGRlbGV0ZSB0aGUgY29udGVudCBkaXJlY3RseSBmb2xsb3dp bmcgYSBidXR0b24uPC9kaXY+Cis8ZGl2IGlkPSJjb250YWluZXIiIGNvbnRlbnRlZGl0YWJsZT0i dHJ1ZSI+PGJ1dHRvbj5idXR0b248L2J1dHRvbj4gdGhpcyB0ZXh0IHNob3VsZCBiZSBvbiB0aGUg c2FtZSBsaW5lIGFzIHRoZSBidXR0b248L2Rpdj4KKzxkaXYgaWQ9InJlc3VsdCI+RkFJTDwvZGl2 PgorPC9ib2R5PgorPHNjcmlwdD4KK3RhcmdldCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJj b250YWluZXIiKTsKK3dpbmRvdy5nZXRTZWxlY3Rpb24oKS5zZXRQb3NpdGlvbih0YXJnZXQsIDEp Oword2luZG93LmdldFNlbGVjdGlvbigpLm1vZGlmeSgibW92ZSIsICJSaWdodCIsICJjaGFyYWN0 ZXIiKTsKK2RvY3VtZW50LmV4ZWNDb21tYW5kKCJkZWxldGUiKTsKK2lmICh0YXJnZXQuY2hpbGRO b2Rlcy5sZW5ndGggPT0gMikKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0Iiku aW5uZXJIVE1MID0gIlBBU1MiOworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworPC9zY3JpcHQ+IAor PC9odG1sPgo=