56046 2011-03-09 12:43:11 -0800 [Qt] Text layout is broken on Symbian 2011-03-30 09:38:42 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED Qt P2 Major --- 1 ostap73 ostap73 abarth commit-queue dbates eric laszlo.gombos luiz nlandry skyul webkit.review.bot yong.li.webkit oldest_to_newest 364707 0 ostap73 2011-03-09 12:43:11 -0800 Load any page that has text on Symbian device and text is not rendered. Appeared to be compiler implementation difference. RVCT compiler treats bitfields as unsigned by default and because of this in RenderBlock:lineHeight comparison "m_lineHeight == -1" is always false . There are number of other places in webkit where integers in bitfields are assumed signed (most compilers have this default). By quote from C++(2003) standard section 9.6/3 : “It is implementation-defined whether a plain (neither explicitly signed nor unsigned) char, short, int or long bit-field is signed or unsigned”. 364714 1 85218 ostap73 2011-03-09 12:53:14 -0800 Created attachment 85218 Change bitfield integers to be signed by default on RVCT compiler. 364796 2 85218 laszlo.gombos 2011-03-09 14:47:48 -0800 Comment on attachment 85218 Change bitfield integers to be signed by default on RVCT compiler. r=me. Great. 364817 3 laszlo.gombos 2011-03-09 15:21:10 -0800 CCing Nick, Daniel and Kwang as the "RVCT interest group" to make sure that they evaluate if a similar change is needed for their ports. 365685 4 85218 commit-queue 2011-03-10 17:14:15 -0800 Comment on attachment 85218 Change bitfield integers to be signed by default on RVCT compiler. Clearing flags on attachment: 85218 Committed r80796: <http://trac.webkit.org/changeset/80796> 365686 5 commit-queue 2011-03-10 17:14:21 -0800 All reviewed patches have been landed. Closing bug. 365756 6 webkit.review.bot 2011-03-10 19:29:55 -0800 http://trac.webkit.org/changeset/80796 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: fast/text/large-text-composed-char-dos.html 376398 7 luiz 2011-03-30 09:38:02 -0700 Revision r80796 cherry-picked into qtwebkit-2.1.x with commit 3ecec08c9c7638a214d0e7c272190a94c27fd5cc <https://gitorious.org/+qtwebkit-developers/webkit/qtwebkit/commit/3ecec08c9c7638a214d0e7c272190a94c27fd5cc> 85218 2011-03-09 12:53:14 -0800 2011-03-10 17:14:15 -0800 Change bitfield integers to be signed by default on RVCT compiler. rvct_signed_integers.diff text/plain 1362 ostap73 ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBmZGQzNTA5Li43YWM0NDUz IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDMtMDkgIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hlc2xh dkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW1F0XSBUZXh0IGxheW91dCBpcyBicm9rZW4gb24gU3ltYmlhbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTYwNDYKKworICAgICAgICBDaGFu Z2UgaW50ZWdlcnMgaW5jbHVkZWQgaW50byBiaXRmaWVsZHMgdG8gYmUgc2lnbmVkIGJ5IGRlZmF1 bHQgb24gUlZDVAorICAgICAgICBjb21waWxlciBhcyBhIGxvdCBvZiBvdGhlciBjb21waWxlcnMg ZG8gKGdjYywgbXN2Yywgd2luc2MpLgorICAgICAgICBUaGVyZSBhcmUgYSBsb3Qgb2YgcGxhY2Vz IGluIHdlYmtpdCB3aGVyZSBpbnRlZ2VycyBpbmNsdWRlZCBpbiBiaXRmaWVsZAorICAgICAgICBh cmUgYXNzdW1lZCB0byBiZSBzaWduZWQuCisKKyAgICAgICAgKiBTb3VyY2UvV2ViS2l0LnByaToK KwogMjAxMS0wMy0wNCAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0LnByaSBiL1NvdXJjZS9XZWJLaXQucHJpCmluZGV4IGY2MWI0ODkuLjU1NjM0OGEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQucHJpCisrKyBiL1NvdXJjZS9XZWJLaXQucHJpCkBAIC05Myw3 ICs5Myw3IEBAIGxpbnV4LWcrKyogewogCiBzeW1iaWFufCotYXJtY2MgewogICAgICMgRW5hYmxl IEdOVSBjb21waWxlciBleHRlbnNpb25zIHRvIHRoZSBBUk0gY29tcGlsZXIgZm9yIGFsbCBRdCBw b3J0cyB1c2luZyBSVkNUCi0gICAgUlZDVF9DT01NT05fQ0ZMQUdTID0gLS1nbnUgLS1kaWFnX3N1 cHByZXNzIDY4LDExMSwxNzcsMzY4LDgzMCwxMjkzCisgICAgUlZDVF9DT01NT05fQ0ZMQUdTID0g LS1nbnUgLS1kaWFnX3N1cHByZXNzIDY4LDExMSwxNzcsMzY4LDgzMCwxMjkzIC0tc2lnbmVkX2Jp dGZpZWxkcwogICAgIFJWQ1RfQ09NTU9OX0NYWEZMQUdTID0gJCRSVkNUX0NPTU1PTl9DRkxBR1Mg LS1ub19wYXJzZV90ZW1wbGF0ZXMKICAgICAjIE1ha2UgZGVidWcgc3ltYm9scyBsZWFuZXIgaW4g UlZDVDQueC4gSWdub3JlZCBieSBjb21waWxlciBmb3IgcmVsZWFzZSBidWlsZHMKICAgICBRTUFL RV9DWFhGTEFHUy5BUk1DQ180XzAgKz0gLS1yZW1vdmVfdW5uZWVkZWRfZW50aXRpZXMK