56035 2011-03-09 11:13:23 -0800 Leaks viewer doesn't work in Safari 5 2011-03-10 08:36:24 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 56090 1 simon.fraser aroben oldest_to_newest 364629 0 simon.fraser 2011-03-09 11:13:23 -0800 If I try to use the leaks viewer with Safari 5, it fails with some JS exceptions: TypeError: Result of expression 'document.getElementById("url-prompt-container").classList' [undefined] is not an object. LeaksViewer.js:111TypeError: Result of expression 'this._loadingIndicator.classList' [undefined] is not an object. 364650 1 85205 aroben 2011-03-09 11:30:43 -0800 Created attachment 85205 Don't use Element.classList or box-shadow in Leaks Viewer 364658 2 aroben 2011-03-09 11:43:54 -0800 Committed r80656: <http://trac.webkit.org/changeset/80656> 85205 2011-03-09 11:30:43 -0800 2011-03-09 11:37:36 -0800 Don't use Element.classList or box-shadow in Leaks Viewer bug-56035-20110309143111.patch text/plain 3408 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogODA2NTIKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL0xlYWtzVmlld2VyL0xl YWtzVmlld2VyLmNzcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL3B1YmxpY19odG1sL0xlYWtzVmlld2VyL0xlYWtzVmlld2VyLmNzcwppbmRleCBiZWZk ZDI5ZWM0MDU5YWIyMWE4Zjk0MjUyYjk5NDNhOGM1MzI1OGM3Li45OWRlMDUxODEzNzU5Zjg1YTM2 NDQ4NzQxZDNlNmIzMDJhYzc0MTBiIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9y dC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9MZWFrc1ZpZXdlci9MZWFrc1Zp ZXdlci5jc3MKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvTGVha3NWaWV3ZXIvTGVha3NWaWV3ZXIuY3NzCkBAIC00Myw3ICs0 Myw3IEBACiAgICAgaGVpZ2h0OiAyMDBweDsKICAgICBtYXJnaW46IGF1dG87CiAgICAgYmFja2dy b3VuZC1jb2xvcjogd2hpdGU7Ci0gICAgYm94LXNoYWRvdzogMCA1cHggMTBweCByZ2JhKDAsIDAs IDAsIDAuOCk7CisgICAgLXdlYmtpdC1ib3gtc2hhZG93OiAwIDVweCAxMHB4IHJnYmEoMCwgMCwg MCwgMC44KTsKICAgICBwYWRkaW5nOiA1MHB4IDA7CiAgICAgdGV4dC1hbGlnbjogY2VudGVyOwog fQpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvTGVha3NWaWV3ZXIvTGVha3NWaWV3ZXIuanMgYi9Ub29scy9CdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9MZWFrc1Zp ZXdlci9MZWFrc1ZpZXdlci5qcwppbmRleCBjZjA3NjIwMTM5YTBmNWEwZDAzOWJiM2M0OTQ2OGFl MTNjNjdmMTU2Li40ZmYwOTcwMDIyMjFlMjViMzU5OTg0YjA4NmVhMTc2NGQzMDQ2NmZlIDEwMDY0 NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9MZWFrc1ZpZXdlci9MZWFrc1ZpZXdlci5qcworKysgYi9Ub29scy9CdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9MZWFrc1ZpZXdl ci9MZWFrc1ZpZXdlci5qcwpAQCAtNzYsMTEgKzc2LDExIEBAIHZhciBMZWFrc1ZpZXdlciA9IHsK IAogICAgIHVybFByb21wdEJ1dHRvbkNsaWNrZWQ6IGZ1bmN0aW9uKGUpIHsKICAgICAgICAgdGhp cy5fbG9hZExlYWtzRnJvbVVSTChkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidXJsIikudmFsdWUp OwotICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidXJsLXByb21wdC1jb250YWluZXIi KS5jbGFzc0xpc3QuYWRkKCJoaWRkZW4iKTsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoInVybC1wcm9tcHQtY29udGFpbmVyIikuYWRkU3R5bGVDbGFzcygiaGlkZGVuIik7CiAgICAg fSwKIAogICAgIF9kaXNwbGF5VVJMUHJvbXB0OiBmdW5jdGlvbigpIHsKLSAgICAgICAgZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoInVybC1wcm9tcHQtY29udGFpbmVyIikuY2xhc3NMaXN0LnJlbW92 ZSgiaGlkZGVuIik7CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ1cmwtcHJvbXB0 LWNvbnRhaW5lciIpLnJlbW92ZVN0eWxlQ2xhc3MoImhpZGRlbiIpOwogICAgICAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgidXJsIikuZm9jdXMoKTsKICAgICB9LAogCkBAIC0xMDYsOSArMTA2 LDkgQEAgdmFyIExlYWtzVmlld2VyID0gewogCiAgICAgX3NldExvYWRpbmdJbmRpY2F0b3JIaWRk ZW46IGZ1bmN0aW9uKGhpZGRlbikgewogICAgICAgICBpZiAoaGlkZGVuKQotICAgICAgICAgICAg dGhpcy5fbG9hZGluZ0luZGljYXRvci5jbGFzc0xpc3QuYWRkKCJoaWRkZW4iKTsKKyAgICAgICAg ICAgIHRoaXMuX2xvYWRpbmdJbmRpY2F0b3IuYWRkU3R5bGVDbGFzcygiaGlkZGVuIik7CiAgICAg ICAgIGVsc2UKLSAgICAgICAgICAgIHRoaXMuX2xvYWRpbmdJbmRpY2F0b3IuY2xhc3NMaXN0LnJl bW92ZSgiaGlkZGVuIik7CisgICAgICAgICAgICB0aGlzLl9sb2FkaW5nSW5kaWNhdG9yLnJlbW92 ZVN0eWxlQ2xhc3MoImhpZGRlbiIpOwogICAgIH0sCiAKICAgICBfdXBkYXRlVGl0bGU6IGZ1bmN0 aW9uKCkgewpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IDM4Y2UyYTNlN2NkZDNiOWZkOTIxNjQwMDQ1NGNhOGI1MWViNDMxMGIuLjkzMDNkNjlkOGZj MmVkMDRhNDhmMTk0MjQ2YjMyODJjNjBjNGI2NDQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNCBAQAogMjAxMS0wMy0wOSAgQWRh bSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKKyAgICAgICAgRG9uJ3QgdXNlIEVsZW1lbnQu Y2xhc3NMaXN0IG9yIGJveC1zaGFkb3cgaW4gTGVha3MgVmlld2VyCisKKyAgICAgICAgVGhleSBh cmVuJ3Qgc3VwcG9ydGVkIGJ5IFNhZmFyaSA1LiBMdWNraWx5IHdlIGhhdmUgc3Vic3RpdHV0ZXMg Zm9yIHRoZW0hCisKKyAgICAgICAgRml4ZXMgPGh0dHA6Ly93ZWJraXQub3JnL2IvNTYwMzU+IExl YWtzIHZpZXdlciBkb2Vzbid0IHdvcmsgaW4gU2FmYXJpIDUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndl YmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL0xlYWtzVmlld2VyL0xlYWtzVmlld2VyLmNzczoK KyAgICAgICAgKCN1cmwtcHJvbXB0KTogVXNlIC13ZWJraXQtYm94LXNoYWRvdyBpbnN0ZWFkIG9m IGJveC1zaGFkb3cuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9MZWFrc1ZpZXdlci9MZWFrc1ZpZXdlci5qczoKKyAgICAg ICAgKExlYWtzVmlld2VyLnVybFByb21wdEJ1dHRvbkNsaWNrZWQpOgorICAgICAgICAoTGVha3NW aWV3ZXIuX2Rpc3BsYXlVUkxQcm9tcHQpOgorICAgICAgICAoTGVha3NWaWV3ZXIuX3NldExvYWRp bmdJbmRpY2F0b3JIaWRkZW4pOgorICAgICAgICBVc2UgYWRkL3JlbW92ZVN0eWxlQ2xhc3MgKGZy b20gdXRpbGl0aWVzLmpzKSBpbnN0ZWFkIG9mIEVsZW1lbnQuY2xhc3NMaXN0LgorCisyMDExLTAz LTA5ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KKwogICAgICAgICBBZGQgYSBsaW5r IHRvIHRoZSBMZWFrcyBWaWV3ZXIgdG9vbCBvbiB0aGUgYnVpbGQud2Via2l0Lm9yZyBob21lcGFn ZQogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IERhdmlkIEtpbHplci4K