56024 2011-03-09 09:57:31 -0800 Web Inspector: it should be possible to copy stack trace from call stack sidebar pane 2011-03-09 11:22:15 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov podivilov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 364552 0 podivilov 2011-03-09 09:57:31 -0800 Web Inspector: it should be possible to copy stack trace from call stack sidebar pane. 364554 1 85187 podivilov 2011-03-09 09:58:06 -0800 Created attachment 85187 Patch. 364558 2 podivilov 2011-03-09 10:02:00 -0800 Sample clipboard: 1. createMenu() at committers-autocomplete.js:275 2. enableAutoComplete() at committers-autocomplete.js:373 3. WebKitCommitters.getCommitters.m_committers() at committers-autocomplete.js:390 4. showEditableField() at field.js:188 5. addListener.O() at yahoo-dom-event.js:8 364567 3 85187 pfeldman 2011-03-09 10:18:04 -0800 Comment on attachment 85187 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=85187&action=review > Source/WebCore/inspector/front-end/CallStackSidebarPane.js:85 > + this._text += WebInspector.UIString("%i. %s() at %s", i + 1, title, subtitle) + "\n"; I am not sure we need numbers. Do Xcode and VS produce those? 364614 4 podivilov 2011-03-09 10:57:28 -0800 (In reply to comment #3) > (From update of attachment 85187 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85187&action=review > > > Source/WebCore/inspector/front-end/CallStackSidebarPane.js:85 > > + this._text += WebInspector.UIString("%i. %s() at %s", i + 1, title, subtitle) + "\n"; > > I am not sure we need numbers. Do Xcode and VS produce those? XCode: "#n ..." where n is zero based frame number counting from the top VS: no numbers Eclipse: "n ..." where n is one based frame number counting from the bottom 364644 5 podivilov 2011-03-09 11:22:15 -0800 Committed r80655: <http://trac.webkit.org/changeset/80655> 85187 2011-03-09 09:58:06 -0800 2011-03-09 10:18:04 -0800 Patch. patch text/plain 2941 podivilov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMzViOTNkLi5lOTMxNGNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDMtMDkgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIElu c3BlY3RvcjogaXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGNvcHkgc3RhY2sgdHJhY2UgZnJvbSBj YWxsIHN0YWNrIHNpZGViYXIgcGFuZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU2MDI0CisKKyAgICAgICAgKiBFbmdsaXNoLmxwcm9qL2xvY2FsaXpl ZFN0cmluZ3MuanM6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9DYWxsU3RhY2tTaWRl YmFyUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5DYWxsU3RhY2tTaWRlYmFyUGFuZSk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ2FsbFN0YWNrU2lkZWJhclBhbmUucHJvdG90eXBlLnVw ZGF0ZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ2FsbFN0YWNrU2lkZWJhclBhbmUucHJvdG90 eXBlLl9jb250ZXh0TWVudSk6CisKIDIwMTEtMDMtMDggIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNh QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBiL1Nv dXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwppbmRleCBjZDRl NmFhODcwMjYwYzcwYTg1YTlmOWRkZDIwM2NiNjYwNWM0YzJiLi43Y2NlZjJmNjk5NzBkYjI4ZTY2 MDIyYzI0YjQ3ZTk1ZDk4YzcyODBjIDEwMDY0NApHSVQgYmluYXJ5IHBhdGNoCmRlbHRhIDEzMAp6 Y21YQEppaDExezxfJGhxQ3RGPW41bWpaI1dZQSshVXtHWiFYMyR7SjFoTnR0Tit2ZjdpVjk7Qnt9 XkM2Kis3IzsKbnZWZnJ5czR8JEwxZ0pXaEFzZmdKVkpISHpDa3R1YEU4dnU2Tk0lckJ1eDA9Tig4 P1BACgpkZWx0YSA5ClFjbVozdGhXWDRZPF8kaHEwVCh8NnJ+bSl9CgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9DYWxsU3RhY2tTaWRlYmFyUGFuZS5qcyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ2FsbFN0YWNrU2lkZWJhclBhbmUu anMKaW5kZXggZTE2MThiMi4uNjBhMmEyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9DYWxsU3RhY2tTaWRlYmFyUGFuZS5qcworKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NhbGxTdGFja1NpZGViYXJQYW5lLmpzCkBAIC0yNyw2 ICsyNyw4IEBAIFdlYkluc3BlY3Rvci5DYWxsU3RhY2tTaWRlYmFyUGFuZSA9IGZ1bmN0aW9uKG1v ZGVsKQogewogICAgIFdlYkluc3BlY3Rvci5TaWRlYmFyUGFuZS5jYWxsKHRoaXMsIFdlYkluc3Bl Y3Rvci5VSVN0cmluZygiQ2FsbCBTdGFjayIpKTsKICAgICB0aGlzLl9tb2RlbCA9IG1vZGVsOwor CisgICAgdGhpcy5ib2R5RWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjb250ZXh0bWVudSIsIHRo aXMuX2NvbnRleHRNZW51LmJpbmQodGhpcyksIHRydWUpOwogfQogCiBXZWJJbnNwZWN0b3IuQ2Fs bFN0YWNrU2lkZWJhclBhbmUucHJvdG90eXBlID0gewpAQCAtMzUsNiArMzcsNyBAQCBXZWJJbnNw ZWN0b3IuQ2FsbFN0YWNrU2lkZWJhclBhbmUucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLmJv ZHlFbGVtZW50LnJlbW92ZUNoaWxkcmVuKCk7CiAKICAgICAgICAgdGhpcy5wbGFjYXJkcyA9IFtd OworICAgICAgICB0aGlzLl90ZXh0ID0gIiI7CiAKICAgICAgICAgaWYgKCFkZXRhaWxzKSB7CiAg ICAgICAgICAgICB2YXIgaW5mb0VsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYi KTsKQEAgLTc4LDYgKzgxLDggQEAgV2ViSW5zcGVjdG9yLkNhbGxTdGFja1NpZGViYXJQYW5lLnBy b3RvdHlwZSA9IHsKIAogICAgICAgICAgICAgdGhpcy5wbGFjYXJkcy5wdXNoKHBsYWNhcmQpOwog ICAgICAgICAgICAgdGhpcy5ib2R5RWxlbWVudC5hcHBlbmRDaGlsZChwbGFjYXJkLmVsZW1lbnQp OworCisgICAgICAgICAgICB0aGlzLl90ZXh0ICs9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiJWku ICVzKCkgYXQgJXMiLCBpICsgMSwgdGl0bGUsIHN1YnRpdGxlKSArICJcbiI7CiAgICAgICAgIH0K IAogICAgICAgICBpZiAoZGV0YWlscy5icmVha3BvaW50KQpAQCAtMTQ4LDYgKzE1MywxNiBAQCBX ZWJJbnNwZWN0b3IuQ2FsbFN0YWNrU2lkZWJhclBhbmUucHJvdG90eXBlID0gewogICAgICAgICB0 aGlzLnNlbGVjdGVkQ2FsbEZyYW1lID0gcGxhY2FyZEVsZW1lbnQucGxhY2FyZC5jYWxsRnJhbWU7 CiAgICAgfSwKIAorICAgIF9jb250ZXh0TWVudTogZnVuY3Rpb24oZXZlbnQpCisgICAgeworICAg ICAgICBpZiAoIXRoaXMuX3RleHQpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgdmFy IGNvbnRleHRNZW51ID0gbmV3IFdlYkluc3BlY3Rvci5Db250ZXh0TWVudSgpOworICAgICAgICBj b250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmluZygiQ29weSBTdGFjayBU cmFjZSIpLCBJbnNwZWN0b3JGcm9udGVuZEhvc3QuY29weVRleHQuYmluZChJbnNwZWN0b3JGcm9u dGVuZEhvc3QsIHRoaXMuX3RleHQpKTsKKyAgICAgICAgY29udGV4dE1lbnUuc2hvdyhldmVudCk7 CisgICAgfSwKKwogICAgIHJlZ2lzdGVyU2hvcnRjdXRzOiBmdW5jdGlvbihzZWN0aW9uKQogICAg IHsKICAgICAgICAgdGhpcy5fc2hvcnRjdXRzID0ge307Cg==