56002 2011-03-09 02:00:04 -0800 Web Inspector: [STYLES] Editing a property value adds a word for any property value that uses a paren 2011-03-10 10:27:21 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 364381 0 apavlov 2011-03-09 02:00:04 -0800 1. Open any page 2. Open the webinspector and pick and element 3. In the element style properties, try to add something like: -webkit-transform: translateZ(0) You'll notice that the moment you type the open parenthesis the word "initial" appears, greyed out. There is no way to remove that so by the time you're done typing you end up with: -webkit-transform: translateZ(0)initial If a property accepts color keywords, you can end up with the word "aliceblue" instead. Upstreaming http://code.google.com/p/chromium/issues/detail?id=75302 364415 1 85156 apavlov 2011-03-09 03:50:18 -0800 Created attachment 85156 [PATCH] Suggested fix 364548 2 joepeck 2011-03-09 09:49:19 -0800 Would the suggestion still affect url()? If you input "url(i" it might suggest initial? Any way to prevent that, or is it a separate bug I should file a new bug? 365110 3 apavlov 2011-03-10 05:28:18 -0800 (In reply to comment #2) > Would the suggestion still affect url()? If you input "url(i" it might suggest initial? > Any way to prevent that, or is it a separate bug I should file a new bug? I wouldn't call it a bug :) Frankly speaking, we do not parse the current value contents and only offer prefix-based suggestions with all keywords allowed in the current property values (and "initial" is one of the keywords). If that is a real nuisance, feel free to file a bug. 365111 4 apavlov 2011-03-10 05:29:29 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/front-end/StylesSidebarPane.js Committed r80710 365280 5 joepeck 2011-03-10 10:15:57 -0800 (In reply to comment #3) > (In reply to comment #2) > > Would the suggestion still affect url()? If you input "url(i" it might suggest initial? > > Any way to prevent that, or is it a separate bug I should file a new bug? > > I wouldn't call it a bug :) Sure, an enhancement. I filed: <http://webkit.org/b/56118> Web Inspector: CSS Autocomplete Should Use More Contextual Information The same can be done for JavaScript, but I think we already have some relevant bugs. I had a patch for improving getElementById to autocomplete id's, but it never landed. 365294 6 apavlov 2011-03-10 10:27:21 -0800 (In reply to comment #5) > (In reply to comment #3) > > (In reply to comment #2) > > > Would the suggestion still affect url()? If you input "url(i" it might suggest initial? > > > Any way to prevent that, or is it a separate bug I should file a new bug? > > > > I wouldn't call it a bug :) > > Sure, an enhancement. I filed: > <http://webkit.org/b/56118> Web Inspector: CSS Autocomplete Should Use More Contextual Information > > The same can be done for JavaScript, but I think we already have some relevant bugs. > I had a patch for improving getElementById to autocomplete id's, but it never landed. Good thing -- can you share your thoughts with me, perhaps over email? I'm curious about to what extent you think the input should be analyzed. 85156 2011-03-09 03:50:18 -0800 2011-03-10 05:29:41 -0800 [PATCH] Suggested fix cssprompt.patch text/plain 1423 apavlov Y29tbWl0IDBhZGIyNzFjMmNmMTY1MTc4NzBkOTllYmVmMTg5MGViNDMzZmQ5YjYKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBXZWQgTWFyIDkg MTQ6NDY6NDIgMjAxMSArMDMwMAoKICAgIGZpeAoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1Y2ZmYmRmLi4yZDMw ODFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDMtMDkgIEFsZXhhbmRlciBQ YXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbU1RZTEVTXSBFZGl0aW5nIGEg cHJvcGVydHkgdmFsdWUgYWRkcyBhIHdvcmQgZm9yIGFueSBwcm9wZXJ0eSB2YWx1ZSB0aGF0IHVz ZXMgYSBwYXJlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTYwMDIKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBh bmUuanM6IEludHJvZHVjZSBhbiBhZGRpdGlvbmFsIGNoZWNrLgorCiAyMDExLTAzLTA4ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKaW5kZXggYzdkMTUxYS4uZDY1OTMyYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFy UGFuZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1Np ZGViYXJQYW5lLmpzCkBAIC0xOTY0LDYgKzE5NjQsOSBAQCBXZWJJbnNwZWN0b3IuU3R5bGVzU2lk ZWJhclBhbmUuQ1NTUHJvcGVydHlQcm9tcHQucHJvdG90eXBlID0gewogICAgIF9idWlsZFByb3Bl cnR5Q29tcGxldGlvbnM6IGZ1bmN0aW9uKHdvcmRSYW5nZSwgYmVzdE1hdGNoT25seSwgY29tcGxl dGlvbnNSZWFkeUNhbGxiYWNrKQogICAgIHsKICAgICAgICAgdmFyIHByZWZpeCA9IHdvcmRSYW5n ZS50b1N0cmluZygpLnRvTG93ZXJDYXNlKCk7CisgICAgICAgIGlmICghcHJlZml4ICYmIGJlc3RN YXRjaE9ubHkpCisgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgdmFyIHJlc3VsdHM7CiAg ICAgICAgIGlmIChiZXN0TWF0Y2hPbmx5KSB7CiAgICAgICAgICAgICByZXN1bHRzID0gW107Cg==