55989 2011-03-08 18:09:11 -0800 [GTK] Possible leaks after splitting TextCheckerClientEnchant. 2011-03-14 20:50:56 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 ryuan.choi webkit-unassigned commit-queue gustavo.noronha gustavo mrobinson xan.lopez oldest_to_newest 364270 0 ryuan.choi 2011-03-08 18:09:11 -0800 I removed g_free(ctext); in Bug 51587, but I am missing to change it's type. 364276 1 85121 ryuan.choi 2011-03-08 18:17:57 -0800 Created attachment 85121 Patch 364312 2 85121 mrobinson 2011-03-08 21:34:49 -0800 Comment on attachment 85121 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85121&action=review Thanks for fixing this. > Source/WebKit/gtk/WebCoreSupport/TextCheckerClientEnchant.cpp:81 > + int utflen = g_utf8_strlen(ctext.get(), -1); Please change ctext to utf8Text and utflen to utf8Length. I know that you didn't add this code, but utflen makes no sense at all. :) 364318 3 85131 ryuan.choi 2011-03-08 21:59:20 -0800 Created attachment 85131 simplechanges 364320 4 ryuan.choi 2011-03-08 22:01:27 -0800 (In reply to comment #2) > (From update of attachment 85121 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85121&action=review > > Thanks for fixing this. > > > Source/WebKit/gtk/WebCoreSupport/TextCheckerClientEnchant.cpp:81 > > + int utflen = g_utf8_strlen(ctext.get(), -1); > > Please change ctext to utf8Text and utflen to utf8Length. I know that you didn't add this code, but utflen makes no sense at all. :) I changed as you mentioned. Additionally I fixed some coding style and removed remained g_free. 364321 5 85132 ryuan.choi 2011-03-08 22:04:22 -0800 Created attachment 85132 simplechanges 364330 6 gustavo.noronha 2011-03-08 23:05:38 -0800 Attachment 85131 did not build on gtk: Build output: http://queues.webkit.org/results/8113347 364743 7 85132 mrobinson 2011-03-09 13:32:16 -0800 Comment on attachment 85132 simplechanges View in context: https://bugs.webkit.org/attachment.cgi?id=85132&action=review Thanks for continuing to clean this code up! I really appreciate it. I've one suggested change. > Source/WebKit/gtk/WebCoreSupport/TextCheckerClientEnchant.cpp:113 > + g_utf8_strncpy(word.get(), cstart, end - start); We've already calculated the final offset here, why not do this: CString word(cstart, bytes); int result = enchant_dict_check(dict, word.data(), -1); 366537 8 85576 ryuan.choi 2011-03-12 00:33:30 -0800 Created attachment 85576 Patch 366539 9 ryuan.choi 2011-03-12 00:41:42 -0800 (In reply to comment #7) > (From update of attachment 85132 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85132&action=review > > Thanks for continuing to clean this code up! I really appreciate it. I've one suggested change. > > > Source/WebKit/gtk/WebCoreSupport/TextCheckerClientEnchant.cpp:113 > > + g_utf8_strncpy(word.get(), cstart, end - start); > > We've already calculated the final offset here, why not do this: > > CString word(cstart, bytes); > int result = enchant_dict_check(dict, word.data(), -1); Personally, it's my pleasure to contribute something for WebKit and get your review. I update patch as you mentioned. Additionally, I thought that some logic will be moved out of nested for loop because it looks not changed in nested for loop. 366689 10 85576 mrobinson 2011-03-13 00:29:09 -0800 Comment on attachment 85576 Patch Thanks! Great cleanup. 366719 11 85576 commit-queue 2011-03-13 13:18:16 -0700 Comment on attachment 85576 Patch Rejecting attachment 85576 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'build-..." exit_code: 2 Last 500 characters of output: ...................................... tables/mozilla_expected_failures/other .. transforms .... transforms/2d ............ transforms/3d/general ..... transforms/3d/hit-testing .... transforms/3d/point-mapping ........ transitions ................. transitions/interrupted-accelerated-transition.html -> failed Exiting early after 1 failures. 21676 tests run. 525.42s total testing time 21675 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 13 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/8175073 366783 12 ryuan.choi 2011-03-13 18:41:40 -0700 Hmm. I don't know why that test case was failed. I tested in my PC, but It looks OK like below. root@ryuan2-desktop:/workspace/gtk_webkit# WebKitBuild/Release/Programs/DumpRenderTree LayoutTests/transitions/interrupted-accelerated-transition.html main frame - has 1 onunload handler(s) PASS - "opacity" property for "box" element at 0.5s saw something close to: 0.5 #EOF Can I know how to reproduce? 367184 13 mrobinson 2011-03-14 13:37:53 -0700 I'm pretty sure this patch is unrelated to that failure. Probaly the test is just flaky. I'll flip the bit again. 367481 14 85576 commit-queue 2011-03-14 20:50:50 -0700 Comment on attachment 85576 Patch Clearing flags on attachment: 85576 Committed r81102: <http://trac.webkit.org/changeset/81102> 367482 15 commit-queue 2011-03-14 20:50:56 -0700 All reviewed patches have been landed. Closing bug. 85121 2011-03-08 18:17:57 -0800 2011-03-08 21:59:14 -0800 Patch bug-55989-20110309111755.patch text/plain 2461 ryuan.choi SW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwNjEyKQorKysgU291cmNlL1dlYktpdC9n dGsvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMDgg IFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFBvc3NpYmxlIGxlYWtzIGFmdGVy IHNwbGl0dGluZyBUZXh0Q2hlY2tlckNsaWVudEVuY2hhbnQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTk4OQorCisgICAgICAgICogV2ViQ29yZVN1 cHBvcnQvVGV4dENoZWNrZXJDbGllbnRFbmNoYW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6VGV4 dENoZWNrZXJDbGllbnRFbmNoYW50OjpjaGVja1NwZWxsaW5nT2ZTdHJpbmcpOiBDb252ZXJ0IGdj aGFyKiB0byBHT3duUHRyPGdjaGFyPi4KKwogMjAxMS0wMy0wOCAgQ2hyaXN0aWFuIER5d2FuICA8 Y2hyaXN0aWFuQGxhbmVkby5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmlu c29uLgpJbmRleDogU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvVGV4dENoZWNrZXJD bGllbnRFbmNoYW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9UZXh0Q2hlY2tlckNsaWVudEVuY2hhbnQuY3BwCShyZXZpc2lvbiA4MDYxMSkKKysr IFNvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L1RleHRDaGVja2VyQ2xpZW50RW5jaGFu dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc3LDE0ICs3NywxNCBAQCB2b2lkIFRleHRDaGVja2Vy Q2xpZW50RW5jaGFudDo6Y2hlY2tTcGVsCiAgICAgaWYgKCFkaWN0cykKICAgICAgICAgcmV0dXJu OwogCi0gICAgZ2NoYXIqIGN0ZXh0ID0gZ191dGYxNl90b191dGY4KGNvbnN0X2Nhc3Q8Z3VuaWNo YXIyKj4odGV4dCksIGxlbmd0aCwgMCwgMCwgMCk7Ci0gICAgaW50IHV0ZmxlbiA9IGdfdXRmOF9z dHJsZW4oY3RleHQsIC0xKTsKKyAgICBHT3duUHRyPGdjaGFyPiBjdGV4dChnX3V0ZjE2X3RvX3V0 ZjgoY29uc3RfY2FzdDxndW5pY2hhcjIqPih0ZXh0KSwgbGVuZ3RoLCAwLCAwLCAwKSk7CisgICAg aW50IHV0ZmxlbiA9IGdfdXRmOF9zdHJsZW4oY3RleHQuZ2V0KCksIC0xKTsKIAogICAgIFBhbmdv TGFuZ3VhZ2UqIGxhbmd1YWdlKHBhbmdvX2xhbmd1YWdlX2dldF9kZWZhdWx0KCkpOwogICAgIEdP d25QdHI8UGFuZ29Mb2dBdHRyPiBhdHRycyhnX25ldyhQYW5nb0xvZ0F0dHIsIHV0ZmxlbisxKSk7 CiAKICAgICAvLyBwYW5nb19nZXRfbG9nX2F0dHJzIHVzZXMgYW4gYWRpdGlvbmFsIHBvc2l0aW9u IGF0IHRoZSBlbmQgb2YgdGhlIHRleHQuCi0gICAgcGFuZ29fZ2V0X2xvZ19hdHRycyhjdGV4dCwg LTEsIC0xLCBsYW5ndWFnZSwgYXR0cnMuZ2V0KCksIHV0ZmxlbisxKTsKKyAgICBwYW5nb19nZXRf bG9nX2F0dHJzKGN0ZXh0LmdldCgpLCAtMSwgLTEsIGxhbmd1YWdlLCBhdHRycy5nZXQoKSwgdXRm bGVuKzEpOwogCiAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBsZW5ndGgrMTsgaSsrKSB7CiAgICAg ICAgIC8vIFdlIGdvIHRocm91Z2ggZWFjaCBjaGFyYWN0ZXIgdW50aWwgd2UgZmluZCBhbiBpc193 b3JkX3N0YXJ0LApAQCAtMTA1LDggKzEwNSw4IEBAIHZvaWQgVGV4dENoZWNrZXJDbGllbnRFbmNo YW50OjpjaGVja1NwZWwKIAogICAgICAgICAgICAgZm9yICg7IGRpY3RzOyBkaWN0cyA9IGRpY3Rz LT5uZXh0KSB7CiAgICAgICAgICAgICAgICAgRW5jaGFudERpY3QqIGRpY3QgPSBzdGF0aWNfY2Fz dDxFbmNoYW50RGljdCo+KGRpY3RzLT5kYXRhKTsKLSAgICAgICAgICAgICAgICBnY2hhciogY3N0 YXJ0ID0gZ191dGY4X29mZnNldF90b19wb2ludGVyKGN0ZXh0LCBzdGFydCk7Ci0gICAgICAgICAg ICAgICAgZ2ludCBieXRlcyA9IHN0YXRpY19jYXN0PGdpbnQ+KGdfdXRmOF9vZmZzZXRfdG9fcG9p bnRlcihjdGV4dCwgZW5kKSAtIGNzdGFydCk7CisgICAgICAgICAgICAgICAgZ2NoYXIqIGNzdGFy dCA9IGdfdXRmOF9vZmZzZXRfdG9fcG9pbnRlcihjdGV4dC5nZXQoKSwgc3RhcnQpOworICAgICAg ICAgICAgICAgIGdpbnQgYnl0ZXMgPSBzdGF0aWNfY2FzdDxnaW50PihnX3V0Zjhfb2Zmc2V0X3Rv X3BvaW50ZXIoY3RleHQuZ2V0KCksIGVuZCkgLSBjc3RhcnQpOwogICAgICAgICAgICAgICAgIGdj aGFyKiB3b3JkID0gZ19uZXcwKGdjaGFyLCBieXRlcysxKTsKICAgICAgICAgICAgICAgICBpbnQg cmVzdWx0OwogCg== 85131 2011-03-08 21:59:20 -0800 2011-03-08 22:04:18 -0800 simplechanges bug-55989-20110309145915.patch text/plain 3058 ryuan.choi SW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwNjEyKQorKysgU291cmNlL1dlYktpdC9n dGsvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMDgg IFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFBvc3NpYmxlIGxlYWtzIGFmdGVy IHNwbGl0dGluZyBUZXh0Q2hlY2tlckNsaWVudEVuY2hhbnQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTk4OQorCisgICAgICAgICogV2ViQ29yZVN1 cHBvcnQvVGV4dENoZWNrZXJDbGllbnRFbmNoYW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6VGV4 dENoZWNrZXJDbGllbnRFbmNoYW50OjpjaGVja1NwZWxsaW5nT2ZTdHJpbmcpOiBDb252ZXJ0IGdj aGFyKiB0byBHT3duUHRyPGdjaGFyPi4KKwogMjAxMS0wMy0wOCAgQ2hyaXN0aWFuIER5d2FuICA8 Y2hyaXN0aWFuQGxhbmVkby5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmlu c29uLgpJbmRleDogU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvVGV4dENoZWNrZXJD bGllbnRFbmNoYW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9UZXh0Q2hlY2tlckNsaWVudEVuY2hhbnQuY3BwCShyZXZpc2lvbiA4MDYxMSkKKysr IFNvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L1RleHRDaGVja2VyQ2xpZW50RW5jaGFu dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc3LDE2ICs3NywxNiBAQCB2b2lkIFRleHRDaGVja2Vy Q2xpZW50RW5jaGFudDo6Y2hlY2tTcGVsCiAgICAgaWYgKCFkaWN0cykKICAgICAgICAgcmV0dXJu OwogCi0gICAgZ2NoYXIqIGN0ZXh0ID0gZ191dGYxNl90b191dGY4KGNvbnN0X2Nhc3Q8Z3VuaWNo YXIyKj4odGV4dCksIGxlbmd0aCwgMCwgMCwgMCk7Ci0gICAgaW50IHV0ZmxlbiA9IGdfdXRmOF9z dHJsZW4oY3RleHQsIC0xKTsKKyAgICBHT3duUHRyPGdjaGFyPiB1dGY4VGV4dChnX3V0ZjE2X3Rv X3V0ZjgoY29uc3RfY2FzdDxndW5pY2hhcjIqPih0ZXh0KSwgbGVuZ3RoLCAwLCAwLCAwKSk7Cisg ICAgaW50IHV0ZjhMZW5ndGggPSBnX3V0Zjhfc3RybGVuKHV0ZjhUZXh0LmdldCgpLCAtMSk7CiAK ICAgICBQYW5nb0xhbmd1YWdlKiBsYW5ndWFnZShwYW5nb19sYW5ndWFnZV9nZXRfZGVmYXVsdCgp KTsKLSAgICBHT3duUHRyPFBhbmdvTG9nQXR0cj4gYXR0cnMoZ19uZXcoUGFuZ29Mb2dBdHRyLCB1 dGZsZW4rMSkpOworICAgIEdPd25QdHI8UGFuZ29Mb2dBdHRyPiBhdHRycyhnX25ldyhQYW5nb0xv Z0F0dHIsIHV0ZjhMZW5ndGggKyAxKSk7CiAKICAgICAvLyBwYW5nb19nZXRfbG9nX2F0dHJzIHVz ZXMgYW4gYWRpdGlvbmFsIHBvc2l0aW9uIGF0IHRoZSBlbmQgb2YgdGhlIHRleHQuCi0gICAgcGFu Z29fZ2V0X2xvZ19hdHRycyhjdGV4dCwgLTEsIC0xLCBsYW5ndWFnZSwgYXR0cnMuZ2V0KCksIHV0 ZmxlbisxKTsKKyAgICBwYW5nb19nZXRfbG9nX2F0dHJzKHV0ZjhUZXh0LmdldCgpLCAtMSwgLTEs IGxhbmd1YWdlLCBhdHRycy5nZXQoKSwgdXRmOExlbmd0aCArIDEpOwogCi0gICAgZm9yIChpbnQg aSA9IDA7IGkgPCBsZW5ndGgrMTsgaSsrKSB7CisgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBsZW5n dGggKyAxOyBpKyspIHsKICAgICAgICAgLy8gV2UgZ28gdGhyb3VnaCBlYWNoIGNoYXJhY3RlciB1 bnRpbCB3ZSBmaW5kIGFuIGlzX3dvcmRfc3RhcnQsCiAgICAgICAgIC8vIHRoZW4gd2UgZ2V0IGlu dG8gYW4gaW5uZXIgbG9vcCB0byBmaW5kIHRoZSBpc193b3JkX2VuZCBjb3JyZXNwb25kaW5nCiAg ICAgICAgIC8vIHRvIGl0LgpAQCAtMTA1LDE1ICsxMDUsMTQgQEAgdm9pZCBUZXh0Q2hlY2tlckNs aWVudEVuY2hhbnQ6OmNoZWNrU3BlbAogCiAgICAgICAgICAgICBmb3IgKDsgZGljdHM7IGRpY3Rz ID0gZGljdHMtPm5leHQpIHsKICAgICAgICAgICAgICAgICBFbmNoYW50RGljdCogZGljdCA9IHN0 YXRpY19jYXN0PEVuY2hhbnREaWN0Kj4oZGljdHMtPmRhdGEpOwotICAgICAgICAgICAgICAgIGdj aGFyKiBjc3RhcnQgPSBnX3V0Zjhfb2Zmc2V0X3RvX3BvaW50ZXIoY3RleHQsIHN0YXJ0KTsKLSAg ICAgICAgICAgICAgICBnaW50IGJ5dGVzID0gc3RhdGljX2Nhc3Q8Z2ludD4oZ191dGY4X29mZnNl dF90b19wb2ludGVyKGN0ZXh0LCBlbmQpIC0gY3N0YXJ0KTsKLSAgICAgICAgICAgICAgICBnY2hh ciogd29yZCA9IGdfbmV3MChnY2hhciwgYnl0ZXMrMSk7CisgICAgICAgICAgICAgICAgZ2NoYXIq IGNzdGFydCA9IGdfdXRmOF9vZmZzZXRfdG9fcG9pbnRlcih1dGY4VGV4dC5nZXQoKSwgc3RhcnQp OworICAgICAgICAgICAgICAgIGdpbnQgYnl0ZXMgPSBzdGF0aWNfY2FzdDxnaW50PihnX3V0Zjhf b2Zmc2V0X3RvX3BvaW50ZXIodXRmOFRleHQuZ2V0KCksIGVuZCkgLSBjc3RhcnQpOworICAgICAg ICAgICAgICAgIEdPd25QdHI8Z2NoYXI+IHdvcmQoZ19uZXcwKGdjaGFyLCBieXRlcyArIDEpKTsK ICAgICAgICAgICAgICAgICBpbnQgcmVzdWx0OwogCiAgICAgICAgICAgICAgICAgZ191dGY4X3N0 cm5jcHkod29yZCwgY3N0YXJ0LCBlbmQgLSBzdGFydCk7CiAKICAgICAgICAgICAgICAgICByZXN1 bHQgPSBlbmNoYW50X2RpY3RfY2hlY2soZGljdCwgd29yZCwgLTEpOwotICAgICAgICAgICAgICAg IGdfZnJlZSh3b3JkKTsKICAgICAgICAgICAgICAgICBpZiAocmVzdWx0KSB7CiAgICAgICAgICAg ICAgICAgICAgICptaXNzcGVsbGluZ0xvY2F0aW9uID0gc3RhcnQ7CiAgICAgICAgICAgICAgICAg ICAgICptaXNzcGVsbGluZ0xlbmd0aCA9IHdvcmRMZW5ndGg7Cg== 85132 2011-03-08 22:04:22 -0800 2011-03-12 00:33:25 -0800 simplechanges bug-55989-20110309150418.patch text/plain 3192 ryuan.choi SW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwNjEyKQorKysgU291cmNlL1dlYktpdC9n dGsvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMDgg IFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFBvc3NpYmxlIGxlYWtzIGFmdGVy IHNwbGl0dGluZyBUZXh0Q2hlY2tlckNsaWVudEVuY2hhbnQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTk4OQorCisgICAgICAgICogV2ViQ29yZVN1 cHBvcnQvVGV4dENoZWNrZXJDbGllbnRFbmNoYW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6VGV4 dENoZWNrZXJDbGllbnRFbmNoYW50OjpjaGVja1NwZWxsaW5nT2ZTdHJpbmcpOiBDb252ZXJ0IGdj aGFyKiB0byBHT3duUHRyPGdjaGFyPi4KKwogMjAxMS0wMy0wOCAgQ2hyaXN0aWFuIER5d2FuICA8 Y2hyaXN0aWFuQGxhbmVkby5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmlu c29uLgpJbmRleDogU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvVGV4dENoZWNrZXJD bGllbnRFbmNoYW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9UZXh0Q2hlY2tlckNsaWVudEVuY2hhbnQuY3BwCShyZXZpc2lvbiA4MDYxMSkKKysr IFNvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L1RleHRDaGVja2VyQ2xpZW50RW5jaGFu dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc3LDE2ICs3NywxNiBAQCB2b2lkIFRleHRDaGVja2Vy Q2xpZW50RW5jaGFudDo6Y2hlY2tTcGVsCiAgICAgaWYgKCFkaWN0cykKICAgICAgICAgcmV0dXJu OwogCi0gICAgZ2NoYXIqIGN0ZXh0ID0gZ191dGYxNl90b191dGY4KGNvbnN0X2Nhc3Q8Z3VuaWNo YXIyKj4odGV4dCksIGxlbmd0aCwgMCwgMCwgMCk7Ci0gICAgaW50IHV0ZmxlbiA9IGdfdXRmOF9z dHJsZW4oY3RleHQsIC0xKTsKKyAgICBHT3duUHRyPGdjaGFyPiB1dGY4VGV4dChnX3V0ZjE2X3Rv X3V0ZjgoY29uc3RfY2FzdDxndW5pY2hhcjIqPih0ZXh0KSwgbGVuZ3RoLCAwLCAwLCAwKSk7Cisg ICAgaW50IHV0ZjhMZW5ndGggPSBnX3V0Zjhfc3RybGVuKHV0ZjhUZXh0LmdldCgpLCAtMSk7CiAK ICAgICBQYW5nb0xhbmd1YWdlKiBsYW5ndWFnZShwYW5nb19sYW5ndWFnZV9nZXRfZGVmYXVsdCgp KTsKLSAgICBHT3duUHRyPFBhbmdvTG9nQXR0cj4gYXR0cnMoZ19uZXcoUGFuZ29Mb2dBdHRyLCB1 dGZsZW4rMSkpOworICAgIEdPd25QdHI8UGFuZ29Mb2dBdHRyPiBhdHRycyhnX25ldyhQYW5nb0xv Z0F0dHIsIHV0ZjhMZW5ndGggKyAxKSk7CiAKICAgICAvLyBwYW5nb19nZXRfbG9nX2F0dHJzIHVz ZXMgYW4gYWRpdGlvbmFsIHBvc2l0aW9uIGF0IHRoZSBlbmQgb2YgdGhlIHRleHQuCi0gICAgcGFu Z29fZ2V0X2xvZ19hdHRycyhjdGV4dCwgLTEsIC0xLCBsYW5ndWFnZSwgYXR0cnMuZ2V0KCksIHV0 ZmxlbisxKTsKKyAgICBwYW5nb19nZXRfbG9nX2F0dHJzKHV0ZjhUZXh0LmdldCgpLCAtMSwgLTEs IGxhbmd1YWdlLCBhdHRycy5nZXQoKSwgdXRmOExlbmd0aCArIDEpOwogCi0gICAgZm9yIChpbnQg aSA9IDA7IGkgPCBsZW5ndGgrMTsgaSsrKSB7CisgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBsZW5n dGggKyAxOyBpKyspIHsKICAgICAgICAgLy8gV2UgZ28gdGhyb3VnaCBlYWNoIGNoYXJhY3RlciB1 bnRpbCB3ZSBmaW5kIGFuIGlzX3dvcmRfc3RhcnQsCiAgICAgICAgIC8vIHRoZW4gd2UgZ2V0IGlu dG8gYW4gaW5uZXIgbG9vcCB0byBmaW5kIHRoZSBpc193b3JkX2VuZCBjb3JyZXNwb25kaW5nCiAg ICAgICAgIC8vIHRvIGl0LgpAQCAtMTA1LDE1ICsxMDUsMTQgQEAgdm9pZCBUZXh0Q2hlY2tlckNs aWVudEVuY2hhbnQ6OmNoZWNrU3BlbAogCiAgICAgICAgICAgICBmb3IgKDsgZGljdHM7IGRpY3Rz ID0gZGljdHMtPm5leHQpIHsKICAgICAgICAgICAgICAgICBFbmNoYW50RGljdCogZGljdCA9IHN0 YXRpY19jYXN0PEVuY2hhbnREaWN0Kj4oZGljdHMtPmRhdGEpOwotICAgICAgICAgICAgICAgIGdj aGFyKiBjc3RhcnQgPSBnX3V0Zjhfb2Zmc2V0X3RvX3BvaW50ZXIoY3RleHQsIHN0YXJ0KTsKLSAg ICAgICAgICAgICAgICBnaW50IGJ5dGVzID0gc3RhdGljX2Nhc3Q8Z2ludD4oZ191dGY4X29mZnNl dF90b19wb2ludGVyKGN0ZXh0LCBlbmQpIC0gY3N0YXJ0KTsKLSAgICAgICAgICAgICAgICBnY2hh ciogd29yZCA9IGdfbmV3MChnY2hhciwgYnl0ZXMrMSk7CisgICAgICAgICAgICAgICAgZ2NoYXIq IGNzdGFydCA9IGdfdXRmOF9vZmZzZXRfdG9fcG9pbnRlcih1dGY4VGV4dC5nZXQoKSwgc3RhcnQp OworICAgICAgICAgICAgICAgIGdpbnQgYnl0ZXMgPSBzdGF0aWNfY2FzdDxnaW50PihnX3V0Zjhf b2Zmc2V0X3RvX3BvaW50ZXIodXRmOFRleHQuZ2V0KCksIGVuZCkgLSBjc3RhcnQpOworICAgICAg ICAgICAgICAgIEdPd25QdHI8Z2NoYXI+IHdvcmQoZ19uZXcwKGdjaGFyLCBieXRlcyArIDEpKTsK ICAgICAgICAgICAgICAgICBpbnQgcmVzdWx0OwogCi0gICAgICAgICAgICAgICAgZ191dGY4X3N0 cm5jcHkod29yZCwgY3N0YXJ0LCBlbmQgLSBzdGFydCk7CisgICAgICAgICAgICAgICAgZ191dGY4 X3N0cm5jcHkod29yZC5nZXQoKSwgY3N0YXJ0LCBlbmQgLSBzdGFydCk7CiAKLSAgICAgICAgICAg ICAgICByZXN1bHQgPSBlbmNoYW50X2RpY3RfY2hlY2soZGljdCwgd29yZCwgLTEpOwotICAgICAg ICAgICAgICAgIGdfZnJlZSh3b3JkKTsKKyAgICAgICAgICAgICAgICByZXN1bHQgPSBlbmNoYW50 X2RpY3RfY2hlY2soZGljdCwgd29yZC5nZXQoKSwgLTEpOwogICAgICAgICAgICAgICAgIGlmIChy ZXN1bHQpIHsKICAgICAgICAgICAgICAgICAgICAgKm1pc3NwZWxsaW5nTG9jYXRpb24gPSBzdGFy dDsKICAgICAgICAgICAgICAgICAgICAgKm1pc3NwZWxsaW5nTGVuZ3RoID0gd29yZExlbmd0aDsK 85576 2011-03-12 00:33:30 -0800 2011-03-14 20:50:50 -0700 Patch bug-55989-20110312173257.patch text/plain 3309 ryuan.choi SW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwOTMwKQorKysgU291cmNlL1dlYktpdC9n dGsvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMTIg IFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFBvc3NpYmxlIGxlYWtzIGFmdGVy IHNwbGl0dGluZyBUZXh0Q2hlY2tlckNsaWVudEVuY2hhbnQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTk4OQorCisgICAgICAgIENvbnZlcnQgZ2No YXIqIHRvIEdPd25QdHI8Z2NoYXI+IGFuZCByZWZhY3RvciB0aGUgY29kZS4KKworICAgICAgICAq IFdlYkNvcmVTdXBwb3J0L1RleHRDaGVja2VyQ2xpZW50RW5jaGFudC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OlRleHRDaGVja2VyQ2xpZW50RW5jaGFudDo6Y2hlY2tTcGVsbGluZ09mU3RyaW5nKToK KwogMjAxMS0wMy0xMSAgTWFyY28gUGVlcmVib29tICA8bWFyY29AcGVlcmVib29tLnVzPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYSBTaWx2YS4KSW5kZXg6IFNvdXJjZS9X ZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L1RleHRDaGVja2VyQ2xpZW50RW5jaGFudC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvVGV4dENoZWNrZXJD bGllbnRFbmNoYW50LmNwcAkocmV2aXNpb24gODA5MjkpCisrKyBTb3VyY2UvV2ViS2l0L2d0ay9X ZWJDb3JlU3VwcG9ydC9UZXh0Q2hlY2tlckNsaWVudEVuY2hhbnQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC03NywxNiArNzcsMTYgQEAgdm9pZCBUZXh0Q2hlY2tlckNsaWVudEVuY2hhbnQ6OmNoZWNr U3BlbAogICAgIGlmICghZGljdHMpCiAgICAgICAgIHJldHVybjsKIAotICAgIGdjaGFyKiBjdGV4 dCA9IGdfdXRmMTZfdG9fdXRmOChjb25zdF9jYXN0PGd1bmljaGFyMio+KHRleHQpLCBsZW5ndGgs IDAsIDAsIDApOwotICAgIGludCB1dGZsZW4gPSBnX3V0Zjhfc3RybGVuKGN0ZXh0LCAtMSk7Cisg ICAgR093blB0cjxnY2hhcj4gdXRmOFRleHQoZ191dGYxNl90b191dGY4KGNvbnN0X2Nhc3Q8Z3Vu aWNoYXIyKj4odGV4dCksIGxlbmd0aCwgMCwgMCwgMCkpOworICAgIGludCB1dGY4TGVuZ3RoID0g Z191dGY4X3N0cmxlbih1dGY4VGV4dC5nZXQoKSwgLTEpOwogCiAgICAgUGFuZ29MYW5ndWFnZSog bGFuZ3VhZ2UocGFuZ29fbGFuZ3VhZ2VfZ2V0X2RlZmF1bHQoKSk7Ci0gICAgR093blB0cjxQYW5n b0xvZ0F0dHI+IGF0dHJzKGdfbmV3KFBhbmdvTG9nQXR0ciwgdXRmbGVuKzEpKTsKKyAgICBHT3du UHRyPFBhbmdvTG9nQXR0cj4gYXR0cnMoZ19uZXcoUGFuZ29Mb2dBdHRyLCB1dGY4TGVuZ3RoICsg MSkpOwogCiAgICAgLy8gcGFuZ29fZ2V0X2xvZ19hdHRycyB1c2VzIGFuIGFkaXRpb25hbCBwb3Np dGlvbiBhdCB0aGUgZW5kIG9mIHRoZSB0ZXh0LgotICAgIHBhbmdvX2dldF9sb2dfYXR0cnMoY3Rl eHQsIC0xLCAtMSwgbGFuZ3VhZ2UsIGF0dHJzLmdldCgpLCB1dGZsZW4rMSk7CisgICAgcGFuZ29f Z2V0X2xvZ19hdHRycyh1dGY4VGV4dC5nZXQoKSwgLTEsIC0xLCBsYW5ndWFnZSwgYXR0cnMuZ2V0 KCksIHV0ZjhMZW5ndGggKyAxKTsKIAotICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbGVuZ3RoKzE7 IGkrKykgeworICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbGVuZ3RoICsgMTsgaSsrKSB7CiAgICAg ICAgIC8vIFdlIGdvIHRocm91Z2ggZWFjaCBjaGFyYWN0ZXIgdW50aWwgd2UgZmluZCBhbiBpc193 b3JkX3N0YXJ0LAogICAgICAgICAvLyB0aGVuIHdlIGdldCBpbnRvIGFuIGlubmVyIGxvb3AgdG8g ZmluZCB0aGUgaXNfd29yZF9lbmQgY29ycmVzcG9uZGluZwogICAgICAgICAvLyB0byBpdC4KQEAg LTEwMywxOCArMTAzLDE1IEBAIHZvaWQgVGV4dENoZWNrZXJDbGllbnRFbmNoYW50OjpjaGVja1Nw ZWwKICAgICAgICAgICAgIC8vIGNoZWNrIGNoYXJhY3RlcnMgdHdpY2UuCiAgICAgICAgICAgICBp ID0gZW5kOwogCisgICAgICAgICAgICBnY2hhciogY3N0YXJ0ID0gZ191dGY4X29mZnNldF90b19w b2ludGVyKHV0ZjhUZXh0LmdldCgpLCBzdGFydCk7CisgICAgICAgICAgICBnaW50IGJ5dGVzID0g c3RhdGljX2Nhc3Q8Z2ludD4oZ191dGY4X29mZnNldF90b19wb2ludGVyKHV0ZjhUZXh0LmdldCgp LCBlbmQpIC0gY3N0YXJ0KTsKKyAgICAgICAgICAgIEdPd25QdHI8Z2NoYXI+IHdvcmQoZ19uZXcw KGdjaGFyLCBieXRlcyArIDEpKTsKKworICAgICAgICAgICAgZ191dGY4X3N0cm5jcHkod29yZC5n ZXQoKSwgY3N0YXJ0LCB3b3JkTGVuZ3RoKTsKKwogICAgICAgICAgICAgZm9yICg7IGRpY3RzOyBk aWN0cyA9IGRpY3RzLT5uZXh0KSB7CiAgICAgICAgICAgICAgICAgRW5jaGFudERpY3QqIGRpY3Qg PSBzdGF0aWNfY2FzdDxFbmNoYW50RGljdCo+KGRpY3RzLT5kYXRhKTsKLSAgICAgICAgICAgICAg ICBnY2hhciogY3N0YXJ0ID0gZ191dGY4X29mZnNldF90b19wb2ludGVyKGN0ZXh0LCBzdGFydCk7 Ci0gICAgICAgICAgICAgICAgZ2ludCBieXRlcyA9IHN0YXRpY19jYXN0PGdpbnQ+KGdfdXRmOF9v ZmZzZXRfdG9fcG9pbnRlcihjdGV4dCwgZW5kKSAtIGNzdGFydCk7Ci0gICAgICAgICAgICAgICAg Z2NoYXIqIHdvcmQgPSBnX25ldzAoZ2NoYXIsIGJ5dGVzKzEpOwotICAgICAgICAgICAgICAgIGlu dCByZXN1bHQ7Ci0KLSAgICAgICAgICAgICAgICBnX3V0Zjhfc3RybmNweSh3b3JkLCBjc3RhcnQs IGVuZCAtIHN0YXJ0KTsKLQotICAgICAgICAgICAgICAgIHJlc3VsdCA9IGVuY2hhbnRfZGljdF9j aGVjayhkaWN0LCB3b3JkLCAtMSk7Ci0gICAgICAgICAgICAgICAgZ19mcmVlKHdvcmQpOwotICAg ICAgICAgICAgICAgIGlmIChyZXN1bHQpIHsKKyAgICAgICAgICAgICAgICBpZiAoZW5jaGFudF9k aWN0X2NoZWNrKGRpY3QsIHdvcmQuZ2V0KCksIHdvcmRMZW5ndGgpKSB7CiAgICAgICAgICAgICAg ICAgICAgICptaXNzcGVsbGluZ0xvY2F0aW9uID0gc3RhcnQ7CiAgICAgICAgICAgICAgICAgICAg ICptaXNzcGVsbGluZ0xlbmd0aCA9IHdvcmRMZW5ndGg7CiAgICAgICAgICAgICAgICAgfSBlbHNl IHsK