55986 2011-03-08 17:20:29 -0800 Use the Cookie Storage from the Private Browsing Storage Session directly 2011-03-09 08:43:06 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jberlin jberlin aroben jberlin oldest_to_newest 364246 0 jberlin 2011-03-08 17:20:29 -0800 There is no need to create an in-memory copy because the Private Browsing Storage Session is already in-memory only. <rdar://problem/9102381> 364268 1 85119 jberlin 2011-03-08 18:02:49 -0800 Created attachment 85119 Patch 364444 2 85119 aroben 2011-03-09 05:15:52 -0800 Comment on attachment 85119 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85119&action=review Why doesn't Mac need the CreateInMemory fallback path? > Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:81 > + privateBrowsingCookieStorage() = wkCreateInMemoryHTTPCookieStorage(); You're leaking this CFHTTPCookieStorageRef. 364455 3 jberlin 2011-03-09 05:58:47 -0800 (In reply to comment #2) > (From update of attachment 85119 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85119&action=review > > Why doesn't Mac need the CreateInMemory fallback path? Because if it isn't using the CFURLSTORAGESESSIONS, it calls wkSetCookieStoragePrivateBrowsingEnabled(enabled), which makes all cookies be stored in memory. > > > Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:81 > > + privateBrowsingCookieStorage() = wkCreateInMemoryHTTPCookieStorage(); > > You're leaking this CFHTTPCookieStorageRef. Hrm, for some reason I thought the result of a Create wasn't already retained. Fixed. 364473 4 aroben 2011-03-09 06:44:28 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 85119 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=85119&action=review > > > > Why doesn't Mac need the CreateInMemory fallback path? > > Because if it isn't using the CFURLSTORAGESESSIONS, it calls wkSetCookieStoragePrivateBrowsingEnabled(enabled), which makes all cookies be stored in memory. I guess I don't understand what the difference between Mac and Windows is here. 364484 5 jberlin 2011-03-09 07:12:06 -0800 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 85119 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=85119&action=review > > > > > > Why doesn't Mac need the CreateInMemory fallback path? > > > > Because if it isn't using the CFURLSTORAGESESSIONS, it calls wkSetCookieStoragePrivateBrowsingEnabled(enabled), which makes all cookies be stored in memory. > > I guess I don't understand what the difference between Mac and Windows is here. wkSetCookieStoragePrivateBrowsingEnabled (and the functionality behind it) doesn't exist on Windows. wkSetCookieStoragePrivateBrowsingEnabled was the way it was done on Mac before my changes to add the CFURLSTORAGESESSIONS stuff. 364517 6 85119 jberlin 2011-03-09 08:42:58 -0800 Comment on attachment 85119 Patch Committed in r80643 http://trac.webkit.org/changeset/80643 85119 2011-03-08 18:02:49 -0800 2011-03-09 08:42:58 -0800 Patch doNotCreatInMemoryStroageForPrivateBrowsingOpensource9102381Take3.patch text/plain 0 jberlin