55978 2011-03-08 15:49:14 -0800 WebKit2: Redo is broken 2011-03-08 16:18:50 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jeffm jeffm oldest_to_newest 364204 0 jeffm 2011-03-08 15:49:14 -0800 If you undo an edit command, you cannot redo it. This is because WebEditCommandProxy::unapply() and WebEditCommandProxy::reapply() are registering the wrong edit command when an undo or redo happens. For example, when we unapply(), we should register a Redo command, not an Undo command. 364205 1 85103 jeffm 2011-03-08 15:53:03 -0800 Created attachment 85103 Patch 364219 2 jeffm 2011-03-08 16:18:50 -0800 Committed r80603: <http://trac.webkit.org/changeset/80603> 85103 2011-03-08 15:53:03 -0800 2011-03-08 16:05:14 -0800 Patch bug-55978-20110308155301.patch text/plain 1869 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwNjAwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMDggIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlYktpdDI6IFJlZG8gaXMgYnJva2VuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTk3OAorICAgICAgICAKKyAgICAgICAg V2ViRWRpdENvbW1hbmRQcm94eTo6dW5hcHBseSgpIGFuZCBXZWJFZGl0Q29tbWFuZFByb3h5Ojpy ZWFwcGx5KCkgd2VyZSByZWdpc3RlcmluZyB0aGUgd3JvbmcgZWRpdCBjb21tYW5kIHdoZW4gYW4g dW5kbyBvciByZWRvIGhhcHBlbnMuCisgICAgICAgIEZvciBleGFtcGxlLCB3aGVuIHdlIHVuYXBw bHkoKSwgd2Ugc2hvdWxkIHJlZ2lzdGVyIGEgUmVkbyBjb21tYW5kLCBub3QgYW4gVW5kbyBjb21t YW5kLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYkVkaXRDb21tYW5kUHJveHkuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJFZGl0Q29tbWFuZFByb3h5Ojp1bmFwcGx5KTogUmVnaXN0ZXIgYSBS ZWRvIGNvbW1hbmQsIG5vdCBhbiBVbmRvIGNvbW1hbmQuCisgICAgICAgIChXZWJLaXQ6OldlYkVk aXRDb21tYW5kUHJveHk6OnJlYXBwbHkpOiBSZWdpc3RlciBhbiBVbmRvIGNvbW1hbmQsIG5vdCBh IFJlZG8gY29tbWFuZC4KKwogMjAxMS0wMy0wOCAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJyYWR5IEVpZHNvbi4KSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJFZGl0Q29tbWFuZFByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRWRpdENvbW1hbmRQcm94eS5jcHAJKHJldmlzaW9uIDgw NjAwKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkVkaXRDb21tYW5kUHJveHkuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC01NCw3ICs1NCw3IEBAIHZvaWQgV2ViRWRpdENvbW1hbmRQcm94 eTo6dW5hcHBseSgpCiAgICAgICAgIHJldHVybjsKIAogICAgIG1fcGFnZS0+cHJvY2VzcygpLT5z ZW5kKE1lc3NhZ2VzOjpXZWJQYWdlOjpVbmFwcGx5RWRpdENvbW1hbmQobV9jb21tYW5kSUQpLCBt X3BhZ2UtPnBhZ2VJRCgpKTsKLSAgICBtX3BhZ2UtPnJlZ2lzdGVyRWRpdENvbW1hbmQodGhpcywg V2ViUGFnZVByb3h5OjpVbmRvKTsKKyAgICBtX3BhZ2UtPnJlZ2lzdGVyRWRpdENvbW1hbmQodGhp cywgV2ViUGFnZVByb3h5OjpSZWRvKTsKIH0KIAogdm9pZCBXZWJFZGl0Q29tbWFuZFByb3h5Ojpy ZWFwcGx5KCkKQEAgLTYzLDcgKzYzLDcgQEAgdm9pZCBXZWJFZGl0Q29tbWFuZFByb3h5OjpyZWFw cGx5KCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV9wYWdlLT5wcm9jZXNzKCktPnNlbmQoTWVz c2FnZXM6OldlYlBhZ2U6OlJlYXBwbHlFZGl0Q29tbWFuZChtX2NvbW1hbmRJRCksIG1fcGFnZS0+ cGFnZUlEKCkpOwotICAgIG1fcGFnZS0+cmVnaXN0ZXJFZGl0Q29tbWFuZCh0aGlzLCBXZWJQYWdl UHJveHk6OlJlZG8pOworICAgIG1fcGFnZS0+cmVnaXN0ZXJFZGl0Q29tbWFuZCh0aGlzLCBXZWJQ YWdlUHJveHk6OlVuZG8pOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK