55964 2011-03-08 13:49:56 -0800 [Qt] Compilation fails with --3d-canvas 2011-03-14 15:25:47 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 jarkko.j.sakkinen webkit-unassigned commit-queue jarkko.j.sakkinen oldest_to_newest 364141 0 jarkko.j.sakkinen 2011-03-08 13:49:56 -0800 There are two issues: - WebCore.pro refers to non-existing files: OESVertexArray.h/cpp - Extension3DQt.cpp uses undefined GL_FALSE. Should include <QGLContext>. 364142 1 jarkko.j.sakkinen 2011-03-08 13:54:27 -0800 Created a fix candidate: - Removed OESVertexArray.h/cpp from WebCore.pro - Added include <QGLWidget> I'll submit patch if this resolves compilation issue. 364148 2 jarkko.j.sakkinen 2011-03-08 14:10:08 -0800 Added WebGLVertexArrayObjectOES.h/cpp to WebCore.pro. 364337 3 jarkko.j.sakkinen 2011-03-08 23:39:00 -0800 Compilation fix seems to work. Now preparing the patch for the contribution. 364342 4 85136 jarkko.j.sakkinen 2011-03-08 23:55:04 -0800 Created attachment 85136 compilation fix 367142 5 jarkko.j.sakkinen 2011-03-14 12:46:56 -0700 Changing to unconfirmed until commit bot has taken this. 367287 6 85136 commit-queue 2011-03-14 15:25:44 -0700 Comment on attachment 85136 compilation fix Clearing flags on attachment: 85136 Committed r81069: <http://trac.webkit.org/changeset/81069> 367288 7 commit-queue 2011-03-14 15:25:47 -0700 All reviewed patches have been landed. Closing bug. 85136 2011-03-08 23:55:04 -0800 2011-03-14 15:25:44 -0700 compilation fix 55964.diff text/plain 2163 jarkko.j.sakkinen ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5NjVjN2EzLi42YTIxODA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDMtMDggIEphcmtrbyBTYWtraW5lbiAgPGphcmtrby5qLnNha2tpbmVuQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb UXRdIENvbXBpbGF0aW9uIGZhaWxzIHdpdGggLS0zZC1jYW52YXMgCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTk2NAorCisgICAgICAgICogV2ViQ29y ZS5wcm86CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRXh0ZW5zaW9uczNEUXQuY3Bw OgorCiAyMDExLTAzLTA4ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByODA1NTEuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnBybyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJv CmluZGV4IDA4ZjA2MzYuLmI0Mzk0YzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNv cmUucHJvCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJvCkBAIC0zMzc5LDkgKzMzNzks OSBAQCBjb250YWlucyhERUZJTkVTLCBFTkFCTEVfV0VCR0w9MSkgewogICAgICAgICBodG1sL2Nh bnZhcy9PRVNTdGFuZGFyZERlcml2YXRpdmVzLmggXAogICAgICAgICBodG1sL2NhbnZhcy9PRVNU ZXh0dXJlRmxvYXQuaCBcCiAgICAgICAgIGh0bWwvY2FudmFzL09FU1ZlcnRleEFycmF5T2JqZWN0 LmggXAotICAgICAgICBodG1sL2NhbnZhcy9PRVNWZXJ0ZXhBcnJheS5oIFwKICAgICAgICAgaHRt bC9jYW52YXMvV2ViR0xUZXh0dXJlLmggXAogICAgICAgICBodG1sL2NhbnZhcy9XZWJHTFVuaWZv cm1Mb2NhdGlvbi5oIFwKKyAgICAgICAgaHRtbC9jYW52YXMvV2ViR0xWZXJ0ZXhBcnJheU9iamVj dE9FUy5oIFwKICAgICAgICAgaHRtbC9jYW52YXMvV2ViS2l0TG9zZUNvbnRleHQuaCBcCiAgICAg ICAgIHBsYXRmb3JtL2dyYXBoaWNzL0V4dGVuc2lvbnMzRC5oIFwKICAgICAgICAgcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaCBcCkBAIC0zNDA4LDkgKzM0MDgsOSBAQCBjb250 YWlucyhERUZJTkVTLCBFTkFCTEVfV0VCR0w9MSkgewogICAgICAgICBodG1sL2NhbnZhcy9PRVNT dGFuZGFyZERlcml2YXRpdmVzLmNwcCBcCiAgICAgICAgIGh0bWwvY2FudmFzL09FU1RleHR1cmVG bG9hdC5jcHAgXAogICAgICAgICBodG1sL2NhbnZhcy9PRVNWZXJ0ZXhBcnJheU9iamVjdC5jcHAg XAotICAgICAgICBodG1sL2NhbnZhcy9PRVNWZXJ0ZXhBcnJheS5jcHAgXAogICAgICAgICBodG1s L2NhbnZhcy9XZWJHTFRleHR1cmUuY3BwIFwKICAgICAgICAgaHRtbC9jYW52YXMvV2ViR0xVbmlm b3JtTG9jYXRpb24uY3BwIFwKKyAgICAgICAgaHRtbC9jYW52YXMvV2ViR0xWZXJ0ZXhBcnJheU9i amVjdE9FUy5jcHAgXAogICAgICAgICBodG1sL2NhbnZhcy9XZWJLaXRMb3NlQ29udGV4dC5jcHAg XAogICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5jcHAgXAogICAg ICAgICBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJhd2luZ0J1ZmZlci5jcHAgXApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRXh0ZW5zaW9uczNEUXQuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRXh0ZW5zaW9uczNEUXQuY3Bw CmluZGV4IGRjZWE3MmYuLjNhZGM5M2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3F0L0V4dGVuc2lvbnMzRFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9xdC9FeHRlbnNpb25zM0RRdC5jcHAKQEAgLTMwLDYgKzMwLDcgQEAK ICNpbmNsdWRlICJFeHRlbnNpb25zM0RRdC5oIgogCiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0 M0QuaCIKKyNpbmNsdWRlIDxRR0xDb250ZXh0PgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK