55940 2011-03-08 07:11:31 -0800 WebKit2 should support Ignore policy from injected bundle client 2011-03-08 13:20:09 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All OS X 10.6 RESOLVED INVALID P2 Normal --- 1 sullivan sullivan sam oldest_to_newest 363952 0 sullivan 2011-03-08 07:11:31 -0800 Currently WebKit2 supports only WKBundlePagePolicyActionPassThrough and WKBundlePagePolicyActionUse from the injected bundle client. It should also support an Ignore policy, so clients don't have to take a round trip through the UI process in order to ignore a request. 363953 1 85047 sullivan 2011-03-08 07:14:35 -0800 Created attachment 85047 Patch to add WKBundlePagePolicyActionIgnore 364016 2 sullivan 2011-03-08 10:12:26 -0800 Fixed in r80568 364047 3 sam 2011-03-08 11:21:49 -0800 This patch was wrong. If you add Ignore, you have to add it for all the policy delegates, not just one of them. 364086 4 sullivan 2011-03-08 12:04:00 -0800 Agreed. I'll revert this patch. 364130 5 sullivan 2011-03-08 13:20:09 -0800 Reverted in 80585. 85047 2011-03-08 07:14:35 -0800 2011-03-08 09:31:31 -0800 Patch to add WKBundlePagePolicyActionIgnore PolicyIgnore_patch.txt text/plain 2278 sullivan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwNTYxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDMtMDggIEpvaG4gU3Vs bGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU1OTQwCisgICAgICAgIFdlYktpdDIgc2hvdWxkIHN1cHBvcnQgSWdub3JlIHBvbGljeSBm cm9tIGluamVjdGVkIGJ1bmRsZSBjbGllbnQKKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0 ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmg6CisgICAgICAgIEFkZGVkIFdLQnVuZGxlUGFn ZVBvbGljeUFjdGlvbklnbm9yZS4KKyAgICAgICAgCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJD b3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rp b24pOgorICAgICAgICBJZiB0aGUgaW5qZWN0ZWQgYnVuZGxlIGNsaWVudCByZXR1cm5zIFdLQnVu ZGxlUGFnZVBvbGljeUFjdGlvbklnbm9yZSwgY29udmVydCBpdAorICAgICAgICB0byB0aGUgbG9h ZGVyJ3MgUG9saWN5SWdub3JlLgorCiAyMDExLTAzLTA4ICBMYXN6bG8gR29tYm9zICA8bGFzemxv LjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRl IENocmlzdGlhbnNlbi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRC dW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuaAkocmV2aXNpb24g ODA1MzApCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9j L1dLQnVuZGxlUGFnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYsNyArMTE2LDggQEAgdHlwZWRl ZiBzdHJ1Y3QgV0tCdW5kbGVQYWdlTG9hZGVyQ2xpZW50IAogCiBlbnVtIHsKICAgICBXS0J1bmRs ZVBhZ2VQb2xpY3lBY3Rpb25QYXNzVGhyb3VnaCwKLSAgICBXS0J1bmRsZVBhZ2VQb2xpY3lBY3Rp b25Vc2UKKyAgICBXS0J1bmRsZVBhZ2VQb2xpY3lBY3Rpb25Vc2UsCisgICAgV0tCdW5kbGVQYWdl UG9saWN5QWN0aW9uSWdub3JlCiB9OwogdHlwZWRlZiB1aW50MzJfdCBXS0J1bmRsZVBhZ2VQb2xp Y3lBY3Rpb247CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBv cnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCShyZXZp c2lvbiA4MDUzMCkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQv V2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NTMsNyArNjUzLDEy IEBAIHZvaWQgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGVjaWQKICAgICAgICAgKG1f ZnJhbWUtPmNvcmVGcmFtZSgpLT5sb2FkZXIoKS0+cG9saWN5Q2hlY2tlcigpLT4qZnVuY3Rpb24p KFBvbGljeVVzZSk7CiAgICAgICAgIHJldHVybjsKICAgICB9Ci0KKyAgICAKKyAgICBpZiAocG9s aWN5ID09IFdLQnVuZGxlUGFnZVBvbGljeUFjdGlvbklnbm9yZSkgeworICAgICAgICAobV9mcmFt ZS0+Y29yZUZyYW1lKCktPmxvYWRlcigpLT5wb2xpY3lDaGVja2VyKCktPipmdW5jdGlvbikoUG9s aWN5SWdub3JlKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICAKICAgICB1aW50NjRfdCBs aXN0ZW5lcklEID0gbV9mcmFtZS0+c2V0VXBQb2xpY3lMaXN0ZW5lcihmdW5jdGlvbik7CiAgICAg Ym9vbCByZWNlaXZlZFBvbGljeUFjdGlvbjsKICAgICB1aW50NjRfdCBwb2xpY3lBY3Rpb247Cg==