55932 2011-03-08 03:48:30 -0800 [GTK] close-web-view emitted on disposed WebView 2011-03-11 02:29:21 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned mrobinson oldest_to_newest 363923 0 pnormand 2011-03-08 03:48:30 -0800 Test fast/frames/iframe-reparenting-plugins.html produces this warning: instance of invalid non-instantiatable type `<invalid>' g_signal_emit_by_name: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed bt: #0 g_logv (log_domain=<value optimized out>, log_level=<value optimized out>, format=<value optimized out>, args1=0x7fff565dbce0) at gmessages.c:563 #1 0x00007fbe63487653 in g_log (log_domain=0x7fbe6229fe40 "", log_level=0, format= 0x1 <Address 0x1 out of bounds>) at gmessages.c:577 #2 0x00007fbe63d86725 in g_type_check_instance (type_instance=<value optimized out>) at gtype.c:4073 #3 0x00007fbe63d849dd in g_signal_emit_by_name (instance=0x7fbe6229fe40, detailed_signal=0x0) at gsignal.c:3065 #4 0x00007fbe662e22a3 in WebKit::emitCloseWebViewSignalLater (view=0x19f84c0) at ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:255 #5 0x00007fbe6347cd6b in g_timeout_dispatch (source=0x23717a0, callback=0, user_data=0x1) at gmain.c:3878 #6 0x00007fbe6347c312 in g_main_dispatch (context=0x198e0d0) at gmain.c:2440 #7 g_main_context_dispatch (context=0x198e0d0) at gmain.c:3013 #8 0x00007fbe634809d8 in g_main_context_iterate (context=0x198e0d0, block=<value optimized out>, dispatch=<value optimized out>, self=<value optimized out>) at gmain.c:3091 #9 0x00007fbe63480ee5 in g_main_loop_run (loop=0x2a942c0) at gmain.c:3299 #10 0x00007fbe653e7557 in IA__gtk_main () at gtkmain.c:1255 #11 0x000000000041f2f5 in runTest (testPathOrURL=...) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:679 #12 0x000000000041e987 in runTestingServerLoop () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:489 #13 0x0000000000420a6c in main (argc=2, argv=0x7fff565dcb58) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1143 363924 1 pnormand 2011-03-08 03:49:00 -0800 (gdb) p *view $2 = {parent_instance = {widget = {object = {parent_instance = {g_type_instance = {g_class = 0x19f8280}, ref_count = 0, qdata = 0xaaaaaaaaaaaaaaaa}, flags = 2863311530}, private_flags = 43690, state = 170 '\252', saved_state = 170 '\252', name = 0xaaaaaaaaaaaaaaaa <Address 0xaaaaaaaaaaaaaaaa out of bounds>, style = 0xaaaaaaaaaaaaaaaa, requisition = {width = -1431655766, height = -1431655766}, allocation = {x = -1431655766, y = -1431655766, width = -1431655766, height = -1431655766}, window = 0xaaaaaaaaaaaaaaaa, parent = 0xaaaaaaaaaaaaaaaa}, focus_child = 0xaaaaaaaaaaaaaaaa, border_width = 43690, need_resize = 0, resize_mode = 1, reallocate_redraws = 1, has_focus_chain = 0}, priv = 0xaaaaaaaaaaaaaaaa} 363925 2 85040 pnormand 2011-03-08 03:57:26 -0800 Created attachment 85040 proposed patch 364175 3 85040 mrobinson 2011-03-08 14:56:46 -0800 Comment on attachment 85040 proposed patch Isn't it possible to use m_closeSoonTimer in the ChromeClient destructor to cancel the source. That seems more reliable than counting on the view pointer to be junk. 364359 4 85142 pnormand 2011-03-09 01:02:44 -0800 Created attachment 85142 updated patch 365268 5 85142 mrobinson 2011-03-10 10:03:39 -0800 Comment on attachment 85142 updated patch Great stuff! Thank you. 365898 6 pnormand 2011-03-11 02:29:21 -0800 Committed r80836: <http://trac.webkit.org/changeset/80836> 85040 2011-03-08 03:57:26 -0800 2011-03-09 01:02:44 -0800 proposed patch proposed-patch.patch text/plain 1654 pnormand RnJvbSAyYjg3ZmQ4ZDYxNWE3ZjFjOGU3YzA1Y2U4ODFhNGQ5NGJjODVkYzBmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDggTWFyIDIwMTEgMTI6NTg6NTMgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBTb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiAuLi4vV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwICB8ICAgIDMgKysrCiAyIGZpbGVzIGNoYW5nZWQs IDE1IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9ndGsvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGNk YWMyMjQuLmNjOTlhYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0w My0wOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gY2xvc2Utd2ViLXZp ZXcgZW1pdHRlZCBvbiBkaXNwb3NlZCBXZWJWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTkzMgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQv Q2hyb21lQ2xpZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6ZW1pdENsb3NlV2ViVmlld1Np Z25hbExhdGVyKTogQXZvaWQgZW1pdHRpbmcgdGhlCisgICAgICAgIGNsb3NlLXdlYi12aWV3IHNp Z25hbCBpZiB0aGUgdmlldyBoYXMgYmVlbiBkaXNwb3NlZCBqdXN0IGJlZm9yZQorICAgICAgICB0 aGUgdGltZXIgZmlyZWQuCisKIDIwMTEtMDMtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVu dEd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRH dGsuY3BwCmluZGV4IDhlODI4YWMuLjQ4NmRlZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Z3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKKysrIGIvU291cmNlL1dlYktp dC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcApAQCAtMjUxLDYgKzI1MSw5 IEBAIHZvaWQgQ2hyb21lQ2xpZW50OjpzZXRSZXNpemFibGUoYm9vbCkKIAogc3RhdGljIGdib29s ZWFuIGVtaXRDbG9zZVdlYlZpZXdTaWduYWxMYXRlcihXZWJLaXRXZWJWaWV3KiB2aWV3KQogewor ICAgIGlmICghR19JU19PQkpFQ1QodmlldykpCisgICAgICAgIHJldHVybiBGQUxTRTsKKwogICAg IGdib29sZWFuIGlzSGFuZGxlZDsKICAgICBnX3NpZ25hbF9lbWl0X2J5X25hbWUodmlldywgImNs b3NlLXdlYi12aWV3IiwgJmlzSGFuZGxlZCk7CiAgICAgcmV0dXJuIEZBTFNFOwotLSAKMS43LjQu MQ== 85142 2011-03-09 01:02:44 -0800 2011-03-10 10:03:39 -0800 updated patch updated-patch.patch text/plain 1529 pnormand RnJvbSBlOWNlNjE4MTcwNTc5OGNlMzEzMTZiZmFjNTk5ZTE4YTIwMjMyNzBiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDkgTWFyIDIwMTEgMTA6MDA6MjQgKzAxMDAKU3ViamVjdDogW1BBVENIXSB1 cGRhdGVkIHBhdGNoCgotLS0KIFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAxMSArKysrKysrKysrKwogLi4uL1dlYktpdC9ndGsvV2ViQ29yZVN1 cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcCAgfCAgICAzICsrKwogMiBmaWxlcyBjaGFuZ2VkLCAx NCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBjNTFk MzdjLi42ODBhM2QyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDMt MDggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIGNsb3NlLXdlYi12aWV3 IGVtaXR0ZWQgb24gZGlzcG9zZWQgV2ViVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU5MzIKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0No cm9tZUNsaWVudEd0ay5jcHA6CisgICAgICAgIChDaHJvbWVDbGllbnQ6OmNocm9tZURlc3Ryb3ll ZCk6IFJlbW92ZSB0aGUgY2xvc2VTb29uVGltZXIgZ2xpYgorICAgICAgICBzb3VyY2UgYmVmb3Jl IGRlc3RydWN0aW9uIG9mIHRoZSBDaHJvbWVDbGllbnQuCisKIDIwMTEtMDMtMDggIENocmlzdGlh biBEeXdhbiAgPGNocmlzdGlhbkBsYW5lZG8uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1h cnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBw b3J0L0Nocm9tZUNsaWVudEd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9y dC9DaHJvbWVDbGllbnRHdGsuY3BwCmluZGV4IDhlODI4YWMuLjRiODRlMzkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKKysr IGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcApA QCAtNzksNiArNzksOSBAQCBDaHJvbWVDbGllbnQ6OkNocm9tZUNsaWVudChXZWJLaXRXZWJWaWV3 KiB3ZWJWaWV3KQogCiB2b2lkIENocm9tZUNsaWVudDo6Y2hyb21lRGVzdHJveWVkKCkKIHsKKyAg ICBpZiAobV9jbG9zZVNvb25UaW1lcikKKyAgICAgICAgZ19zb3VyY2VfcmVtb3ZlKG1fY2xvc2VT b29uVGltZXIpOworCiAgICAgZGVsZXRlIHRoaXM7CiB9CiAKLS0gCjEuNy40LjE=