<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>55903</bug_id>
          
          <creation_ts>2011-03-07 13:44:44 -0800</creation_ts>
          <short_desc>SubresourceLoader should expose a way to set the outgoing referer/origin.</short_desc>
          <delta_ts>2011-03-21 13:06:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Page Loading</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>24683</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="David Levin">levin</reporter>
          <assigned_to name="David Levin">levin</assigned_to>
          <cc>abarth</cc>
    
    <cc>buildbot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>363553</commentid>
    <comment_count>0</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-03-07 13:44:44 -0800</bug_when>
    <thetext>See summary.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363560</commentid>
    <comment_count>1</comment_count>
      <attachid>84978</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2011-03-07 13:55:21 -0800</bug_when>
    <thetext>Created attachment 84978
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363565</commentid>
    <comment_count>2</comment_count>
      <attachid>84978</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-07 14:00:21 -0800</bug_when>
    <thetext>Comment on attachment 84978
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84978&amp;action=review

&gt; Source/WebCore/loader/SubresourceLoader.cpp:63
&gt; +PassRefPtr&lt;SubresourceLoader&gt; SubresourceLoader::create(Frame* frame, SubresourceLoaderClient* client, const ResourceRequest&amp; request, SecurityCheckPolicy securityCheck, bool sendResourceLoadCallbacks, bool shouldContentSniff, const String* outgoingReferrer)

Maybe pass a null string instead of a pointer to indicate no override?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363582</commentid>
    <comment_count>3</comment_count>
    <who name="Build Bot">buildbot</who>
    <bug_when>2011-03-07 14:18:33 -0800</bug_when>
    <thetext>Attachment 84978 did not build on win:
Build output: http://queues.webkit.org/results/8103615</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363607</commentid>
    <comment_count>4</comment_count>
      <attachid>84978</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2011-03-07 14:50:01 -0800</bug_when>
    <thetext>Comment on attachment 84978
Patch

r- due to Adam&apos;s comment and last minute change that doesn&apos;t compile :(.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363632</commentid>
    <comment_count>5</comment_count>
      <attachid>84988</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2011-03-07 15:31:38 -0800</bug_when>
    <thetext>Created attachment 84988
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363636</commentid>
    <comment_count>6</comment_count>
      <attachid>84988</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-07 15:34:10 -0800</bug_when>
    <thetext>Comment on attachment 84988
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84988&amp;action=review

&gt; Source/WebCore/loader/SubresourceLoader.cpp:63
&gt; -PassRefPtr&lt;SubresourceLoader&gt; SubresourceLoader::create(Frame* frame, SubresourceLoaderClient* client, const ResourceRequest&amp; request, SecurityCheckPolicy securityCheck, bool sendResourceLoadCallbacks, bool shouldContentSniff)
&gt; +PassRefPtr&lt;SubresourceLoader&gt; SubresourceLoader::create(Frame* frame, SubresourceLoaderClient* client, const ResourceRequest&amp; request, SecurityCheckPolicy securityCheck, bool sendResourceLoadCallbacks, bool shouldContentSniff, String outgoingReferrer)

We usually pass String by const reference.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363637</commentid>
    <comment_count>7</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-07 15:34:24 -0800</bug_when>
    <thetext>(The const reference reduces refchurn)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363638</commentid>
    <comment_count>8</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-03-07 15:37:19 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; (The const reference reduces refchurn)

I started that way but

In this case, it saves me from creating another string as I can just modify string parameter that was passed in (and in general makes the variable names clearer by getting rid of this other variable -- no more outgoingReferrer vs referrer).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363641</commentid>
    <comment_count>9</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-07 15:43:30 -0800</bug_when>
    <thetext>As you like it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>370855</commentid>
    <comment_count>10</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-03-21 13:06:42 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; We usually pass String by const reference.
Fixed and committed as http://trac.webkit.org/changeset/81605</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>84978</attachid>
            <date>2011-03-07 13:55:21 -0800</date>
            <delta_ts>2011-03-07 14:50:01 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-55903-20110307135519.patch</filename>
            <type>text/plain</type>
            <size>3591</size>
            <attacher name="David Levin">levin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODA0ODgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNzljODA3ZjQ4M2IyZjM2
NGZhMWNmM2RlZGE0M2YzOTUwYzA4M2QyLi5lMTBiNTg5MDk2NWEwMmJjMjJmNzIzZmY3NzIxNmNl
MmMzMThhNjdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMDcgIERhdmlk
IExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFN1YnJlc291cmNlTG9hZGVyIHNob3VsZCBleHBvc2UgYSB3
YXkgdG8gc2V0IHRoZSBvdXRnb2luZyByZWZlcmVyL29yaWdpbgorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU5MDMKKworICAgICAgICBObyBuZXcgdGVz
dHMgYXMgbm8gbmV3IGZ1bmN0aW9uYWxpdHkgaXMgZXhwb3NlZC4KKworICAgICAgICAqIGxvYWRl
ci9TdWJyZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdWJyZXNvdXJjZUxv
YWRlcjo6Y3JlYXRlKToKKyAgICAgICAgKiBsb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuaDoKKwog
MjAxMS0wMy0wNyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl
dmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVy
L1N1YnJlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJj
ZUxvYWRlci5jcHAKaW5kZXggZjk0OGVjMzFkMTEwZTVlN2UwZTAxOGYxNDQ5MWQ3YzY2ODViZTFj
NS4uZjE3NzI5OTdkMzliMWViYTcwY2RiZmNhMTBkMDYzMzJjMGJiNmE1ZCAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCkBAIC02MCw3ICs2MCw3IEBAIFN1
YnJlc291cmNlTG9hZGVyOjp+U3VicmVzb3VyY2VMb2FkZXIoKQogI2VuZGlmCiB9CiAKLVBhc3NS
ZWZQdHI8U3VicmVzb3VyY2VMb2FkZXI+IFN1YnJlc291cmNlTG9hZGVyOjpjcmVhdGUoRnJhbWUq
IGZyYW1lLCBTdWJyZXNvdXJjZUxvYWRlckNsaWVudCogY2xpZW50LCBjb25zdCBSZXNvdXJjZVJl
cXVlc3QmIHJlcXVlc3QsIFNlY3VyaXR5Q2hlY2tQb2xpY3kgc2VjdXJpdHlDaGVjaywgYm9vbCBz
ZW5kUmVzb3VyY2VMb2FkQ2FsbGJhY2tzLCBib29sIHNob3VsZENvbnRlbnRTbmlmZikKK1Bhc3NS
ZWZQdHI8U3VicmVzb3VyY2VMb2FkZXI+IFN1YnJlc291cmNlTG9hZGVyOjpjcmVhdGUoRnJhbWUq
IGZyYW1lLCBTdWJyZXNvdXJjZUxvYWRlckNsaWVudCogY2xpZW50LCBjb25zdCBSZXNvdXJjZVJl
cXVlc3QmIHJlcXVlc3QsIFNlY3VyaXR5Q2hlY2tQb2xpY3kgc2VjdXJpdHlDaGVjaywgYm9vbCBz
ZW5kUmVzb3VyY2VMb2FkQ2FsbGJhY2tzLCBib29sIHNob3VsZENvbnRlbnRTbmlmZiwgY29uc3Qg
U3RyaW5nKiBvdXRnb2luZ1JlZmVycmVyKQogewogICAgIGlmICghZnJhbWUpCiAgICAgICAgIHJl
dHVybiAwOwpAQCAtNzYsMTEgKzc2LDIxIEBAIFBhc3NSZWZQdHI8U3VicmVzb3VyY2VMb2FkZXI+
IFN1YnJlc291cmNlTG9hZGVyOjpjcmVhdGUoRnJhbWUqIGZyYW1lLCBTdWJyZXNvdXJjCiAgICAg
ICAgIHJldHVybiAwOwogICAgIH0KICAgICAKLSAgICBpZiAoU2VjdXJpdHlPcmlnaW46OnNob3Vs
ZEhpZGVSZWZlcnJlcihyZXF1ZXN0LnVybCgpLCBmbC0+b3V0Z29pbmdSZWZlcnJlcigpKSkKKyAg
ICBTdHJpbmcgcmVmZXJyZXI7CisgICAgU3RyaW5nIG91dGdvaW5nT3JpZ2luOworICAgIGlmIChv
dXRnb2luZ1JlZmVycmVyKSB7CisgICAgICAgIHJlZmVycmVyID0gKm91dGdvaW5nUmVmZXJyZXI7
CisgICAgICAgIG91dGdvaW5nT3JpZ2luID0gU2VjdXJpdHlPcmlnaW46OmNyZWF0ZUZyb21TdHJp
bmcocmVmZXJyZXIpLT50b1N0cmluZygpOworICAgIH0gZWxzZSB7CisgICAgICAgIHJlZmVycmVy
ID0gZmwtPm91dGdvaW5nUmVmZXJyZXIoKTsKKyAgICAgICAgb3V0Z29pbmdPcmlnaW4gPSBmbC0+
b3V0Z29pbmdPcmlnaW4oKTsKKyAgICB9CisKKyAgICBpZiAoU2VjdXJpdHlPcmlnaW46OnNob3Vs
ZEhpZGVSZWZlcnJlcihyZXF1ZXN0LnVybCgpLCByZWZlcnJlcikpCiAgICAgICAgIG5ld1JlcXVl
c3QuY2xlYXJIVFRQUmVmZXJyZXIoKTsKICAgICBlbHNlIGlmICghcmVxdWVzdC5odHRwUmVmZXJy
ZXIoKSkKLSAgICAgICAgbmV3UmVxdWVzdC5zZXRIVFRQUmVmZXJyZXIoZmwtPm91dGdvaW5nUmVm
ZXJyZXIoKSk7Ci0gICAgRnJhbWVMb2FkZXI6OmFkZEhUVFBPcmlnaW5JZk5lZWRlZChuZXdSZXF1
ZXN0LCBmbC0+b3V0Z29pbmdPcmlnaW4oKSk7CisgICAgICAgIG5ld1JlcXVlc3Quc2V0SFRUUFJl
ZmVycmVyKHJlZmVycmVyKCkpOworICAgIEZyYW1lTG9hZGVyOjphZGRIVFRQT3JpZ2luSWZOZWVk
ZWQobmV3UmVxdWVzdCwgb3V0Z29pbmdPcmlnaW4pOwogCiAgICAgZmwtPmFkZEV4dHJhRmllbGRz
VG9TdWJyZXNvdXJjZVJlcXVlc3QobmV3UmVxdWVzdCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy
L1N1YnJlc291cmNlTG9hZGVyLmgKaW5kZXggY2I3ZWQ4MWVjNGE4ZWI3NDU5MDljYzZlMGQzYWI2
YWYwYTJkMGQ2My4uZjBhNzhlZGI1NGE0ODAxZjk5ZjMyYjMzZWFiNjNkZGZmMWVjYzRlMiAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmgKKysrIGIv
U291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmgKQEAgLTM5LDcgKzM5LDcg
QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIAogICAgIGNsYXNzIFN1YnJlc291cmNlTG9hZGVy
IDogcHVibGljIFJlc291cmNlTG9hZGVyIHsKICAgICBwdWJsaWM6Ci0gICAgICAgIHN0YXRpYyBQ
YXNzUmVmUHRyPFN1YnJlc291cmNlTG9hZGVyPiBjcmVhdGUoRnJhbWUqLCBTdWJyZXNvdXJjZUxv
YWRlckNsaWVudCosIGNvbnN0IFJlc291cmNlUmVxdWVzdCYsIFNlY3VyaXR5Q2hlY2tQb2xpY3kg
PSBEb1NlY3VyaXR5Q2hlY2ssIGJvb2wgc2VuZFJlc291cmNlTG9hZENhbGxiYWNrcyA9IHRydWUs
IGJvb2wgc2hvdWxkQ29udGVudFNuaWZmID0gdHJ1ZSk7CisgICAgICAgIHN0YXRpYyBQYXNzUmVm
UHRyPFN1YnJlc291cmNlTG9hZGVyPiBjcmVhdGUoRnJhbWUqLCBTdWJyZXNvdXJjZUxvYWRlckNs
aWVudCosIGNvbnN0IFJlc291cmNlUmVxdWVzdCYsIFNlY3VyaXR5Q2hlY2tQb2xpY3kgPSBEb1Nl
Y3VyaXR5Q2hlY2ssIGJvb2wgc2VuZFJlc291cmNlTG9hZENhbGxiYWNrcyA9IHRydWUsIGJvb2wg
c2hvdWxkQ29udGVudFNuaWZmID0gdHJ1ZSwgY29uc3QgU3RyaW5nKiBvdXRnb2luZ1JlZmVycmVy
ID0gMCk7CiAKICAgICAgICAgdm9pZCBjbGVhckNsaWVudCgpIHsgbV9jbGllbnQgPSAwOyB9CiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>84988</attachid>
            <date>2011-03-07 15:31:38 -0800</date>
            <delta_ts>2011-03-07 15:34:10 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-55903-20110307153136.patch</filename>
            <type>text/plain</type>
            <size>3694</size>
            <attacher name="David Levin">levin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODA0ODgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNzljODA3ZjQ4M2IyZjM2
NGZhMWNmM2RlZGE0M2YzOTUwYzA4M2QyLi5lMTBiNTg5MDk2NWEwMmJjMjJmNzIzZmY3NzIxNmNl
MmMzMThhNjdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMDcgIERhdmlk
IExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFN1YnJlc291cmNlTG9hZGVyIHNob3VsZCBleHBvc2UgYSB3
YXkgdG8gc2V0IHRoZSBvdXRnb2luZyByZWZlcmVyL29yaWdpbgorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU5MDMKKworICAgICAgICBObyBuZXcgdGVz
dHMgYXMgbm8gbmV3IGZ1bmN0aW9uYWxpdHkgaXMgZXhwb3NlZC4KKworICAgICAgICAqIGxvYWRl
ci9TdWJyZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdWJyZXNvdXJjZUxv
YWRlcjo6Y3JlYXRlKToKKyAgICAgICAgKiBsb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuaDoKKwog
MjAxMS0wMy0wNyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl
dmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVy
L1N1YnJlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJj
ZUxvYWRlci5jcHAKaW5kZXggZjk0OGVjMzFkMTEwZTVlN2UwZTAxOGYxNDQ5MWQ3YzY2ODViZTFj
NS4uN2RkNTNmODk5NzcwNDcwNWNlNzQwNTViOWYzNjJjOTc4YzE3ZDExZSAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCkBAIC02MCw3ICs2MCw3IEBAIFN1
YnJlc291cmNlTG9hZGVyOjp+U3VicmVzb3VyY2VMb2FkZXIoKQogI2VuZGlmCiB9CiAKLVBhc3NS
ZWZQdHI8U3VicmVzb3VyY2VMb2FkZXI+IFN1YnJlc291cmNlTG9hZGVyOjpjcmVhdGUoRnJhbWUq
IGZyYW1lLCBTdWJyZXNvdXJjZUxvYWRlckNsaWVudCogY2xpZW50LCBjb25zdCBSZXNvdXJjZVJl
cXVlc3QmIHJlcXVlc3QsIFNlY3VyaXR5Q2hlY2tQb2xpY3kgc2VjdXJpdHlDaGVjaywgYm9vbCBz
ZW5kUmVzb3VyY2VMb2FkQ2FsbGJhY2tzLCBib29sIHNob3VsZENvbnRlbnRTbmlmZikKK1Bhc3NS
ZWZQdHI8U3VicmVzb3VyY2VMb2FkZXI+IFN1YnJlc291cmNlTG9hZGVyOjpjcmVhdGUoRnJhbWUq
IGZyYW1lLCBTdWJyZXNvdXJjZUxvYWRlckNsaWVudCogY2xpZW50LCBjb25zdCBSZXNvdXJjZVJl
cXVlc3QmIHJlcXVlc3QsIFNlY3VyaXR5Q2hlY2tQb2xpY3kgc2VjdXJpdHlDaGVjaywgYm9vbCBz
ZW5kUmVzb3VyY2VMb2FkQ2FsbGJhY2tzLCBib29sIHNob3VsZENvbnRlbnRTbmlmZiwgU3RyaW5n
IG91dGdvaW5nUmVmZXJyZXIpCiB7CiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAgcmV0dXJuIDA7
CkBAIC03NiwxMSArNzYsMTggQEAgUGFzc1JlZlB0cjxTdWJyZXNvdXJjZUxvYWRlcj4gU3VicmVz
b3VyY2VMb2FkZXI6OmNyZWF0ZShGcmFtZSogZnJhbWUsIFN1YnJlc291cmMKICAgICAgICAgcmV0
dXJuIDA7CiAgICAgfQogICAgIAotICAgIGlmIChTZWN1cml0eU9yaWdpbjo6c2hvdWxkSGlkZVJl
ZmVycmVyKHJlcXVlc3QudXJsKCksIGZsLT5vdXRnb2luZ1JlZmVycmVyKCkpKQorICAgIFN0cmlu
ZyBvdXRnb2luZ09yaWdpbjsKKyAgICBpZiAob3V0Z29pbmdSZWZlcnJlci5pc051bGwoKSkgewor
ICAgICAgICBvdXRnb2luZ1JlZmVycmVyID0gZmwtPm91dGdvaW5nUmVmZXJyZXIoKTsKKyAgICAg
ICAgb3V0Z29pbmdPcmlnaW4gPSBmbC0+b3V0Z29pbmdPcmlnaW4oKTsKKyAgICB9IGVsc2UKKyAg
ICAgICAgb3V0Z29pbmdPcmlnaW4gPSBTZWN1cml0eU9yaWdpbjo6Y3JlYXRlRnJvbVN0cmluZyhv
dXRnb2luZ1JlZmVycmVyKS0+dG9TdHJpbmcoKTsKKworICAgIGlmIChTZWN1cml0eU9yaWdpbjo6
c2hvdWxkSGlkZVJlZmVycmVyKHJlcXVlc3QudXJsKCksIG91dGdvaW5nUmVmZXJyZXIpKQogICAg
ICAgICBuZXdSZXF1ZXN0LmNsZWFySFRUUFJlZmVycmVyKCk7CiAgICAgZWxzZSBpZiAoIXJlcXVl
c3QuaHR0cFJlZmVycmVyKCkpCi0gICAgICAgIG5ld1JlcXVlc3Quc2V0SFRUUFJlZmVycmVyKGZs
LT5vdXRnb2luZ1JlZmVycmVyKCkpOwotICAgIEZyYW1lTG9hZGVyOjphZGRIVFRQT3JpZ2luSWZO
ZWVkZWQobmV3UmVxdWVzdCwgZmwtPm91dGdvaW5nT3JpZ2luKCkpOworICAgICAgICBuZXdSZXF1
ZXN0LnNldEhUVFBSZWZlcnJlcihvdXRnb2luZ1JlZmVycmVyKTsKKyAgICBGcmFtZUxvYWRlcjo6
YWRkSFRUUE9yaWdpbklmTmVlZGVkKG5ld1JlcXVlc3QsIG91dGdvaW5nT3JpZ2luKTsKIAogICAg
IGZsLT5hZGRFeHRyYUZpZWxkc1RvU3VicmVzb3VyY2VSZXF1ZXN0KG5ld1JlcXVlc3QpOwogCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuaCBiL1Nv
dXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5oCmluZGV4IGNiN2VkODFlYzRh
OGViNzQ1OTA5Y2M2ZTBkM2FiNmFmMGEyZDBkNjMuLjU4NGEwZDMxODA2OTZmN2Y5YzhkNzc2ZWUy
NGJmYzg0ZTI4YjFhZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNv
dXJjZUxvYWRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRl
ci5oCkBAIC0zMSw2ICszMSw4IEBACiAKICNpbmNsdWRlICJGcmFtZUxvYWRlclR5cGVzLmgiCiAj
aW5jbHVkZSAiUmVzb3VyY2VMb2FkZXIuaCIKKworI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmlu
Zy5oPgogIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC0zOSw3ICs0MSw3IEBAIG5hbWVzcGFj
ZSBXZWJDb3JlIHsKICAgICAKICAgICBjbGFzcyBTdWJyZXNvdXJjZUxvYWRlciA6IHB1YmxpYyBS
ZXNvdXJjZUxvYWRlciB7CiAgICAgcHVibGljOgotICAgICAgICBzdGF0aWMgUGFzc1JlZlB0cjxT
dWJyZXNvdXJjZUxvYWRlcj4gY3JlYXRlKEZyYW1lKiwgU3VicmVzb3VyY2VMb2FkZXJDbGllbnQq
LCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmLCBTZWN1cml0eUNoZWNrUG9saWN5ID0gRG9TZWN1cml0
eUNoZWNrLCBib29sIHNlbmRSZXNvdXJjZUxvYWRDYWxsYmFja3MgPSB0cnVlLCBib29sIHNob3Vs
ZENvbnRlbnRTbmlmZiA9IHRydWUpOworICAgICAgICBzdGF0aWMgUGFzc1JlZlB0cjxTdWJyZXNv
dXJjZUxvYWRlcj4gY3JlYXRlKEZyYW1lKiwgU3VicmVzb3VyY2VMb2FkZXJDbGllbnQqLCBjb25z
dCBSZXNvdXJjZVJlcXVlc3QmLCBTZWN1cml0eUNoZWNrUG9saWN5ID0gRG9TZWN1cml0eUNoZWNr
LCBib29sIHNlbmRSZXNvdXJjZUxvYWRDYWxsYmFja3MgPSB0cnVlLCBib29sIHNob3VsZENvbnRl
bnRTbmlmZiA9IHRydWUsIFN0cmluZyBvdXRnb2luZ1JlZmVycmVyID0gU3RyaW5nKCkpOwogCiAg
ICAgICAgIHZvaWQgY2xlYXJDbGllbnQoKSB7IG1fY2xpZW50ID0gMDsgfQogCg==
</data>
<flag name="review"
          id="77047"
          type_id="1"
          status="+"
          setter="abarth"
    />
    <flag name="commit-queue"
          id="77051"
          type_id="3"
          status="-"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>