55878 2011-03-07 07:35:57 -0800 [Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer 2011-03-08 00:10:30 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 54458 0 zan webkit-unassigned commit-queue mdelaney7 oldest_to_newest 363339 0 zan 2011-03-07 07:35:57 -0800 Gtk uses ImageBuffer::toDataURL in ImageBufferGtk.cpp to get data URL for a buffer. If data URL should be of mimetype image/jpeg, current code uses quality parameter if passed and utilizes it when saving a GdkPixbuf (which we get from the cairo surface) to a buffer. The problem is that quality passed to the gdk_pixbuf_save_to_buffer function should be in range of [0, 100] while we currently keep it in range [0.0, 1.0]. This results in canvas/philip/tests/toDataURL.jpeg.quality.basic.html failing. 363342 1 84944 zan 2011-03-07 07:44:12 -0800 Created attachment 84944 Put quality into an appropriate range. This patch multiplies quality variable, which is originally in range [0.0, 1.0] by 100.0 to ensure it is in the correct range of [0, 100], as seen in gdk_pixbuf_save function documentation[1]. [1] http://library.gnome.org/devel/gdk-pixbuf/2.22/gdk-pixbuf-file-saving.html#gdk-pixbuf-save 363524 2 84944 mrobinson 2011-03-07 13:08:10 -0800 Comment on attachment 84944 Put quality into an appropriate range. Nice catch. 363862 3 84944 commit-queue 2011-03-08 00:10:25 -0800 Comment on attachment 84944 Put quality into an appropriate range. Clearing flags on attachment: 84944 Committed r80546: <http://trac.webkit.org/changeset/80546> 363863 4 commit-queue 2011-03-08 00:10:30 -0800 All reviewed patches have been landed. Closing bug. 84944 2011-03-07 07:44:12 -0800 2011-03-08 00:10:25 -0800 Put quality into an appropriate range. q.p text/plain 2881 zan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmNDk1OGI5Li5iOGQxYjI2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMt MDcgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSB0b0RhdGFVUkwgdXNlcyBp bmNvcnJlY3QgcXVhbGl0eSB2YWx1ZSB3aGVuIHNhdmluZyBHZGtQaXhidWYgdG8gYnVmZmVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTg3OAorCisg ICAgICAgIEVuYWJsZSBhIHBhc3NpbmcgdGVzdCBub3cgdGhhdCB3ZSBwcm9wZXJseSB1c2UgdGhl IHF1YWxpdHkgdmFsdWUgd2hlbiByZXF1ZXN0aW5nCisgICAgICAgIGEgR2RrUGl4YnVmIHRvIGJl IHNhdmVkIGludG8gYSBidWZmZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2tpcHBlZDoK KwogMjAxMS0wMy0wNSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjgwNDI4LgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9n dGsvU2tpcHBlZAppbmRleCBhMTkyZjRmLi4zZDMwOWNhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tp cHBlZApAQCAtMTAwNCw3ICsxMDA0LDYgQEAgY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXR0ZXJu LnBhaW50LnJlcGVhdHguY29vcmQxLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0dGVy bi5wYWludC5yZXBlYXR4Lm91dHNpZGUuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXR0 ZXJuLnBhaW50LnJlcGVhdHkuY29vcmQxLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0 dGVybi5wYWludC5yZXBlYXR5Lm91dHNpZGUuaHRtbAotY2FudmFzL3BoaWxpcC90ZXN0cy90b0Rh dGFVUkwuanBlZy5xdWFsaXR5LmJhc2ljLmh0bWwKIAogIyBGYWlsaW5nIHRlc3RzIGFmdGVyIHN5 bmMgd2l0aCBQaGlsaXAgVGF5bG9yJ3MgdXBzdHJlYW0gdGVzdHMKIGNhbnZhcy9waGlsaXAvdGVz dHMvMmQuZHJhd0ltYWdlLmltYWdlLmluY29tcGxldGUub21pdHRlZC5odG1sCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggZDIzNDhmYS4uZmU0NDlkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTAz LTA3ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0d0a10gdG9EYXRhVVJMIHVzZXMg aW5jb3JyZWN0IHF1YWxpdHkgdmFsdWUgd2hlbiBzYXZpbmcgR2RrUGl4YnVmIHRvIGJ1ZmZlcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU4NzgKKwor ICAgICAgICBNdWx0aXBseSB0aGUgcXVhbGl0eSBwYXJhbWV0ZXIgYnkgMTAwIHRvIHB1dCBpdCBp biB0aGUgcmFuZ2UgWzAsIDEwMF0gYXMgbmVlZGVkCisgICAgICAgIHdoZW4gc2F2aW5nIEdka1Bp eGJ1ZiB0byBhIGJ1ZmZlci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFn ZUJ1ZmZlckd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6dG9EYXRhVVJM KToKKwogMjAxMS0wMy0wNSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjgwNDI4LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdlQnVmZmVyR3RrLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFnZUJ1ZmZlckd0ay5j cHAKaW5kZXggMmFhMDE2ZS4uM2RhMGY5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdlQnVmZmVyR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvSW1hZ2VCdWZmZXJHdGsuY3BwCkBAIC01NCw3ICs1NCw3 IEBAIFN0cmluZyBJbWFnZUJ1ZmZlcjo6dG9EYXRhVVJMKGNvbnN0IFN0cmluZyYgbWltZVR5cGUs IGNvbnN0IGRvdWJsZSogcXVhbGl0eSkgY29uCiAgICAgR0Vycm9yKiBlcnJvciA9IDA7CiAgICAg Z2Jvb2xlYW4gc3VjY2VzcyA9IEZBTFNFOwogICAgIGlmICh0eXBlID09ICJqcGVnIiAmJiBxdWFs aXR5ICYmICpxdWFsaXR5ID49IDAuMCAmJiAqcXVhbGl0eSA8PSAxLjApIHsKLSAgICAgICAgU3Ry aW5nIHF1YWxpdHlTdHJpbmcgPSBTdHJpbmc6OmZvcm1hdCgiJWYiLCAqcXVhbGl0eSk7CisgICAg ICAgIFN0cmluZyBxdWFsaXR5U3RyaW5nID0gU3RyaW5nOjpmb3JtYXQoIiVmIiwgKnF1YWxpdHkg KiAxMDAuMCk7CiAgICAgICAgIHN1Y2Nlc3MgPSBnZGtfcGl4YnVmX3NhdmVfdG9fYnVmZmVyKHBp eGJ1Zi5nZXQoKSwgJmJ1ZmZlci5vdXRQdHIoKSwgJmJ1ZmZlclNpemUsCiAgICAgICAgICAgICB0 eXBlLnV0ZjgoKS5kYXRhKCksICZlcnJvciwgInF1YWxpdHkiLCBxdWFsaXR5U3RyaW5nLnV0Zjgo KS5kYXRhKCksIE5VTEwpOwogICAgIH0gZWxzZSB7Cg==