55868 2011-03-07 03:48:56 -0800 [GTK] Do not set juntion sides on scrollbar stepper buttons 2011-03-08 02:05:35 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned oldest_to_newest 363291 0 cgarcia 2011-03-07 03:48:56 -0800 It breaks themes using rounded stepper buttons on scrollbars like Adwaita 363292 1 cgarcia 2011-03-07 03:51:05 -0800 See gtk+ commit: http://git.gnome.org/browse/gtk+/commit/?id=11f07f9bdcc34861368faa8b54775157bbd0d9e6 363293 2 84932 cgarcia 2011-03-07 03:52:01 -0800 Created attachment 84932 Patch 363528 3 84932 mrobinson 2011-03-07 13:10:04 -0800 Comment on attachment 84932 Patch Seems sane. 363909 4 cgarcia 2011-03-08 02:04:37 -0800 Committed r80555: <http://trac.webkit.org/changeset/80555> 84932 2011-03-07 03:52:01 -0800 2011-03-08 02:05:35 -0800 Patch juntion-sides-scrollbar.diff text/plain 3978 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNWJiODMyLi43YjlhY2U4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDMtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IERvIG5vdCBzZXQganVudGlvbiBzaWRlcyBvbiBzY3JvbGxiYXIgc3RlcHBlciBidXR0b25zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTg2OAorCisg ICAgICAgIEZpeGVzIHJlbmRlcmluZyBvZiBzdGVwcGVycyBmb3IgdGhlbWVzIHVzaW5nIHJvdW5k ZWQgc3RlcHBlcgorICAgICAgICBidXR0b25zIG9uIHNjcm9sbGJhcnMgbGlrZSBBZHdhaXRhLgor CisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrMy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTY3JvbGxiYXJUaGVtZUd0azo6cGFpbnRCdXR0b24pOgorCiAyMDExLTAzLTA2 ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Ny b2xsYmFyVGhlbWVHdGszLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxi YXJUaGVtZUd0azMuY3BwCmluZGV4IDhiYzQyYWYuLmIwYjUxNDYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0azMuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0azMuY3BwCkBAIC0xMzUsNDAg KzEzNSwxNiBAQCB2b2lkIFNjcm9sbGJhclRoZW1lR3RrOjpwYWludEJ1dHRvbihHcmFwaGljc0Nv bnRleHQqIGNvbnRleHQsIFNjcm9sbGJhciogc2Nyb2xsYgogICAgICAgICBmbGFncyB8PSBHVEtf U1RBVEVfRkxBR19JTlNFTlNJVElWRTsKICAgICBndGtfc3R5bGVfY29udGV4dF9zZXRfc3RhdGUo bV9jb250ZXh0LCBzdGF0aWNfY2FzdDxHdGtTdGF0ZUZsYWdzPihmbGFncykpOwogCi0gICAgZ3Vp bnQgc2lkZXMgPSBndGtfc3R5bGVfY29udGV4dF9nZXRfanVuY3Rpb25fc2lkZXMobV9jb250ZXh0 KTsKLSAgICBpZiAoc2Nyb2xsYmFyLT5vcmllbnRhdGlvbigpID09IFZlcnRpY2FsU2Nyb2xsYmFy KQotICAgICAgICBzaWRlcyAmPSB+KEdUS19KVU5DVElPTl9UT1AgfCBHVEtfSlVOQ1RJT05fQk9U VE9NKTsKLSAgICBlbHNlCi0gICAgICAgIHNpZGVzICY9IH4oR1RLX0pVTkNUSU9OX0xFRlQgfCBH VEtfSlVOQ1RJT05fUklHSFQpOwotCi0gICAgc3dpdGNoIChwYXJ0KSB7Ci0gICAgY2FzZSBCYWNr QnV0dG9uU3RhcnRQYXJ0OgotICAgICAgICBzaWRlcyB8PSAoc2Nyb2xsYmFyLT5vcmllbnRhdGlv bigpID09IFZlcnRpY2FsU2Nyb2xsYmFyKSA/IEdUS19KVU5DVElPTl9CT1RUT00gOiBHVEtfSlVO Q1RJT05fUklHSFQ7Ci0gICAgICAgIGJyZWFrOwotICAgIGNhc2UgQmFja0J1dHRvbkVuZFBhcnQ6 Ci0gICAgY2FzZSBGb3J3YXJkQnV0dG9uRW5kUGFydDoKLSAgICAgICAgc2lkZXMgfD0gKHNjcm9s bGJhci0+b3JpZW50YXRpb24oKSA9PSBWZXJ0aWNhbFNjcm9sbGJhcikgPwotICAgICAgICAgICAg ICAgIEdUS19KVU5DVElPTl9UT1AgfCBHVEtfSlVOQ1RJT05fQk9UVE9NIDogR1RLX0pVTkNUSU9O X1JJR0hUIHwgR1RLX0pVTkNUSU9OX0xFRlQ7Ci0gICAgICAgIGJyZWFrOwotICAgIGNhc2UgRm9y d2FyZEJ1dHRvblN0YXJ0UGFydDoKLSAgICAgICAgc2lkZXMgfD0gKHNjcm9sbGJhci0+b3JpZW50 YXRpb24oKSA9PSBWZXJ0aWNhbFNjcm9sbGJhcikgPyBHVEtfSlVOQ1RJT05fVE9QIDogR1RLX0pV TkNUSU9OX0xFRlQ7Ci0gICAgICAgIGJyZWFrOwotICAgIGRlZmF1bHQ6Ci0gICAgICAgIEFTU0VS VF9OT1RfUkVBQ0hFRCgpOwotICAgIH0KLSAgICBndGtfc3R5bGVfY29udGV4dF9zZXRfanVuY3Rp b25fc2lkZXMobV9jb250ZXh0LCBzdGF0aWNfY2FzdDxHdGtKdW5jdGlvblNpZGVzPihzaWRlcykp OwogICAgIGd0a19zdHlsZV9jb250ZXh0X2FkZF9jbGFzcyhtX2NvbnRleHQsIEdUS19TVFlMRV9D TEFTU19CVVRUT04pOwotCiAgICAgZ3RrX3JlbmRlcl9iYWNrZ3JvdW5kKG1fY29udGV4dCwgY29u dGV4dC0+cGxhdGZvcm1Db250ZXh0KCksIHJlY3QueCgpLCByZWN0LnkoKSwgcmVjdC53aWR0aCgp LCByZWN0LmhlaWdodCgpKTsKICAgICBndGtfcmVuZGVyX2ZyYW1lKG1fY29udGV4dCwgY29udGV4 dC0+cGxhdGZvcm1Db250ZXh0KCksIHJlY3QueCgpLCByZWN0LnkoKSwgcmVjdC53aWR0aCgpLCBy ZWN0LmhlaWdodCgpKTsKIAogICAgIGdmbG9hdCBhcnJvd1NjYWxpbmc7CiAgICAgZ3RrX3N0eWxl X2NvbnRleHRfZ2V0X3N0eWxlKG1fY29udGV4dCwgImFycm93LXNjYWxpbmciLCAmYXJyb3dTY2Fs aW5nLCBOVUxMKTsKIAotICAgIEludFNpemUgYXJyb3dTaXplID0gcmVjdC5zaXplKCk7Ci0gICAg YXJyb3dTaXplLnNjYWxlKGFycm93U2NhbGluZyk7Ci0gICAgRmxvYXRQb2ludCBhcnJvd1BvaW50 KHJlY3QueCgpICsgKHJlY3Qud2lkdGgoKSAtIGFycm93U2l6ZS53aWR0aCgpKSAvIDIsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgIHJlY3QueSgpICsgKHJlY3QuaGVpZ2h0KCkgLSBhcnJvd1Np emUuaGVpZ2h0KCkpIC8gMik7CisgICAgZG91YmxlIGFycm93U2l6ZSA9IHN0ZDo6bWluKHJlY3Qu d2lkdGgoKSwgcmVjdC5oZWlnaHQoKSkgKiBhcnJvd1NjYWxpbmc7CisgICAgRmxvYXRQb2ludCBh cnJvd1BvaW50KHJlY3QueCgpICsgKHJlY3Qud2lkdGgoKSAtIGFycm93U2l6ZSkgLyAyLAorICAg ICAgICAgICAgICAgICAgICAgICAgICByZWN0LnkoKSArIChyZWN0LmhlaWdodCgpIC0gYXJyb3dT aXplKSAvIDIpOwogCiAgICAgaWYgKGZsYWdzICYgR1RLX1NUQVRFX0ZMQUdfQUNUSVZFKSB7CiAg ICAgICAgIGdpbnQgYXJyb3dEaXNwbGFjZW1lbnRYLCBhcnJvd0Rpc3BsYWNlbWVudFk7CkBAIC0x NzksMTYgKzE1NSwxNCBAQCB2b2lkIFNjcm9sbGJhclRoZW1lR3RrOjpwYWludEJ1dHRvbihHcmFw aGljc0NvbnRleHQqIGNvbnRleHQsIFNjcm9sbGJhciogc2Nyb2xsYgogICAgICAgICBhcnJvd1Bv aW50Lm1vdmUoYXJyb3dEaXNwbGFjZW1lbnRYLCBhcnJvd0Rpc3BsYWNlbWVudFkpOwogICAgIH0K IAotICAgIGdkb3VibGUgYW5nbGUsIHNpemU7CisgICAgZ2RvdWJsZSBhbmdsZTsKICAgICBpZiAo c2Nyb2xsYmFyLT5vcmllbnRhdGlvbigpID09IFZlcnRpY2FsU2Nyb2xsYmFyKSB7Ci0gICAgICAg IHNpemUgPSBhcnJvd1NpemUud2lkdGgoKTsKICAgICAgICAgYW5nbGUgPSAocGFydCA9PSBGb3J3 YXJkQnV0dG9uRW5kUGFydCB8fCBwYXJ0ID09IEZvcndhcmRCdXR0b25TdGFydFBhcnQpID8gR19Q SSA6IDA7CiAgICAgfSBlbHNlIHsKLSAgICAgICAgc2l6ZSA9IGFycm93U2l6ZS5oZWlnaHQoKTsK ICAgICAgICAgYW5nbGUgPSAocGFydCA9PSBGb3J3YXJkQnV0dG9uRW5kUGFydCB8fCBwYXJ0ID09 IEZvcndhcmRCdXR0b25TdGFydFBhcnQpID8gR19QSSAvIDIgOiAzICogKEdfUEkgLyAyKTsKICAg ICB9CiAKLSAgICBndGtfcmVuZGVyX2Fycm93KG1fY29udGV4dCwgY29udGV4dC0+cGxhdGZvcm1D b250ZXh0KCksIGFuZ2xlLCBhcnJvd1BvaW50LngoKSwgYXJyb3dQb2ludC55KCksIHNpemUpOwor ICAgIGd0a19yZW5kZXJfYXJyb3cobV9jb250ZXh0LCBjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQo KSwgYW5nbGUsIGFycm93UG9pbnQueCgpLCBhcnJvd1BvaW50LnkoKSwgYXJyb3dTaXplKTsKIAog ICAgIGd0a19zdHlsZV9jb250ZXh0X3Jlc3RvcmUobV9jb250ZXh0KTsKIH0K