55866 2011-03-07 03:15:41 -0800 [GTK] Use doubles instead of integers for coordinates when rendering arrows 2011-03-08 02:01:49 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned oldest_to_newest 363280 0 cgarcia 2011-03-07 03:15:41 -0800 To prevent off-by-one rounding errors, see gtk+ commits: http://git.gnome.org/browse/gtk+/commit/?id=fa4fb6724c4afbd59535148303bc5ba8265f4d70 http://git.gnome.org/browse/gtk+/commit/?id=230bd4b4617bb2bc803d946658529a0b3e15b44c 363281 1 84930 cgarcia 2011-03-07 03:18:29 -0800 Created attachment 84930 Patch 363906 2 cgarcia 2011-03-08 02:01:01 -0800 Committed r80554: <http://trac.webkit.org/changeset/80554> 84930 2011-03-07 03:18:29 -0800 2011-03-08 02:01:49 -0800 Patch doubles-arrows.diff text/plain 2963 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNWJiODMyLi4yZTNjY2UxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDMtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IFVzZSBkb3VibGVzIGluc3RlYWQgb2YgaW50ZWdlcnMgZm9yIGNvb3JkaW5hdGVzIHdoZW4gcmVu ZGVyaW5nIGFycm93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTU4NjYKKworICAgICAgICBUbyBwcmV2ZW50IG9mZi1ieS1vbmUgcm91bmRpbmcgZXJy b3JzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrMy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUd0azo6cGFpbnRNZW51TGlzdCk6CisgICAgICAgICog cGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrMy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT Y3JvbGxiYXJUaGVtZUd0azo6cGFpbnRCdXR0b24pOgorCiAyMDExLTAzLTA2ICBBZGFtIEJhcnRo ICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsz LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0azMuY3BwCmlu ZGV4IDdmYTBmMDQuLjUyN2RlMWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9SZW5kZXJUaGVtZUd0azMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9SZW5kZXJUaGVtZUd0azMuY3BwCkBAIC00ODMsMTQgKzQ4MywxNCBAQCBib29sIFJlbmRlclRo ZW1lR3RrOjpwYWludE1lbnVMaXN0KFJlbmRlck9iamVjdCogcmVuZGVyT2JqZWN0LCBjb25zdCBQ YWludEluZm8mCiAgICAgZ3RrX3N0eWxlX2NvbnRleHRfZ2V0X3N0eWxlKGFycm93U3R5bGVDb250 ZXh0LCAiYXJyb3ctc2NhbGluZyIsICZhcnJvd1NjYWxpbmcsIE5VTEwpOwogCiAgICAgSW50U2l6 ZSBhcnJvd1NpemUobWluQXJyb3dTaXplLCBpbm5lclJlY3QuaGVpZ2h0KCkpOwotICAgIEludFBv aW50IGFycm93UG9zaXRpb24gPSBpbm5lclJlY3QubG9jYXRpb24oKTsKKyAgICBGbG9hdFBvaW50 IGFycm93UG9zaXRpb24oaW5uZXJSZWN0LmxvY2F0aW9uKCkpOwogICAgIGlmIChkaXJlY3Rpb24g PT0gR1RLX1RFWFRfRElSX0xUUikKICAgICAgICAgYXJyb3dQb3NpdGlvbi5tb3ZlKGlubmVyUmVj dC53aWR0aCgpIC0gYXJyb3dTaXplLndpZHRoKCksIDApOwogCiAgICAgLy8gR1RLKyBhY3R1YWxs eSBmZXRjaGVzIHRoZSB4YWxpZ24gYW5kIHZhbGlnbiB2YWx1ZXMgZnJvbSB0aGUgd2lkZ2V0LCBi dXQgc2luY2Ugd2UKICAgICAvLyBkb24ndCBoYXZlIGEgd2lkZ2V0IGhlcmUsIHdlIGFyZSBqdXN0 IHVzaW5nIHRoZSBkZWZhdWx0IHhhbGlnbiBhbmQgdmFsaWduIHZhbHVlcyBvZiAwLjUuCiAgICAg Z2ludCBleHRlbnQgPSBzdGQ6Om1pbihhcnJvd1NpemUud2lkdGgoKSwgYXJyb3dTaXplLmhlaWdo dCgpKSAqIGFycm93U2NhbGluZzsKLSAgICBhcnJvd1Bvc2l0aW9uLm1vdmUoc3RkOjpmbG9vcigo YXJyb3dTaXplLndpZHRoKCkgLSBleHRlbnQpIC8gMiksIHN0ZDo6Zmxvb3IoKGFycm93U2l6ZS5o ZWlnaHQoKSAtIGV4dGVudCkgLyAyKSk7CisgICAgYXJyb3dQb3NpdGlvbi5tb3ZlKChhcnJvd1Np emUud2lkdGgoKSAtIGV4dGVudCkgLyAyLCAoYXJyb3dTaXplLmhlaWdodCgpIC0gZXh0ZW50KSAv IDIpOwogCiAgICAgZ3RrX3N0eWxlX2NvbnRleHRfc2V0X3N0YXRlKGFycm93U3R5bGVDb250ZXh0 LCBzdGF0ZSk7CiAgICAgZ3RrX3JlbmRlcl9hcnJvdyhhcnJvd1N0eWxlQ29udGV4dCwgY2Fpcm9D b250ZXh0LCBHX1BJLCBhcnJvd1Bvc2l0aW9uLngoKSwgYXJyb3dQb3NpdGlvbi55KCksIGV4dGVu dCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsYmFyVGhl bWVHdGszLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0 azMuY3BwCmluZGV4IGQwMDAwNjMuLjhiYzQyYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0azMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0azMuY3BwCkBAIC0xNjcsOCArMTY3LDggQEAg dm9pZCBTY3JvbGxiYXJUaGVtZUd0azo6cGFpbnRCdXR0b24oR3JhcGhpY3NDb250ZXh0KiBjb250 ZXh0LCBTY3JvbGxiYXIqIHNjcm9sbGIKIAogICAgIEludFNpemUgYXJyb3dTaXplID0gcmVjdC5z aXplKCk7CiAgICAgYXJyb3dTaXplLnNjYWxlKGFycm93U2NhbGluZyk7Ci0gICAgSW50UG9pbnQg YXJyb3dQb2ludChyZWN0LngoKSArIChyZWN0LndpZHRoKCkgLSBhcnJvd1NpemUud2lkdGgoKSkg LyAyLAotICAgICAgICAgICAgICAgICAgICAgICAgcmVjdC55KCkgKyAocmVjdC5oZWlnaHQoKSAt IGFycm93U2l6ZS5oZWlnaHQoKSkgLyAyKTsKKyAgICBGbG9hdFBvaW50IGFycm93UG9pbnQocmVj dC54KCkgKyAocmVjdC53aWR0aCgpIC0gYXJyb3dTaXplLndpZHRoKCkpIC8gMiwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgcmVjdC55KCkgKyAocmVjdC5oZWlnaHQoKSAtIGFycm93U2l6ZS5o ZWlnaHQoKSkgLyAyKTsKIAogICAgIGlmIChmbGFncyAmIEdUS19TVEFURV9GTEFHX0FDVElWRSkg ewogICAgICAgICBnaW50IGFycm93RGlzcGxhY2VtZW50WCwgYXJyb3dEaXNwbGFjZW1lbnRZOwo=