55834 2011-03-05 15:58:37 -0800 Implement LayoutTestController::setValueForUser on Windows 2012-03-15 16:50:10 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED InRadar, LayoutTestFailure, PlatformOnly P2 Normal --- 1 jberlin isherman abarth aroben darin eric isherman jberlin lynn.neir webkit.review.bot oldest_to_newest 363014 0 jberlin 2011-03-05 15:58:37 -0800 http://trac.webkit.org/changeset/80412 http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/10084 http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r80412%20(10087)/results.html http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/26028 http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r80412%20(26029)/results.html Until the failure can be investigated, the failing results should be landed as expected results for platform win. 363015 1 isherman 2011-03-05 16:01:03 -0800 (In reply to comment #0) > http://trac.webkit.org/changeset/80412 > > http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/10084 > http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r80412%20(10087)/results.html > > http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/26028 > http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r80412%20(26029)/results.html > > Until the failure can be investigated, the failing results should be landed as expected results for platform win. Oops, this is my bad for not landing the expectations with the patch that added the test. The test depends on a LayoutTestController method that's implemented only on Mac. 363745 2 85007 isherman 2011-03-07 18:24:02 -0800 Created attachment 85007 Patch 363746 3 85007 darin 2011-03-07 18:28:19 -0800 Comment on attachment 85007 Patch Jessie said the failing results should be landed. Not that the test should be skipped. 363749 4 isherman 2011-03-07 18:34:10 -0800 (In reply to comment #3) > (From update of attachment 85007 [details]) > Jessie said the failing results should be landed. Not that the test should be skipped. I'd like to understand: What makes the one better than the other? 363777 5 darin 2011-03-07 19:50:11 -0800 (In reply to comment #4) > (In reply to comment #3) > > Jessie said the failing results should be landed. Not that the test should be skipped. > > I'd like to understand: What makes the one better than the other? The basics: If test results are landed, we can easily track if any change in behavior occurs, or if a crash is introduced. If we simply skip a test, then the code covered by the test is not exercised at all, and future patches may change behavior without anyone noticing. 363839 6 isherman 2011-03-07 23:06:00 -0800 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > Jessie said the failing results should be landed. Not that the test should be skipped. > > > > I'd like to understand: What makes the one better than the other? > > The basics: If test results are landed, we can easily track if any change in behavior occurs, or if a crash is introduced. If we simply skip a test, then the code covered by the test is not exercised at all, and future patches may change behavior without anyone noticing. Hmm... that makes sense, but I'm not sure how it applies to this particular bug. This particular test depends on a LayoutTestController method that is not implemented on Windows. Without this method, I wouldn't expect the test to provide any additional code coverage. Is the idea to run the test just in case it happens to provide additional code coverage unrelated to the main functionality that it's meant to test? 363844 7 85024 isherman 2011-03-07 23:14:49 -0800 Created attachment 85024 Set expectations 363846 8 85025 isherman 2011-03-07 23:18:45 -0800 Created attachment 85025 Set expectations, valid diff (copy pasting diff output because webkit-patch upload is misbehaving... hopefully without errors this time) 363957 9 jberlin 2011-03-08 07:26:20 -0800 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (In reply to comment #3) > > > > Jessie said the failing results should be landed. Not that the test should be skipped. > > > > > > I'd like to understand: What makes the one better than the other? > > > > The basics: If test results are landed, we can easily track if any change in behavior occurs, or if a crash is introduced. If we simply skip a test, then the code covered by the test is not exercised at all, and future patches may change behavior without anyone noticing. > > Hmm... that makes sense, but I'm not sure how it applies to this particular bug. This particular test depends on a LayoutTestController method that is not implemented on Windows. Without this method, I wouldn't expect the test to provide any additional code coverage. Is the idea to run the test just in case it happens to provide additional code coverage unrelated to the main functionality that it's meant to test? In this case, where the LayoutTestController method is not implemented on Windows at all, I think we usually add it to the skip list because, as you point out, it doesn't really provide any additional code coverage as is. When I originally suggested that failing expectations be landed, I did not realize that it was failing due to a LayoutTestController method being implemented on Windows. 364277 10 85122 isherman 2011-03-08 18:20:44 -0800 Created attachment 85122 Patch 365220 11 aroben 2011-03-10 08:53:23 -0800 *** Bug 56104 has been marked as a duplicate of this bug. *** 365223 12 85122 aroben 2011-03-10 08:56:04 -0800 Comment on attachment 85122 Patch I think checking in expected failure results is in fact the right thing to do. In general our rule is: if the test is failing the same way every time, and isn't crashing or timing out, we should check in expected failure results. See http://article.gmane.org/gmane.os.opendarwin.webkit.devel/10017 for some discussion of this policy. 365224 13 aroben 2011-03-10 08:57:11 -0800 Sorry for all the confusion. I'll take care of fixing the results. 365235 14 aroben 2011-03-10 09:13:27 -0800 Added Windows expected failure results Committed r80730: <http://trac.webkit.org/changeset/80730> 365238 15 jberlin 2011-03-10 09:17:14 -0800 <rdar://problem/9114972> 564596 16 128797 lynn.neir 2012-02-24 13:34:09 -0800 Created attachment 128797 implementation for LayoutTestController::setValueForUser in LayoutTestControllerWin.cpp I have implementation for this method. Please review attached code. The test /fast/forms/onchange-setvalueforuser.html now passes with this code (at least on wincairo port). I have attached the modified method LayoutTestController::setValueForUser in Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp Sorry if I submitted patch incorrectly, I am not sure how this is done. Thanks, Lynn 564602 17 128797 aroben 2012-02-24 13:38:39 -0800 Comment on attachment 128797 implementation for LayoutTestController::setValueForUser in LayoutTestControllerWin.cpp Thanks for the patch! It looks like this isn't actually a patch file. <http://www.webkit.org/coding/contributing.html> describes how to make a patch file. You should also set patches you wish to be reviewed to "r?", not "r+". 570101 18 129992 lynn.neir 2012-03-02 19:55:44 -0800 Created attachment 129992 patch file with code to provide fix for this bug. 570102 19 129993 lynn.neir 2012-03-02 19:57:13 -0800 Created attachment 129993 updated Layout test for patch fix. 570104 20 webkit.review.bot 2012-03-02 19:59:21 -0800 Attachment 129992 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/w..." exit_code: 1 Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp:800: Tab found; better to use spaces [whitespace/tab] [1] Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp:802: Tab found; better to use spaces [whitespace/tab] [1] Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp:804: Tab found; better to use spaces [whitespace/tab] [1] Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp:805: Tab found; better to use spaces [whitespace/tab] [1] Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp:807: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 571018 21 129993 jberlin 2012-03-05 13:55:27 -0800 Comment on attachment 129993 updated Layout test for patch fix. This should not be a separate from the patch that adds support to DRT. You should be landing the test changes at the same time as the DRT changes. You are going to need to land these results as win-wk2 failing results because you are not adding WKTR support. 571021 22 129992 jberlin 2012-03-05 13:59:11 -0800 Comment on attachment 129992 patch file with code to provide fix for this bug. View in context: https://bugs.webkit.org/attachment.cgi?id=129992&action=review Looks good to me, but you should fix the style issues and combine it with the patches to change the layout test expected results. >> Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp:805 >> + valueBSTR.Attach(JSStringCopyBSTR(value)); > > Tab found; better to use spaces [whitespace/tab] [1] You should be able do this one line: // The false parameter tells the _bstr_t constructor to adopt the BSTR we pass it. _bstr_t valueBSTR(JSStringCopyBSTR(value), false); 572151 23 130443 lynn.neir 2012-03-06 14:22:30 -0800 Created attachment 130443 patch with code fix and updated test case - patch file that combines changes for source code fix and update to layout test. - fix style issue (i.e., removed tabs). - update _bstr_t constructor to simplify code. 573387 24 jberlin 2012-03-07 17:13:37 -0800 (In reply to comment #23) > Created an attachment (id=130443) [details] > patch with code fix and updated test case > > - patch file that combines changes for source code fix and update to layout test. > - fix style issue (i.e., removed tabs). > - update _bstr_t constructor to simplify code. Looks like you lost your ChangeLogs? Did you run prepare-ChangeLog at top level? 573613 25 lynn.neir 2012-03-07 22:17:33 -0800 (In reply to comment #24) > (In reply to comment #23) > > Created an attachment (id=130443) [details] [details] > > patch with code fix and updated test case > > > > - patch file that combines changes for source code fix and update to layout test. > > - fix style issue (i.e., removed tabs). > > - update _bstr_t constructor to simplify code. > > Looks like you lost your ChangeLogs? > > Did you run prepare-ChangeLog at top level? I didn't know I had to that. I just ran prepare-ChangeLog at top level and it produced changes to Tools/ChangeLog and LayoutTest/ChangeLog. What do I do with these changeLog files? LayoutTests/ChangeLog 2012-03-07 Lynn Neir <lynn.neir@skype.net> Need a short description and bug URL (OOPS!) Reviewed by NOBODY (OOPS!). * platform/win/fast/forms/onchange-setvalueforuser-expected.txt: Removed . Tools/ChangeLog: 2012-03-07 Lynn Neir <lynn.neir@skype.net> Need a short description and bug URL (OOPS!) Reviewed by NOBODY (OOPS!). * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setValueForUser): Lynn 573865 26 jberlin 2012-03-08 08:53:28 -0800 (In reply to comment #25) > (In reply to comment #24) > > (In reply to comment #23) > > > Created an attachment (id=130443) [details] [details] [details] > > > patch with code fix and updated test case > > > > > > - patch file that combines changes for source code fix and update to layout test. > > > - fix style issue (i.e., removed tabs). > > > - update _bstr_t constructor to simplify code. > > > > Looks like you lost your ChangeLogs? > > > > Did you run prepare-ChangeLog at top level? > > I didn't know I had to that. I just ran prepare-ChangeLog at top level and it produced changes to Tools/ChangeLog and LayoutTest/ChangeLog. What do I do with these changeLog files? > > LayoutTests/ChangeLog > 2012-03-07 Lynn Neir <lynn.neir@skype.net> > > Need a short description and bug URL (OOPS!) Replace this line (and the one in Tools/ChangeLog) with the title and URL of the bug: Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834 > > Reviewed by NOBODY (OOPS!). When I r+ your patch (which I am holding off on doing because you don't have the ChangeLogs included yet and you didn't move the expected results to the win-wk2 directory), this line will become: Reviewed by Jessie Berlin. However, you should leave it alone (Reviewed by NOBODY (OOPS!)) when you post another version of your patch to this bugzilla. Below that, you should add a brief summary of your changes. In this case, when you move the expected results to the win-wk2 directory because you are only fixing DRT and not WKTR, that summary would be something like: "Moved expected failing results to win-wk2 because the test should now pass on DRT". > > * platform/win/fast/forms/onchange-setvalueforuser-expected.txt: Removed The reason I want you to move the expected failing results to LayoutTests/platform/win-wk2/fast/forms/onchange-setvalueforuser-expected.txt is that the change you are making is only to DumpRenderTree, which only runs the tests in WebKit1. In order to make this test pass in WebKit2, you would need to add similar support to WebKitTestRunner. While that would be great to do, it doesn't have to be done in this patch. However, we need to be expecting the failing results when we run the test in WebKit2 on Windows. Does that make sense? 576290 27 aroben 2012-03-12 11:11:00 -0700 http://www.webkit.org/coding/contributing.html has more information about how to use prepare-ChangeLog and how to submit a patch in general. 578589 28 131888 lynn.neir 2012-03-14 11:26:29 -0700 Created attachment 131888 implementation for setValueForUser in DumpRenderTree and WebKitTestRunner 578620 29 131888 jberlin 2012-03-14 12:02:14 -0700 Comment on attachment 131888 implementation for setValueForUser in DumpRenderTree and WebKitTestRunner View in context: https://bugs.webkit.org/attachment.cgi?id=131888&action=review I think it is really great that you are going ahead and adding a WebKitTestRunner implementation! How did you test this fix out for WebKitTestRunner? It doesn't look like you have taken the fast/forms/onchange-setvalueforuser.html off the WK2 Skipped list (found in LayoutTests/platform/wk2/Skipped), so this test still won't run in WK2. > Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:437 > + WKBundleNodeHandleSetHTMLInputElementValueForUser(WKBundleNodeHandleCreate(context, const_cast<JSObjectRef>(element)), toWK(value).get()); You are leaking the WKBundleNodeHandle here. You should use a WKRetainPtr for it: WKRetainPtr<WKBundleNodeHandle> nodeHandle(AdoptWK, WKBundleNodeHandleCreate(context, const_cast<JSObjectRef>(element)), toWK(value).get())); 578627 30 lynn.neir 2012-03-14 12:12:28 -0700 (In reply to comment #29) > (From update of attachment 131888 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131888&action=review > > I think it is really great that you are going ahead and adding a WebKitTestRunner implementation! > > How did you test this fix out for WebKitTestRunner? It doesn't look like you have taken the fast/forms/onchange-setvalueforuser.html off the WK2 Skipped list (found in LayoutTests/platform/wk2/Skipped), so this test still won't run in WK2. > I did see that skipped there but wasn't sure that Skipped files was related to platform/win-wk2/Skipped. The item is not present in later Skipped file. I guess somehow the wk2/Skipped is parent skip file??? So should I remove from platform/wk2/Skipped. > > Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:437 > > + WKBundleNodeHandleSetHTMLInputElementValueForUser(WKBundleNodeHandleCreate(context, const_cast<JSObjectRef>(element)), toWK(value).get()); > > You are leaking the WKBundleNodeHandle here. > > You should use a WKRetainPtr for it: > > WKRetainPtr<WKBundleNodeHandle> nodeHandle(AdoptWK, WKBundleNodeHandleCreate(context, const_cast<JSObjectRef>(element)), toWK(value).get())); Sorry, I'll fix that up. I had it like that then streamlined code but wrongly! 578632 31 jberlin 2012-03-14 12:18:08 -0700 (In reply to comment #30) > (In reply to comment #29) > > (From update of attachment 131888 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=131888&action=review > > > > I think it is really great that you are going ahead and adding a WebKitTestRunner implementation! > > > > How did you test this fix out for WebKitTestRunner? It doesn't look like you have taken the fast/forms/onchange-setvalueforuser.html off the WK2 Skipped list (found in LayoutTests/platform/wk2/Skipped), so this test still won't run in WK2. > > > > I did see that skipped there but wasn't sure that Skipped files was related to platform/win-wk2/Skipped. The item is not present in later Skipped file. I guess somehow the wk2/Skipped is parent skip file??? Yes. The Skipped files for win-wk2, mac-wk2, and gtk-wk2 all "inherit" from the wk2 Skipped file. That way it is possible to skip a file for all of WK2 once instead of having to add it to each Skipped file individually. > > So should I remove from platform/wk2/Skipped. Yes (and then run the test in WK2 to make sure it passes: run-webkit-tests -2 LayoutTests/fast/forms/onchange-setvalueforuser.html > > > > Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:437 > > > + WKBundleNodeHandleSetHTMLInputElementValueForUser(WKBundleNodeHandleCreate(context, const_cast<JSObjectRef>(element)), toWK(value).get()); > > > > You are leaking the WKBundleNodeHandle here. > > > > You should use a WKRetainPtr for it: > > > > WKRetainPtr<WKBundleNodeHandle> nodeHandle(AdoptWK, WKBundleNodeHandleCreate(context, const_cast<JSObjectRef>(element)), toWK(value).get())); > > Sorry, I'll fix that up. I had it like that then streamlined code but wrongly! 578640 32 lynn.neir 2012-03-14 12:23:09 -0700 (In reply to comment #31) > (In reply to comment #30) > > (In reply to comment #29) > > > (From update of attachment 131888 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=131888&action=review > > > > > > I think it is really great that you are going ahead and adding a WebKitTestRunner implementation! > > > > > > How did you test this fix out for WebKitTestRunner? It doesn't look like you have taken the fast/forms/onchange-setvalueforuser.html off the WK2 Skipped list (found in LayoutTests/platform/wk2/Skipped), so this test still won't run in WK2. > > > > > > > I did see that skipped there but wasn't sure that Skipped files was related to platform/win-wk2/Skipped. The item is not present in later Skipped file. I guess somehow the wk2/Skipped is parent skip file??? > > Yes. The Skipped files for win-wk2, mac-wk2, and gtk-wk2 all "inherit" from the wk2 Skipped file. That way it is possible to skip a file for all of WK2 once instead of having to add it to each Skipped file individually. > > > > > So should I remove from platform/wk2/Skipped. > > Yes (and then run the test in WK2 to make sure it passes: > > run-webkit-tests -2 LayoutTests/fast/forms/onchange-setvalueforuser.html > yes that the same command line I ran previously and said passed. I guess maybe it ignores skip file in this case? In any case, i'll remove from skipped file and resubmit patch shortly. thanks. 578655 33 131900 lynn.neir 2012-03-14 12:34:45 -0700 Created attachment 131900 new patch - fixed leak and updated wk2 skipped file. 578755 34 131900 jberlin 2012-03-14 14:13:06 -0700 Comment on attachment 131900 new patch - fixed leak and updated wk2 skipped file. r=me! Do you need me to set commit-queue+ as well? It doesn't look like you are a committer .. 578770 35 lynn.neir 2012-03-14 14:22:17 -0700 (In reply to comment #34) > (From update of attachment 131900 [details]) > r=me! > > Do you need me to set commit-queue+ as well? It doesn't look like you are a committer .. yes. i am not a committer. 578787 36 131900 webkit.review.bot 2012-03-14 14:34:53 -0700 Comment on attachment 131900 new patch - fixed leak and updated wk2 skipped file. Rejecting attachment 131900 from review queue. jberlin@webkit.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 578801 37 131900 jberlin 2012-03-14 14:52:22 -0700 Comment on attachment 131900 new patch - fixed leak and updated wk2 skipped file. Yes, I actually do have reviewership. 579739 38 lynn.neir 2012-03-15 14:25:59 -0700 (In reply to comment #37) > (From update of attachment 131900 [details]) > Yes, I actually do have reviewership. Anything I need to do here? Looks like code has not been committed yet. 579782 39 jberlin 2012-03-15 15:04:38 -0700 (In reply to comment #38) > (In reply to comment #37) > > (From update of attachment 131900 [details] [details]) > > Yes, I actually do have reviewership. > > Anything I need to do here? Looks like code has not been committed yet. The commit queue seems be taking quite a long time getting to this patch ... http://queues.webkit.org/queue-status/commit-queue 579797 40 eric 2012-03-15 15:13:27 -0700 Sorry, the commit-queue has had 3 troubles in the last 3 days. :( 1. some hangs due to some svn.webkit.org outage. 2. the feeder-queue (which is what cq-'s when someone's review-bit isn't set) was failing to update its working copy (which abarth fixed last night). 3. Finally, the cq's were all hung this morning due to bug 81251. I'm very sorry for the outages, and I'm happy to land the patch on Lynn's behalf. I expect the CQ's should catch up sometime after 5PM tonight (when the input rate comes down). The CQs are currently 40 patches behind due to volume after last night's outage (#3 on the above list). We're working on robustness more today, so that hopefully this won't happen again. thanks again for your patience. 579890 41 131900 webkit.review.bot 2012-03-15 16:44:17 -0700 Comment on attachment 131900 new patch - fixed leak and updated wk2 skipped file. Clearing flags on attachment: 131900 Committed r110909: <http://trac.webkit.org/changeset/110909> 579891 42 webkit.review.bot 2012-03-15 16:44:24 -0700 All reviewed patches have been landed. Closing bug. 579896 43 isherman 2012-03-15 16:50:10 -0700 Thanks for implementing this, Lynn! :) 85007 2011-03-07 18:24:02 -0800 2011-03-07 23:14:49 -0800 Patch bug-55834-20110307182401.patch text/plain 1234 isherman U3VidmVyc2lvbiBSZXZpc2lvbjogODA0ODAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkZTM1OWIwZTA1ZDBhY2U2YmI1NjJj ZDkyYmY5YWU5YmZmOTk3MTJlLi5hNjhiYzNhOTUyOTczN2RiOTExYjdjMmVjZGMzYWJmMWQ0Yjcz N2MyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDMtMDcgIElseWEgU2hlcm1hbiAgPGlz aGVybWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBmYXN0L2Zvcm1zL29uY2hhbmdlLXNldHZhbHVlZm9ydXNlci5odG1sIGZh aWxpbmcgb24gV2luZG93cyA3IGFuZCBXaW5kb3dzIFhQIHNpbmNlIHI4MDQxMgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU4MzQKKworICAgICAgICAq IHBsYXRmb3JtL3dpbi9Ta2lwcGVkOiBTa2lwIGZhc3QvZm9ybXMvb25jaGFuZ2Utc2V0dmFsdWVm b3J1c2VyLmh0bWwgZm9yIG5vdworCiAyMDExLTAzLTA3ICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFN0ZXZlIEJsb2NrLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS93aW4vU2tpcHBlZAppbmRleCAxOWQ2OTVhOTRlZjE1ZTZmZTcxNDc1MjZjMjQyNzU0Njdl OGI3MWI1Li43OTg4YzU3MjYyYzhlYjViNjM2ODVlYThkMjVjYjBkN2M4ZmNjMTg5IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS93aW4vU2tpcHBlZApAQCAtMTE2NCwzICsxMTY0LDYgQEAgaW5zcGVjdG9yL2RlYnVn Z2VyCiAKICMgRm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDUx OQogZmFzdC94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1yZXNwb25zZXR5cGUtYXJyYXli dWZmZXIuaHRtbAorCisjIE1pc3NpbmcgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0VmFsdWVGb3JV c2VyKCkgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1ODM0CitmYXN0 L2Zvcm1zL29uY2hhbmdlLXNldHZhbHVlZm9ydXNlci5odG1sCg== 85024 2011-03-07 23:14:49 -0800 2011-03-07 23:18:45 -0800 Set expectations asdf.diff text/plain 1048 isherman ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NzIyMTEwLi42ZmNjZjBkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDMt MDcgIElseWEgU2hlcm1hbiAgPGlzaGVybWFuQGNocm9taXVtLm9yZz4KKworICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgZmFzdC9mb3Jtcy9vbmNoYW5nZS1zZXR2 YWx1ZWZvcnVzZXIuaHRtbCBmYWlsaW5nIG9uIFdpbmRvd3MgNyBhbmQgV2luZG93cyBYUCBzaW5j ZSByODA0MTIKKyAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTU4MzQKKworICAgICAgICogcGxhdGZvcm0vd2luL2Zhc3QvZm9ybXMvb25jaGFuZ2Utc2V0dmFs dWVmb3J1c2VyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMTEtMDMtMDcgIEZ1bWl0b3NoaSBV a2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdXBkYXRlIGNo cm9taXVtIHRlc3QgZXhwZWN0YXRpb25zLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vd2luL2Zhc3QvZm9ybXMvb25jaGFuZ2Utc2V0dmFsdWVmb3J1c2VyLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0L2Zvcm1zL29uY2hhbmdlLXNldHZhbHVlZm9y dXNlci0KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYzE5ZmIzYQotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0L2Zvcm1zL29uY2hhbmdl LXNldHZhbHVlZm9ydXNlci1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw0IEBACitUaGlzIHRlc3Rz IHRoYXQgb25jaGFuZ2UgY29ycmVjdGx5IGZpcmVzIGFmdGVyIGNhbGxpbmcgc2V0VmFsdWVGb3JV c2VyKCkuIEl0IGNhbiBvbmx5IGJlIHJ1biB1c2luZyBEdW1wUmVuZGVyVHJlZS4KKworRkFJTCBv bmNoYW5nZSBuZXZlciBmaXJlZAorCg== 85025 2011-03-07 23:18:45 -0800 2011-03-08 18:20:42 -0800 Set expectations, valid diff asdf.diff text/plain 1059 isherman ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NzIyMTEwLi42ZmNjZjBkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDMt MDcgIElseWEgU2hlcm1hbiAgPGlzaGVybWFuQGNocm9taXVtLm9yZz4KKworICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgZmFzdC9mb3Jtcy9vbmNoYW5nZS1zZXR2 YWx1ZWZvcnVzZXIuaHRtbCBmYWlsaW5nIG9uIFdpbmRvd3MgNyBhbmQgV2luZG93cyBYUCBzaW5j ZSByODA0MTIKKyAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTU4MzQKKworICAgICAgICogcGxhdGZvcm0vd2luL2Zhc3QvZm9ybXMvb25jaGFuZ2Utc2V0dmFs dWVmb3J1c2VyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMTEtMDMtMDcgIEZ1bWl0b3NoaSBV a2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CgogICAgICAgICBVbnJldmlld2VkLCB1cGRhdGUgY2hy b21pdW0gdGVzdCBleHBlY3RhdGlvbnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS93aW4vZmFzdC9mb3Jtcy9vbmNoYW5nZS1zZXR2YWx1ZWZvcnVzZXItZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2Zhc3QvZm9ybXMvb25jaGFuZ2Utc2V0dmFsdWVmb3J1 c2VyLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5jMTlm YjNhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2Zhc3QvZm9y bXMvb25jaGFuZ2Utc2V0dmFsdWVmb3J1c2VyLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDQgQEAK K1RoaXMgdGVzdHMgdGhhdCBvbmNoYW5nZSBjb3JyZWN0bHkgZmlyZXMgYWZ0ZXIgY2FsbGluZyBz ZXRWYWx1ZUZvclVzZXIoKS4gSXQgY2FuIG9ubHkgYmUgcnVuIHVzaW5nIER1bXBSZW5kZXJUcmVl LgorCitGQUlMIG9uY2hhbmdlIG5ldmVyIGZpcmVkCisK 85122 2011-03-08 18:20:44 -0800 2011-03-10 16:31:21 -0800 Patch bug-55834-20110308182043.patch text/plain 1260 isherman U3VidmVyc2lvbiBSZXZpc2lvbjogODA1NjQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzMzE3ZjE5MDdhNjFmZmNjN2MzNTUx NDYyN2Q2NTIwY2U0M2ZhYzNhLi42YWE5OWQ3NmM2NDdmZTMwNGFlMTk1YTk4ZTJhYTFkNGUwMjI3 OGQ5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDMtMDggIElseWEgU2hlcm1hbiAgPGlz aGVybWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBmYXN0L2Zvcm1zL29uY2hhbmdlLXNldHZhbHVlZm9ydXNlci5odG1sIGZh aWxpbmcgb24gV2luZG93cyA3IGFuZCBXaW5kb3dzIFhQIHNpbmNlIHI4MDQxMgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU4MzQKKworICAgICAgICAq IHBsYXRmb3JtL3dpbi9Ta2lwcGVkOiBTa2lwIGZhc3QvZm9ybXMvb25jaGFuZ2Utc2V0dmFsdWVm b3J1c2VyLmh0bWwgZm9yIG5vdworCiAyMDExLTAzLTA4ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5v cm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyODA0NzgpOiBicm9rZSBH VEsgaW5zcGVjdG9yIHRlc3RzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4v U2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkCmluZGV4IDFmYmMzN2U5 MWZjMWZhNTA1NDczYzgyNDgyYTA4YTA1MTYxNDhiMzcuLmVmZWFhOGQyNjY4OTAxMDAyY2Q0ODEz MDhjOGNlY2Q3OWVmYzY0OGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9T a2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkCkBAIC0xMTcxLDMg KzExNzEsNiBAQCBlZGl0aW5nL3Bhc3RlYm9hcmQvb25wYXN0ZS10ZXh0LWh0bWwtdHlwZXMuaHRt bAogCiAjIERhdGFUcmFuc2Zlckl0ZW1zIGlzIG5vdCB5ZXQgaW1wbGVtZW50ZWQuCiBlZGl0aW5n L3Bhc3RlYm9hcmQvZGF0YS10cmFuc2Zlci1pdGVtcy5odG1sCisKKyMgTWlzc2luZyBsYXlvdXRU ZXN0Q29udHJvbGxlci5zZXRWYWx1ZUZvclVzZXIoKSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTU4MzQKK2Zhc3QvZm9ybXMvb25jaGFuZ2Utc2V0dmFsdWVmb3J1c2Vy Lmh0bWwK 128797 2012-02-24 13:34:09 -0800 2012-02-29 11:28:01 -0800 implementation for LayoutTestController::setValueForUser in LayoutTestControllerWin.cpp LayoutTestControllerWinPatch.txt text/plain 742 lynn.neir dm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0VmFsdWVGb3JVc2VyKEpTQ29udGV4dFJlZiBj b250ZXh0LCBKU1ZhbHVlUmVmIGVsZW1lbnQsIEpTU3RyaW5nUmVmIHZhbHVlKQ0Kew0KICAgIENP TVB0cjxJV2ViVmlldz4gd2ViVmlldzsNCiAgICBpZiAoRkFJTEVEKGZyYW1lLT53ZWJWaWV3KCZ3 ZWJWaWV3KSkpDQogICAgICAgIHJldHVybjsNCg0KICAgIENPTVB0cjxJV2ViVmlld1ByaXZhdGU+ IHdlYlZpZXdQcml2YXRlKFF1ZXJ5LCB3ZWJWaWV3KTsNCiAgICBpZiAoIXdlYlZpZXdQcml2YXRl KQ0KICAgICAgICByZXR1cm47DQoNCiAgICBDT01QdHI8SURPTUVsZW1lbnQ+IGRvbUVsZW1lbnQ7 DQogICAgaWYgKEZBSUxFRCh3ZWJWaWV3UHJpdmF0ZS0+ZWxlbWVudEZyb21KUyhjb250ZXh0LCBl bGVtZW50LCAmZG9tRWxlbWVudCkpKQ0KICAgICAgICByZXR1cm47DQoNCglDT01QdHI8SURPTUhU TUxJbnB1dEVsZW1lbnQ+IGRvbUlucHV0RWxlbWVudDsNCiAgICBpZiAoRkFJTEVEKGRvbUVsZW1l bnQtPlF1ZXJ5SW50ZXJmYWNlKElJRF9JRE9NSFRNTElucHV0RWxlbWVudCwgcmVpbnRlcnByZXRf Y2FzdDx2b2lkKio+KCZkb21JbnB1dEVsZW1lbnQpKSkpDQoJCXJldHVybjsNCg0KCUJTVFIgdmFs dWVCU1RSID0gSlNTdHJpbmdDb3B5QlNUUih2YWx1ZSk7DQoNCglkb21JbnB1dEVsZW1lbnQtPnNl dFZhbHVlRm9yVXNlcih2YWx1ZUJTVFIpOw0KDQoJU3lzRnJlZVN0cmluZyh2YWx1ZUJTVFIpOw0K fQ== 129992 2012-03-02 19:55:44 -0800 2012-03-06 14:22:30 -0800 patch file with code to provide fix for this bug. fix.patch text/plain 1812 lynn.neir SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwOTIzMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTAyLTI5ICBMeW5uIE5laXIgIDxseW5uLm5laXJAc2t5cGUubmV0Pgor CisgICAgICAgIEltcGxlbWVudCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0VmFsdWVGb3JVc2Vy IG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU1ODM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBEdW1wUmVuZGVyVHJlZS93aW4vTGF5b3V0VGVzdENvbnRyb2xsZXJXaW4uY3BwOgorICAg ICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFZhbHVlRm9yVXNlcik6CisKIDIwMTItMDIt MjkgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF1b V0syXSBXZWJLaXRUZXN0UnVubmVyIHNob3VsZCB1c2UgNDgweDM2MCBzaXplZCB2aWV3IGZvciBX M0MgU1ZHIHRlc3RzCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vTGF5b3V0VGVzdENv bnRyb2xsZXJXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9M YXlvdXRUZXN0Q29udHJvbGxlcldpbi5jcHAJKHJldmlzaW9uIDEwOTIyMCkKKysrIFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3dpbi9MYXlvdXRUZXN0Q29udHJvbGxlcldpbi5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTc4NSw3ICs3ODUsMjYgQEAgdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0VXNl clN0eWxlUwogCiB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRWYWx1ZUZvclVzZXIoSlND b250ZXh0UmVmIGNvbnRleHQsIEpTVmFsdWVSZWYgZWxlbWVudCwgSlNTdHJpbmdSZWYgdmFsdWUp CiB7Ci0gICAgLy8gRklYTUU6IGltcGxlbWVudAorICAgIENPTVB0cjxJV2ViVmlldz4gd2ViVmll dzsKKyAgICBpZiAoRkFJTEVEKGZyYW1lLT53ZWJWaWV3KCZ3ZWJWaWV3KSkpCisgICAgICAgIHJl dHVybjsKKworICAgIENPTVB0cjxJV2ViVmlld1ByaXZhdGU+IHdlYlZpZXdQcml2YXRlKFF1ZXJ5 LCB3ZWJWaWV3KTsKKyAgICBpZiAoIXdlYlZpZXdQcml2YXRlKQorICAgICAgICByZXR1cm47CisK KyAgICBDT01QdHI8SURPTUVsZW1lbnQ+IGRvbUVsZW1lbnQ7CisgICAgaWYgKEZBSUxFRCh3ZWJW aWV3UHJpdmF0ZS0+ZWxlbWVudEZyb21KUyhjb250ZXh0LCBlbGVtZW50LCAmZG9tRWxlbWVudCkp KQorICAgICAgICByZXR1cm47CisKKwlDT01QdHI8SURPTUhUTUxJbnB1dEVsZW1lbnQ+IGRvbUlu cHV0RWxlbWVudDsKKyAgICBpZiAoRkFJTEVEKGRvbUVsZW1lbnQtPlF1ZXJ5SW50ZXJmYWNlKElJ RF9JRE9NSFRNTElucHV0RWxlbWVudCwgcmVpbnRlcnByZXRfY2FzdDx2b2lkKio+KCZkb21JbnB1 dEVsZW1lbnQpKSkpCisJCXJldHVybjsKKworCV9ic3RyX3QgdmFsdWVCU1RSOworCXZhbHVlQlNU Ui5BdHRhY2goSlNTdHJpbmdDb3B5QlNUUih2YWx1ZSkpOworCisJZG9tSW5wdXRFbGVtZW50LT5z ZXRWYWx1ZUZvclVzZXIodmFsdWVCU1RSKTsKIH0KIAogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxl cjo6c2V0Vmlld01vZGVNZWRpYUZlYXR1cmUoSlNTdHJpbmdSZWYgbW9kZSkK 129993 2012-03-02 19:57:13 -0800 2012-03-06 14:22:30 -0800 updated Layout test for patch fix. test.patch text/plain 1119 lynn.neir SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwOTIzMykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAyLTI5ICBMeW5uIE5laXIgIDxseW5u Lm5laXJAc2t5cGUubmV0PgorCisgICAgICAgIEltcGxlbWVudCBMYXlvdXRUZXN0Q29udHJvbGxl cjo6c2V0VmFsdWVGb3JVc2VyIG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU1ODM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vZmFzdC9mb3Jtcy9vbmNoYW5nZS1z ZXR2YWx1ZWZvcnVzZXItZXhwZWN0ZWQudHh0OiBSZW1vdmVkLgorCiAyMDEyLTAyLTI5ICBEbWl0 cnkgTG9tb3YgIDxkc2xvbW92QGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZDogdXBk YXRpbmcgZXhwZWN0YXRpb25zIGZvciBjaHJtaXVtIChlcnJvciBtZXNzYWdlcykKSW5kZXg6IExh eW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0L2Zvcm1zL29uY2hhbmdlLXNldHZhbHVlZm9ydXNl ci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2Zh c3QvZm9ybXMvb25jaGFuZ2Utc2V0dmFsdWVmb3J1c2VyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MTA5MjIwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2Zhc3QvZm9ybXMvb25jaGFuZ2Ut c2V0dmFsdWVmb3J1c2VyLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw0ICswLDAg QEAKLVRoaXMgdGVzdHMgdGhhdCBvbmNoYW5nZSBjb3JyZWN0bHkgZmlyZXMgYWZ0ZXIgY2FsbGlu ZyBzZXRWYWx1ZUZvclVzZXIoKS4gSXQgY2FuIG9ubHkgYmUgcnVuIHVzaW5nIER1bXBSZW5kZXJU cmVlLgotCi1GQUlMIG9uY2hhbmdlIG5ldmVyIGZpcmVkCi0K 130443 2012-03-06 14:22:30 -0800 2012-03-14 11:26:29 -0700 patch with code fix and updated test case mypatch.patch text/plain 1675 lynn.neir SW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9MYXlvdXRUZXN0Q29udHJvbGxlcldpbi5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0xheW91dFRlc3RDb250 cm9sbGVyV2luLmNwcAkocmV2aXNpb24gMTA5OTU0KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUv d2luL0xheW91dFRlc3RDb250cm9sbGVyV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzg1LDcg Kzc4NSwyNSBAQCB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRVc2VyU3R5bGVTCiAKIHZv aWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFZhbHVlRm9yVXNlcihKU0NvbnRleHRSZWYgY29u dGV4dCwgSlNWYWx1ZVJlZiBlbGVtZW50LCBKU1N0cmluZ1JlZiB2YWx1ZSkKIHsKLSAgICAvLyBG SVhNRTogaW1wbGVtZW50CisgICAgQ09NUHRyPElXZWJWaWV3PiB3ZWJWaWV3OworICAgIGlmIChG QUlMRUQoZnJhbWUtPndlYlZpZXcoJndlYlZpZXcpKSkKKyAgICAgICAgcmV0dXJuOworCisgICAg Q09NUHRyPElXZWJWaWV3UHJpdmF0ZT4gd2ViVmlld1ByaXZhdGUoUXVlcnksIHdlYlZpZXcpOwor ICAgIGlmICghd2ViVmlld1ByaXZhdGUpCisgICAgICAgIHJldHVybjsKKworICAgIENPTVB0cjxJ RE9NRWxlbWVudD4gZG9tRWxlbWVudDsKKyAgICBpZiAoRkFJTEVEKHdlYlZpZXdQcml2YXRlLT5l bGVtZW50RnJvbUpTKGNvbnRleHQsIGVsZW1lbnQsICZkb21FbGVtZW50KSkpCisgICAgICAgIHJl dHVybjsKKworICAgIENPTVB0cjxJRE9NSFRNTElucHV0RWxlbWVudD4gZG9tSW5wdXRFbGVtZW50 OworICAgIGlmIChGQUlMRUQoZG9tRWxlbWVudC0+UXVlcnlJbnRlcmZhY2UoSUlEX0lET01IVE1M SW5wdXRFbGVtZW50LCByZWludGVycHJldF9jYXN0PHZvaWQqKj4oJmRvbUlucHV0RWxlbWVudCkp KSkKKyAgICAgICAgcmV0dXJuOworCisgICAgX2JzdHJfdCB2YWx1ZUJTVFIoSlNTdHJpbmdDb3B5 QlNUUih2YWx1ZSksIGZhbHNlKTsKKworICAgIGRvbUlucHV0RWxlbWVudC0+c2V0VmFsdWVGb3JV c2VyKHZhbHVlQlNUUik7CiB9CiAKIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFZpZXdN b2RlTWVkaWFGZWF0dXJlKEpTU3RyaW5nUmVmIG1vZGUpCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS93aW4vZmFzdC9mb3Jtcy9vbmNoYW5nZS1zZXR2YWx1ZWZvcnVzZXItZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0L2Zvcm1zL29uY2hh bmdlLXNldHZhbHVlZm9ydXNlci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDEwOTk1NCkKKysrIExh eW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0L2Zvcm1zL29uY2hhbmdlLXNldHZhbHVlZm9ydXNl ci1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMCwwIEBACi1UaGlzIHRlc3Rz IHRoYXQgb25jaGFuZ2UgY29ycmVjdGx5IGZpcmVzIGFmdGVyIGNhbGxpbmcgc2V0VmFsdWVGb3JV c2VyKCkuIEl0IGNhbiBvbmx5IGJlIHJ1biB1c2luZyBEdW1wUmVuZGVyVHJlZS4KLQotRkFJTCBv bmNoYW5nZSBuZXZlciBmaXJlZAotCg== 131888 2012-03-14 11:26:29 -0700 2012-03-14 12:34:45 -0700 implementation for setValueForUser in DumpRenderTree and WebKitTestRunner setValueForUserPatch.patch text/plain 5961 lynn.neir SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMDcxNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDEyLTAzLTE0ICBMeW5uIE5laXIgIDxseW5uLm5laXJAc2t5cGUubmV0Pgor CisgICAgICAgIEltcGxlbWVudCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0VmFsdWVGb3JVc2Vy IG9uIFdpbmRvd3MgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1ODM0 CisKKyAgICAgICAgSW1wbGVtZW50ZWQgc2V0VmFsdWVGb3JVc2VyIGluIGJvdGggRHVtcFJlbmRl clRyZWUgYW5kIFdlYktpdFRlc3RSdW5uZXIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS93aW4vTGF5b3V0VGVzdENvbnRy b2xsZXJXaW4uY3BwOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFZhbHVlRm9y VXNlcik6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5n cy9MYXlvdXRUZXN0Q29udHJvbGxlci5pZGw6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9J bmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXVFI6Okxh eW91dFRlc3RDb250cm9sbGVyOjpzZXRWYWx1ZUZvclVzZXIpOgorICAgICAgICAoV1RSKToKKyAg ICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xheW91dFRlc3RDb250cm9s bGVyLmg6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcik6CisKIDIwMTItMDMtMTMgIEpl ciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgTGlvbiBJbnRlbCBEZWJ1 ZyBXZWJLaXQyIFRlc3RzIGNyYXNoaW5nIHVuZGVyIFtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9s bGVyIF9zdGFydEVudGVyRnVsbFNjcmVlbkFuaW1hdGlvbldpdGhEdXJhdGlvbjpdCkluZGV4OiBU b29scy9EdW1wUmVuZGVyVHJlZS93aW4vTGF5b3V0VGVzdENvbnRyb2xsZXJXaW4uY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9MYXlvdXRUZXN0Q29udHJvbGxlcldp bi5jcHAJKHJldmlzaW9uIDExMDcxMykKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9MYXlv dXRUZXN0Q29udHJvbGxlcldpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc3OSw3ICs3NzksMjUg QEAgdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0VXNlclN0eWxlUwogCiB2b2lkIExheW91 dFRlc3RDb250cm9sbGVyOjpzZXRWYWx1ZUZvclVzZXIoSlNDb250ZXh0UmVmIGNvbnRleHQsIEpT VmFsdWVSZWYgZWxlbWVudCwgSlNTdHJpbmdSZWYgdmFsdWUpCiB7Ci0gICAgLy8gRklYTUU6IGlt cGxlbWVudAorICAgIENPTVB0cjxJV2ViVmlldz4gd2ViVmlldzsKKyAgICBpZiAoRkFJTEVEKGZy YW1lLT53ZWJWaWV3KCZ3ZWJWaWV3KSkpCisgICAgICAgIHJldHVybjsKKworICAgIENPTVB0cjxJ V2ViVmlld1ByaXZhdGU+IHdlYlZpZXdQcml2YXRlKFF1ZXJ5LCB3ZWJWaWV3KTsKKyAgICBpZiAo IXdlYlZpZXdQcml2YXRlKQorICAgICAgICByZXR1cm47CisKKyAgICBDT01QdHI8SURPTUVsZW1l bnQ+IGRvbUVsZW1lbnQ7CisgICAgaWYgKEZBSUxFRCh3ZWJWaWV3UHJpdmF0ZS0+ZWxlbWVudEZy b21KUyhjb250ZXh0LCBlbGVtZW50LCAmZG9tRWxlbWVudCkpKQorICAgICAgICByZXR1cm47CisK KyAgICBDT01QdHI8SURPTUhUTUxJbnB1dEVsZW1lbnQ+IGRvbUlucHV0RWxlbWVudDsKKyAgICBp ZiAoRkFJTEVEKGRvbUVsZW1lbnQtPlF1ZXJ5SW50ZXJmYWNlKElJRF9JRE9NSFRNTElucHV0RWxl bWVudCwgcmVpbnRlcnByZXRfY2FzdDx2b2lkKio+KCZkb21JbnB1dEVsZW1lbnQpKSkpCisgICAg ICAgIHJldHVybjsKKworICAgIF9ic3RyX3QgdmFsdWVCU1RSKEpTU3RyaW5nQ29weUJTVFIodmFs dWUpLCBmYWxzZSk7CisKKyAgICBkb21JbnB1dEVsZW1lbnQtPnNldFZhbHVlRm9yVXNlcih2YWx1 ZUJTVFIpOwogfQogCiB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRWaWV3TW9kZU1lZGlh RmVhdHVyZShKU1N0cmluZ1JlZiBtb2RlKQpJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9J bmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5j cHAJKHJldmlzaW9uIDExMDcxMykKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRC dW5kbGUvTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MjksNiAr NDI5LDE0IEBAIGJvb2wgTGF5b3V0VGVzdENvbnRyb2xsZXI6OmlzUGFnZUJveFZpc2kKICAgICBy ZXR1cm4gV0tCdW5kbGVJc1BhZ2VCb3hWaXNpYmxlKEluamVjdGVkQnVuZGxlOjpzaGFyZWQoKS5i dW5kbGUoKSwgbWFpbkZyYW1lLCBwYWdlSW5kZXgpOwogfQogCit2b2lkIExheW91dFRlc3RDb250 cm9sbGVyOjpzZXRWYWx1ZUZvclVzZXIoSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTVmFsdWVSZWYg ZWxlbWVudCwgSlNTdHJpbmdSZWYgdmFsdWUpCit7CisgICAgaWYgKCFlbGVtZW50IHx8ICFKU1Zh bHVlSXNPYmplY3QoY29udGV4dCwgZWxlbWVudCkpCisgICAgICAgIHJldHVybjsKKworICAgIFdL QnVuZGxlTm9kZUhhbmRsZVNldEhUTUxJbnB1dEVsZW1lbnRWYWx1ZUZvclVzZXIoV0tCdW5kbGVO b2RlSGFuZGxlQ3JlYXRlKGNvbnRleHQsIGNvbnN0X2Nhc3Q8SlNPYmplY3RSZWY+KGVsZW1lbnQp KSwgdG9XSyh2YWx1ZSkuZ2V0KCkpOworfQorCiB1bnNpZ25lZCBMYXlvdXRUZXN0Q29udHJvbGxl cjo6d2luZG93Q291bnQoKQogewogICAgIHJldHVybiBJbmplY3RlZEJ1bmRsZTo6c2hhcmVkKCku cGFnZUNvdW50KCk7CkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxl L0xheW91dFRlc3RDb250cm9sbGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5oCShyZXZpc2lvbiAxMTA3 MTMpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xheW91dFRlc3RD b250cm9sbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTEzOCw2ICsxMzgsOCBAQCBwdWJsaWM6CiAg ICAgSlNSZXRhaW5QdHI8SlNTdHJpbmdSZWY+IHBhZ2VTaXplQW5kTWFyZ2luc0luUGl4ZWxzKGlu dCBwYWdlSW5kZXgsIGludCB3aWR0aCwgaW50IGhlaWdodCwgaW50IG1hcmdpblRvcCwgaW50IG1h cmdpblJpZ2h0LCBpbnQgbWFyZ2luQm90dG9tLCBpbnQgbWFyZ2luTGVmdCk7CiAgICAgYm9vbCBp c1BhZ2VCb3hWaXNpYmxlKGludCBwYWdlSW5kZXgpOwogCisgICAgdm9pZCBzZXRWYWx1ZUZvclVz ZXIoSlNDb250ZXh0UmVmLCBKU1ZhbHVlUmVmIGVsZW1lbnQsIEpTU3RyaW5nUmVmIHZhbHVlKTsK KwogICAgIGVudW0gV2hhdFRvRHVtcCB7IFJlbmRlclRyZWUsIE1haW5GcmFtZVRleHQsIEFsbEZy YW1lc1RleHQgfTsKICAgICBXaGF0VG9EdW1wIHdoYXRUb0R1bXAoKSBjb25zdCB7IHJldHVybiBt X3doYXRUb0R1bXA7IH0KIApJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1 bmRsZS9CaW5kaW5ncy9MYXlvdXRUZXN0Q29udHJvbGxlci5pZGwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5ncy9MYXlvdXRUZXN0Q29u dHJvbGxlci5pZGwJKHJldmlzaW9uIDExMDcxMykKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvQmluZGluZ3MvTGF5b3V0VGVzdENvbnRyb2xsZXIuaWRsCSh3b3JraW5n IGNvcHkpCkBAIC04Myw2ICs4Myw4IEBAIG1vZHVsZSBXVFIgewogICAgICAgICBET01TdHJpbmcg cGFnZVNpemVBbmRNYXJnaW5zSW5QaXhlbHMoaW4gaW50IHBhZ2VJbmRleCwgaW4gaW50IHdpZHRo LCBpbiBpbnQgaGVpZ2h0LCBpbiBpbnQgbWFyZ2luVG9wLCBpbiBpbnQgbWFyZ2luUmlnaHQsIGlu IGludCBtYXJnaW5Cb3R0b20sIGluIGludCBtYXJnaW5MZWZ0KTsKICAgICAgICAgYm9vbGVhbiBp c1BhZ2VCb3hWaXNpYmxlKGluIGludCBwYWdlSW5kZXgpOwogCisgICAgICAgIFtQYXNzQ29udGV4 dF0gdm9pZCBzZXRWYWx1ZUZvclVzZXIoaW4gb2JqZWN0IGVsZW1lbnQsIGluIERPTVN0cmluZyB2 YWx1ZSk7CisKICAgICAgICAgLy8gQW5pbWF0aW9uIHRlc3RpbmcuCiAgICAgICAgIGludCBudW1i ZXJPZkFjdGl2ZUFuaW1hdGlvbnMoKTsKICAgICAgICAgYm9vbGVhbiBwYXVzZUFuaW1hdGlvbkF0 VGltZU9uRWxlbWVudFdpdGhJZChpbiBET01TdHJpbmcgYW5pbWF0aW9uTmFtZSwgaW4gZG91Ymxl IHRpbWUsIGluIERPTVN0cmluZyBlbGVtZW50SWQpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTEwNzE2 KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTItMDMtMTQgIEx5bm4gTmVpciAgPGx5bm4ubmVpckBza3lwZS5uZXQ+CisKKyAgICAg ICAgSW1wbGVtZW50IExheW91dFRlc3RDb250cm9sbGVyOjpzZXRWYWx1ZUZvclVzZXIgb24gV2lu ZG93cyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU4MzQKKworICAg ICAgICByZW1vdmVkIHRlc3QsIG5vIGxvbmdlciBuZWVkZWQgYXMgdGVzdCBwYXNzZXMgYW5kIG1h dGNoZXMgYmFzZWxpbmUgZXhwZWN0ZWQgcmVzdWx0cy4KKworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vd2luL2Zhc3QvZm9ybXMvb25j aGFuZ2Utc2V0dmFsdWVmb3J1c2VyLWV4cGVjdGVkLnR4dDogUmVtb3ZlZC4KKwogMjAxMi0wMy0x NCAgSmVzc2llIEJlcmxpbiAgPGpiZXJsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFN1cHBvcnQg ZHJhZyBpbiBtb3VzZSBldmVudHMgZm9yIFdlYktpdDIgRXZlbnRTZW5kZXIKSW5kZXg6IExheW91 dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0L2Zvcm1zL29uY2hhbmdlLXNldHZhbHVlZm9ydXNlci1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2Zhc3Qv Zm9ybXMvb25jaGFuZ2Utc2V0dmFsdWVmb3J1c2VyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTEw NzEzKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2Zhc3QvZm9ybXMvb25jaGFuZ2Utc2V0 dmFsdWVmb3J1c2VyLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw0ICswLDAgQEAK LVRoaXMgdGVzdHMgdGhhdCBvbmNoYW5nZSBjb3JyZWN0bHkgZmlyZXMgYWZ0ZXIgY2FsbGluZyBz ZXRWYWx1ZUZvclVzZXIoKS4gSXQgY2FuIG9ubHkgYmUgcnVuIHVzaW5nIER1bXBSZW5kZXJUcmVl LgotCi1GQUlMIG9uY2hhbmdlIG5ldmVyIGZpcmVkCi0K 131900 2012-03-14 12:34:45 -0700 2012-03-15 16:44:17 -0700 new patch - fixed leak and updated wk2 skipped file. setValueForUserPatch2.patch text/plain 6819 lynn.neir SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMDcyOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDEyLTAzLTE0ICBMeW5uIE5laXIgIDxseW5uLm5laXJAc2t5cGUubmV0Pgor CisgICAgICAgIEltcGxlbWVudCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0VmFsdWVGb3JVc2Vy IG9uIFdpbmRvd3MgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1ODM0 CisKKyAgICAgICAgSW1wbGVtZW50ZWQgc2V0VmFsdWVGb3JVc2VyIGluIGJvdGggRHVtcFJlbmRl clRyZWUgYW5kIFdlYktpdFRlc3RSdW5uZXIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS93aW4vTGF5b3V0VGVzdENvbnRy b2xsZXJXaW4uY3BwOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFZhbHVlRm9y VXNlcik6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5n cy9MYXlvdXRUZXN0Q29udHJvbGxlci5pZGw6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9J bmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXVFI6Okxh eW91dFRlc3RDb250cm9sbGVyOjpzZXRWYWx1ZUZvclVzZXIpOgorICAgICAgICAoV1RSKToKKyAg ICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xheW91dFRlc3RDb250cm9s bGVyLmg6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcik6CisKIDIwMTItMDMtMTQgIERp cmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUGxlYXNlIGFkZCBh IHdheSB0byBtYW51YWxseSBza2lwIHNvbWUgdGVzdHMgaW4gTlJXVApJbmRleDogVG9vbHMvRHVt cFJlbmRlclRyZWUvd2luL0xheW91dFRlc3RDb250cm9sbGVyV2luLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vTGF5b3V0VGVzdENvbnRyb2xsZXJXaW4uY3BwCShy ZXZpc2lvbiAxMTA3MTMpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vTGF5b3V0VGVzdENv bnRyb2xsZXJXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NzksNyArNzc5LDI1IEBAIHZvaWQg TGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFVzZXJTdHlsZVMKIAogdm9pZCBMYXlvdXRUZXN0Q29u dHJvbGxlcjo6c2V0VmFsdWVGb3JVc2VyKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU1ZhbHVlUmVm IGVsZW1lbnQsIEpTU3RyaW5nUmVmIHZhbHVlKQogewotICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQK KyAgICBDT01QdHI8SVdlYlZpZXc+IHdlYlZpZXc7CisgICAgaWYgKEZBSUxFRChmcmFtZS0+d2Vi Vmlldygmd2ViVmlldykpKQorICAgICAgICByZXR1cm47CisKKyAgICBDT01QdHI8SVdlYlZpZXdQ cml2YXRlPiB3ZWJWaWV3UHJpdmF0ZShRdWVyeSwgd2ViVmlldyk7CisgICAgaWYgKCF3ZWJWaWV3 UHJpdmF0ZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgQ09NUHRyPElET01FbGVtZW50PiBkb21F bGVtZW50OworICAgIGlmIChGQUlMRUQod2ViVmlld1ByaXZhdGUtPmVsZW1lbnRGcm9tSlMoY29u dGV4dCwgZWxlbWVudCwgJmRvbUVsZW1lbnQpKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgQ09N UHRyPElET01IVE1MSW5wdXRFbGVtZW50PiBkb21JbnB1dEVsZW1lbnQ7CisgICAgaWYgKEZBSUxF RChkb21FbGVtZW50LT5RdWVyeUludGVyZmFjZShJSURfSURPTUhUTUxJbnB1dEVsZW1lbnQsIHJl aW50ZXJwcmV0X2Nhc3Q8dm9pZCoqPigmZG9tSW5wdXRFbGVtZW50KSkpKQorICAgICAgICByZXR1 cm47CisKKyAgICBfYnN0cl90IHZhbHVlQlNUUihKU1N0cmluZ0NvcHlCU1RSKHZhbHVlKSwgZmFs c2UpOworCisgICAgZG9tSW5wdXRFbGVtZW50LT5zZXRWYWx1ZUZvclVzZXIodmFsdWVCU1RSKTsK IH0KIAogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0Vmlld01vZGVNZWRpYUZlYXR1cmUo SlNTdHJpbmdSZWYgbW9kZSkKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRC dW5kbGUvTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktp dFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCShyZXZp c2lvbiAxMTA3MTMpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xh eW91dFRlc3RDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDI5LDYgKzQyOSwxNSBA QCBib29sIExheW91dFRlc3RDb250cm9sbGVyOjppc1BhZ2VCb3hWaXNpCiAgICAgcmV0dXJuIFdL QnVuZGxlSXNQYWdlQm94VmlzaWJsZShJbmplY3RlZEJ1bmRsZTo6c2hhcmVkKCkuYnVuZGxlKCks IG1haW5GcmFtZSwgcGFnZUluZGV4KTsKIH0KIAordm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6 c2V0VmFsdWVGb3JVc2VyKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU1ZhbHVlUmVmIGVsZW1lbnQs IEpTU3RyaW5nUmVmIHZhbHVlKQoreworICAgIGlmICghZWxlbWVudCB8fCAhSlNWYWx1ZUlzT2Jq ZWN0KGNvbnRleHQsIGVsZW1lbnQpKQorICAgICAgICByZXR1cm47CisKKyAgICBXS1JldGFpblB0 cjxXS0J1bmRsZU5vZGVIYW5kbGVSZWY+IG5vZGVIYW5kbGUoQWRvcHRXSywgV0tCdW5kbGVOb2Rl SGFuZGxlQ3JlYXRlKGNvbnRleHQsIGNvbnN0X2Nhc3Q8SlNPYmplY3RSZWY+KGVsZW1lbnQpKSk7 CisgICAgV0tCdW5kbGVOb2RlSGFuZGxlU2V0SFRNTElucHV0RWxlbWVudFZhbHVlRm9yVXNlcihu b2RlSGFuZGxlLmdldCgpLCB0b1dLKHZhbHVlKS5nZXQoKSk7Cit9CisKIHVuc2lnbmVkIExheW91 dFRlc3RDb250cm9sbGVyOjp3aW5kb3dDb3VudCgpCiB7CiAgICAgcmV0dXJuIEluamVjdGVkQnVu ZGxlOjpzaGFyZWQoKS5wYWdlQ291bnQoKTsKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvTGF5b3V0VGVzdENvbnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xheW91dFRlc3RDb250cm9sbGVyLmgJ KHJldmlzaW9uIDExMDcxMykKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5k bGUvTGF5b3V0VGVzdENvbnRyb2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTM4LDYgKzEzOCw4 IEBAIHB1YmxpYzoKICAgICBKU1JldGFpblB0cjxKU1N0cmluZ1JlZj4gcGFnZVNpemVBbmRNYXJn aW5zSW5QaXhlbHMoaW50IHBhZ2VJbmRleCwgaW50IHdpZHRoLCBpbnQgaGVpZ2h0LCBpbnQgbWFy Z2luVG9wLCBpbnQgbWFyZ2luUmlnaHQsIGludCBtYXJnaW5Cb3R0b20sIGludCBtYXJnaW5MZWZ0 KTsKICAgICBib29sIGlzUGFnZUJveFZpc2libGUoaW50IHBhZ2VJbmRleCk7CiAKKyAgICB2b2lk IHNldFZhbHVlRm9yVXNlcihKU0NvbnRleHRSZWYsIEpTVmFsdWVSZWYgZWxlbWVudCwgSlNTdHJp bmdSZWYgdmFsdWUpOworCiAgICAgZW51bSBXaGF0VG9EdW1wIHsgUmVuZGVyVHJlZSwgTWFpbkZy YW1lVGV4dCwgQWxsRnJhbWVzVGV4dCB9OwogICAgIFdoYXRUb0R1bXAgd2hhdFRvRHVtcCgpIGNv bnN0IHsgcmV0dXJuIG1fd2hhdFRvRHVtcDsgfQogCkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVu bmVyL0luamVjdGVkQnVuZGxlL0JpbmRpbmdzL0xheW91dFRlc3RDb250cm9sbGVyLmlkbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0JpbmRpbmdz L0xheW91dFRlc3RDb250cm9sbGVyLmlkbAkocmV2aXNpb24gMTEwNzEzKQorKysgVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5ncy9MYXlvdXRUZXN0Q29udHJvbGxl ci5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTgzLDYgKzgzLDggQEAgbW9kdWxlIFdUUiB7CiAgICAg ICAgIERPTVN0cmluZyBwYWdlU2l6ZUFuZE1hcmdpbnNJblBpeGVscyhpbiBpbnQgcGFnZUluZGV4 LCBpbiBpbnQgd2lkdGgsIGluIGludCBoZWlnaHQsIGluIGludCBtYXJnaW5Ub3AsIGluIGludCBt YXJnaW5SaWdodCwgaW4gaW50IG1hcmdpbkJvdHRvbSwgaW4gaW50IG1hcmdpbkxlZnQpOwogICAg ICAgICBib29sZWFuIGlzUGFnZUJveFZpc2libGUoaW4gaW50IHBhZ2VJbmRleCk7CiAKKyAgICAg ICAgW1Bhc3NDb250ZXh0XSB2b2lkIHNldFZhbHVlRm9yVXNlcihpbiBvYmplY3QgZWxlbWVudCwg aW4gRE9NU3RyaW5nIHZhbHVlKTsKKwogICAgICAgICAvLyBBbmltYXRpb24gdGVzdGluZy4KICAg ICAgICAgaW50IG51bWJlck9mQWN0aXZlQW5pbWF0aW9ucygpOwogICAgICAgICBib29sZWFuIHBh dXNlQW5pbWF0aW9uQXRUaW1lT25FbGVtZW50V2l0aElkKGluIERPTVN0cmluZyBhbmltYXRpb25O YW1lLCBpbiBkb3VibGUgdGltZSwgaW4gRE9NU3RyaW5nIGVsZW1lbnRJZCk7CkluZGV4OiBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShy ZXZpc2lvbiAxMTA3MjgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNCBAQAorMjAxMi0wMy0xNCAgTHlubiBOZWlyICA8bHlubi5uZWlyQHNreXBl Lm5ldD4KKworICAgICAgICBJbXBsZW1lbnQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFZhbHVl Rm9yVXNlciBvbiBXaW5kb3dzIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NTgzNAorCisgICAgICAgIHJlbW92ZWQgdGVzdCwgbm8gbG9uZ2VyIG5lZWRlZCBhcyB0ZXN0 IHBhc3NlcyBhbmQgbWF0Y2hlcyBiYXNlbGluZSBleHBlY3RlZCByZXN1bHRzIGFuZCBhbHNvIHVw ZGF0ZWQgd2syIHNraXBwZWQgZmlsZSB0byBubyBsb25nZXIgc2tpcCB0aGlzIHRlc3QuCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93 aW4vZmFzdC9mb3Jtcy9vbmNoYW5nZS1zZXR2YWx1ZWZvcnVzZXItZXhwZWN0ZWQudHh0OiBSZW1v dmVkLgorICAgICAgICAqIHBsYXRmb3JtL3drMi9Ta2lwcGVkOgorCiAyMDEyLTAzLTE0ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVXBkYXRlIFNWRyBiYXNlbGlu ZSBhZnRlciB3b3JrIG9uIDx1c2U+IGVsZW1lbnQuICBUaGVzZSByZXN1bHRzIGFsbApJbmRleDog TGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2Zhc3QvZm9ybXMvb25jaGFuZ2Utc2V0dmFsdWVmb3J1 c2VyLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4v ZmFzdC9mb3Jtcy9vbmNoYW5nZS1zZXR2YWx1ZWZvcnVzZXItZXhwZWN0ZWQudHh0CShyZXZpc2lv biAxMTA3MTMpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vZmFzdC9mb3Jtcy9vbmNoYW5n ZS1zZXR2YWx1ZWZvcnVzZXItZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzAs MCBAQAotVGhpcyB0ZXN0cyB0aGF0IG9uY2hhbmdlIGNvcnJlY3RseSBmaXJlcyBhZnRlciBjYWxs aW5nIHNldFZhbHVlRm9yVXNlcigpLiBJdCBjYW4gb25seSBiZSBydW4gdXNpbmcgRHVtcFJlbmRl clRyZWUuCi0KLUZBSUwgb25jaGFuZ2UgbmV2ZXIgZmlyZWQKLQpJbmRleDogTGF5b3V0VGVzdHMv cGxhdGZvcm0vd2syL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0v d2syL1NraXBwZWQJKHJldmlzaW9uIDExMDcxMykKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dr Mi9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0xMDMwLDkgKzEwMzAsNiBAQCBmYXN0L2RvbS90 aW1lci1pbmNyZWFzZS1taW4taW50ZXJ2YWwuaHRtCiBmYXN0L2RvbS90aW1lci1pbmNyZWFzZS10 aGVuLWRlY3JlYXNlLW1pbi1pbnRlcnZhbC1yZXBlYXRpbmcuaHRtbAogZmFzdC9kb20vdGltZXIt aW5jcmVhc2UtdGhlbi1kZWNyZWFzZS1taW4taW50ZXJ2YWwuaHRtbAogCi0jIFdlYktpdFRlc3RS dW5uZXIgbmVlZHMgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0VmFsdWVGb3JVc2VyCi1mYXN0L2Zv cm1zL29uY2hhbmdlLXNldHZhbHVlZm9ydXNlci5odG1sCi0KICMgV2ViS2l0VGVzdFJ1bm5lciBu ZWVkcyBsYXlvdXRUZXN0Q29udHJvbGxlci5vcmlnaW5zV2l0aExvY2FsU3RvcmFnZQogc3RvcmFn ZS9kb21zdG9yYWdlL2xvY2Fsc3RvcmFnZS9zdG9yYWdldHJhY2tlci9zdG9yYWdlLXRyYWNrZXIt MS1wcmVwYXJlLmh0bWwKIHN0b3JhZ2UvZG9tc3RvcmFnZS9sb2NhbHN0b3JhZ2Uvc3RvcmFnZXRy YWNrZXIvc3RvcmFnZS10cmFja2VyLTItY3JlYXRlLmh0bWwK