55818 2011-03-05 02:05:58 -0800 Web Inspector: [Text editor] Regression in handling DOMNodeInserted/DOMNodeRemoved events 2011-03-09 03:02:17 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 aandrey webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr podivilov rik timothy yurys oldest_to_newest 362916 0 aandrey 2011-03-05 02:05:58 -0800 Newly inserted line rows may have the "lineNumber" property set (e.g. when inserting via a native Undo), thus interfering with the current numeration. We should also delete the "lineNumber" from line rows on DOMNodeRemoved event as a double defense. 362918 1 84854 aandrey 2011-03-05 02:11:12 -0800 Created attachment 84854 Patch 362926 2 84854 pfeldman 2011-03-05 03:38:51 -0800 Comment on attachment 84854 Patch Test? 364399 3 84854 podivilov 2011-03-09 03:02:09 -0800 Comment on attachment 84854 Patch Clearing flags on attachment: 84854 Committed r80632: <http://trac.webkit.org/changeset/80632> 364400 4 podivilov 2011-03-09 03:02:17 -0800 All reviewed patches have been landed. Closing bug. 84854 2011-03-05 02:11:12 -0800 2011-03-09 03:02:09 -0800 Patch bug-55818-20110305131110.patch text/plain 2760 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogODA0MTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4MTdhYjBkNDAzOTI2YWY4 MjdiNWViZmVjZGFkM2I0ODAxMDk1NGU2Li4zYmU0ZjAxMzE1ZTU3YmU3MDZlODkyNDg2ZmE3ODEy OGJkZjkzYTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMDUgIEFuZHJl eSBBZGFpa2luICA8YWFuZHJleUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtUZXh0IGVkaXRvcl0gUmVn cmVzc2lvbiBpbiBoYW5kbGluZyBET01Ob2RlSW5zZXJ0ZWQvRE9NTm9kZVJlbW92ZWQgZXZlbnRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTgxOAor CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwucHJvdG90eXBlLl9oYW5kbGVET01VcGRh dGVzKToKKwogMjAxMS0wMy0wNSAgSWx5YSBTaGVybWFuICA8aXNoZXJtYW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzCmluZGV4IDYxNTkzYjQ4ODRiNzE5 OGY1N2YwODc0ZWM0ZDE0MGU0OGY5NTUzZDQuLmQ1ZmE1NDFkYzBkMjg1YjhhZWE2MDQ5NDQ2YzIy YTVmMmM5MTcwMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvVGV4dFZpZXdlci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1RleHRWaWV3ZXIuanMKQEAgLTExNDEsMTIgKzExNDEsMzcgQEAgV2ViSW5zcGVjdG9yLlRleHRF ZGl0b3JNYWluUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhpcy5fcmVhZE9ubHkp CiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgdmFyIGxpbmVOdW1iZXIgPSBsaW5lUm93 LmxpbmVOdW1iZXI7CisgICAgICAgIGlmICh0YXJnZXQgPT09IGxpbmVSb3cgJiYgZS50eXBlID09 PSAiRE9NTm9kZUluc2VydGVkIikgeworICAgICAgICAgICAgLy8gRW5zdXJlIHRoYXQgdGhlIG5l d2x5IGluc2VydGVkIGxpbmUgcm93IGhhcyBubyBsaW5lTnVtYmVyLgorICAgICAgICAgICAgZGVs ZXRlIGxpbmVSb3cubGluZU51bWJlcjsKKyAgICAgICAgfQorCisgICAgICAgIHZhciBzdGFydExp bmUgPSAwOworICAgICAgICBmb3IgKHZhciByb3cgPSBsaW5lUm93OyByb3c7IHJvdyA9IHJvdy5w cmV2aW91c1NpYmxpbmcpIHsKKyAgICAgICAgICAgIGlmICh0eXBlb2Ygcm93LmxpbmVOdW1iZXIg PT09ICJudW1iZXIiKSB7CisgICAgICAgICAgICAgICAgc3RhcnRMaW5lID0gcm93LmxpbmVOdW1i ZXI7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKwor ICAgICAgICB2YXIgZW5kTGluZSA9IHN0YXJ0TGluZSArIDE7CisgICAgICAgIGZvciAodmFyIHJv dyA9IGxpbmVSb3cubmV4dFNpYmxpbmc7IHJvdzsgcm93ID0gcm93Lm5leHRTaWJsaW5nKSB7Cisg ICAgICAgICAgICBpZiAodHlwZW9mIHJvdy5saW5lTnVtYmVyID09PSAibnVtYmVyIikgeworICAg ICAgICAgICAgICAgIGVuZExpbmUgPSByb3cubGluZU51bWJlcjsKKyAgICAgICAgICAgICAgICBi cmVhazsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCisgICAgICAgIGlmICh0YXJnZXQgPT09 IGxpbmVSb3cgJiYgZS50eXBlID09PSAiRE9NTm9kZVJlbW92ZWQiKSB7CisgICAgICAgICAgICAv LyBOb3cgdGhpcyB3aWxsIG5vIGxvbmdlciBiZSB2YWxpZC4KKyAgICAgICAgICAgIGRlbGV0ZSBs aW5lUm93LmxpbmVOdW1iZXI7CisgICAgICAgIH0KKyAKICAgICAgICAgaWYgKHRoaXMuX2RpcnR5 TGluZXMpIHsKLSAgICAgICAgICAgIHRoaXMuX2RpcnR5TGluZXMuc3RhcnQgPSBNYXRoLm1pbih0 aGlzLl9kaXJ0eUxpbmVzLnN0YXJ0LCBsaW5lTnVtYmVyKTsKLSAgICAgICAgICAgIHRoaXMuX2Rp cnR5TGluZXMuZW5kID0gTWF0aC5tYXgodGhpcy5fZGlydHlMaW5lcy5lbmQsIGxpbmVOdW1iZXIg KyAxKTsKKyAgICAgICAgICAgIHRoaXMuX2RpcnR5TGluZXMuc3RhcnQgPSBNYXRoLm1pbih0aGlz Ll9kaXJ0eUxpbmVzLnN0YXJ0LCBzdGFydExpbmUpOworICAgICAgICAgICAgdGhpcy5fZGlydHlM aW5lcy5lbmQgPSBNYXRoLm1heCh0aGlzLl9kaXJ0eUxpbmVzLmVuZCwgZW5kTGluZSk7CiAgICAg ICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICB0aGlzLl9kaXJ0eUxpbmVzID0geyBzdGFydDogbGlu ZU51bWJlciwgZW5kOiBsaW5lTnVtYmVyICsgMSB9OworICAgICAgICAgICAgdGhpcy5fZGlydHlM aW5lcyA9IHsgc3RhcnQ6IHN0YXJ0TGluZSwgZW5kOiBlbmRMaW5lIH07CiAgICAgICAgICAgICBz ZXRUaW1lb3V0KHRoaXMuX2FwcGx5RG9tVXBkYXRlcy5iaW5kKHRoaXMpLCAwKTsKICAgICAgICAg ICAgIC8vIFJlbW92ZSBtYXJrZWQgcmFuZ2VzLCBpZiBhbnkuCiAgICAgICAgICAgICB0aGlzLm1h cmtBbmRSZXZlYWxSYW5nZShudWxsKTsK