55782 2011-03-04 09:53:14 -0800 [Qt] Need symbian version of cryptographicallyRandomValuesFromOS 2011-03-07 06:17:18 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED Qt P3 Normal --- 50251 1 ostap73 ostap73 commit-queue webkit.review.bot oldest_to_newest 362580 0 ostap73 2011-03-04 09:53:14 -0800 Symbian doesn't have /dev/urandom and qtwebkit crashes because it cannot open this file. 362584 1 84768 ostap73 2011-03-04 09:58:49 -0800 Created attachment 84768 Symbian version of cryptographicallyRandomValuesFromOS 362589 2 webkit.review.bot 2011-03-04 10:00:43 -0800 Attachment 84768 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/OSRandomSource.cpp:59: Missing space before ( in if( [whitespace/parens] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 362600 3 84774 ostap73 2011-03-04 10:09:57 -0800 Created attachment 84774 Fix style error 362659 4 84789 ostap73 2011-03-04 12:15:54 -0800 Created attachment 84789 Fix changelog. 362663 5 84789 laszlo.gombos 2011-03-04 12:24:26 -0800 Comment on attachment 84789 Fix changelog. Looks good to me. r+. 362870 6 84789 commit-queue 2011-03-04 22:03:06 -0800 Comment on attachment 84789 Fix changelog. Clearing flags on attachment: 84789 Committed r80407: <http://trac.webkit.org/changeset/80407> 362871 7 commit-queue 2011-03-04 22:03:11 -0800 All reviewed patches have been landed. Closing bug. 84768 2011-03-04 09:58:49 -0800 2011-03-04 10:09:57 -0800 Symbian version of cryptographicallyRandomValuesFromOS cryptographicallyRandomValuesFromOS_01.diff text/plain 1752 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBhMjM5MDAuLjQwMzEwZWIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTAzLTA0ICBWaWF0Y2hlc2xhdiBP c3RhcGVua28gIDxvc3RhcGVua28udmlhdGNoZXNsYXZAbm9raWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTmVlZCBzeW1iaWFuIHZl cnNpb24gb2YgY3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21WYWx1ZXNGcm9tT1MKKyAgICAgICAgSW1w bGVtZW50IFN5bWJpYW4gdmVyc2lvbiBvZiBjcnlwdG9ncmFwaGljYWxseVJhbmRvbVZhbHVlc0Zy b21PUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU3 ODIKKworICAgICAgICAqIHd0Zi9PU1JhbmRvbVNvdXJjZS5jcHA6CisgICAgICAgIChXVEY6OmNy eXB0b2dyYXBoaWNhbGx5UmFuZG9tVmFsdWVzRnJvbU9TKToKKwogMjAxMS0wMy0wMyAgVGltb3Ro eSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBBUElTaGltcyB1 c2FibGUgZnJvbSBXZWJDb3JlLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0 Zi9PU1JhbmRvbVNvdXJjZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL09TUmFuZG9t U291cmNlLmNwcAppbmRleCAwYzE0MTZhLi45ZDcwMDlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvd3RmL09TUmFuZG9tU291cmNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL09TUmFuZG9tU291cmNlLmNwcApAQCAtMjksNiArMjksMTAgQEAKICNpbmNsdWRl IDxzdGRpbnQuaD4KICNpbmNsdWRlIDxzdGRsaWIuaD4KIAorI2lmIE9TKFNZTUJJQU4pCisjaW5j bHVkZSA8ZTMybWF0aC5oPgorI2VuZGlmCisKICNpZiBPUyhVTklYKQogI2luY2x1ZGUgPGZjbnRs Lmg+CiAjaW5jbHVkZSA8dW5pc3RkLmg+CkBAIC00NCw3ICs0OCwxOSBAQCBuYW1lc3BhY2UgV1RG IHsKICNpZiBVU0UoT1NfUkFORE9NTkVTUykKIHZvaWQgY3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21W YWx1ZXNGcm9tT1ModW5zaWduZWQgY2hhciogYnVmZmVyLCBzaXplX3QgbGVuZ3RoKQogewotI2lm IE9TKFVOSVgpCisjaWYgT1MoU1lNQklBTikKKyAgICBUSW50IHJhbmRvbTsKKyAgICB3aGlsZSAo bGVuZ3RoID4gc2l6ZW9mKHJhbmRvbSkpIHsKKyAgICAgICAgcmFuZG9tID0gTWF0aDo6UmFuZG9t KCk7CisgICAgICAgIG1lbWNweShidWZmZXIsICZyYW5kb20sIHNpemVvZihyYW5kb20pKTsKKyAg ICAgICAgbGVuZ3RoIC09IHNpemVvZihyYW5kb20pOworICAgICAgICBidWZmZXIgKz0gc2l6ZW9m KHJhbmRvbSk7CisgICAgfQorICAgIGlmKGxlbmd0aCA+IDApIHsKKyAgICAgICAgcmFuZG9tID0g TWF0aDo6UmFuZG9tKCk7CisgICAgICAgIG1lbWNweShidWZmZXIsICZyYW5kb20sIGxlbmd0aCk7 CisgICAgfQorI2VsaWYgT1MoVU5JWCkKICAgICBpbnQgZmQgPSBvcGVuKCIvZGV2L3VyYW5kb20i LCBPX1JET05MWSwgMCk7CiAgICAgaWYgKGZkIDwgMCkKICAgICAgICAgQ1JBU0goKTsgLy8gV2Ug bmVlZCAvZGV2L3VyYW5kb20gZm9yIHRoaXMgQVBJIHRvIHdvcmsuLi4K 84774 2011-03-04 10:09:57 -0800 2011-03-04 12:15:54 -0800 Fix style error cryptographicallyRandomValuesFromOS_01.diff text/plain 1753 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBhMjM5MDAuLjQwMzEwZWIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTAzLTA0ICBWaWF0Y2hlc2xhdiBP c3RhcGVua28gIDxvc3RhcGVua28udmlhdGNoZXNsYXZAbm9raWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTmVlZCBzeW1iaWFuIHZl cnNpb24gb2YgY3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21WYWx1ZXNGcm9tT1MKKyAgICAgICAgSW1w bGVtZW50IFN5bWJpYW4gdmVyc2lvbiBvZiBjcnlwdG9ncmFwaGljYWxseVJhbmRvbVZhbHVlc0Zy b21PUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU3 ODIKKworICAgICAgICAqIHd0Zi9PU1JhbmRvbVNvdXJjZS5jcHA6CisgICAgICAgIChXVEY6OmNy eXB0b2dyYXBoaWNhbGx5UmFuZG9tVmFsdWVzRnJvbU9TKToKKwogMjAxMS0wMy0wMyAgVGltb3Ro eSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBBUElTaGltcyB1 c2FibGUgZnJvbSBXZWJDb3JlLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0 Zi9PU1JhbmRvbVNvdXJjZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL09TUmFuZG9t U291cmNlLmNwcAppbmRleCAwYzE0MTZhLi45ZDcwMDlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvd3RmL09TUmFuZG9tU291cmNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL09TUmFuZG9tU291cmNlLmNwcApAQCAtMjksNiArMjksMTAgQEAKICNpbmNsdWRl IDxzdGRpbnQuaD4KICNpbmNsdWRlIDxzdGRsaWIuaD4KIAorI2lmIE9TKFNZTUJJQU4pCisjaW5j bHVkZSA8ZTMybWF0aC5oPgorI2VuZGlmCisKICNpZiBPUyhVTklYKQogI2luY2x1ZGUgPGZjbnRs Lmg+CiAjaW5jbHVkZSA8dW5pc3RkLmg+CkBAIC00NCw3ICs0OCwxOSBAQCBuYW1lc3BhY2UgV1RG IHsKICNpZiBVU0UoT1NfUkFORE9NTkVTUykKIHZvaWQgY3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21W YWx1ZXNGcm9tT1ModW5zaWduZWQgY2hhciogYnVmZmVyLCBzaXplX3QgbGVuZ3RoKQogewotI2lm IE9TKFVOSVgpCisjaWYgT1MoU1lNQklBTikKKyAgICBUSW50IHJhbmRvbTsKKyAgICB3aGlsZSAo bGVuZ3RoID4gc2l6ZW9mKHJhbmRvbSkpIHsKKyAgICAgICAgcmFuZG9tID0gTWF0aDo6UmFuZG9t KCk7CisgICAgICAgIG1lbWNweShidWZmZXIsICZyYW5kb20sIHNpemVvZihyYW5kb20pKTsKKyAg ICAgICAgbGVuZ3RoIC09IHNpemVvZihyYW5kb20pOworICAgICAgICBidWZmZXIgKz0gc2l6ZW9m KHJhbmRvbSk7CisgICAgfQorICAgIGlmIChsZW5ndGggPiAwKSB7CisgICAgICAgIHJhbmRvbSA9 IE1hdGg6OlJhbmRvbSgpOworICAgICAgICBtZW1jcHkoYnVmZmVyLCAmcmFuZG9tLCBsZW5ndGgp OworICAgIH0KKyNlbGlmIE9TKFVOSVgpCiAgICAgaW50IGZkID0gb3BlbigiL2Rldi91cmFuZG9t IiwgT19SRE9OTFksIDApOwogICAgIGlmIChmZCA8IDApCiAgICAgICAgIENSQVNIKCk7IC8vIFdl IG5lZWQgL2Rldi91cmFuZG9tIGZvciB0aGlzIEFQSSB0byB3b3JrLi4uCg== 84789 2011-03-04 12:15:54 -0800 2011-03-04 22:03:06 -0800 Fix changelog. cryptographicallyRandomValuesFromOS_02.diff text/plain 1755 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBhMjM5MDAuLmU4MGI4ZTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTAzLTA0ICBWaWF0Y2hlc2xhdiBP c3RhcGVua28gIDxvc3RhcGVua28udmlhdGNoZXNsYXZAbm9raWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTmVlZCBzeW1iaWFuIHZl cnNpb24gb2YgY3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21WYWx1ZXNGcm9tT1MKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1NzgyCisKKyAgICAgICAgSW1w bGVtZW50IFN5bWJpYW4gdmVyc2lvbiBvZiBjcnlwdG9ncmFwaGljYWxseVJhbmRvbVZhbHVlc0Zy b21PUworCisgICAgICAgICogd3RmL09TUmFuZG9tU291cmNlLmNwcDoKKyAgICAgICAgKFdURjo6 Y3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21WYWx1ZXNGcm9tT1MpOgorCiAyMDExLTAzLTAzICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIEFQSVNoaW1z IHVzYWJsZSBmcm9tIFdlYkNvcmUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL09TUmFuZG9tU291cmNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvT1NSYW5k b21Tb3VyY2UuY3BwCmluZGV4IDBjMTQxNmEuLjdkODZmNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvT1NSYW5kb21Tb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS93dGYvT1NSYW5kb21Tb3VyY2UuY3BwCkBAIC0yOSw2ICsyOSwxMCBAQAogI2luY2x1 ZGUgPHN0ZGludC5oPgogI2luY2x1ZGUgPHN0ZGxpYi5oPgogCisjaWYgT1MoU1lNQklBTikKKyNp bmNsdWRlIDxlMzJtYXRoLmg+CisjZW5kaWYKKwogI2lmIE9TKFVOSVgpCiAjaW5jbHVkZSA8ZmNu dGwuaD4KICNpbmNsdWRlIDx1bmlzdGQuaD4KQEAgLTQ0LDcgKzQ4LDE5IEBAIG5hbWVzcGFjZSBX VEYgewogI2lmIFVTRShPU19SQU5ET01ORVNTKQogdm9pZCBjcnlwdG9ncmFwaGljYWxseVJhbmRv bVZhbHVlc0Zyb21PUyh1bnNpZ25lZCBjaGFyKiBidWZmZXIsIHNpemVfdCBsZW5ndGgpCiB7Ci0j aWYgT1MoVU5JWCkKKyNpZiBPUyhTWU1CSUFOKQorICAgIFRJbnQgcmFuZG9tOworICAgIHdoaWxl IChsZW5ndGggPiBzaXplb2YocmFuZG9tKSkgeworICAgICAgICByYW5kb20gPSBNYXRoOjpSYW5k b20oKTsKKyAgICAgICAgbWVtY3B5KGJ1ZmZlciwgJnJhbmRvbSwgc2l6ZW9mKHJhbmRvbSkpOwor ICAgICAgICBsZW5ndGggLT0gc2l6ZW9mKHJhbmRvbSk7CisgICAgICAgIGJ1ZmZlciArPSBzaXpl b2YocmFuZG9tKTsKKyAgICB9CisgICAgaWYgKGxlbmd0aCA+IDApIHsKKyAgICAgICAgcmFuZG9t ID0gTWF0aDo6UmFuZG9tKCk7CisgICAgICAgIG1lbWNweShidWZmZXIsICZyYW5kb20sIGxlbmd0 aCk7CisgICAgfQorI2VsaWYgT1MoVU5JWCkKICAgICBpbnQgZmQgPSBvcGVuKCIvZGV2L3VyYW5k b20iLCBPX1JET05MWSwgMCk7CiAgICAgaWYgKGZkIDwgMCkKICAgICAgICAgQ1JBU0goKTsgLy8g V2UgbmVlZCAvZGV2L3VyYW5kb20gZm9yIHRoaXMgQVBJIHRvIHdvcmsuLi4K