55768 2011-03-04 05:06:52 -0800 Web Inspector: Remove unnecessary domain and success flags from the response messages. 2011-03-04 05:26:43 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 362424 0 loislo 2011-03-04 05:06:52 -0800 We have domain property in the response messages. It is not required because we dispatch the responses on the callback associated with seq. We have success == false at the same time when we have not empty errors property and true in the other case. 362428 1 84729 loislo 2011-03-04 05:13:17 -0800 Created attachment 84729 [patch] initial version 362432 2 84729 loislo 2011-03-04 05:26:35 -0800 Comment on attachment 84729 [patch] initial version Clearing flags on attachment: 84729 Committed r80345: <http://trac.webkit.org/changeset/80345> 362433 3 loislo 2011-03-04 05:26:43 -0800 All reviewed patches have been landed. Closing bug. 84729 2011-03-04 05:13:17 -0800 2011-03-04 05:26:35 -0800 [patch] initial version patch text/plain 7179 loislo ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzMTEzODQ3Li4zZDJlMzlkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDMt MDQgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlbW92 ZSB1bm5lY2Vzc2FyeSBkb21haW4gYW5kIHN1Y2Nlc3MgZmxhZ3MgZnJvbSB0aGUgcmVzcG9uc2Ug bWVzc2FnZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NTc2OAorCisgICAgICAgIFdlIGhhdmUgZG9tYWluIHByb3BlcnR5IGluIHRoZSByZXNwb25z ZSBtZXNzYWdlcyBidXQgaXQgaXMgbm90IHVzZWQgYmVjYXVzZSB3ZSBkaXNwYXRjaAorICAgICAg ICB0aGUgcmVzcG9uc2VzIG9uIHRoZSBjYWxsYmFjayBhc3NvY2lhdGVkIHdpdGggc2VxLgorCisg ICAgICAgIElmIHdlIGhhdmUgcHJvcGVydHkgJ2Vycm9ycycgaW4gdGhlIHJlc3BvbnNlIHRoZW4g c3VjY2VzcyBlcSBmYWxzZSBhbmQgdHJ1ZSBpbiB0aGUgb3RoZXIgY2FzZS4KKworICAgICAgICAq IGluc3BlY3Rvci9wcm90b2NvbC9ydW50aW1lLWFnZW50LWV4cGVjdGVkLnR4dDoKKyAgICAgICAg KiBpbnNwZWN0b3IvcmVwb3J0LXByb3RvY29sLWVycm9ycy1leHBlY3RlZC50eHQ6CisKIDIwMTEt MDMtMDMgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9p bnNwZWN0b3IvcHJvdG9jb2wvcnVudGltZS1hZ2VudC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvcHJvdG9jb2wvcnVudGltZS1hZ2VudC1leHBlY3RlZC50eHQKaW5kZXggYjhi NjZjZS4uM2U1NDY1MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3Byb3RvY29s L3J1bnRpbWUtYWdlbnQtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9w cm90b2NvbC9ydW50aW1lLWFnZW50LWV4cGVjdGVkLnR4dApAQCAtMTgsOCArMTgsNiBAQCByZXF1 ZXN0OgogcmVzcG9uc2U6CiB7CiAgICAgc2VxIDogPG51bWJlcj4KLSAgICBkb21haW4gOiAiUnVu dGltZSIKLSAgICBzdWNjZXNzIDogdHJ1ZQogICAgIGJvZHkgOiB7CiAgICAgICAgIHJlc3VsdCA6 IHsKICAgICAgICAgICAgIG9iamVjdElkIDogewpAQCAtNTUsOCArNTMsNiBAQCByZXF1ZXN0Ogog cmVzcG9uc2U6CiB7CiAgICAgc2VxIDogPG51bWJlcj4KLSAgICBkb21haW4gOiAiUnVudGltZSIK LSAgICBzdWNjZXNzIDogdHJ1ZQogICAgIGJvZHkgOiB7CiAgICAgICAgIHJlc3VsdCA6IHsKICAg ICAgICAgICAgIG9iamVjdElkIDogbnVsbApAQCAtODksOCArODUsNiBAQCByZXF1ZXN0OgogcmVz cG9uc2U6CiB7CiAgICAgc2VxIDogPG51bWJlcj4KLSAgICBkb21haW4gOiAiUnVudGltZSIKLSAg ICBzdWNjZXNzIDogdHJ1ZQogICAgIGJvZHkgOiB7CiAgICAgICAgIHJlc3VsdCA6IHRydWUKICAg ICB9CkBAIC0xMTgsOCArMTEyLDYgQEAgcmVxdWVzdDoKIHJlc3BvbnNlOgogewogICAgIHNlcSA6 IDxudW1iZXI+Ci0gICAgZG9tYWluIDogIlJ1bnRpbWUiCi0gICAgc3VjY2VzcyA6IHRydWUKICAg ICBib2R5IDogewogICAgICAgICByZXN1bHQgOiB0cnVlCiAgICAgfQpAQCAtMTQ3LDggKzEzOSw2 IEBAIHJlcXVlc3Q6CiByZXNwb25zZToKIHsKICAgICBzZXEgOiA8bnVtYmVyPgotICAgIGRvbWFp biA6ICJSdW50aW1lIgotICAgIHN1Y2Nlc3MgOiB0cnVlCiAgICAgYm9keSA6IHsKICAgICAgICAg cmVzdWx0IDogewogICAgICAgICAgICAgMCA6IHsKQEAgLTIwNiw4ICsxOTYsNiBAQCByZXF1ZXN0 OgogcmVzcG9uc2U6CiB7CiAgICAgc2VxIDogPG51bWJlcj4KLSAgICBkb21haW4gOiAiUnVudGlt ZSIKLSAgICBzdWNjZXNzIDogdHJ1ZQogfQogCiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpAQCAtMjI3LDggKzIxNSw2IEBAIHJlcXVl c3Q6CiByZXNwb25zZToKIHsKICAgICBzZXEgOiA8bnVtYmVyPgotICAgIGRvbWFpbiA6ICJSdW50 aW1lIgotICAgIHN1Y2Nlc3MgOiB0cnVlCiB9CiAKID09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvcmVwb3J0LXByb3RvY29sLWVycm9ycy1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9pbnNwZWN0b3IvcmVwb3J0LXByb3RvY29sLWVycm9ycy1leHBlY3RlZC50eHQKaW5kZXgg ZDk2ZjA2Yi4uMDUzZDU0ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3JlcG9y dC1wcm90b2NvbC1lcnJvcnMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rv ci9yZXBvcnQtcHJvdG9jb2wtZXJyb3JzLWV4cGVjdGVkLnR4dApAQCAtMiw2NiArMiw1NCBAQCBU ZXN0cyB0aGF0IEluc3BlY3RvckJhY2tlbmREaXNwYXRjaGVyIGlzIGNhdGNoaW5nIGluY29ycmVj dCBtZXNzYWdlcy4KIAogewogICAgIHNlcSA6IDAKLSAgICBzdWNjZXNzIDogZmFsc2UKICAgICBl cnJvcnMgOiB7CiAgICAgICAgIDAgOiAiUHJvdG9jb2wgRXJyb3I6IEludmFsaWQgbWVzc2FnZSBm b3JtYXQuIE1lc3NhZ2Ugc2hvdWxkIGJlIGluIEpTT04gZm9ybWF0LiIKICAgICB9CiB9CiB7CiAg ICAgc2VxIDogMAotICAgIHN1Y2Nlc3MgOiBmYWxzZQogICAgIGVycm9ycyA6IHsKICAgICAgICAg MCA6ICJQcm90b2NvbCBFcnJvcjogSW52YWxpZCBtZXNzYWdlIGZvcm1hdC4gJ2NvbW1hbmQnIHBy b3BlcnR5IHdhc24ndCBmb3VuZC4iCiAgICAgfQogfQogewogICAgIHNlcSA6IDAKLSAgICBzdWNj ZXNzIDogZmFsc2UKICAgICBlcnJvcnMgOiB7CiAgICAgICAgIDAgOiAiUHJvdG9jb2wgRXJyb3I6 IEludmFsaWQgbWVzc2FnZSBmb3JtYXQuIFRoZSB0eXBlIG9mICdjb21tYW5kJyBwcm9wZXJ0eSBz aG91bGQgYmUgc3RyaW5nLiIKICAgICB9CiB9CiB7CiAgICAgc2VxIDogMAotICAgIHN1Y2Nlc3Mg OiBmYWxzZQogICAgIGVycm9ycyA6IHsKICAgICAgICAgMCA6ICJQcm90b2NvbCBFcnJvcjogSW52 YWxpZCBtZXNzYWdlIGZvcm1hdC4gJ3NlcScgcHJvcGVydHkgd2FzIG5vdCBmb3VuZCBpbiB0aGUg cmVxdWVzdC4iCiAgICAgfQogfQogewogICAgIHNlcSA6IDAKLSAgICBzdWNjZXNzIDogZmFsc2UK ICAgICBlcnJvcnMgOiB7CiAgICAgICAgIDAgOiAiUHJvdG9jb2wgRXJyb3I6IEludmFsaWQgbWVz c2FnZSBmb3JtYXQuIFRoZSB0eXBlIG9mICdzZXEnIHByb3BlcnR5IHNob3VsZCBiZSBudW1iZXIu IgogICAgIH0KIH0KIHsKICAgICBzZXEgOiAxCi0gICAgc3VjY2VzcyA6IGZhbHNlCiAgICAgZXJy b3JzIDogewogICAgICAgICAwIDogIlByb3RvY29sIEVycm9yOiBJbnZhbGlkIGNvbW1hbmQgd2Fz IHJlY2VpdmVkLiAndGVzdCcgd2Fzbid0IGZvdW5kIGluIGRvbWFpbiBET00uIgogICAgIH0KIH0K IHsKICAgICBzZXEgOiAyCi0gICAgZG9tYWluIDogIk5ldHdvcmsiCi0gICAgc3VjY2VzcyA6IGZh bHNlCiAgICAgZXJyb3JzIDogewogICAgICAgICAwIDogIlByb3RvY29sIEVycm9yOiAnYXJndW1l bnRzJyBwcm9wZXJ0eSB3aXRoIHR5cGUgJ29iamVjdCcgd2FzIG5vdCBmb3VuZC4iCiAgICAgfQog fQogewogICAgIHNlcSA6IDMKLSAgICBkb21haW4gOiAiTmV0d29yayIKLSAgICBzdWNjZXNzIDog ZmFsc2UKICAgICBlcnJvcnMgOiB7CiAgICAgICAgIDAgOiAiUHJvdG9jb2wgRXJyb3I6ICdhcmd1 bWVudHMnIHByb3BlcnR5IHdpdGggdHlwZSAnb2JqZWN0JyB3YXMgbm90IGZvdW5kLiIKICAgICB9 CiB9CiB7CiAgICAgc2VxIDogNAotICAgIGRvbWFpbiA6ICJOZXR3b3JrIgotICAgIHN1Y2Nlc3Mg OiBmYWxzZQogICAgIGVycm9ycyA6IHsKICAgICAgICAgMCA6ICJQcm90b2NvbCBFcnJvcjogQXJn dW1lbnQgJ2ZyYW1lSWQnIHdpdGggdHlwZSAnTnVtYmVyJyB3YXMgbm90IGZvdW5kLiIKICAgICAg ICAgMSA6ICJQcm90b2NvbCBFcnJvcjogQXJndW1lbnQgJ3VybCcgd2l0aCB0eXBlICdTdHJpbmcn IHdhcyBub3QgZm91bmQuIgpAQCAtNzAsOCArNTgsNiBAQCBUZXN0cyB0aGF0IEluc3BlY3RvckJh Y2tlbmREaXNwYXRjaGVyIGlzIGNhdGNoaW5nIGluY29ycmVjdCBtZXNzYWdlcy4KIH0KIHsKICAg ICBzZXEgOiA1Ci0gICAgZG9tYWluIDogIk5ldHdvcmsiCi0gICAgc3VjY2VzcyA6IGZhbHNlCiAg ICAgZXJyb3JzIDogewogICAgICAgICAwIDogIlByb3RvY29sIEVycm9yOiBBcmd1bWVudCAnZnJh bWVJZCcgd2l0aCB0eXBlICdOdW1iZXInIHdhcyBub3QgZm91bmQuIgogICAgICAgICAxIDogIlBy b3RvY29sIEVycm9yOiBBcmd1bWVudCAndXJsJyB3aXRoIHR5cGUgJ1N0cmluZycgd2FzIG5vdCBm b3VuZC4iCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggYmZiY2JmMS4uNTFmZGY3OSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE3IEBACisyMDExLTAzLTA0ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX ZWIgSW5zcGVjdG9yOiBSZW1vdmUgdW5uZWNlc3NhcnkgZG9tYWluIGFuZCBzdWNjZXNzIGZsYWdz IGZyb20gdGhlIHJlc3BvbnNlIG1lc3NhZ2VzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU3NjgKKworICAgICAgICBXZSBoYXZlIGRvbWFpbiBwcm9w ZXJ0eSBpbiB0aGUgcmVzcG9uc2UgbWVzc2FnZXMgYnV0IGl0IGlzIG5vdCB1c2VkIGJlY2F1c2Ug d2UgZGlzcGF0Y2gKKyAgICAgICAgdGhlIHJlc3BvbnNlcyBvbiB0aGUgY2FsbGJhY2sgYXNzb2Np YXRlZCB3aXRoIHNlcS4KKworICAgICAgICBJZiB3ZSBoYXZlIHByb3BlcnR5ICdlcnJvcnMnIGlu IHRoZSByZXNwb25zZSB0aGVuIHN1Y2Nlc3MgZXEgZmFsc2UgYW5kIHRydWUgaW4gdGhlIG90aGVy IGNhc2UuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5wbToK KwogMjAxMS0wMy0wNCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucG0gYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5wbQppbmRleCAyYTQwN2I5Li5k Zjg3M2Q5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRv ckluc3BlY3Rvci5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRv ckluc3BlY3Rvci5wbQpAQCAtNTEzLDggKzUxMyw2IEBAIHN1YiBnZW5lcmF0ZUJhY2tlbmRGdW5j dGlvbgogICAgIHB1c2goQGZ1bmN0aW9uLCAiICAgIGlmICgoY2FsbElkIHx8IHByb3RvY29sRXJy b3JzLT5sZW5ndGgoKSkgJiYgbV9pbnNwZWN0b3JBZ2VudC0+aGFzRnJvbnRlbmQoKSkgeyIpOwog ICAgIHB1c2goQGZ1bmN0aW9uLCAiICAgICAgICBSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiByZXNw b25zZU1lc3NhZ2UgPSBJbnNwZWN0b3JPYmplY3Q6OmNyZWF0ZSgpOyIpOwogICAgIHB1c2goQGZ1 bmN0aW9uLCAiICAgICAgICByZXNwb25zZU1lc3NhZ2UtPnNldE51bWJlcihcInNlcVwiLCBjYWxs SWQpOyIpOwotICAgIHB1c2goQGZ1bmN0aW9uLCAiICAgICAgICByZXNwb25zZU1lc3NhZ2UtPnNl dFN0cmluZyhcImRvbWFpblwiLCBcIiRkb21haW5cIik7Iik7Ci0gICAgcHVzaChAZnVuY3Rpb24s ICIgICAgICAgIHJlc3BvbnNlTWVzc2FnZS0+c2V0Qm9vbGVhbihcInN1Y2Nlc3NcIiwgIXByb3Rv Y29sRXJyb3JzLT5sZW5ndGgoKSk7Iik7CiAgICAgcHVzaChAZnVuY3Rpb24sICIiKTsKICAgICBw dXNoKEBmdW5jdGlvbiwgIiAgICAgICAgaWYgKHByb3RvY29sRXJyb3JzLT5sZW5ndGgoKSkiKTsK ICAgICBwdXNoKEBmdW5jdGlvbiwgIiAgICAgICAgICAgIHJlc3BvbnNlTWVzc2FnZS0+c2V0QXJy YXkoXCJlcnJvcnNcIiwgcHJvdG9jb2xFcnJvcnMpOyIpOwpAQCAtNjAwLDcgKzU5OCw2IEBAIHZv aWQgJHtiYWNrZW5kQ2xhc3NOYW1lfTo6cmVwb3J0UHJvdG9jb2xFcnJvcihjb25zdCBsb25nIGNh bGxJZCwgY29uc3QgU3RyaW5nJiBlCiB7CiAgICAgUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gbWVz c2FnZSA9IEluc3BlY3Rvck9iamVjdDo6Y3JlYXRlKCk7CiAgICAgbWVzc2FnZS0+c2V0TnVtYmVy KCJzZXEiLCBjYWxsSWQpOwotICAgIG1lc3NhZ2UtPnNldEJvb2xlYW4oInN1Y2Nlc3MiLCBmYWxz ZSk7CiAgICAgUmVmUHRyPEluc3BlY3RvckFycmF5PiBlcnJvcnMgPSBJbnNwZWN0b3JBcnJheTo6 Y3JlYXRlKCk7CiAgICAgZXJyb3JzLT5wdXNoU3RyaW5nKGVycm9yVGV4dCk7CiAgICAgbWVzc2Fn ZS0+c2V0QXJyYXkoImVycm9ycyIsIGVycm9ycyk7CkBAIC04NDgsNyArODQ1LDcgQEAgSW5zcGVj dG9yQmFja2VuZFN0dWIucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIGFyZ3VtZW50cy5w dXNoKG1lc3NhZ2VPYmplY3QuYm9keVtrZXldKTsKIAogICAgICAgICBpZiAoInNlcSIgaW4gbWVz c2FnZU9iamVjdCkgeyAvLyBqdXN0IGEgcmVzcG9uc2UgZm9yIHNvbWUgcmVxdWVzdAotICAgICAg ICAgICAgaWYgKG1lc3NhZ2VPYmplY3Quc3VjY2VzcykKKyAgICAgICAgICAgIGlmICghbWVzc2Fn ZU9iamVjdC5lcnJvcnMpCiAgICAgICAgICAgICAgICAgdGhpcy5fY2FsbGJhY2tzW21lc3NhZ2VP YmplY3Quc2VxXS5hcHBseShudWxsLCBhcmd1bWVudHMpOwogICAgICAgICAgICAgZWxzZQogICAg ICAgICAgICAgICAgIHRoaXMucmVwb3J0UHJvdG9jb2xFcnJvcihtZXNzYWdlT2JqZWN0KTsK