55761 2011-03-04 03:06:51 -0800 [GTK] media/audio-repaint.html times out 2011-03-04 09:23:48 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned jer.noble mrobinson oldest_to_newest 362393 0 pnormand 2011-03-04 03:06:51 -0800 The test does a seek and just after waits for the seeked event. This is not very reliable as the seek is done *before* we listen on the seeked event. 362394 1 84718 pnormand 2011-03-04 03:09:38 -0800 Created attachment 84718 proposed patch 362395 2 pnormand 2011-03-04 03:11:07 -0800 Jer, would this patch make sense? 362396 3 84719 pnormand 2011-03-04 03:13:18 -0800 Created attachment 84719 proposed patch 362534 4 jer.noble 2011-03-04 08:45:01 -0800 Indeed it would. Looks good to me. (Though you should probably add the CR back to the end of the file.) :-) 362550 5 84719 mrobinson 2011-03-04 09:08:36 -0800 Comment on attachment 84719 proposed patch This makes a lot of sense. 362557 6 pnormand 2011-03-04 09:23:48 -0800 Committed r80360: <http://trac.webkit.org/changeset/80360> 84718 2011-03-04 03:09:38 -0800 2011-03-04 03:13:18 -0800 proposed patch proposed-patch.patch text/plain 3778 pnormand RnJvbSBjNzYwMWMxODMwNzgxZDI3NjJiNGU5YTg5MjA3MDQ3ZDU0ODFiOWJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDQgTWFyIDIwMTEgMTI6MTA6NDAgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgIDggKysrKysrKysKIExheW91dFRlc3RzL21lZGlhL2F1ZGlvLXJl cGFpbnQuaHRtbCAgICAgICAgICAgICAgIHwgICAgNCArKy0tCiBUb29scy9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDkgKysrKysrKysrCiAuLi4vd2Vi a2l0cHkvdG9vbC9jb21tYW5kcy9yZWJhc2VsaW5lc2VydmVyLnB5ICAgICB8ICAgIDggKysrKysr LS0KIDQgZmlsZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggZTNiMGQ3MC4uNDA3NGVlMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDExIEBACisyMDExLTAzLTA0 ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL XSBtZWRpYS9hdWRpby1yZXBhaW50Lmh0bWwgdGltZXMgb3V0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTc2MQorCisgICAgICAgICogbWVkaWEvYXVk aW8tcmVwYWludC5odG1sOiBSZWdpc3RlciB0aGUgc2Vla2VkIGV2ZW50IGxpc3RlbmVyCisgICAg ICAgIGJlZm9yZSBwZXJmb3JtaW5nIHRoZSBzZWVrIGFuZCB0aHVzIGF2b2lkIGEgdGltZW91dCBv ZiB0aGUgdGVzdC4KKwogMjAxMS0wMy0wMyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvYXVkaW8tcmVwYWludC5odG1sIGIvTGF5b3V0VGVzdHMv bWVkaWEvYXVkaW8tcmVwYWludC5odG1sCmluZGV4IDMzNzAyMzkuLjYwODBkMWYgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL21lZGlhL2F1ZGlvLXJlcGFpbnQuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9tZWRpYS9hdWRpby1yZXBhaW50Lmh0bWwKQEAgLTIwLDEzICsyMCwxMyBAQAogICAgICAgICAg ICAgZm9yIChpID0gMDsgaSA8IGNvdW50OyArK2kpIHsKICAgICAgICAgICAgICAgICB2YXIgYXVk aW8gPSBhdWRpb0VsZW1lbnRzW2ldOwogICAgICAgICAgICAgICAgIGF1ZGlvLnBhdXNlKCk7Ci0g ICAgICAgICAgICAgICAgYXVkaW8uY3VycmVudFRpbWUgPSBhdWRpby5kdXJhdGlvbiAqIDAuNTA7 CiAgICAgICAgICAgICAgICAgYXVkaW8uYWRkRXZlbnRMaXN0ZW5lcigic2Vla2VkIiwgZnVuY3Rp b24oKSB7CiAgICAgICAgICAgICAgICAgICAgIGlmICghLS1jb3VudCAmJiB3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpCiAgICAgICAgICAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5ub3RpZnlEb25lKCk7CiAgICAgICAgICAgICAgICAgfSwgdHJ1ZSk7CisgICAgICAgICAg ICAgICAgYXVkaW8uY3VycmVudFRpbWUgPSBhdWRpby5kdXJhdGlvbiAqIDAuNTA7CiAgICAgICAg ICAgICB9CiAgICAgICAgIH0sIDEwMCk7CiAgICAgfQogPC9zY3JpcHQ+Ci08L2JvZHk+ClwgTm8g bmV3bGluZSBhdCBlbmQgb2YgZmlsZQorPC9ib2R5PgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdl TG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGExZGVmY2UuLjE1ZDlhOGIgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAor MjAxMS0wMy0wNCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gbWVkaWEv YXVkaW8tcmVwYWludC5odG1sIHRpbWVzIG91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU3NjEKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv dG9vbC9jb21tYW5kcy9yZWJhc2VsaW5lc2VydmVyLnB5OgorCiAyMDExLTAzLTAyICBNT1JJVEEg SGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbnQg VGFtdXJhLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRz L3JlYmFzZWxpbmVzZXJ2ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvcmViYXNlbGluZXNlcnZlci5weQppbmRleCBjNzlkNzkwLi5iMWMxOWViIDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcmViYXNlbGluZXNlcnZlci5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcmViYXNlbGluZXNl cnZlci5weQpAQCAtNDE2LDcgKzQxNiwxMSBAQCBjbGFzcyBSZWJhc2VsaW5lU2VydmVyKEFic3Ry YWN0RGVjbGFyYXRpdmVDb21tYW5kKToKIAogICAgICAgICBwcmludCAnUGFyc2luZyB1bmV4cGVj dGVkX3Jlc3VsdHMuanNvbi4uLicKICAgICAgICAgcmVzdWx0c19qc29uX3BhdGggPSBmaWxlc3lz dGVtLmpvaW4ocmVzdWx0c19kaXJlY3RvcnksICd1bmV4cGVjdGVkX3Jlc3VsdHMuanNvbicpCi0g ICAgICAgIHJlc3VsdHNfanNvbiA9IGpzb25fcmVzdWx0c19nZW5lcmF0b3IubG9hZF9qc29uKGZp bGVzeXN0ZW0sIHJlc3VsdHNfanNvbl9wYXRoKQorICAgICAgICB0cnk6CisgICAgICAgICAgICBy ZXN1bHRzX2pzb24gPSBqc29uX3Jlc3VsdHNfZ2VuZXJhdG9yLmxvYWRfanNvbihmaWxlc3lzdGVt LCByZXN1bHRzX2pzb25fcGF0aCkKKyAgICAgICAgZXhjZXB0IElPRXJyb3IsIGVycm9yOgorICAg ICAgICAgICAgcHJpbnQgJ0Vycm9yIHdoaWxlIGxvYWRpbmcgdW5leHBlY3RlZF9yZXN1bHRzLmpz b246JywgZXJyb3IKKyAgICAgICAgICAgIHJlc3VsdHNfanNvbiA9IHt9CiAKICAgICAgICAgcG9y dCA9IGZhY3RvcnkuZ2V0KCkKICAgICAgICAgbGF5b3V0X3Rlc3RzX2RpcmVjdG9yeSA9IHBvcnQu bGF5b3V0X3Rlc3RzX2RpcigpCkBAIC00MzEsNyArNDM1LDcgQEAgY2xhc3MgUmViYXNlbGluZVNl cnZlcihBYnN0cmFjdERlY2xhcmF0aXZlQ29tbWFuZCk6CiAgICAgICAgICAgICBzY20pCiAKICAg ICAgICAgcHJpbnQgJ0dhdGhlcmluZyBjdXJyZW50IGJhc2VsaW5lcy4uLicKLSAgICAgICAgZm9y IHRlc3RfZmlsZSwgdGVzdF9qc29uIGluIHJlc3VsdHNfanNvblsndGVzdHMnXS5pdGVtcygpOgor ICAgICAgICBmb3IgdGVzdF9maWxlLCB0ZXN0X2pzb24gaW4gcmVzdWx0c19qc29uLmdldCgndGVz dHMnLCB7fSkuaXRlbXMoKToKICAgICAgICAgICAgIHRlc3RfanNvblsnc3RhdGUnXSA9IFNUQVRF X05FRURTX1JFQkFTRUxJTkUKICAgICAgICAgICAgIHRlc3RfcGF0aCA9IGZpbGVzeXN0ZW0uam9p bihsYXlvdXRfdGVzdHNfZGlyZWN0b3J5LCB0ZXN0X2ZpbGUpCiAgICAgICAgICAgICB0ZXN0X2pz b25bJ2Jhc2VsaW5lcyddID0gX2dldF90ZXN0X2Jhc2VsaW5lcyh0ZXN0X2ZpbGUsIHRlc3RfY29u ZmlnKQotLSAKMS43LjQuMQ== 84719 2011-03-04 03:13:18 -0800 2011-03-04 09:08:36 -0800 proposed patch proposed-patch.patch text/plain 1702 pnormand RnJvbSBkZDgwNTllZjhlYWNhYTFkYjZlZWQ3MzNjZmNhOGYzMjc2NDhmMzk3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDQgTWFyIDIwMTEgMTI6MTQ6MzQgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg fCAgICA4ICsrKysrKysrCiBMYXlvdXRUZXN0cy9tZWRpYS9hdWRpby1yZXBhaW50Lmh0bWwgfCAg ICA0ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggZTNiMGQ3MC4uNDA3NGVlMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDExIEBACisyMDEx LTAzLTA0ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXSBtZWRpYS9hdWRpby1yZXBhaW50Lmh0bWwgdGltZXMgb3V0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTc2MQorCisgICAgICAgICogbWVk aWEvYXVkaW8tcmVwYWludC5odG1sOiBSZWdpc3RlciB0aGUgc2Vla2VkIGV2ZW50IGxpc3RlbmVy CisgICAgICAgIGJlZm9yZSBwZXJmb3JtaW5nIHRoZSBzZWVrIGFuZCB0aHVzIGF2b2lkIGEgdGlt ZW91dCBvZiB0aGUgdGVzdC4KKwogMjAxMS0wMy0wMyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFu QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5Lgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvYXVkaW8tcmVwYWludC5odG1sIGIvTGF5b3V0 VGVzdHMvbWVkaWEvYXVkaW8tcmVwYWludC5odG1sCmluZGV4IDMzNzAyMzkuLjYwODBkMWYgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL2F1ZGlvLXJlcGFpbnQuaHRtbAorKysgYi9MYXlv dXRUZXN0cy9tZWRpYS9hdWRpby1yZXBhaW50Lmh0bWwKQEAgLTIwLDEzICsyMCwxMyBAQAogICAg ICAgICAgICAgZm9yIChpID0gMDsgaSA8IGNvdW50OyArK2kpIHsKICAgICAgICAgICAgICAgICB2 YXIgYXVkaW8gPSBhdWRpb0VsZW1lbnRzW2ldOwogICAgICAgICAgICAgICAgIGF1ZGlvLnBhdXNl KCk7Ci0gICAgICAgICAgICAgICAgYXVkaW8uY3VycmVudFRpbWUgPSBhdWRpby5kdXJhdGlvbiAq IDAuNTA7CiAgICAgICAgICAgICAgICAgYXVkaW8uYWRkRXZlbnRMaXN0ZW5lcigic2Vla2VkIiwg ZnVuY3Rpb24oKSB7CiAgICAgICAgICAgICAgICAgICAgIGlmICghLS1jb3VudCAmJiB3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgICAgICAgICAgICAgICAgICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CiAgICAgICAgICAgICAgICAgfSwgdHJ1ZSk7CisgICAg ICAgICAgICAgICAgYXVkaW8uY3VycmVudFRpbWUgPSBhdWRpby5kdXJhdGlvbiAqIDAuNTA7CiAg ICAgICAgICAgICB9CiAgICAgICAgIH0sIDEwMCk7CiAgICAgfQogPC9zY3JpcHQ+Ci08L2JvZHk+ ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQorPC9ib2R5PgotLSAKMS43LjQuMQ==