55752 2011-03-04 01:04:24 -0800 Remove default parameter for compatibility in WebFontInfo::familyForChars() 2011-03-10 20:44:54 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 kochi webkit-unassigned commit-queue jshin tony oldest_to_newest 362351 0 kochi 2011-03-04 01:04:24 -0800 https://bugs.webkit.org/show_bug.cgi?id=55453 introduced an interface change between Chromium and WebKit, and for maintaining compatibility, WebFontInfo::familyForChars()'s 3rd parameter is declared as a default parameter (preferredLocale = 0). Once Chromium side of changes are complete, remove the default parameter. 365034 1 85293 kochi 2011-03-10 00:56:14 -0800 Created attachment 85293 Remove default parameter for familyForChars(), which is no longer necessary. 365042 2 kochi 2011-03-10 01:16:18 -0800 Tony, Could you please review and commit if this looks good? This is a clean up of remaining stuff in https://bugs.webkit.org/show_bug.cgi?id=55453 Thanks! 365797 3 85293 commit-queue 2011-03-10 20:44:51 -0800 Comment on attachment 85293 Remove default parameter for familyForChars(), which is no longer necessary. Clearing flags on attachment: 85293 Committed r80810: <http://trac.webkit.org/changeset/80810> 365798 4 commit-queue 2011-03-10 20:44:54 -0800 All reviewed patches have been landed. Closing bug. 85293 2011-03-10 00:56:14 -0800 2011-03-10 20:44:51 -0800 Remove default parameter for familyForChars(), which is no longer necessary. WebKit-chromium-remove-default-param.patch text/plain 1325 kochi SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MDY5NSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEg QEAKKzIwMTEtMDMtMTAgIFRha2F5b3NoaSBLb2NoaSAgPGtvY2hpQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgZGVm YXVsdCBwYXJhbWV0ZXIgZGVjbGFyYXRpb24gZm9yIGZhbWlsaUZvckNoYXJzKCksIHdoaWNoIGlz IG5vIGxvbmdlciBuZWNlc3NhcnkuCisKKyAgICAgICAgKiBwdWJsaWMvZ3RrL1dlYkZvbnRJbmZv Lmg6CisKIDIwMTEtMDMtMDggIEhhbnMgV2VubmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkgT3Jsb3cuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9ndGsvV2ViRm9udEluZm8uaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9ndGsvV2ViRm9udEluZm8uaAkocmV2aXNpb24gODA2OTUpCisr KyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9ndGsvV2ViRm9udEluZm8uaAkod29ya2lu ZyBjb3B5KQpAQCAtNTAsNyArNTAsNyBAQAogICAgIC8vCiAgICAgLy8gUmV0dXJuczogdGhlIGZv bnQgZmFtaWx5IG9yIGFuIGVtcHR5IHN0cmluZyBpZiB0aGUgcmVxdWVzdCBjb3VsZCBub3QgYmUK ICAgICAvLyBzYXRpc2ZpZWQuCi0gICAgV0VCS0lUX0FQSSBzdGF0aWMgV2ViQ1N0cmluZyBmYW1p bHlGb3JDaGFycyhjb25zdCBXZWJVQ2hhciogY2hhcmFjdGVycywgc2l6ZV90IG51bUNoYXJhY3Rl cnMsIGNvbnN0IGNoYXIqIHByZWZlcnJlZExvY2FsZSA9IDApOworICAgIFdFQktJVF9BUEkgc3Rh dGljIFdlYkNTdHJpbmcgZmFtaWx5Rm9yQ2hhcnMoY29uc3QgV2ViVUNoYXIqIGNoYXJhY3RlcnMs IHNpemVfdCBudW1DaGFyYWN0ZXJzLCBjb25zdCBjaGFyKiBwcmVmZXJyZWRMb2NhbGUpOwogCiAg ICAgLy8gRmlsbCBvdXQgdGhlIGdpdmVuIFdlYkZvbnRSZW5kZXJTdHlsZSB3aXRoIHRoZSB1c2Vy J3MgcHJlZmVyZW5jZXMgZm9yCiAgICAgLy8gcmVuZGVyaW5nIHRoZSBnaXZlbiBmb250IGF0IHRo ZSBnaXZlbiBzaXplLgo=