55744 2011-03-03 21:28:09 -0800 Move WKViewExecuteCommand() to WKPageExecuteCommand() 2011-03-04 10:10:34 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 jeffm jeffm darin jeffm oldest_to_newest 362257 0 jeffm 2011-03-03 21:28:09 -0800 Per Darin Adler's suggestion in bug 49829, I'm going to move the API to execute a WebCore EditorCommand from WKView to WKPage. Initially, this will only be used on Windows. 362488 1 84749 jeffm 2011-03-04 07:46:50 -0800 Created attachment 84749 Patch 362573 2 84749 darin 2011-03-04 09:49:29 -0800 Comment on attachment 84749 Patch Thanks. I like this better. 362601 3 jeffm 2011-03-04 10:10:34 -0800 Committed r80365: <http://trac.webkit.org/changeset/80365> 84749 2011-03-04 07:46:50 -0800 2011-03-04 09:49:28 -0800 Patch bug-55744-20110304074648.patch text/plain 3575 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwMzUxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDMtMDQgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE1vdmUgV0tWaWV3RXhlY3V0ZUNvbW1hbmQoKSB0byBXS1BhZ2VFeGVj dXRlQ29tbWFuZCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01NTc0NAorICAgICAgICAKKyAgICAgICAgRXhlY3V0aW5nIGEgY29tbWFuZCBvcGVyYXRl cyBvbiBhIHBhZ2UsIHNvIGl0IG1ha2VzIG1vcmUgc2Vuc2UgZm9yIGl0IHRvIGJlIGluIFdLUGFn ZS4KKyAgICAgICAgVGhpcyBhbHNvIG1ha2VzIGl0IGF2YWlsYWJsZSBvbiBhbGwgcGxhdGZvcm1z LCBub3QganVzdCBXaW5kb3dzLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5j cHA6CisgICAgICAgIChXS1BhZ2VFeGVjdXRlQ29tbWFuZCk6IEFkZGVkLgorICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvQy9XS1BhZ2UuaDogQWRkIFdLUGFnZUV4ZWN1dGVDb21tYW5kKCkuCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9DL3dpbi9XS1ZpZXcuY3BwOiBSZW1vdmUgV0tWaWV3RXhlY3V0 ZUNvbW1hbmQoKS4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0Mvd2luL1dLVmlldy5oOiBSZW1v dmUgV0tWaWV3RXhlY3V0ZUNvbW1hbmQoKS4KKwogMjAxMS0wMy0wMyAgQnJpYW4gV2VpbnN0ZWlu ICA8YndlaW5zdGVpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jl bi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCShyZXZp c2lvbiA4MDM0NykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00OTIsMyArNDkyLDggQEAgV0tQYWdlRGVidWdQYWludEZsYWdz IFdLUGFnZUdldERlYnVnUGFpbgogewogICAgIHJldHVybiBXZWJQYWdlUHJveHk6OmRlYnVnUGFp bnRGbGFncygpOwogfQorCit2b2lkIFdLUGFnZUV4ZWN1dGVDb21tYW5kKFdLUGFnZVJlZiBwYWdl UmVmLCBXS1N0cmluZ1JlZiBjb21tYW5kKQoreworICAgIHRvSW1wbChwYWdlUmVmKS0+ZXhlY3V0 ZUVkaXRDb21tYW5kKHRvSW1wbChjb21tYW5kKS0+c3RyaW5nKCkpOworfQpJbmRleDogU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuaAkocmV2aXNpb24gODAzNDcpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmgJKHdvcmtpbmcgY29weSkKQEAgLTM2 Myw2ICszNjMsMTkgQEAgV0tfRVhQT1JUIHZvaWQgV0tQYWdlR2V0Q29udGVudHNBc1N0cmluZwog dHlwZWRlZiB2b2lkICgqV0tQYWdlRm9yY2VSZXBhaW50RnVuY3Rpb24pKFdLRXJyb3JSZWYsIHZv aWQqKTsKIFdLX0VYUE9SVCB2b2lkIFdLUGFnZUZvcmNlUmVwYWludChXS1BhZ2VSZWYgcGFnZSwg dm9pZCogY29udGV4dCwgV0tQYWdlRm9yY2VSZXBhaW50RnVuY3Rpb24gZnVuY3Rpb24pOwogCisv KgorICAgIFNvbWUgb2YgdGhlIG1vcmUgY29tbW9uIGNvbW1hbmQgbmFtZSBzdHJpbmdzIGluY2x1 ZGUgdGhlIGZvbGxvd2luZywgYWx0aG91Z2ggYW55IFdlYkNvcmUgRWRpdG9yQ29tbWFuZCBzdHJp bmcgaXMgc3VwcG9ydGVkOgorICAgIAorICAgICJDdXQiCisgICAgIkNvcHkiCisgICAgIlBhc3Rl IgorICAgICJTZWxlY3RBbGwiCisgICAgIlVuZG8iCisgICAgIlJlZG8iCisqLworCitXS19FWFBP UlQgdm9pZCBXS1BhZ2VFeGVjdXRlQ29tbWFuZChXS1BhZ2VSZWYgcGFnZSwgV0tTdHJpbmdSZWYg Y29tbWFuZCk7CisKICNpZmRlZiBfX2NwbHVzcGx1cwogfQogI2VuZGlmCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Mvd2luL1dLVmlldy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL3dpbi9XS1ZpZXcuY3BwCShyZXZpc2lvbiA4MDM0 NykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy93aW4vV0tWaWV3LmNwcAkod29y a2luZyBjb3B5KQpAQCAtODEsOCArODEsMyBAQCBXS1ZpZXdGaW5kSW5kaWNhdG9yQ2FsbGJhY2sg V0tWaWV3R2V0RmluCiB7ICAgIAogICAgIHJldHVybiB0b0ltcGwodmlld1JlZiktPmdldEZpbmRJ bmRpY2F0b3JDYWxsYmFjayhjb250ZXh0KTsKIH0KLQotdm9pZCBXS1ZpZXdFeGVjdXRlQ29tbWFu ZChXS1ZpZXdSZWYgdmlld1JlZiwgV0tTdHJpbmdSZWYgY29tbWFuZCkKLXsKLSAgICB0b0ltcGwo dmlld1JlZiktPnBhZ2UoKS0+ZXhlY3V0ZUVkaXRDb21tYW5kKHRvSW1wbChjb21tYW5kKS0+c3Ry aW5nKCkpOwotfQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL3dpbi9XS1Zp ZXcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Mvd2luL1dL Vmlldy5oCShyZXZpc2lvbiA4MDM0NykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Qy93aW4vV0tWaWV3LmgJKHdvcmtpbmcgY29weSkKQEAgLTUwLDE5ICs1MCw2IEBAIHR5cGVkZWYg dm9pZCAoKldLVmlld0ZpbmRJbmRpY2F0b3JDYWxsYmEKIFdLX0VYUE9SVCB2b2lkIFdLVmlld1Nl dEZpbmRJbmRpY2F0b3JDYWxsYmFjayhXS1ZpZXdSZWYgdmlldywgV0tWaWV3RmluZEluZGljYXRv ckNhbGxiYWNrIGNhbGxiYWNrLCB2b2lkKiBjb250ZXh0KTsKIFdLX0VYUE9SVCBXS1ZpZXdGaW5k SW5kaWNhdG9yQ2FsbGJhY2sgV0tWaWV3R2V0RmluZEluZGljYXRvckNhbGxiYWNrKFdLVmlld1Jl ZiB2aWV3LCB2b2lkKiogY29udGV4dCk7CiAKLS8qCi0gICAgVmFsaWQgY29tbWFuZCBuYW1lIHN0 cmluZ3MgaW5jbHVkZToKLSAgICAKLSAgICAiQ3V0IgotICAgICJDb3B5IgotICAgICJQYXN0ZSIK LSAgICAiU2VsZWN0QWxsIgotICAgICJVbmRvIgotICAgICJSZWRvIgotKi8KLQotV0tfRVhQT1JU IHZvaWQgV0tWaWV3RXhlY3V0ZUNvbW1hbmQoV0tWaWV3UmVmIHZpZXcsIFdLU3RyaW5nUmVmIGNv bW1hbmQpOwotCiAjaWZkZWYgX19jcGx1c3BsdXMKIH0KICNlbmRpZgo=