55735 2011-03-03 17:54:38 -0800 AX: kAXCellForColumnAndRowParameterizedAttribute doesn't work ARIA grids with colspans 2011-03-07 09:20:35 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach bdakin oldest_to_newest 362145 0 cfleizach 2011-03-03 17:54:38 -0800 If a table is defined as an aria-grid and the cells have colspans, AX will not return the right element for kAXCellForColumnAndRowParameterizedAttribute. We need to check the ranges of each cell before returning one. 362147 1 cfleizach 2011-03-03 17:54:50 -0800 rdar://9051688 362179 2 84675 cfleizach 2011-03-03 18:20:02 -0800 Created attachment 84675 patch 362723 3 84675 bdakin 2011-03-04 15:00:02 -0800 Comment on attachment 84675 patch 140 int intRow = static_cast<int>(row); 141 int intColumn = static_cast<int>(column); This can probably be a soft-cast instead of a static cast, and I think that would be better. We try to only use static_cast when necessary. 363373 4 cfleizach 2011-03-07 09:20:35 -0800 http://trac.webkit.org/changeset/80470 84675 2011-03-03 18:20:02 -0800 2011-03-04 15:00:02 -0800 patch patch.txt text/plain 7257 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwMzA3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDMtMDMgIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBWDoga0FYQ2VsbEZvckNvbHVtbkFuZFJvd1BhcmFtZXRl cml6ZWRBdHRyaWJ1dGUgZG9lc24ndCB3b3JrIEFSSUEgZ3JpZHMgd2l0aCBjb2xzcGFucworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU3MzUKKworICAg ICAgICBUaGUgQVJJQSBncmlkIGltcGxlbWVudGF0aW9uIG5lZWRlZCB0byB2ZXJpZnkgdGhlIHJv dy9jb2x1bW4gcmFuZ2Ugb2YgYSBjZWxsIGluc3RlYWQgb2YgCisgICAgICAgIGFzc3VtaW5nIGEg MS0xIG1hcHBpbmcgYmV0d2VlbiBjaGlsZHJlbiBhbmQgcm93L2NvbHVtbi4KKworICAgICAgICBU ZXN0OiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLXRhYmxlLXdpdGgtY29sc3Bhbi1j ZWxscy5odG1sCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlBUklBR3Jp ZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5QVJJQUdyaWQ6OmNlbGxGb3JD b2x1bW5BbmRSb3cpOgorCiAyMDExLTAzLTAzICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBmaXguIE5lZWQgd2luL2NVUkwgRG93bmxvYWRCdW5k bGUgc3R1Yi4KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwMzA3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMDMgIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBWDoga0FYQ2VsbEZvckNvbHVtbkFuZFJvd1BhcmFtZXRl cml6ZWRBdHRyaWJ1dGUgZG9lc24ndCB3b3JrIEFSSUEgZ3JpZHMgd2l0aCBjb2xzcGFucworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU3MzUKKworICAg ICAgICAqIHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2FyaWEtdGFibGUtd2l0aC1jb2xzcGFu LWNlbGxzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vz c2liaWxpdHkvYXJpYS10YWJsZS13aXRoLWNvbHNwYW4tY2VsbHMuaHRtbDogQWRkZWQuCisKIDIw MTEtMDMtMDMgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgVW5yZXZpZXdlZCBDaHJvbWl1bSBTbm93IExlb3BhcmQgZXhwZWN0YXRpb25zIHVwZGF0ZS4K SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eUFSSUFHcmlk LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlBUklBR3JpZC5jcHAJKHJldmlzaW9uIDgwMTc1KQorKysgU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5QVJJQUdyaWQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x MzcsMTggKzEzNyw0MCBAQAogICAgIGlmIChjb2x1bW4gPj0gY29sdW1uQ291bnQoKSB8fCByb3cg Pj0gcm93Q291bnQoKSkKICAgICAgICAgcmV0dXJuIDA7CiAgICAgCi0gICAgQWNjZXNzaWJpbGl0 eU9iamVjdCogdGFibGVSb3cgPSBtX3Jvd3Nbcm93XS5nZXQoKTsKLSAgICBpZiAoIXRhYmxlUm93 KQotICAgICAgICByZXR1cm4gMDsKKyAgICBpbnQgaW50Um93ID0gc3RhdGljX2Nhc3Q8aW50Pihy b3cpOworICAgIGludCBpbnRDb2x1bW4gPSBzdGF0aWNfY2FzdDxpbnQ+KGNvbHVtbik7ICAgIAor CisgICAgcGFpcjxpbnQsIGludD4gY29sdW1uUmFuZ2U7CisgICAgcGFpcjxpbnQsIGludD4gcm93 UmFuZ2U7CiAgICAgCi0gICAgQWNjZXNzaWJpbGl0eUNoaWxkcmVuVmVjdG9yIGNoaWxkcmVuID0g dGFibGVSb3ctPmNoaWxkcmVuKCk7Ci0gICAgLy8gaW4gY2FzZSB0aGlzIHJvdyBoYWQgZmV3ZXIg Y29sdW1ucyB0aGFuIG90aGVyIHJvd3MKLSAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiB0YWJsZUNl bGwgPSAwOwotICAgIGlmIChjb2x1bW4gPj0gY2hpbGRyZW4uc2l6ZSgpKQotICAgICAgICByZXR1 cm4gMDsKKyAgICAvLyBJdGVyYXRlIGJhY2t3YXJkcyB0aHJvdWdoIHRoZSByb3dzIGluIGNhc2Ug dGhlIGRlc2lyZWQgY2VsbCBoYXMgYSByb3dzcGFuIGFuZCBleGlzdHMKKyAgICAvLyBpbiBhIHBy ZXZpb3VzIHJvdy4KKyAgICBmb3IgKDsgaW50Um93ID49IDA7IC0taW50Um93KSB7CisgICAgICAg IEFjY2Vzc2liaWxpdHlPYmplY3QqIHRhYmxlUm93ID0gbV9yb3dzW2ludFJvd10uZ2V0KCk7Cisg ICAgICAgIGlmICghdGFibGVSb3cpCisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgCisg ICAgICAgIEFjY2Vzc2liaWxpdHlDaGlsZHJlblZlY3RvciBjaGlsZHJlbiA9IHRhYmxlUm93LT5j aGlsZHJlbigpOworICAgICAgICB1bnNpZ25lZCBjaGlsZHJlbkxlbmd0aCA9IGNoaWxkcmVuLnNp emUoKTsKKyAgICAgICAgCisgICAgICAgIC8vIFNpbmNlIHNvbWUgY2VsbHMgbWF5IGhhdmUgY29s c3BhbnMsIHdlIGhhdmUgdG8gY2hlY2sgdGhlIGFjdHVhbCByYW5nZSBvZiBlYWNoCisgICAgICAg IC8vIGNlbGwgdG8gZGV0ZXJtaW5lIHdoaWNoIGlzIHRoZSByaWdodCBvbmUuCisgICAgICAgIGZv ciAodW5zaWduZWQgayA9IDA7IGsgPCBjaGlsZHJlbkxlbmd0aDsgKytrKSB7CisgICAgICAgICAg ICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjaGlsZCA9IGNoaWxkcmVuW2tdLmdldCgpOworICAgICAg ICAgICAgaWYgKCFjaGlsZC0+aXNUYWJsZUNlbGwoKSkgCisgICAgICAgICAgICAgICAgY29udGlu dWU7CisgICAgICAgICAgICAKKyAgICAgICAgICAgIEFjY2Vzc2liaWxpdHlUYWJsZUNlbGwqIHRh YmxlQ2VsbENoaWxkID0gc3RhdGljX2Nhc3Q8QWNjZXNzaWJpbGl0eVRhYmxlQ2VsbCo+KGNoaWxk KTsKKyAgICAgICAgICAgIHRhYmxlQ2VsbENoaWxkLT5jb2x1bW5JbmRleFJhbmdlKGNvbHVtblJh bmdlKTsKKyAgICAgICAgICAgIHRhYmxlQ2VsbENoaWxkLT5yb3dJbmRleFJhbmdlKHJvd1Jhbmdl KTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgaWYgKChpbnRDb2x1bW4gPj0gY29sdW1uUmFu Z2UuZmlyc3QgJiYgaW50Q29sdW1uIDwgKGNvbHVtblJhbmdlLmZpcnN0ICsgY29sdW1uUmFuZ2Uu c2Vjb25kKSkKKyAgICAgICAgICAgICAgICAmJiAoaW50Um93ID49IHJvd1JhbmdlLmZpcnN0ICYm IGludFJvdyA8IChyb3dSYW5nZS5maXJzdCArIHJvd1JhbmdlLnNlY29uZCkpKQorICAgICAgICAg ICAgICAgIHJldHVybiB0YWJsZUNlbGxDaGlsZDsKKyAgICAgICAgfQorICAgIH0KIAotICAgIHRh YmxlQ2VsbCA9IGNoaWxkcmVuW2NvbHVtbl0uZ2V0KCk7Ci0gICAgcmV0dXJuIHN0YXRpY19jYXN0 PEFjY2Vzc2liaWxpdHlUYWJsZUNlbGwqPih0YWJsZUNlbGwpOworICAgIHJldHVybiAwOwogfQog ICAgIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL2FjY2Vzc2liaWxpdHkvYXJpYS10YWJsZS13aXRoLWNvbHNwYW4tY2VsbHMtZXhwZWN0ZWQu dHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5 L2FyaWEtdGFibGUtd2l0aC1jb2xzcGFuLWNlbGxzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkK KysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2FyaWEtdGFibGUtd2l0 aC1jb2xzcGFuLWNlbGxzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxOCBA QAorRnJlbW9udAorTGVhdmVzCUFycml2ZXMJUm91dGUKKzc6MDAgQU0JODowMCBBTQlGQjEKKzc6 MDAgQU0JODowMCBBTQorNzowMCBBTQk4OjAwIEFNCitUaGlzIHRlc3RzIGlmIGFuIEFSSUEgZ3Jp ZCBoYXMgYSB0YWJsZSBjZWxsIHdpdGggY29sc3BhbnMsIHRoZW4gY2VsbEZvclJvd0FuZENvbHVt biBzdGlsbCByZXR1cm5zIHRoZSBjb3JyZWN0IGNlbGwuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxs IHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBM RVRFIi4KKworCitQQVNTIGdyaWQuY2VsbEZvckNvbHVtbkFuZFJvdygyLCAwKS5yb2xlIGlzICdB WFJvbGU6IEFYQ2VsbCcKK1BBU1MgZ3JpZC5jZWxsRm9yQ29sdW1uQW5kUm93KDIsIDApLmRlc2Ny aXB0aW9uIGlzICdBWERlc2NyaXB0aW9uOiBDb2xzcGFuQ2VsbCcKK1BBU1MgZ3JpZC5jZWxsRm9y Q29sdW1uQW5kUm93KDIsIDQpLnJvbGUgaXMgJ0FYUm9sZTogQVhDZWxsJworUEFTUyBncmlkLmNl bGxGb3JDb2x1bW5BbmRSb3coMiwgNCkuZGVzY3JpcHRpb24gaXMgJ0FYRGVzY3JpcHRpb246IFJv d3NwYW5DZWxsJworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBM RVRFCisKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2FyaWEt dGFibGUtd2l0aC1jb2xzcGFuLWNlbGxzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS10YWJsZS13aXRoLWNvbHNwYW4tY2VsbHMu aHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmls aXR5L2FyaWEtdGFibGUtd2l0aC1jb2xzcGFuLWNlbGxzLmh0bWwJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsNTEgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VO Ij4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uLy4u L2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQ+Cit2YXIgc3Vj Y2Vzc2Z1bGx5UGFyc2VkID0gZmFsc2U7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8u Li9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8 Ym9keSBpZD0iYm9keSI+CisKKzx0YWJsZSB0YWJpbmRleD0iMCIgaWQ9ImdyaWQiIHJvbGU9Imdy aWQiIGNsYXNzPSJhbSIgYXJpYS1sYWJlbD0iTW9ybmluZyBzY2hlZHVsZSI+Cis8dHIgcm9sZT0i cm93Ij48dGggY29sc3Bhbj0iMyIgYXJpYS1sYWJlbD0iQ29sc3BhbkNlbGwiPkZyZW1vbnQ8L3Ro PjwvdHI+Cis8dHIgcm9sZT0icm93Ij48dGQgcm9sZT0iY29sdW1uaGVhZGVyIj5MZWF2ZXM8L3Rk Pjx0ZCByb2xlPSJjb2x1bW5oZWFkZXIiPkFycml2ZXM8L3RkPjx0ZCByb2xlPSJjb2x1bW5oZWFk ZXIiPlJvdXRlPC90ZD48L3RyPgorPHRyIHJvbGU9InJvdyI+PHRkIGFyaWEtbGFiZWw9IkJBUlQg YXQiPjc6MDAgQU08L3RkPjx0ZD44OjAwIEFNPC90ZD48dGQgYXJpYS1sYWJlbD0iUm93c3BhbkNl bGwiIHJvd3NwYW49IjMiPkZCMTwvdGQ+PC90cj4KKzx0ciByb2xlPSJyb3ciPjx0ZCBhcmlhLWxh YmVsPSJCQVJUIGF0Ij43OjAwIEFNPC90ZD48dGQ+ODowMCBBTTwvdGQ+PC90cj4KKzx0ciByb2xl PSJyb3ciPjx0ZCBhcmlhLWxhYmVsPSJCQVJUIGF0Ij43OjAwIEFNPC90ZD48dGQ+ODowMCBBTTwv dGQ+PC90cj4KKzwvdGFibGU+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0i Y29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CisKKyAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0 cyBpZiBhbiBBUklBIGdyaWQgaGFzIGEgdGFibGUgY2VsbCB3aXRoIGNvbHNwYW5zLCB0aGVuIGNl bGxGb3JSb3dBbmRDb2x1bW4gc3RpbGwgcmV0dXJucyB0aGUgY29ycmVjdCBjZWxsLiIpOworCisg ICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgeworCisgICAgICAgIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJncmlkIikuZm9jdXMoKTsKKyAgICAgICAgdmFyIGdyaWQgPSBh Y2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudDsKKworICAgICAgICBzaG91bGRC ZSgiZ3JpZC5jZWxsRm9yQ29sdW1uQW5kUm93KDIsIDApLnJvbGUiLCAiJ0FYUm9sZTogQVhDZWxs JyIpOworICAgICAgICBzaG91bGRCZSgiZ3JpZC5jZWxsRm9yQ29sdW1uQW5kUm93KDIsIDApLmRl c2NyaXB0aW9uIiwgIidBWERlc2NyaXB0aW9uOiBDb2xzcGFuQ2VsbCciKTsKKworICAgICAgICBz aG91bGRCZSgiZ3JpZC5jZWxsRm9yQ29sdW1uQW5kUm93KDIsIDQpLnJvbGUiLCAiJ0FYUm9sZTog QVhDZWxsJyIpOworICAgICAgICBzaG91bGRCZSgiZ3JpZC5jZWxsRm9yQ29sdW1uQW5kUm93KDIs IDQpLmRlc2NyaXB0aW9uIiwgIidBWERlc2NyaXB0aW9uOiBSb3dzcGFuQ2VsbCciKTsKKworICAg ICAgICAvLyBWZXJpZnkgbm90aGluZyBmdW5ueSBoYXBwZW5zIHdoZW4gd2UgYXNrIGZvciBzdHJh bmdlIHZhbHVlcy4gV2UnbGwgY3Jhc2ggaWYgc29tZXRoaW5nIHdlbnQgYXdyeS4KKyAgICAgICAg Zm9yICh2YXIgayA9IC0xOyBrIDwgMTA7IGsrKykgeworICAgICAgICAgICAgZm9yICh2YXIgaiA9 IC0xOyBqIDwgMTA7IGorKykgeworICAgICAgICAgICAgICAgIHZhciB0ZXN0ID0gZ3JpZC5jZWxs Rm9yQ29sdW1uQW5kUm93KGssIGopOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgfQor CisgICAgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0PgorCis8c2NyaXB0IHNy Yz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4K KzwvYm9keT4KKzwvaHRtbD4K