5573 2005-10-31 10:59:35 -0800 Bidi algorithm: AN after L has incorrect resolved level 2005-11-28 08:23:40 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 VERIFIED FIXED P2 Normal --- 1 mitz hyatt oldest_to_newest 23384 0 mitz 2005-10-31 10:59:35 -0800 Summary: if the embedding level is even, then in the sequence L AN, the AN's resolved level should be greater (by 2) than the L's. WebKit treats them as if they have the same resolved level. (3.3.5 in the UBA). To reproduce: open the test case in Safari. Expected: the two lines to be the same, from left to right: English, Hebrew, Arabic digits. Firefox renders as expected. Actual: on the second line, from left to right: English, Arabic digits, Hebrew. 23386 1 4543 mitz 2005-10-31 11:02:40 -0800 Created attachment 4543 Testcase 23388 2 4544 mitz 2005-10-31 11:40:16 -0800 Created attachment 4544 Terminate L run when encountring AN on an even level 23389 3 4545 mitz 2005-10-31 11:43:59 -0800 Created attachment 4545 Terminate L run when encountring AN on an even level Oops! Corrected style. 23390 4 4545 mitz 2005-10-31 11:44:24 -0800 Comment on attachment 4545 Terminate L run when encountring AN on an even level Fixes the testcase and doesn't break any of the layout tests. 23409 5 4545 darin 2005-10-31 14:17:40 -0800 Comment on attachment 4545 Terminate L run when encountring AN on an even level In the future, it's probably worthwhile adding a comment in code that has a case that falls through to the next case, since the mistake of leaving out a break is so common and we don't want anyone to think this is a mistake. But that's a minor quibble. r=me 4543 2005-10-31 11:02:40 -0800 2005-10-31 11:02:40 -0800 Testcase bidi-AN-after-L.html text/html 442 mitz PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgCiJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9sb29zZS5kdGQiPgo8aHRtbD4KPGhl YWQ+CiAgICA8dGl0bGU+QU4gYWZ0ZXIgTDwvdGl0bGU+CjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+ CiAgICAubHJvIHsgZGlyZWN0aW9uOmx0cjsgdW5pY29kZS1iaWRpOmJpZGktb3ZlcnJpZGU7IH07 Cjwvc3R5bGU+CjwvaGVhZD4KPGJvZHk+ClRoZSBmb2xsb3dpbmcgdHdvIGxpbmVzIHNob3VsZCBi ZSB0aGUgc2FtZToKPHAgY2xhc3M9ImxybyI+YWJjJiN4MDVkMjsmI3gwNWQxOyYjeDA1ZDA7JiN4 MDY2MTsmI3gwNjYyOyYjeDA2NjM7PC9wPgo8cD5hYmMmI3gwNjYxOyYjeDA2NjI7JiN4MDY2Mzsm I3gwNWQwOyYjeDA1ZDE7JiN4MDVkMjs8L3A+CjwvYm9keT4KPC9odG1sPg== 4544 2005-10-31 11:40:16 -0800 2005-10-31 11:43:59 -0800 Terminate L run when encountring AN on an even level 5573_r1.patch text/plain 716 mitz SW5kZXg6IGJpZGkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2to dG1sL3JlbmRlcmluZy9iaWRpLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNTMKZGlmZiAt cCAtdSAtcjEuMTUzIGJpZGkuY3BwCi0tLSBiaWRpLmNwcAkyNCBPY3QgMjAwNSAyMjo1MTowNiAt MDAwMAkxLjE1MworKysgYmlkaS5jcHAJMzEgT2N0IDIwMDUgMTk6MzQ6NTQgLTAwMDAKQEAgLTEx ODIsNiArMTE4Miw5IEBAIHZvaWQgUmVuZGVyQmxvY2s6OmJpZGlSZW9yZGVyTGluZShjb25zdCAK ICAgICAgICAgICAgIHN3aXRjaChiaWRpLnN0YXR1cy5sYXN0KQogICAgICAgICAgICAgICAgIHsK ICAgICAgICAgICAgICAgICBjYXNlIFFDaGFyOjpEaXJMOgorICAgICAgICAgICAgICAgICAgICBp ZiAoYmlkaS5jb250ZXh0LT5kaXIgPT0gUUNoYXI6OkRpckwpIHsKKyAgICAgICAgICAgICAgICAg ICAgICAgIGFwcGVuZFJ1bihiaWRpKTsKKyAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAg ICAgICAgIGNhc2UgUUNoYXI6OkRpckFOOgogICAgICAgICAgICAgICAgICAgICBiaWRpLmVvciA9 IGJpZGkuY3VycmVudDsgYmlkaS5zdGF0dXMuZW9yID0gUUNoYXI6OkRpckFOOyBicmVhazsKICAg ICAgICAgICAgICAgICBjYXNlIFFDaGFyOjpEaXJSOgo= 4545 2005-10-31 11:43:59 -0800 2005-10-31 14:17:40 -0800 Terminate L run when encountring AN on an even level 5573_r2.patch text/plain 691 mitz SW5kZXg6IGJpZGkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2to dG1sL3JlbmRlcmluZy9iaWRpLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNTMKZGlmZiAt cCAtdSAtcjEuMTUzIGJpZGkuY3BwCi0tLSBiaWRpLmNwcAkyNCBPY3QgMjAwNSAyMjo1MTowNiAt MDAwMAkxLjE1MworKysgYmlkaS5jcHAJMzEgT2N0IDIwMDUgMTk6NDc6NDMgLTAwMDAKQEAgLTEx ODIsNiArMTE4Miw4IEBAIHZvaWQgUmVuZGVyQmxvY2s6OmJpZGlSZW9yZGVyTGluZShjb25zdCAK ICAgICAgICAgICAgIHN3aXRjaChiaWRpLnN0YXR1cy5sYXN0KQogICAgICAgICAgICAgICAgIHsK ICAgICAgICAgICAgICAgICBjYXNlIFFDaGFyOjpEaXJMOgorICAgICAgICAgICAgICAgICAgICBp ZiAoYmlkaS5jb250ZXh0LT5kaXIgPT0gUUNoYXI6OkRpckwpCisgICAgICAgICAgICAgICAgICAg ICAgICBhcHBlbmRSdW4oYmlkaSk7CiAgICAgICAgICAgICAgICAgY2FzZSBRQ2hhcjo6RGlyQU46 CiAgICAgICAgICAgICAgICAgICAgIGJpZGkuZW9yID0gYmlkaS5jdXJyZW50OyBiaWRpLnN0YXR1 cy5lb3IgPSBRQ2hhcjo6RGlyQU47IGJyZWFrOwogICAgICAgICAgICAgICAgIGNhc2UgUUNoYXI6 OkRpclI6Cg==