<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>55704</bug_id>
          
          <creation_ts>2011-03-03 13:47:48 -0800</creation_ts>
          <short_desc>QuickTime plugin should opt in to a 32-bit non-executable heap</short_desc>
          <delta_ts>2011-03-07 18:33:02 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac (Intel)</rep_platform>
          <op_sys>OS X 10.6</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Damian Kaleta">dkaleta</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>andersca</cc>
    
    <cc>ayao</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dkaleta</cc>
    
    <cc>ike</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>361904</commentid>
    <comment_count>0</comment_count>
    <who name="Damian Kaleta">dkaleta</who>
    <bug_when>2011-03-03 13:47:48 -0800</bug_when>
    <thetext>Not all plugins should be opt out of 32-bit NX.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>361908</commentid>
    <comment_count>1</comment_count>
      <attachid>84619</attachid>
    <who name="Damian Kaleta">dkaleta</who>
    <bug_when>2011-03-03 13:54:33 -0800</bug_when>
    <thetext>Created attachment 84619
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>361914</commentid>
    <comment_count>2</comment_count>
      <attachid>84619</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2011-03-03 13:59:36 -0800</bug_when>
    <thetext>Comment on attachment 84619
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84619&amp;action=review

&gt; WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:222
&gt; +bool PluginProcessProxy::pluginNeedsExecutableHeap(const PluginInfoStore::Plugin&amp; pluginInfo) const

This doesn&apos;t need to be a member function of PluginProcessProxy, it can just be a static free function (and I&apos;d put it above the call site.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>361917</commentid>
    <comment_count>3</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2011-03-03 14:03:42 -0800</bug_when>
    <thetext>Bug title makes no sense. What is NX?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>361923</commentid>
    <comment_count>4</comment_count>
    <who name="Damian Kaleta">dkaleta</who>
    <bug_when>2011-03-03 14:08:32 -0800</bug_when>
    <thetext>Simon, 
Take a look at this: &lt;rdar://problem/8105706&gt;
and that: http://en.wikipedia.org/wiki/NX_bit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>361928</commentid>
    <comment_count>5</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2011-03-03 14:11:55 -0800</bug_when>
    <thetext>You should spell out &quot;non-executable&quot;, and clarify what 32-bit NX is. Does this only apply to 32-bit plug-in, or does it mean something else? And is the plugin opting out, or is the browser forcing this on the plug-in?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>361996</commentid>
    <comment_count>6</comment_count>
      <attachid>84638</attachid>
    <who name="Damian Kaleta">dkaleta</who>
    <bug_when>2011-03-03 15:18:25 -0800</bug_when>
    <thetext>Created attachment 84638
Proposed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362164</commentid>
    <comment_count>7</comment_count>
    <who name="Ivan Krstić">ike</who>
    <bug_when>2011-03-03 18:08:20 -0800</bug_when>
    <thetext>This patch is confused. The ChangeLog states that Silverlight and QuickTime should opt *in* to a 32-bit NX heap, which means their heap should not be executable. But then it opts them *out* by making pluginNeedsExecutableHeap() claim that those two plugins need an executable heap — i.e. that they cannot run with NX. It also opts all other plugins into running with an NX heap.

Assuming you&apos;re really trying to say &quot;QuickTime and Silverlight should run with a non-executable heap (opt-in), and other plugins should have an executable one (opt-out)&quot;, you need to invert your true/false returns in pluginNeedsExecutableHeap.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362569</commentid>
    <comment_count>8</comment_count>
    <who name="Damian Kaleta">dkaleta</who>
    <bug_when>2011-03-04 09:41:00 -0800</bug_when>
    <thetext>I misunderstood this bug, let me clarify the ChangeLog and make changes to the patch.

(In reply to comment #7)
&gt; This patch is confused. The ChangeLog states that Silverlight and QuickTime should opt *in* to a 32-bit NX heap, which means their heap should not be executable. But then it opts them *out* by making pluginNeedsExecutableHeap() claim that those two plugins need an executable heap — i.e. that they cannot run with NX. It also opts all other plugins into running with an NX heap.
&gt; 
&gt; Assuming you&apos;re really trying to say &quot;QuickTime and Silverlight should run with a non-executable heap (opt-in), and other plugins should have an executable one (opt-out)&quot;, you need to invert your true/false returns in pluginNeedsExecutableHeap.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362579</commentid>
    <comment_count>9</comment_count>
      <attachid>84766</attachid>
    <who name="Damian Kaleta">dkaleta</who>
    <bug_when>2011-03-04 09:53:07 -0800</bug_when>
    <thetext>Created attachment 84766
Proposed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362588</commentid>
    <comment_count>10</comment_count>
    <who name="Ivan Krstić">ike</who>
    <bug_when>2011-03-04 09:59:42 -0800</bug_when>
    <thetext>Looks good to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362841</commentid>
    <comment_count>11</comment_count>
      <attachid>84766</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-03-04 18:14:29 -0800</bug_when>
    <thetext>Comment on attachment 84766
Proposed patch.

Rejecting attachment 84766 from commit-queue.

Failed to run &quot;[&apos;./Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;--bot-id=cr-jail-7&apos;, &apos;build-...&quot; exit_code: 2

Last 500 characters of output:
.......................................................................................................................................................................................................................
inspector ...........
inspector/audits .
inspector/audits/audits-panel-functional.html -&gt; failed

Exiting early after 1 failures. 12761 tests run.
301.30s total testing time

12760 test cases (99%) succeeded
1 test case (&lt;1%) had incorrect layout
8 test cases (&lt;1%) had stderr output

Full output: http://queues.webkit.org/results/8082846</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363748</commentid>
    <comment_count>12</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2011-03-07 18:33:02 -0800</bug_when>
    <thetext>Committed r80523: &lt;http://trac.webkit.org/changeset/80523&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>84619</attachid>
            <date>2011-03-03 13:54:33 -0800</date>
            <delta_ts>2011-03-03 15:18:25 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>textmate stdin Bts5SO.txt</filename>
            <type>text/plain</type>
            <size>2672</size>
            <attacher name="Damian Kaleta">dkaleta</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n
CShyZXZpc2lvbiA4MDI4MSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMDMgIERhbWlhbiBLYWxldGEgIDxka2FsZXRhQGFwcGxl
LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO
b3QgYWxsIHBsdWdpbnMgc2hvdWxkIGJlIG9wdCBvdXQgb2YgMzItYml0IE5YCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTcwNAorICAgICAgICA8cmRh
cjovL3Byb2JsZW0vODEwNTcwNj4KKworICAgICAgICAqIFVJUHJvY2Vzcy9QbHVnaW5zL1BsdWdp
blByb2Nlc3NQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblByb2Nlc3NQcm94eTo6
UGx1Z2luUHJvY2Vzc1Byb3h5KToKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luUHJvY2Vzc1Byb3h5
OjpwbHVnaW5OZWVkc0V4ZWN1dGFibGVIZWFwKTogQWRkZWQuIE1pY3Jvc29mdCBTaWx2ZXJsaWdo
dCBhbmQgUXVpY2sgVGltZSBwbHVnaW5zIHNob3VsZCBvcHQgaW4sIAorICAgICAgICB0aGUgcmVz
dCBzaG91bGQgb3B0IG91dCBvZiAzMi1iaXQgTlguCisgICAgICAgICogVUlQcm9jZXNzL1BsdWdp
bnMvUGx1Z2luUHJvY2Vzc1Byb3h5Lmg6CisKIDIwMTEtMDMtMDMgIE1hY2llaiBTdGFjaG93aWFr
ICA8bWpzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBCcmFkeSBFaWRzb24uCklu
ZGV4OiBXZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb2Nlc3NQcm94eS5jcHAKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzUHJveHku
Y3BwCShyZXZpc2lvbiA4MDI4MSkKKysrIFdlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvUGx1Z2lu
UHJvY2Vzc1Byb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTMsOSArNTMsNyBAQAogICAgIGxh
dW5jaE9wdGlvbnMucHJvY2Vzc1R5cGUgPSBQcm9jZXNzTGF1bmNoZXI6OlBsdWdpblByb2Nlc3M7
CiAjaWYgUExBVEZPUk0oTUFDKQogICAgIGxhdW5jaE9wdGlvbnMuYXJjaGl0ZWN0dXJlID0gcGx1
Z2luSW5mby5wbHVnaW5BcmNoaXRlY3R1cmU7Ci0KLSAgICAvLyBGSVhNRTogVGhpcyBzaG91bGRu
J3QgYmUgdHJ1ZSBmb3IgYWxsIHBsdWctaW5zLgotICAgIGxhdW5jaE9wdGlvbnMuZXhlY3V0YWJs
ZUhlYXAgPSB0cnVlOworICAgIGxhdW5jaE9wdGlvbnMuZXhlY3V0YWJsZUhlYXAgPSBwbHVnaW5O
ZWVkc0V4ZWN1dGFibGVIZWFwKHBsdWdpbkluZm8pOwogI2VuZGlmCiAKICAgICBtX3Byb2Nlc3NM
YXVuY2hlciA9IFByb2Nlc3NMYXVuY2hlcjo6Y3JlYXRlKHRoaXMsIGxhdW5jaE9wdGlvbnMpOwpA
QCAtMjE5LDYgKzIxNywxNiBAQAogICAgIAogICAgIHdlYlBsdWdpblNpdGVEYXRhTWFuYWdlci0+
ZGlkQ2xlYXJTaXRlRGF0YUZvclNpbmdsZVBsdWdpbihjYWxsYmFja0lEKTsKIH0KKyAKKyNpZiBQ
TEFURk9STShNQUMpCitib29sIFBsdWdpblByb2Nlc3NQcm94eTo6cGx1Z2luTmVlZHNFeGVjdXRh
YmxlSGVhcChjb25zdCBQbHVnaW5JbmZvU3RvcmU6OlBsdWdpbiYgcGx1Z2luSW5mbykgY29uc3QK
K3sKKyAgICBpZiAocGx1Z2luSW5mby5idW5kbGVJZGVudGlmaWVyID09ICJjb20uYXBwbGUuUXVp
Y2tUaW1lIFBsdWdpbi5wbHVnaW4iIHx8IHBsdWdpbkluZm8uYnVuZGxlSWRlbnRpZmllciA9PSAi
Y29tLm1pY3Jvc29mdC5TaWx2ZXJsaWdodFBsdWdpbiIpCisgICAgICAgIHJldHVybiB0cnVlOwor
ICAgIAorICAgIHJldHVybiBmYWxzZTsKK30KKyNlbmRpZgogCiB9IC8vIG5hbWVzcGFjZSBXZWJL
aXQKIApJbmRleDogV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzUHJveHku
aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBXZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb2Nlc3NQ
cm94eS5oCShyZXZpc2lvbiA4MDI4MSkKKysrIFdlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvUGx1
Z2luUHJvY2Vzc1Byb3h5LmgJKHdvcmtpbmcgY29weSkKQEAgLTgwLDYgKzgwLDEwIEBACiAgICAg
dm9pZCBkaWRDcmVhdGVXZWJQcm9jZXNzQ29ubmVjdGlvbihjb25zdCBDb3JlSVBDOjpNYWNoUG9y
dCYpOwogICAgIHZvaWQgZGlkR2V0U2l0ZXNXaXRoRGF0YShjb25zdCBWZWN0b3I8U3RyaW5nPiYg
c2l0ZXMsIHVpbnQ2NF90IGNhbGxiYWNrSUQpOwogICAgIHZvaWQgZGlkQ2xlYXJTaXRlRGF0YSh1
aW50NjRfdCBjYWxsYmFja0lEKTsKKyAgICAKKyNpZiBQTEFURk9STShNQUMpCisgICAgYm9vbCBw
bHVnaW5OZWVkc0V4ZWN1dGFibGVIZWFwKGNvbnN0IFBsdWdpbkluZm9TdG9yZTo6UGx1Z2luJikg
Y29uc3Q7CisjZW5kaWYKIAogICAgIHZvaWQgcGxhdGZvcm1Jbml0aWFsaXplUGx1Z2luUHJvY2Vz
cyhQbHVnaW5Qcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzKTsKIAo=
</data>
<flag name="review"
          id="76631"
          type_id="1"
          status="-"
          setter="andersca"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>84638</attachid>
            <date>2011-03-03 15:18:25 -0800</date>
            <delta_ts>2011-03-04 09:53:07 -0800</delta_ts>
            <desc>Proposed patch.</desc>
            <filename>textmate stdin R99IKD.txt</filename>
            <type>text/plain</type>
            <size>2087</size>
            <attacher name="Damian Kaleta">dkaleta</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwMjg4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMDMgIERhbWlhbiBL
YWxldGEgIDxka2FsZXRhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBOb3QgYWxsIHBsdWdpbnMgc2hvdWxkIGJlIG9wdGVkIG91dCBv
ZiAzMi1iaXQgTlgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTU1NzA0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84MTA1NzA2PgorCisgICAgICAgICog
VUlQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc1Byb3h5LmNwcDoKKyAgICAgICAgKFdlYktp
dDo6cGx1Z2luTmVlZHNFeGVjdXRhYmxlSGVhcCk6IEFkZGVkLiBNaWNyb3NvZnQgU2lsdmVybGln
aHQgYW5kIFF1aWNrIFRpbWUgcGx1Z2lucyBzaG91bGQgb3B0IGluLCAKKyAgICAgICAgdGhlIHJl
c3Qgc2hvdWxkIG9wdCBvdXQgb2YgMzItYml0IE5YLgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5Q
cm9jZXNzUHJveHk6OlBsdWdpblByb2Nlc3NQcm94eSk6CisKIDIwMTEtMDMtMDMgIE1hY2llaiBT
dGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBCcmFkeSBF
aWRzb24uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9j
ZXNzUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVn
aW5zL1BsdWdpblByb2Nlc3NQcm94eS5jcHAJKHJldmlzaW9uIDgwMjgxKQorKysgU291cmNlL1dl
YktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc1Byb3h5LmNwcAkod29ya2luZyBj
b3B5KQpAQCAtMzgsNiArMzgsMTYgQEAKICNpbmNsdWRlICJXZWJQcm9jZXNzUHJveHkuaCIKIAog
bmFtZXNwYWNlIFdlYktpdCB7CisgICAgCisjaWYgUExBVEZPUk0oTUFDKQorc3RhdGljIGJvb2wg
cGx1Z2luTmVlZHNFeGVjdXRhYmxlSGVhcChjb25zdCBQbHVnaW5JbmZvU3RvcmU6OlBsdWdpbiYg
cGx1Z2luSW5mbykKK3sKKyAgICBpZiAocGx1Z2luSW5mby5idW5kbGVJZGVudGlmaWVyID09ICJj
b20uYXBwbGUuUXVpY2tUaW1lIFBsdWdpbi5wbHVnaW4iIHx8IHBsdWdpbkluZm8uYnVuZGxlSWRl
bnRpZmllciA9PSAiY29tLm1pY3Jvc29mdC5TaWx2ZXJsaWdodFBsdWdpbiIpCisgICAgICAgIHJl
dHVybiB0cnVlOworICAgIAorICAgIHJldHVybiBmYWxzZTsKK30KKyNlbmRpZgogCiBQYXNzT3du
UHRyPFBsdWdpblByb2Nlc3NQcm94eT4gUGx1Z2luUHJvY2Vzc1Byb3h5OjpjcmVhdGUoUGx1Z2lu
UHJvY2Vzc01hbmFnZXIqIFBsdWdpblByb2Nlc3NNYW5hZ2VyLCBjb25zdCBQbHVnaW5JbmZvU3Rv
cmU6OlBsdWdpbiYgcGx1Z2luSW5mbykKIHsKQEAgLTUzLDkgKzYzLDcgQEAgUGx1Z2luUHJvY2Vz
c1Byb3h5OjpQbHVnaW5Qcm9jZXNzUHJveHkoUAogICAgIGxhdW5jaE9wdGlvbnMucHJvY2Vzc1R5
cGUgPSBQcm9jZXNzTGF1bmNoZXI6OlBsdWdpblByb2Nlc3M7CiAjaWYgUExBVEZPUk0oTUFDKQog
ICAgIGxhdW5jaE9wdGlvbnMuYXJjaGl0ZWN0dXJlID0gcGx1Z2luSW5mby5wbHVnaW5BcmNoaXRl
Y3R1cmU7Ci0KLSAgICAvLyBGSVhNRTogVGhpcyBzaG91bGRuJ3QgYmUgdHJ1ZSBmb3IgYWxsIHBs
dWctaW5zLgotICAgIGxhdW5jaE9wdGlvbnMuZXhlY3V0YWJsZUhlYXAgPSB0cnVlOworICAgIGxh
dW5jaE9wdGlvbnMuZXhlY3V0YWJsZUhlYXAgPSBwbHVnaW5OZWVkc0V4ZWN1dGFibGVIZWFwKHBs
dWdpbkluZm8pOwogI2VuZGlmCiAKICAgICBtX3Byb2Nlc3NMYXVuY2hlciA9IFByb2Nlc3NMYXVu
Y2hlcjo6Y3JlYXRlKHRoaXMsIGxhdW5jaE9wdGlvbnMpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>84766</attachid>
            <date>2011-03-04 09:53:07 -0800</date>
            <delta_ts>2011-03-04 18:14:29 -0800</delta_ts>
            <desc>Proposed patch.</desc>
            <filename>textmate stdin OO0d5m.txt</filename>
            <type>text/plain</type>
            <size>2025</size>
            <attacher name="Damian Kaleta">dkaleta</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwMzYxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMDQgIERhbWlhbiBL
YWxldGEgIDxka2FsZXRhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBRdWlja1RpbWUgcGx1Z2luIHNob3VsZCBvcHQgaW4gdG8gYSAz
Mi1iaXQgbm9uLWV4ZWN1dGFibGUgaGVhcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9NTU3MDQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgxMDU3MDY+
CisKKyAgICAgICAgKiBVSVByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzUHJveHkuY3BwOgor
ICAgICAgICAoV2ViS2l0OjpwbHVnaW5OZWVkc0V4ZWN1dGFibGVIZWFwKTogRGVjaWRlcyBwZXIg
cGx1Z2luIGlmIGl0IHNob3VsZCBvcHQtaW4gdG8gYSAzMi1iaXQgbm9uLWV4ZWN1dGFibGUgaGVh
cC4KKyAgICAgICAgQnkgZGVmYXVsdCBpdCBzaG91bGQgb3B0LW91dC4KKyAgICAgICAgKFdlYktp
dDo6UGx1Z2luUHJvY2Vzc1Byb3h5OjpQbHVnaW5Qcm9jZXNzUHJveHkpOgorCiAyMDExLTAzLTA0
ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgTExWTSBDb21waWxl
ciBidWlsZCBmaXguCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9QbHVn
aW5Qcm9jZXNzUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz
cy9QbHVnaW5zL1BsdWdpblByb2Nlc3NQcm94eS5jcHAJKHJldmlzaW9uIDgwMzYxKQorKysgU291
cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc1Byb3h5LmNwcAkod29y
a2luZyBjb3B5KQpAQCAtMzgsNiArMzgsMTYgQEAKICNpbmNsdWRlICJXZWJQcm9jZXNzUHJveHku
aCIKIAogbmFtZXNwYWNlIFdlYktpdCB7CisgICAgCisjaWYgUExBVEZPUk0oTUFDKQorc3RhdGlj
IGJvb2wgcGx1Z2luTmVlZHNFeGVjdXRhYmxlSGVhcChjb25zdCBQbHVnaW5JbmZvU3RvcmU6OlBs
dWdpbiYgcGx1Z2luSW5mbykKK3sKKyAgICBpZiAocGx1Z2luSW5mby5idW5kbGVJZGVudGlmaWVy
ID09ICJjb20uYXBwbGUuUXVpY2tUaW1lIFBsdWdpbi5wbHVnaW4iKQorICAgICAgICByZXR1cm4g
ZmFsc2U7CisgICAgCisgICAgcmV0dXJuIHRydWU7Cit9CisjZW5kaWYKIAogUGFzc093blB0cjxQ
bHVnaW5Qcm9jZXNzUHJveHk+IFBsdWdpblByb2Nlc3NQcm94eTo6Y3JlYXRlKFBsdWdpblByb2Nl
c3NNYW5hZ2VyKiBQbHVnaW5Qcm9jZXNzTWFuYWdlciwgY29uc3QgUGx1Z2luSW5mb1N0b3JlOjpQ
bHVnaW4mIHBsdWdpbkluZm8pCiB7CkBAIC01Myw5ICs2Myw3IEBAIFBsdWdpblByb2Nlc3NQcm94
eTo6UGx1Z2luUHJvY2Vzc1Byb3h5KFAKICAgICBsYXVuY2hPcHRpb25zLnByb2Nlc3NUeXBlID0g
UHJvY2Vzc0xhdW5jaGVyOjpQbHVnaW5Qcm9jZXNzOwogI2lmIFBMQVRGT1JNKE1BQykKICAgICBs
YXVuY2hPcHRpb25zLmFyY2hpdGVjdHVyZSA9IHBsdWdpbkluZm8ucGx1Z2luQXJjaGl0ZWN0dXJl
OwotCi0gICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkbid0IGJlIHRydWUgZm9yIGFsbCBwbHVnLWlu
cy4KLSAgICBsYXVuY2hPcHRpb25zLmV4ZWN1dGFibGVIZWFwID0gdHJ1ZTsKKyAgICBsYXVuY2hP
cHRpb25zLmV4ZWN1dGFibGVIZWFwID0gcGx1Z2luTmVlZHNFeGVjdXRhYmxlSGVhcChwbHVnaW5J
bmZvKTsKICNlbmRpZgogCiAgICAgbV9wcm9jZXNzTGF1bmNoZXIgPSBQcm9jZXNzTGF1bmNoZXI6
OmNyZWF0ZSh0aGlzLCBsYXVuY2hPcHRpb25zKTsK
</data>
<flag name="review"
          id="76796"
          type_id="1"
          status="+"
          setter="andersca"
    />
    <flag name="commit-queue"
          id="76797"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
      

    </bug>

</bugzilla>