55703 2011-03-03 13:27:02 -0800 [GStreamer] When seeking webKitWebSrcStop release the frame but should not. 2011-03-11 09:09:49 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 menard webkit-unassigned commit-queue gustavo mrobinson pnormand oldest_to_newest 361890 0 menard 2011-03-03 13:27:02 -0800 When calling webKitWebSrcStop in case of a seeking, the frame should not be reset (the source hasn't change). The frame may be used to get the network context. Some network stack (like Qt) are relaying on the network context. 361893 1 84616 menard 2011-03-03 13:28:29 -0800 Created attachment 84616 Proposed patch. 365894 2 pnormand 2011-03-11 02:16:55 -0800 This patch looks harmless :) I tested it on GTK, runned the media tests fine and did testing on Vimeo and Youtube and had no problem. The frame will now only be released on seek errors and in the PAUSED to READY transition, which sounds fine to me. 365897 3 pnormand 2011-03-11 02:23:52 -0800 If the commit-queue lands this it might have issues with the ChangeLog as the patch doesn't seem to be based on HEAD, right? 365910 4 menard 2011-03-11 03:15:19 -0800 (In reply to comment #3) > If the commit-queue lands this it might have issues with the ChangeLog as the patch doesn't seem to be based on HEAD, right? I don't think so. It has some magic stuff for the changelogs :) 365918 5 pnormand 2011-03-11 04:05:02 -0800 CCing possible reviewers 366031 6 84616 commit-queue 2011-03-11 09:09:45 -0800 Comment on attachment 84616 Proposed patch. Clearing flags on attachment: 84616 Committed r80854: <http://trac.webkit.org/changeset/80854> 366032 7 commit-queue 2011-03-11 09:09:49 -0800 All reviewed patches have been landed. Closing bug. 84616 2011-03-03 13:28:29 -0800 2011-03-11 09:09:45 -0800 Proposed patch. patch2.diff text/plain 1573 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzM2MyMWYxLi5hOTUxNjM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTEtMDMtMDMgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5v cmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dT dHJlYW1lcl0gV2hlbiBzZWVraW5nIHdlYktpdFdlYlNyY1N0b3AgcmVsZWFzZSB0aGUgZnJhbWUg YnV0IHNob3VsZCBub3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01NTcwMworCisgICAgICAgIFdoZW4gY2FsbGluZyB3ZWJLaXRXZWJTcmNTdG9wIGlu IGNhc2Ugb2YgYSBzZWVraW5nLCB0aGUgZnJhbWUgc2hvdWxkIG5vdAorICAgICAgICBiZSByZXNl dCAodGhlIHNvdXJjZSBoYXNuJ3QgY2hhbmdlKS4gVGhlIGZyYW1lIG1heSBiZSB1c2VkIHRvIGdl dCB0aGUgbmV0d29yaworICAgICAgICBjb250ZXh0LiBTb21lIG5ldHdvcmsgc3RhY2sgKGxpa2Ug UXQpIGFyZSByZWxheWluZyBvbiB0aGUgbmV0d29yayBjb250ZXh0CisgICAgICAgIHRvIHdvcmsu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNl R1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKHdlYktpdFdlYlNyY1N0b3ApOgorCisyMDExLTAzLTAz ICBBbGV4aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCiAgICAgICAg IFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCiAKICAgICAgICAgV2hlbiBidWlsZGluZyB3aXRo IERFRklORVMrPVVTRV9HU1RSRUFNRVI9MSB3ZSBkb24ndCB3YW50IHRvIGRlZmluZSBFTkFCTEVf UVRfTVVMVElNRURJQSB0byAxLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVh bWVyLmNwcAppbmRleCA4NmUzZTdhLi42NmVhOWJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0 V2ViU291cmNlR1N0cmVhbWVyLmNwcApAQCAtMzUyLDcgKzM1Miw3IEBAIHN0YXRpYyB2b2lkIHdl YktpdFdlYlNyY1N0b3AoV2ViS2l0V2ViU3JjKiBzcmMsIGJvb2wgc2Vla2luZykKICAgICB9CiAg ICAgcHJpdi0+cmVzb3VyY2VIYW5kbGUgPSAwOwogCi0gICAgaWYgKHByaXYtPmZyYW1lKQorICAg IGlmIChwcml2LT5mcmFtZSAmJiAhc2Vla2luZykKICAgICAgICAgcHJpdi0+ZnJhbWUucmVsZWFz ZSgpOwogCiAgICAgR1NUX09CSkVDVF9MT0NLKHNyYyk7Cg==