55702 2011-03-03 13:14:22 -0800 Scrubbing <video> with HTTP Live Stream resizes element to 0x0 2011-03-23 17:59:49 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED http://events.apple.com.edgesuite.net/1103pijanbdvaaj/event/index.html InRadar, PlatformOnly P2 Normal --- 1 jer.noble jer.noble eric.carlson simon.fraser oldest_to_newest 361883 0 jer.noble 2011-03-03 13:14:22 -0800 Scrubbing the iPad2 - march 2 event keynote video in Safari on Snow Leopard kills video presentation. 361884 1 jer.noble 2011-03-03 13:14:36 -0800 <rdar://problem/9078563> 361913 2 84620 jer.noble 2011-03-03 13:59:14 -0800 Created attachment 84620 Patch 361921 3 84620 simon.fraser 2011-03-03 14:06:42 -0800 Comment on attachment 84620 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84620&action=review > Source/WebCore/ChangeLog:9 > + a HTTP Live Stream. So we will cache the last valid value returned by QTKit "an HTTP Live Stream"? > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.h:211 > + FloatSize m_cachedNaturalSize; You could make this mutable. > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:232 > + , m_cachedNaturalSize(FloatSize()) No need to initialize; FloatSize has its own ctor. 361994 4 jer.noble 2011-03-03 15:15:27 -0800 (In reply to comment #3) > (From update of attachment 84620 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=84620&action=review > > > Source/WebCore/ChangeLog:9 > > + a HTTP Live Stream. So we will cache the last valid value returned by QTKit > > "an HTTP Live Stream"? http://owl.english.purdue.edu/owl/resource/540/01/ I guess it depends on whether you pronounce it "aich tee tee pee" or "haich tee tee pee". :-D > > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.h:211 > > + FloatSize m_cachedNaturalSize; > > You could make this mutable. Fantastic idea. > > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:232 > > + , m_cachedNaturalSize(FloatSize()) > > No need to initialize; FloatSize has its own actor. Sure. Thanks! 372580 5 jer.noble 2011-03-23 17:59:49 -0700 Committed r81833: <http://trac.webkit.org/changeset/81833> 84620 2011-03-03 13:59:14 -0800 2011-03-03 14:06:42 -0800 Patch bug-55702-20110303135913.patch text/plain 3820 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogNzgzODIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3NDJiOTU1ZDZhY2NlMzNi OWMzNTI4ZGJjMDdhNWY2ZjUyZmVkNmQwLi5hMTg3MTA2N2IzYzZkYzFhY2RiZmQ1NDU1ODE0NDI1 ODhlNmNkODljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDMtMDMgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU2NydWJiaW5nIDx2aWRlbz4gd2l0aCBIVFRQIExpdmUgU3Ry ZWFtIHJlc2l6ZXMgZWxlbWVudCB0byAweDAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTU1NzAyCisKKyAgICAgICAgUVRLaXQgd2lsbCBvY2Nhc2lvbmFs bHkgc2V0IHRoZSBuYXR1cmFsIHNpemUgb2YgYSBRVE1vdmllIHRvIDB4MCB3aGlsZSBzY3J1YmJp bmcKKyAgICAgICAgYSBIVFRQIExpdmUgU3RyZWFtLiAgU28gd2Ugd2lsbCBjYWNoZSB0aGUgbGFz dCB2YWxpZCB2YWx1ZSByZXR1cm5lZCBieSBRVEtpdAorICAgICAgICBhbmQgdXNlIHRoYXQgYXMg b3VyIG5hdHVyYWxTaXplIHVudGlsIGEgbmV3IHZhbGlkIHZhbHVlIGlzIHJldHVybmVkLgorCisg ICAgICAgIFVuZm9ydHVuYXRlbHksIFFUS2l0IHdpbGwgYWxzbyBmYWlsIHRvIGdlbmVyYXRlIGEg bm90aWZpY2F0aW9uIHdoZW4gdGhlIG5hdHVyYWwgc2l6ZQorICAgICAgICBjaGFuZ2VzLCBzbyB3 ZSBhcmUgZm9yY2VkIHRvIGNhY2hlIHRoZSBuYXR1cmFsIHNpemUgZnJvbSB3aXRoaW4gbmF0dXJh bFNpemUoKSwgd2hpY2gKKyAgICAgICAgaXMgYSBjb25zdCBmdW5jdGlvbiwgbmVjZXNzaXRhdGlu ZyBhIGNvbnN0X2Nhc3QgdG8gc2V0IG1fY2FjaGVkTmF0dXJhbFNpemUuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQuaDogQWRkZWQgbV9j YWNoZWROYXR1cmFsU2l6ZS4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQ bGF5ZXJQcml2YXRlUVRLaXQubW06CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZh dGVRVEtpdDo6TWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQpOiBJbml0aWFsaXplIG1fY2FjaGVkTmF0 dXJhbFNpemUuCisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVRVEtpdDo6bmF0 dXJhbFNpemUpOiAKKwogMjAxMS0wMi0xMSAgTWlrZSBSZWVkICA8cmVlZEBnb29nbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0Lmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRl UVRLaXQuaAppbmRleCA5NWFiNDU2YjZhMTFkNDc5NWNjOWUwM2QxYWU0N2ZjZjIwNmNhOWRiLi5j ZThkOGUyYzk3OTI2Mjc4NDA4MjdjNzczMGY5NWVmN2UzYWQyMGE3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQ cml2YXRlUVRLaXQuaApAQCAtMjA4LDYgKzIwOCw3IEBAIHByaXZhdGU6CiAgICAgZG91YmxlIG1f dGltZVN0YXJ0ZWRQbGF5aW5nOwogICAgIGRvdWJsZSBtX3RpbWVTdG9wcGVkUGxheWluZzsKICNl bmRpZgorICAgIEZsb2F0U2l6ZSBtX2NhY2hlZE5hdHVyYWxTaXplOwogfTsKIAogfQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJp dmF0ZVFUS2l0Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlh UGxheWVyUHJpdmF0ZVFUS2l0Lm1tCmluZGV4IDhiMWZiOTI0YzcwM2Y4NzU0ZWVmN2YwNmJjYjJm NDk5ZTA2YTkxMjMuLmYxZGUwYjI2NzYyY2JjMjE3NTJiNTg5NzQxMTdkYTU5ZTBkMzBjZmIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXll clByaXZhdGVRVEtpdC5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9t YWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW0KQEAgLTIyOSw2ICsyMjksNyBAQCBNZWRpYVBs YXllclByaXZhdGVRVEtpdDo6TWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQoTWVkaWFQbGF5ZXIqIHBs YXllcikKICAgICAsIG1fdGltZVN0YXJ0ZWRQbGF5aW5nKDApCiAgICAgLCBtX3RpbWVTdG9wcGVk UGxheWluZygwKQogI2VuZGlmCisgICAgLCBtX2NhY2hlZE5hdHVyYWxTaXplKEZsb2F0U2l6ZSgp KQogewogfQogCkBAIC04MjUsOCArODI2LDE5IEBAIEludFNpemUgTWVkaWFQbGF5ZXJQcml2YXRl UVRLaXQ6Om5hdHVyYWxTaXplKCkgY29uc3QKICAgICAvLyAgICBkaW1lbnNpb25zLCBhc3BlY3Qg cmF0aW8sIGNsZWFuIGFwZXJ0dXJlLCByZXNvbHV0aW9uLCBhbmQgc28gZm9ydGgsIGFzIGRlZmlu ZWQgZm9yIHRoZSAKICAgICAvLyAgICBmb3JtYXQgdXNlZCBieSB0aGUgcmVzb3VyY2UKICAgICAK LSAgICBOU1NpemUgbmF0dXJhbFNpemUgPSBbW21fcXRNb3ZpZS5nZXQoKSBhdHRyaWJ1dGVGb3JL ZXk6UVRNb3ZpZU5hdHVyYWxTaXplQXR0cmlidXRlXSBzaXplVmFsdWVdOwotICAgIHJldHVybiBJ bnRTaXplKG5hdHVyYWxTaXplLndpZHRoICogbV9zY2FsZUZhY3Rvci53aWR0aCgpLCBuYXR1cmFs U2l6ZS5oZWlnaHQgKiBtX3NjYWxlRmFjdG9yLmhlaWdodCgpKTsKKyAgICBGbG9hdFNpemUgbmF0 dXJhbFNpemUoW1ttX3F0TW92aWUuZ2V0KCkgYXR0cmlidXRlRm9yS2V5OlFUTW92aWVOYXR1cmFs U2l6ZUF0dHJpYnV0ZV0gc2l6ZVZhbHVlXSk7CisgICAgaWYgKG5hdHVyYWxTaXplLmlzRW1wdHko KSAmJiBtX2lzU3RyZWFtaW5nKSB7CisgICAgICAgIC8vIEhUVFAgTGl2ZSBTdHJlYW1zIHdpbGwg b2NjYXNpb25hbGx5IHJldHVybiB7MCwwfSBuYXR1cmFsIHNpemVzIHdoaWxlIHNjcnViYmluZy4K KyAgICAgICAgLy8gV29yayBhcm91bmQgdGhpcyBwcm9ibGVtICg8cmRhcjovL3Byb2JsZW0vOTA3 ODU2Mz4pIGJ5IHJldHVybmluZyB0aGUgbGFzdCB2YWxpZCAKKyAgICAgICAgLy8gY2FjaGVkIG5h dHVyYWwgc2l6ZToKKyAgICAgICAgbmF0dXJhbFNpemUgPSBtX2NhY2hlZE5hdHVyYWxTaXplOwor ICAgIH0gZWxzZSB7CisgICAgICAgIC8vIFVuZm9ydHVuYXRlbHksIGR1ZSB0byBhbm90aGVyIFFU S2l0IGJ1ZyAoPHJkYXI6Ly9wcm9ibGVtLzkwODIwNzE+KSB3ZSB3b24ndCBnZXQgYSBzaXplQ2hh bmdlZAorICAgICAgICAvLyBldmVudCB3aGVuIHRoaXMgaGFwcGVucywgc28gd2UgbXVzdCBjYWNo ZSB0aGUgbGFzdCB2YWxpZCBuYXR1cmFsU2l6ZSBoZXJlOgorICAgICAgICBjb25zdF9jYXN0PEZs b2F0U2l6ZSY+KG1fY2FjaGVkTmF0dXJhbFNpemUpID0gbmF0dXJhbFNpemU7CisgICAgfQorICAg ICAgICAKKyAgICByZXR1cm4gSW50U2l6ZShuYXR1cmFsU2l6ZS53aWR0aCgpICogbV9zY2FsZUZh Y3Rvci53aWR0aCgpLCBuYXR1cmFsU2l6ZS5oZWlnaHQoKSAqIG1fc2NhbGVGYWN0b3IuaGVpZ2h0 KCkpOwogfQogCiBib29sIE1lZGlhUGxheWVyUHJpdmF0ZVFUS2l0OjpoYXNWaWRlbygpIGNvbnN0 Cg==