55697 2011-03-03 12:10:38 -0800 Assertion failure in toElement(WebCore::Node*) 2011-03-03 21:15:25 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED http://websocket.org/echo.html P2 Major --- 1 ap aestes abarth aestes commit-queue eric oldest_to_newest 361821 0 ap 2011-03-03 12:10:38 -0800 Steps to reproduce: open http://websocket.org/echo.html ASSERTION FAILED: !node || node->isElementNode() /Users/ap/Safari/OpenSource/Source/WebCore/dom/Element.h(413) : WebCore::Element* WebCore::toElement(WebCore::Node*) 1 WebCore::toElement(WebCore::Node*) 2 WebCore::HTMLElementStack::ElementRecord::element() const 3 WebCore::HTMLElementStack::top() const 4 WebCore::HTMLConstructionSite::currentElement() const 5 WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken(WebCore::AtomicHTMLToken&) 6 WebCore::HTMLTreeBuilder::constructTreeFromToken(WebCore::HTMLToken&) 7 WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) 8 WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode) 9 WebCore::HTMLDocumentParser::insert(WebCore::SegmentedString const&) 10 WebCore::HTMLDocumentParser::parseDocumentFragment(WTF::String const&, WebCore::DocumentFragment*, WebCore::Element*, WebCore::FragmentScriptingPermission) 11 WebCore::DocumentFragment::parseHTML(WTF::String const&, WebCore::Element*, WebCore::FragmentScriptingPermission) 12 WebCore::createFragmentFromSource(WTF::String const&, WebCore::Element*, int&) 13 WebCore::HTMLElement::setInnerHTML(WTF::String const&, int&) 14 WebCore::setJSHTMLElementInnerHTML(JSC::ExecState*, JSC::JSObject*, JSC::JSValue) 15 bool JSC::lookupPut<WebCore::JSHTMLElement>(JSC::ExecState*, JSC::Identifier const&, JSC::JSValue, JSC::HashTable const*, WebCore::JSHTMLElement*) 16 void JSC::lookupPut<WebCore::JSHTMLElement, WebCore::JSElement>(JSC::ExecState*, JSC::Identifier const&, JSC::JSValue, JSC::HashTable const*, WebCore::JSHTMLElement*, JSC::PutPropertySlot&) 17 WebCore::JSHTMLElement::put(JSC::ExecState*, JSC::Identifier const&, JSC::JSValue, JSC::PutPropertySlot&) 18 void JSC::lookupPut<WebCore::JSHTMLDivElement, WebCore::JSHTMLElement>(JSC::ExecState*, JSC::Identifier const&, JSC::JSValue, JSC::HashTable const*, WebCore::JSHTMLDivElement*, JSC::PutPropertySlot&) 19 WebCore::JSHTMLDivElement::put(JSC::ExecState*, JSC::Identifier const&, JSC::JSValue, JSC::PutPropertySlot&) 20 JSC::JSValue::put(JSC::ExecState*, JSC::Identifier const&, JSC::JSValue, JSC::PutPropertySlot&) 21 cti_op_put_by_id 22 jscGeneratedNativeCode 23 JSC::JITCode::execute(JSC::RegisterFile*, JSC::ExecState*, JSC::JSGlobalData*) 24 JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::ScopeChainNode*, JSC::JSObject*) 25 JSC::evaluate(JSC::ExecState*, JSC::ScopeChainNode*, JSC::SourceCode const&, JSC::JSValue) 26 WebCore::JSMainThreadExecState::evaluate(JSC::ExecState*, JSC::ScopeChainNode*, JSC::SourceCode const&, JSC::JSValue) 27 WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld*) 28 WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) 29 WebCore::ScriptElement::executeScript(WebCore::ScriptSourceCode const&) 30 WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent(WebCore::PendingScript&) 31 WebCore::HTMLScriptRunner::executeParsingBlockingScript() 361916 1 84621 aestes 2011-03-03 14:03:03 -0800 Created attachment 84621 Test case Attached a reduction. This happens when the root node of a fragment is foreign content. This is simple to fix. 361929 2 84625 aestes 2011-03-03 14:13:31 -0800 Created attachment 84625 Patch 361930 3 84625 eric 2011-03-03 14:16:59 -0800 Comment on attachment 84625 Patch Thanks. 362246 4 84625 commit-queue 2011-03-03 21:15:20 -0800 Comment on attachment 84625 Patch Clearing flags on attachment: 84625 Committed r80320: <http://trac.webkit.org/changeset/80320> 362247 5 commit-queue 2011-03-03 21:15:25 -0800 All reviewed patches have been landed. Closing bug. 84621 2011-03-03 14:03:03 -0800 2011-03-03 14:03:03 -0800 Test case fragment-foreign-content.html text/html 63 aestes PGJvZHk+CjxzY3JpcHQ+CmRvY3VtZW50LmJvZHkuaW5uZXJIVE1MICs9ICI8c3ZnIC8+IjsKPC9z Y3JpcHQ+ 84625 2011-03-03 14:13:31 -0800 2011-03-03 21:15:20 -0800 Patch bug-55697-20110303141330.patch text/plain 3608 aestes SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwMjgzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMDMgIEFuZHkgRXN0 ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFzc2VydGlvbiBmYWlsdXJlIGluIHRvRWxlbWVudChXZWJDb3JlOjpO b2RlKikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1 Njk3CisKKyAgICAgICAgVGVzdDogZmFzdC9wYXJzZXIvZnJhZ21lbnQtZm9yZWlnbi1jb250ZW50 Lmh0bWwKKworICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OmNvbnN0cnVjdFRyZWVGcm9tQXRvbWljVG9r ZW4pOiBUaGUgY3VycmVudAorICAgICAgICBlbGVtZW50IGluIHRoZSBIVE1MRWxlbWVudFN0YWNr IG1pZ2h0IGJlIGEgRG9jdW1lbnRGcmFnbWVudCBpZiBhCisgICAgICAgIGZyYWdtZW50IGlzIGJl aW5nIHBhcnNlZCB3aG8ncyBmaXJzdCBub2RlIGlzIGZvcmVpZ24gY29udGVudC4KKwogMjAxMS0w My0wMyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3Jl IGJ1aWxkIGZpeGluZy4gTW92ZSBXZWJDb3JlS2V5Ym9hcmRVSU1vZGUuaCB0byBhIGNyb3NzLXBs YXRmb3JtIGxvY2F0aW9uLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRy ZWVCdWlsZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9I VE1MVHJlZUJ1aWxkZXIuY3BwCShyZXZpc2lvbiA4MDIzMSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0 bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0NSw3ICs0 NDUsNyBAQCB2b2lkIEhUTUxUcmVlQnVpbGRlcjo6Y29uc3RydWN0VHJlZUZyb21BCiAgICAgLy8g dGhlIFUrMDAwMCBjaGFyYWN0ZXJzIGludG8gcmVwbGFjZW1lbnQgY2hhcmFjdGVycyBoYXMgY29t cGF0aWJpbGl0eQogICAgIC8vIHByb2JsZW1zLgogICAgIG1fcGFyc2VyLT50b2tlbml6ZXIoKS0+ c2V0Rm9yY2VOdWxsQ2hhcmFjdGVyUmVwbGFjZW1lbnQobV9pbnNlcnRpb25Nb2RlID09IFRleHRN b2RlIHx8IG1faW5zZXJ0aW9uTW9kZSA9PSBJbkZvcmVpZ25Db250ZW50TW9kZSk7Ci0gICAgbV9w YXJzZXItPnRva2VuaXplcigpLT5zZXRTaG91bGRBbGxvd0NEQVRBKG1faW5zZXJ0aW9uTW9kZSA9 PSBJbkZvcmVpZ25Db250ZW50TW9kZSAmJiBtX3RyZWUuY3VycmVudEVsZW1lbnQoKS0+bmFtZXNw YWNlVVJJKCkgIT0geGh0bWxOYW1lc3BhY2VVUkkpOworICAgIG1fcGFyc2VyLT50b2tlbml6ZXIo KS0+c2V0U2hvdWxkQWxsb3dDREFUQShtX2luc2VydGlvbk1vZGUgPT0gSW5Gb3JlaWduQ29udGVu dE1vZGUgJiYgbV90cmVlLmN1cnJlbnROb2RlKCktPm5hbWVzcGFjZVVSSSgpICE9IHhodG1sTmFt ZXNwYWNlVVJJKTsKIH0KIAogdm9pZCBIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NUb2tlbihBdG9t aWNIVE1MVG9rZW4mIHRva2VuKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gODAyODMpCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wMy0w MyAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXNzZXJ0aW9uIGZhaWx1cmUgaW4gdG9FbGVtZW50 KFdlYkNvcmU6Ok5vZGUqKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTU2OTcKKworICAgICAgICAqIGZhc3QvcGFyc2VyL2ZyYWdtZW50LWZvcmVpZ24t Y29udGVudC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcGFyc2VyL2ZyYWdt ZW50LWZvcmVpZ24tY29udGVudC5odG1sOiBBZGRlZC4KKwogMjAxMS0wMy0wMyAgU2hlcmlmZiBC b3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cm9sbGluZyBvdXQgcjgwMjcyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvZnJhZ21l bnQtZm9yZWlnbi1jb250ZW50LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L3BhcnNlci9mcmFnbWVudC1mb3JlaWduLWNvbnRlbnQtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvZnJhZ21lbnQtZm9yZWlnbi1jb250 ZW50LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorVGVzdCBmb3IgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1Njk3LiBWZXJpZnkgdGhhdCBX ZWJLaXQgZG9lcyBub3QgQVNTRVJUIHdoZW4gdGhlIHJvb3Qgbm9kZSBvZiBhIGZyYWdtZW50IGlz IGZvcmVpZ24gY29udGVudC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvcGFyc2VyL2ZyYWdtZW50 LWZvcmVpZ24tY29udGVudC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvcGFy c2VyL2ZyYWdtZW50LWZvcmVpZ24tY29udGVudC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvZmFzdC9wYXJzZXIvZnJhZ21lbnQtZm9yZWlnbi1jb250ZW50Lmh0bWwJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsMTEgQEAKKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwor ICAgICAgICAKKyAgICBmdW5jdGlvbiB0ZXN0KCkKKyAgICB7CisgICAgICAgIGRvY3VtZW50LmJv ZHkuaW5uZXJIVE1MICs9ICI8c3ZnIC8+IjsKKyAgICB9Cis8L3NjcmlwdD4KKzxib2R5IG9ubG9h ZD0idGVzdCgpIj4KK1Rlc3QgZm9yIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01NTY5NyI+aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU1Njk3PC9hPi4gVmVyaWZ5IHRoYXQgV2ViS2l0IGRvZXMgbm90IEFTU0VSVCB3aGVuIHRo ZSByb290IG5vZGUgb2YgYSBmcmFnbWVudCBpcyBmb3JlaWduIGNvbnRlbnQuClwgTm8gbmV3bGlu ZSBhdCBlbmQgb2YgZmlsZQo=