55690 2011-03-03 11:18:23 -0800 Web Inspector: install onerror handler in inspector tests 2011-03-10 06:49:11 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 361771 0 caseq 2011-03-03 11:18:23 -0800 Currently, web inspector console is not captured in test output. We redefine console.log & co in inspector test suites to direct the messages to test output, yet if an exception happens in front-end during test, we do not capture the exception information. This patch adds onerror handler that will post error information to test output. 361782 1 84597 caseq 2011-03-03 11:24:08 -0800 Created attachment 84597 patch 362696 2 84597 commit-queue 2011-03-04 14:24:46 -0800 Comment on attachment 84597 patch Rejecting attachment 84597 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: ed 3 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/http/tests/inspector/inspector-test.js Hunk #1 FAILED at 74. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/http/tests/inspector/inspector-test.js.rej patching file LayoutTests/http/tests/inspector/resources/extension-main.js Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Pavel Feldman', u'--fo..." exit_code: 1 Full output: http://queues.webkit.org/results/8038025 365134 3 caseq 2011-03-10 06:47:57 -0800 Manually committed r80417: http://trac.webkit.org/changeset/80417 365136 4 84597 caseq 2011-03-10 06:49:11 -0800 Comment on attachment 84597 patch Removing pfeldman's r+ from obsolete patch. 84597 2011-03-03 11:24:08 -0800 2011-03-10 06:49:11 -0800 patch onerror.diff text/plain 2069 caseq ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1MmZlZTUyLi4zOTYzZWQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMt MDMgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBpbnN0YWxs IG9uZXJyb3IgaGFuZGxlciBpbiBpbnNwZWN0b3IgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1NjkwCisKKyAgICAgICAgKiBodHRwL3Rlc3Rz L2luc3BlY3Rvci9pbnNwZWN0b3ItdGVzdC5qczoKKyAgICAgICAgKGluaXRpYWxpemVfSW5zcGVj dG9yVGVzdC5vbkVycm9yKToKKyAgICAgICAgKiBodHRwL3Rlc3RzL2luc3BlY3Rvci9yZXNvdXJj ZXMvZXh0ZW5zaW9uLW1haW4uanM6CisgICAgICAgIChvbkVycm9yKToKKwogMjAxMS0wMy0wMyAg VmljdG9yaWEgS2lyc3QgIDx2cmtAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBF cmljIENhcmxzb24uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rv ci9pbnNwZWN0b3ItdGVzdC5qcyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2lu c3BlY3Rvci10ZXN0LmpzCmluZGV4IGNmNjZiZDQuLjE5MmUzNzggMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2luc3BlY3Rvci10ZXN0LmpzCisrKyBiL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2luc3BlY3Rvci10ZXN0LmpzCkBAIC03NCw3ICs3 NCwxNCBAQCBJbnNwZWN0b3JUZXN0LmFkZFJlc3VsdCA9IGZ1bmN0aW9uKHRleHQpCiAgICAgfQog fQogCi1jb25zb2xlLmVycm9yID0gSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQ7CitmdW5jdGlvbiBv bkVycm9yKGV2ZW50KQoreworICAgIHdpbmRvdy5yZW1vdmVFdmVudExpc3RlbmVyKCJlcnJvciIs IG9uRXJyb3IpOworICAgIEluc3BlY3RvclRlc3QuYWRkUmVzdWx0KCJVbmNhdWdodCBleGNlcHRp b24gaW4gaW5zcGVjdG9yIGZyb250LWVuZDogIiArIGV2ZW50Lm1lc3NhZ2UgKyAiIFsiICsgZXZl bnQuZmlsZW5hbWUgKyAiOiIgKyBldmVudC5saW5lbm8gKyAiXSIpOworICAgIEluc3BlY3RvclRl c3QuY29tcGxldGVUZXN0KCk7Cit9CisKK3dpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJlcnJvciIs IG9uRXJyb3IpOwogCiBJbnNwZWN0b3JUZXN0LmFkZFJlc3VsdHMgPSBmdW5jdGlvbih0ZXh0QXJy YXkpCiB7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9yZXNv dXJjZXMvZXh0ZW5zaW9uLW1haW4uanMgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rv ci9yZXNvdXJjZXMvZXh0ZW5zaW9uLW1haW4uanMKaW5kZXggZTk0YmQyMy4uY2JjODczOCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2VzL2V4dGVu c2lvbi1tYWluLmpzCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291 cmNlcy9leHRlbnNpb24tbWFpbi5qcwpAQCAtMSwzICsxLDEyIEBACitmdW5jdGlvbiBvbkVycm9y KGV2ZW50KQoreworICAgIHdpbmRvdy5yZW1vdmVFdmVudExpc3RlbmVyKCJlcnJvciIsIG9uRXJy b3IpOworICAgIG91dHB1dCgiVW5jYXVnaHQgZXhjZXB0aW9uIGluIGV4dGVuc2lvbiBjb250ZXh0 OiAiICsgZXZlbnQubWVzc2FnZSArICIgWyIgKyBldmVudC5maWxlbmFtZSArICI6IiArIGV2ZW50 LmxpbmVubyArICJdIik7CisgICAgdG9wLnBvc3RNZXNzYWdlKHsgY29tbWFuZDogImV4dGVuc2lv bi10ZXN0cy1kb25lIiB9LCAiKiIpOworfQorCit3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigiZXJy b3IiLCBvbkVycm9yKTsKKwogZnVuY3Rpb24gZmV0Y2hUZXN0cygpCiB7CiAgICAgZnVuY3Rpb24g Y2FsbGJhY2socmVzdWx0KQo=