55675 2011-03-03 07:42:21 -0800 Changing svg transform attribute to the same value triggers repaint 2014-05-12 06:23:44 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 55829 55771 1 paroga paroga buildbot darin dglazkov eric gustavo.noronha gustavo krit rwlbuis webkit.review.bot xan.lopez zimmermann oldest_to_newest 361613 0 paroga 2011-03-03 07:42:21 -0800 When you have <rect fill="red" transform="scale(2)" /> and set the _fill_ attribute to "red" again it doesn't trigger a repaint. If you set the _transform_ attribute of the rect to "scale(2)" again, it requests a repaint. 362595 1 84772 paroga 2011-03-04 10:07:56 -0800 Created attachment 84772 Patch 362935 2 84772 zimmermann 2011-03-05 04:31:58 -0800 Comment on attachment 84772 Patch Are you sure it's worth the gain for the common-case, where the attribute indeed changed to a new value? Looks like an expensive test for a corner case... 362996 3 84879 paroga 2011-03-05 15:12:14 -0800 Created attachment 84879 Alternative Patch (depends on bug 55829) (In reply to comment #2) > Are you sure it's worth the gain for the common-case, where the attribute indeed changed to a new value? Looks like an expensive test for a corner case... I'm not 100% happy with the patch either, but I was my first try to fix this problem. I also added a a change comparison in the setAttribute directly, but many unit LayoutTest failed. This patch disables the whole svgAttributeChanged method, if the attribute stays the same but requires bug 55829. 362998 4 webkit.review.bot 2011-03-05 15:16:39 -0800 Attachment 84879 did not build on chromium: Build output: http://queues.webkit.org/results/8105082 363010 5 buildbot 2011-03-05 15:34:37 -0800 Attachment 84879 did not build on win: Build output: http://queues.webkit.org/results/8101158 363016 6 gustavo.noronha 2011-03-05 16:01:26 -0800 Attachment 84879 did not build on gtk: Build output: http://queues.webkit.org/results/8106078 363017 7 webkit-ews 2011-03-05 16:05:48 -0800 Attachment 84879 did not build on qt: Build output: http://queues.webkit.org/results/8098361 363023 8 webkit.review.bot 2011-03-05 16:46:30 -0800 Attachment 84879 did not build on chromium: Build output: http://queues.webkit.org/results/8103166 363024 9 webkit.review.bot 2011-03-05 17:11:46 -0800 Attachment 84879 did not build on mac: Build output: http://queues.webkit.org/results/8105104 382958 10 eric 2011-04-10 16:22:48 -0700 svgAttributeChanged is kinda a disaster anyway. I can't remember why it's needed. 383169 11 zimmermann 2011-04-11 08:01:08 -0700 (In reply to comment #10) > svgAttributeChanged is kinda a disaster anyway. I can't remember why it's needed. You're saying this since ages, it's not a disaster in anyway, but just fine. I explained several times why it's needed (unify SVG DOM _and_ XML DOM changes). 392845 12 84772 aroben 2011-04-26 15:38:57 -0700 Comment on attachment 84772 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84772&action=review I don't understand why the code was moved from svgAttributeChanged to parseMappedAttribute. Your ChangeLog should probably explain this. > Source/WebCore/ChangeLog:5 > + Chaning svg transform attribute to the same value triggers repaint Typo: Chaning 392939 13 84879 aroben 2011-04-26 16:09:33 -0700 Comment on attachment 84879 Alternative Patch (depends on bug 55829) View in context: https://bugs.webkit.org/attachment.cgi?id=84879&action=review > Source/WebCore/svg/SVGElement.cpp:386 > - if (attr->name() != HTMLNames::styleAttr) > + if (type != ChangedAttributeToSameValue && attr->name() != HTMLNames::styleAttr) Does HTMLElement or Element do this? 545442 14 eric 2012-01-30 15:02:51 -0800 Just noticed this nearly 12-month-old bug. Nico: Thoughts on this change? You're much more familiar with SVG these days than I. 568887 15 84879 eric 2012-03-01 13:53:40 -0800 Comment on attachment 84879 Alternative Patch (depends on bug 55829) With no response, and no answer to Adam's question, marking this r-. Feel free to mark this r? again with questions answered. 1008559 16 krit 2014-05-12 06:23:44 -0700 We do no longer have AttributeChangedType. Transforms should be handled by CSS in the future anyway. 84772 2011-03-04 10:07:56 -0800 2011-04-26 15:38:56 -0700 Patch bug-55675.patch text/plain 3191 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxZWM0YTZmLi41MTEyYmZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDMtMDQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmluZyBz dmcgdHJhbnNmb3JtIGF0dHJpYnV0ZSB0byB0aGUgc2FtZSB2YWx1ZSB0cmlnZ2VycyByZXBhaW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTY3NQor CisgICAgICAgIENvbXBhcmUgdGhlIG9sZCBBZmZpbmVUcmFuc2Zvcm0gd2l0aCB0aGUgbmV3IEFm ZmluZVRyYW5zZm9ybSBiZWZvcmUgdHJpZ2dlcmluZyBhIHJlbGF5b3V0LgorCisgICAgICAgICog c3ZnL1NWR1N0eWxlZFRyYW5zZm9ybWFibGVFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNWR1N0eWxlZFRyYW5zZm9ybWFibGVFbGVtZW50OjpwYXJzZU1hcHBlZEF0dHJpYnV0ZSk6Cisg ICAgICAgICogc3ZnL1NWR1N0eWxlZFRyYW5zZm9ybWFibGVFbGVtZW50Lmg6CisKIDIwMTEtMDMt MDQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcv U1ZHU3R5bGVkVHJhbnNmb3JtYWJsZUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NW R1N0eWxlZFRyYW5zZm9ybWFibGVFbGVtZW50LmNwcAppbmRleCBiYWZhM2I2Li40ZTJhNjJmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHU3R5bGVkVHJhbnNmb3JtYWJsZUVsZW1l bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdTdHlsZWRUcmFuc2Zvcm1hYmxlRWxl bWVudC5jcHAKQEAgLTcxLDI3ICs3MSwzMCBAQCBBZmZpbmVUcmFuc2Zvcm0qIFNWR1N0eWxlZFRy YW5zZm9ybWFibGVFbGVtZW50OjpzdXBwbGVtZW50YWxUcmFuc2Zvcm0oKQogCiB2b2lkIFNWR1N0 eWxlZFRyYW5zZm9ybWFibGVFbGVtZW50OjpwYXJzZU1hcHBlZEF0dHJpYnV0ZShBdHRyaWJ1dGUq IGF0dHIpCiB7Ci0gICAgaWYgKFNWR1RyYW5zZm9ybWFibGU6OmlzS25vd25BdHRyaWJ1dGUoYXR0 ci0+bmFtZSgpKSkgewotICAgICAgICBTVkdUcmFuc2Zvcm1MaXN0IG5ld0xpc3Q7Ci0gICAgICAg IGlmICghU1ZHVHJhbnNmb3JtYWJsZTo6cGFyc2VUcmFuc2Zvcm1BdHRyaWJ1dGUobmV3TGlzdCwg YXR0ci0+dmFsdWUoKSkpCi0gICAgICAgICAgICBuZXdMaXN0LmNsZWFyKCk7Ci0gICAgICAgIGRl dGFjaEFuaW1hdGVkVHJhbnNmb3JtTGlzdFdyYXBwZXJzKG5ld0xpc3Quc2l6ZSgpKTsKLSAgICAg ICAgc2V0VHJhbnNmb3JtQmFzZVZhbHVlKG5ld0xpc3QpOwotICAgIH0gZWxzZSAKKyAgICBpZiAo IVNWR1RyYW5zZm9ybWFibGU6OmlzS25vd25BdHRyaWJ1dGUoYXR0ci0+bmFtZSgpKSkgewogICAg ICAgICBTVkdTdHlsZWRMb2NhdGFibGVFbGVtZW50OjpwYXJzZU1hcHBlZEF0dHJpYnV0ZShhdHRy KTsKLX0KKyAgICAgICAgcmV0dXJuOworICAgIH0KIAotdm9pZCBTVkdTdHlsZWRUcmFuc2Zvcm1h YmxlRWxlbWVudDo6c3ZnQXR0cmlidXRlQ2hhbmdlZChjb25zdCBRdWFsaWZpZWROYW1lJiBhdHRy TmFtZSkKLXsKLSAgICBTVkdTdHlsZWRMb2NhdGFibGVFbGVtZW50OjpzeW5jaHJvbml6ZVByb3Bl cnR5KGF0dHJOYW1lKTsKKyAgICBBZmZpbmVUcmFuc2Zvcm0gb2xkVHJhbnNmb3JtOworICAgIHRy YW5zZm9ybUJhc2VWYWx1ZSgpLmNvbmNhdGVuYXRlKG9sZFRyYW5zZm9ybSk7CiAKLSAgICBpZiAo IVNWR1N0eWxlZFRyYW5zZm9ybWFibGVFbGVtZW50Ojppc0tub3duQXR0cmlidXRlKGF0dHJOYW1l KSkKLSAgICAgICAgcmV0dXJuOworICAgIFNWR1RyYW5zZm9ybUxpc3QgbmV3TGlzdDsKKyAgICBp ZiAoIVNWR1RyYW5zZm9ybWFibGU6OnBhcnNlVHJhbnNmb3JtQXR0cmlidXRlKG5ld0xpc3QsIGF0 dHItPnZhbHVlKCkpKQorICAgICAgICBuZXdMaXN0LmNsZWFyKCk7CisgICAgZGV0YWNoQW5pbWF0 ZWRUcmFuc2Zvcm1MaXN0V3JhcHBlcnMobmV3TGlzdC5zaXplKCkpOworICAgIHNldFRyYW5zZm9y bUJhc2VWYWx1ZShuZXdMaXN0KTsKIAogICAgIFJlbmRlck9iamVjdCogb2JqZWN0ID0gcmVuZGVy ZXIoKTsKICAgICBpZiAoIW9iamVjdCkKICAgICAgICAgcmV0dXJuOwogCisgICAgQWZmaW5lVHJh bnNmb3JtIG5ld1RyYW5zZm9ybTsKKyAgICBuZXdMaXN0LmNvbmNhdGVuYXRlKG5ld1RyYW5zZm9y bSk7CisKKyAgICBpZiAob2xkVHJhbnNmb3JtID09IG5ld1RyYW5zZm9ybSkKKyAgICAgICAgcmV0 dXJuOworCiAgICAgb2JqZWN0LT5zZXROZWVkc1RyYW5zZm9ybVVwZGF0ZSgpOwogICAgIFJlbmRl clNWR1Jlc291cmNlOjptYXJrRm9yTGF5b3V0QW5kUGFyZW50UmVzb3VyY2VJbnZhbGlkYXRpb24o b2JqZWN0KTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdTdHlsZWRUcmFu c2Zvcm1hYmxlRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1N0eWxlZFRyYW5zZm9y bWFibGVFbGVtZW50LmgKaW5kZXggOWQ2ODM0YS4uY2JkNzBlZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvc3ZnL1NWR1N0eWxlZFRyYW5zZm9ybWFibGVFbGVtZW50LmgKKysrIGIvU291cmNl L1dlYkNvcmUvc3ZnL1NWR1N0eWxlZFRyYW5zZm9ybWFibGVFbGVtZW50LmgKQEAgLTU4LDcgKzU4 LDYgQEAgcHJvdGVjdGVkOgogICAgIFNWR1N0eWxlZFRyYW5zZm9ybWFibGVFbGVtZW50KGNvbnN0 IFF1YWxpZmllZE5hbWUmLCBEb2N1bWVudCopOwogCiAgICAgdmlydHVhbCB2b2lkIHBhcnNlTWFw cGVkQXR0cmlidXRlKEF0dHJpYnV0ZSopOwotICAgIHZpcnR1YWwgdm9pZCBzdmdBdHRyaWJ1dGVD aGFuZ2VkKGNvbnN0IFF1YWxpZmllZE5hbWUmKTsKICAgICB2aXJ0dWFsIHZvaWQgc3luY2hyb25p emVQcm9wZXJ0eShjb25zdCBRdWFsaWZpZWROYW1lJik7CiAgICAgdm9pZCBmaWxsUGFzc2VkQXR0 cmlidXRlVG9Qcm9wZXJ0eVR5cGVNYXAoQXR0cmlidXRlVG9Qcm9wZXJ0eVR5cGVNYXAmKTsKIAo= 84879 2011-03-05 15:12:14 -0800 2012-03-01 13:53:39 -0800 Alternative Patch (depends on bug 55829) bug-55675b.patch text/plain 1342 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhODk4NDFkLi5iODgxMmYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDMtMDUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdpbmcg c3ZnIHRyYW5zZm9ybSBhdHRyaWJ1dGUgdG8gdGhlIHNhbWUgdmFsdWUgdHJpZ2dlcnMgcmVwYWlu dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU2NzUK KworICAgICAgICBEbyBub3QgY2FsbCBzdmdBdHRyaWJ1dGVDaGFuZ2VkIGlmIHRoZSB2YWx1ZSBv ZiB0aGUgYXR0cmlidXRlIGlzIHRoZSBzYW1lIGFnYWluLgorCisgICAgICAgICogc3ZnL1NWR0Vs ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHRWxlbWVudDo6YXR0cmlidXRlQ2hhbmdl ZCk6CisKIDIwMTEtMDMtMDUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9zdmcvU1ZHRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRWxl bWVudC5jcHAKaW5kZXggMTQ4NjU5OC4uY2Y5OWRhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvc3ZnL1NWR0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50 LmNwcApAQCAtMzgzLDcgKzM4Myw3IEBAIHZvaWQgU1ZHRWxlbWVudDo6YXR0cmlidXRlQ2hhbmdl ZChBdHRyaWJ1dGUqIGF0dHIsIEF0dHJpYnV0ZUNoYW5nZWRUeXBlIHR5cGUsIGJvCiAKICAgICAv LyBDaGFuZ2VzIHRvIHRoZSBzdHlsZSBhdHRyaWJ1dGUgYXJlIHByb2Nlc3NlZCBsYXppbHkgKHNl ZSBFbGVtZW50OjpnZXRBdHRyaWJ1dGUoKSBhbmQgcmVsYXRlZCBtZXRob2RzKSwKICAgICAvLyBz byB3ZSBkb24ndCB3YW50IGNoYW5nZXMgdG8gdGhlIHN0eWxlIGF0dHJpYnV0ZSB0byByZXN1bHQg aW4gZXh0cmEgd29yayBoZXJlLgotICAgIGlmIChhdHRyLT5uYW1lKCkgIT0gSFRNTE5hbWVzOjpz dHlsZUF0dHIpCisgICAgaWYgKHR5cGUgIT0gQ2hhbmdlZEF0dHJpYnV0ZVRvU2FtZVZhbHVlICYm IGF0dHItPm5hbWUoKSAhPSBIVE1MTmFtZXM6OnN0eWxlQXR0cikKICAgICAgICAgc3ZnQXR0cmli dXRlQ2hhbmdlZChhdHRyLT5uYW1lKCkpOwogfQogCg==