55674 2011-03-03 07:21:32 -0800 Many tests fail in WebKit2 mode on Windows due to incorrect parsing of absolute Windows-style file: URLs 2011-03-03 11:22:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED http://build.webkit.org/results/Windows%207%20Release%20%28WebKit2%20Tests%29/r80235%20(3670)/results.html InRadar, LayoutTestFailure, PlatformOnly P2 Normal --- 1 aroben webkit-unassigned abarth eric.carlson eric jer.noble webkit.review.bot oldest_to_newest 361603 0 aroben 2011-03-03 07:21:32 -0800 Most/all media tests time out on Windows 7 Release (WebKit2 Tests). See the URL for an example. 361625 1 aroben 2011-03-03 08:01:14 -0800 <rdar://problem/9080865> 361645 2 aroben 2011-03-03 08:50:25 -0800 Just looking at media/audio-constructor-preload.html, I see HTMLMediaElement::scheduleLoad get called, but the load timer never fires. 361656 3 aroben 2011-03-03 09:02:25 -0800 Even though the timer doesn't fire, HTMLMediaElement::load is getting called by JS, so the load is starting. But it looks like we're getting a bogus URL: file://c/Documents%20and%20Settings/Adam%20Roben/dev/WebKit/OpenSource/LayoutTests/media/content/test.wav Note the missing colon after "file://c". I think this is actually the root cause of a lot of test failures in WebKit2 on Windows. 361657 4 aroben 2011-03-03 09:03:50 -0800 Just to close the loop on the timer issue: HTMLMediaElement::load is canceling the timer, since the load is now happening synchronously. 361659 5 aroben 2011-03-03 09:04:28 -0800 Document::m_baseURL is also missing the colon. 361660 6 aroben 2011-03-03 09:05:46 -0800 As is Document::m_documentURI. 361671 7 aroben 2011-03-03 09:22:54 -0800 KURL::parse is getting passed this: file://c:/Documents and Settings/Adam Roben/dev/WebKit/OpenSource/LayoutTests/media/audio-constructor-preload.html It parses the colon in "c:" as introducing a port number. But then there is no port number so it continues on its merry way, and "c" gets set as the host. Clearly KURL is buggy with respect to absolute Windows-style file: URLs. DRT on Windows used CFURL to convert the path into a URL. 361674 8 aroben 2011-03-03 09:25:18 -0800 I have a workaround. I'll file a new bug for the underlying KURL issue. 361676 9 aroben 2011-03-03 09:27:29 -0800 Bug 55683 covers the KURL issue. 361680 10 84574 aroben 2011-03-03 09:32:03 -0800 Created attachment 84574 Work around a bug in KURL's parsing of Windows-style absolute file: URLs 361686 11 aroben 2011-03-03 09:36:53 -0800 Committed r80249: <http://trac.webkit.org/changeset/80249> 361775 12 webkit.review.bot 2011-03-03 11:22:06 -0800 http://trac.webkit.org/changeset/80249 might have broken Windows 7 Release (Tests) The following tests are not passing: animations/combo-transform-rotate+scale.html animations/keyframe-timing-functions-transform.html inspector/extensions/extensions-audits.html 84574 2011-03-03 09:32:03 -0800 2011-03-03 09:32:46 -0800 Work around a bug in KURL's parsing of Windows-style absolute file: URLs bug-55674-20110303123211.patch text/plain 1664 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogODAyNDAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNmJjNzZmMzA2NDlmOTg1NGZiYTBhZDE4MmE1YzJjN2Q1 MzVmNDVmLi40Mjc2YzYyNjRkNmQ2ZGY4YzE1YmE4NzRhZjdhYzAyODM0NTcwYzYwIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTEtMDMtMDMgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCisgICAgICAg IFdvcmsgYXJvdW5kIGEgYnVnIGluIEtVUkwncyBwYXJzaW5nIG9mIFdpbmRvd3Mtc3R5bGUgYWJz b2x1dGUgZmlsZTogVVJMcworCisgICAgICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzU1 Njc0PiBNYW55IHRlc3RzIGZhaWwgaW4gV2ViS2l0MiBtb2RlIG9uIFdpbmRvd3MgZHVlIHRvCisg ICAgICAgIGluY29ycmVjdCBwYXJzaW5nIG9mIGFic29sdXRlIFdpbmRvd3Mtc3R5bGUgZmlsZTog VVJMcworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog V2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5jcHA6CisgICAgICAgIChXVFI6OmNyZWF0 ZVdLVVJMKTogQWRkIGEgImxvY2FsaG9zdCIgaG9zdCB0byBmaWxlOiBVUkxzIHdlIGNyZWF0ZSB0 byB3b3JrIGFyb3VuZAorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi81NTY4Mz4uCisKKzIw MTEtMDMtMDMgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgorCiAgICAgICAgIExvb2sg Zm9yIFdpbmRvd3Mtc3R5bGUgcGF0aHMgd2hlbiBjaGVja2luZyB3aGV0aGVyIGEgdGVzdCBpcyBh biBJbnNwZWN0b3IgdGVzdAogCiAgICAgICAgIFdUUiBwYXJ0IG9mIDxodHRwOi8vd2Via2l0Lm9y Zy9iLzU1NjcyPiA8cmRhcjovL3Byb2JsZW0vOTA4MDg2Nz4gQWxsIGluc3BlY3RvciB0ZXN0cyB0 aW1lCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNw cCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uY3BwCmluZGV4IGUyZTQx ZTJjNjcyZWJkN2MxNDA4MDlhYzNiMTA0ZmE1NDcyNGI3MmMuLjMyMjdiZTk4NzdjNWMyYmNjNjU5 ZWMxYzkzNzgwODk4YmZiYWRhYTEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv VGVzdEludm9jYXRpb24uY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9j YXRpb24uY3BwCkBAIC01OCw3ICs1OCw4IEBAIHN0YXRpYyBXS1VSTFJlZiBjcmVhdGVXS1VSTChj b25zdCBjaGFyKiBwYXRoT3JVUkwpCiAgICAgaWYgKCFsZW5ndGgpCiAgICAgICAgIHJldHVybiAw OwogCi0gICAgY29uc3QgY2hhciogZmlsZVByZWZpeCA9ICJmaWxlOi8vIjsKKyAgICAvLyBGSVhN RTogUmVtb3ZlIHRoZSAibG9jYWxob3N0LyIgc3VmZml4IG9uY2UgPGh0dHA6Ly93ZWJraXQub3Jn L2IvNTU2ODM+IGlzIGZpeGVkLgorICAgIGNvbnN0IGNoYXIqIGZpbGVQcmVmaXggPSAiZmlsZTov L2xvY2FsaG9zdC8iOwogICAgIHN0YXRpYyBjb25zdCBzaXplX3QgcHJlZml4TGVuZ3RoID0gc3Ry bGVuKGZpbGVQcmVmaXgpOwogI2lmIE9TKFdJTkRPV1MpCiAgICAgY29uc3QgY2hhciBzZXBhcmF0 b3IgPSAnXFwnOwo=