55636 2011-03-02 17:37:14 -0800 Rename WebKit::WebPage::validateMenuItem() to validateCommand() 2011-03-02 17:59:50 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jeffm jeffm oldest_to_newest 361245 0 jeffm 2011-03-02 17:37:14 -0800 Rename WebKit::WebPage::validateMenuItem() to validateCommand() 361248 1 jeffm 2011-03-02 17:39:27 -0800 Since this method can validate more than menu items, validateCommand() is a better name. Also rename various messages and WebKit::WebPageProxy::didValidateMenuItem() to didValidateCommand(). 361251 2 84498 jeffm 2011-03-02 17:43:13 -0800 Created attachment 84498 Patch 361270 3 jeffm 2011-03-02 17:59:50 -0800 Committed r80194: <http://trac.webkit.org/changeset/80194> 84498 2011-03-02 17:43:13 -0800 2011-03-02 17:55:36 -0800 Patch bug-55636-20110302174310.patch text/plain 7472 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwMTg5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDMtMDIgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJlbmFtZSBXZWJLaXQ6OldlYlBhZ2U6OnZhbGlkYXRlTWVudUl0ZW0o KSB0byB2YWxpZGF0ZUNvbW1hbmQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTU2MzYKKyAgICAgICAgCisgICAgICAgIFNpbmNlIHRoaXMgbWV0aG9k IGNhbiB2YWxpZGF0ZSBtb3JlIHRoYW4gbWVudSBpdGVtcywgdmFsaWRhdGVDb21tYW5kKCkgaXMg YSBiZXR0ZXIgbmFtZS4gIEFsc28gcmVuYW1lIHZhcmlvdXMgbWVzc2FnZXMgYW5kIFdlYktpdDo6 V2ViUGFnZVByb3h5OjpkaWRWYWxpZGF0ZU1lbnVJdGVtKCkgdG8gZGlkVmFsaWRhdGVDb21tYW5k KCkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06CisgICAgICAgICgt W1dLVmlldyB2YWxpZGF0ZVVzZXJJbnRlcmZhY2VJdGVtOl0pOiBDYWxsIHZhbGlkYXRlQ29tbWFu ZCgpIGluc3RlYWQgb2YgdmFsaWRhdGVNZW51SXRlbSgpLgorICAgICAgICAqIFVJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnZhbGlkYXRl Q29tbWFuZCk6IFJlbmFtZWQgZnJvbSB2YWxpZGF0ZU1lbnVJdGVtKCkuCisgICAgICAgIChXZWJL aXQ6OldlYlBhZ2VQcm94eTo6ZGlkVmFsaWRhdGVDb21tYW5kKTogUmVuYW1lZCBmcm9tIGRpZFZh bGlkYXRlTWVudUl0ZW0oKS4KKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6Cisg ICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdlcy5pbjogUmVuYW1lZCBEaWRW YWxpZGF0ZU1lbnVJdGVtIHRvIERpZFZhbGlkYXRlQ29tbWFuZC4KKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnZhbGlk YXRlQ29tbWFuZCk6IFJlbmFtZWQgZnJvbSB2YWxpZGF0ZU1lbnVJdGVtKCkuCisgICAgICAgICog V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBh Z2UvV2ViUGFnZS5tZXNzYWdlcy5pbjogUmVuYW1lZCBWYWxpZGF0ZU1lbnVJdGVtIHRvICBWYWxp ZGF0ZUNvbW1hbmQuCisKIDIwMTEtMDMtMDIgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBw bGUuY29tPgogCiAgICAgICAgIE1ha2UgdGhlIHJ1bkphdmFTY3JpcHRJbk1haW5GcmFtZSBjYWxs YmFjayBzZW5kIGEgV0tTZXJpYWxpemVkU2NyaXB0VmFsdWVSZWYuCkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNpb24gODAxMjQpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAt NjA4LDExICs2MDgsMTEgQEAgdm9pZCBXZWJQYWdlUHJveHk6OnNldFdpbmRvd1Jlc2l6ZXJTaXpl KAogICAgIHByb2Nlc3MoKS0+c2VuZChNZXNzYWdlczo6V2ViUGFnZTo6U2V0V2luZG93UmVzaXpl clNpemUod2luZG93UmVzaXplclNpemUpLCBtX3BhZ2VJRCk7CiB9CiAKLXZvaWQgV2ViUGFnZVBy b3h5Ojp2YWxpZGF0ZU1lbnVJdGVtKGNvbnN0IFN0cmluZyYgY29tbWFuZE5hbWUpCit2b2lkIFdl YlBhZ2VQcm94eTo6dmFsaWRhdGVDb21tYW5kKGNvbnN0IFN0cmluZyYgY29tbWFuZE5hbWUpCiB7 CiAgICAgaWYgKCFpc1ZhbGlkKCkpCiAgICAgICAgIHJldHVybjsKLSAgICBwcm9jZXNzKCktPnNl bmQoTWVzc2FnZXM6OldlYlBhZ2U6OlZhbGlkYXRlTWVudUl0ZW0oY29tbWFuZE5hbWUpLCBtX3Bh Z2VJRCk7CisgICAgcHJvY2VzcygpLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlOjpWYWxpZGF0ZUNv bW1hbmQoY29tbWFuZE5hbWUpLCBtX3BhZ2VJRCk7CiB9CiAgICAgCiB2b2lkIFdlYlBhZ2VQcm94 eTo6ZXhlY3V0ZUVkaXRDb21tYW5kKGNvbnN0IFN0cmluZyYgY29tbWFuZE5hbWUpCkBAIC0yMzM2 LDcgKzIzMzYsNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6c2V0Q3Vyc29yKGNvbnN0IFdlYkNvCiAg ICAgbV9wYWdlQ2xpZW50LT5zZXRDdXJzb3IoY3Vyc29yKTsKIH0KIAotdm9pZCBXZWJQYWdlUHJv eHk6OmRpZFZhbGlkYXRlTWVudUl0ZW0oY29uc3QgU3RyaW5nJiBjb21tYW5kTmFtZSwgYm9vbCBp c0VuYWJsZWQsIGludDMyX3Qgc3RhdGUpCit2b2lkIFdlYlBhZ2VQcm94eTo6ZGlkVmFsaWRhdGVD b21tYW5kKGNvbnN0IFN0cmluZyYgY29tbWFuZE5hbWUsIGJvb2wgaXNFbmFibGVkLCBpbnQzMl90 IHN0YXRlKQogewogICAgIG1fcGFnZUNsaWVudC0+c2V0RWRpdENvbW1hbmRTdGF0ZShjb21tYW5k TmFtZSwgaXNFbmFibGVkLCBzdGF0ZSk7CiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5oCShyZXZpc2lvbiA4MDEyNSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuaAkod29ya2luZyBjb3B5KQpAQCAtMTk5LDcgKzE5OSw3IEBAIHB1 YmxpYzoKICAgICBib29sIGlzVmlld1Zpc2libGUoKSBjb25zdCB7IHJldHVybiBtX2lzVmlzaWJs ZTsgfQogCiAgICAgdm9pZCBleGVjdXRlRWRpdENvbW1hbmQoY29uc3QgU3RyaW5nJiBjb21tYW5k TmFtZSk7Ci0gICAgdm9pZCB2YWxpZGF0ZU1lbnVJdGVtKGNvbnN0IFN0cmluZyYgY29tbWFuZE5h bWUpOworICAgIHZvaWQgdmFsaWRhdGVDb21tYW5kKGNvbnN0IFN0cmluZyYgY29tbWFuZE5hbWUp OwogCiAgICAgY29uc3QgU2VsZWN0aW9uU3RhdGUmIHNlbGVjdGlvblN0YXRlKCkgY29uc3QgeyBy ZXR1cm4gbV9zZWxlY3Rpb25TdGF0ZTsgfQogICAgIGJvb2wgY2FuRGVsZXRlKCkgY29uc3QgeyBy ZXR1cm4gaGFzU2VsZWN0ZWRSYW5nZSgpICYmIGlzQ29udGVudEVkaXRhYmxlKCk7IH0KQEAgLTU2 Nyw3ICs1NjcsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgdGFrZUZvY3VzKGJvb2wgZGlyZWN0aW9u KTsKICAgICB2b2lkIHNldFRvb2xUaXAoY29uc3QgU3RyaW5nJik7CiAgICAgdm9pZCBzZXRDdXJz b3IoY29uc3QgV2ViQ29yZTo6Q3Vyc29yJik7Ci0gICAgdm9pZCBkaWRWYWxpZGF0ZU1lbnVJdGVt KGNvbnN0IFN0cmluZyYgY29tbWFuZE5hbWUsIGJvb2wgaXNFbmFibGVkLCBpbnQzMl90IHN0YXRl KTsKKyAgICB2b2lkIGRpZFZhbGlkYXRlQ29tbWFuZChjb25zdCBTdHJpbmcmIGNvbW1hbmROYW1l LCBib29sIGlzRW5hYmxlZCwgaW50MzJfdCBzdGF0ZSk7CiAKICAgICB2b2lkIGRpZFJlY2VpdmVF dmVudCh1aW50MzJfdCBvcGFxdWVUeXBlLCBib29sIGhhbmRsZWQpOwogCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmluCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW4JKHJldmlz aW9uIDgwMTI0KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5tZXNz YWdlcy5pbgkod29ya2luZyBjb3B5KQpAQCAtMzIsNyArMzIsNyBAQCBtZXNzYWdlcyAtPiBXZWJQ YWdlUHJveHkgewogICAgIE1pc3NpbmdQbHVnaW5CdXR0b25DbGlja2VkKFdURjo6U3RyaW5nIG1p bWVUeXBlLCBXVEY6OlN0cmluZyB1cmwpCiAgICAgRGlkQ2hhbmdlVmlld3BvcnREYXRhKFdlYkNv cmU6OlZpZXdwb3J0QXJndW1lbnRzIGFyZ3VtZW50cykKICAgICBEaWRSZWNlaXZlRXZlbnQodWlu dDMyX3QgdHlwZSwgYm9vbCBoYW5kbGVkKQotICAgIERpZFZhbGlkYXRlTWVudUl0ZW0oV1RGOjpT dHJpbmcgY29tbWFuZE5hbWUsIGJvb2wgaXNFbmFibGVkLCBpbnQzMl90IHN0YXRlKQorICAgIERp ZFZhbGlkYXRlQ29tbWFuZChXVEY6OlN0cmluZyBjb21tYW5kTmFtZSwgYm9vbCBpc0VuYWJsZWQs IGludDMyX3Qgc3RhdGUpCiAgICAgU2V0Q3Vyc29yKFdlYkNvcmU6OkN1cnNvciBjdXJzb3IpCiAg ICAgU2V0U3RhdHVzVGV4dChXVEY6OlN0cmluZyBzdGF0dXNUZXh0KQogICAgIFNldFRvb2xUaXAo V1RGOjpTdHJpbmcgdG9vbFRpcCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv bWFjL1dLVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDgwMTI0KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC02NjcsOCArNjY3LDcgQEAg LSAoQk9PTCl2YWxpZGF0ZVVzZXJJbnRlcmZhY2VJdGVtOihpZCA8TgogICAgICAgICAvLyBJZiB3 ZSBhcmUgbm90IGFscmVhZHkgYXdhaXRpbmcgdmFsaWRhdGlvbiBmb3IgdGhpcyBjb21tYW5kLCBz dGFydCB0aGUgYXN5bmNocm9ub3VzIHZhbGlkYXRpb24gcHJvY2Vzcy4KICAgICAgICAgLy8gRklY TUU6IFRoZW9yZXRpY2FsbHksIHRoZXJlIGlzIGEgcmFjZSBoZXJlOyB3aGVuIHdlIGdldCB0aGUg YW5zd2VyIGl0IG1pZ2h0IGJlIG9sZCwgZnJvbSBhIHByZXZpb3VzIHRpbWUKICAgICAgICAgLy8g d2UgYXNrZWQgZm9yIHRoZSBzYW1lIGNvbW1hbmQ7IHRoZXJlIGlzIG5vIGd1YXJhbnRlZSB0aGUg YW5zd2VyIGlzIHN0aWxsIHZhbGlkLgotICAgICAgICAvLyBGSVhNRTogVGhlIGZ1bmN0aW9uIGNh bGxlZCBoZXJlIHNob3VsZCBiZSByZW5hbWVkIHZhbGlkYXRlQ29tbWFuZCBiZWNhdXNlIGl0IGlz IG5vdCBzcGVjaWZpYyB0byBtZW51IGl0ZW1zLgotICAgICAgICBfZGF0YS0+X3BhZ2UtPnZhbGlk YXRlTWVudUl0ZW0oY29tbWFuZE5hbWUpOworICAgICAgICBfZGF0YS0+X3BhZ2UtPnZhbGlkYXRl Q29tbWFuZChjb21tYW5kTmFtZSk7CiAgICAgfQogCiAgICAgLy8gVHJlYXQgYXMgZW5hYmxlZCB1 bnRpbCB3ZSBnZXQgdGhlIHJlc3VsdCBiYWNrIGZyb20gdGhlIHdlYiBwcm9jZXNzIGFuZCBfc2V0 VXNlckludGVyZmFjZUl0ZW1TdGF0ZSBpcyBjYWxsZWQuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCShyZXZpc2lvbiA4MDEyNCkKKysrIFNv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtOTc5LDcgKzk3OSw3IEBAIHZvaWQgV2ViUGFnZTo6Z2VzdHVyZUV2ZW50KGNvbnN0IFdl Ykdlc3QKIH0KICNlbmRpZgogCi12b2lkIFdlYlBhZ2U6OnZhbGlkYXRlTWVudUl0ZW0oY29uc3Qg U3RyaW5nJiBjb21tYW5kTmFtZSkKK3ZvaWQgV2ViUGFnZTo6dmFsaWRhdGVDb21tYW5kKGNvbnN0 IFN0cmluZyYgY29tbWFuZE5hbWUpCiB7CiAgICAgYm9vbCBpc0VuYWJsZWQgPSBmYWxzZTsKICAg ICBpbnQzMl90IHN0YXRlID0gMDsKQEAgLTk5MCw3ICs5OTAsNyBAQCB2b2lkIFdlYlBhZ2U6OnZh bGlkYXRlTWVudUl0ZW0oY29uc3QgU3RyCiAgICAgICAgIGlzRW5hYmxlZCA9IGNvbW1hbmQuaXNT dXBwb3J0ZWQoKSAmJiBjb21tYW5kLmlzRW5hYmxlZCgpOwogICAgIH0KIAotICAgIHNlbmQoTWVz c2FnZXM6OldlYlBhZ2VQcm94eTo6RGlkVmFsaWRhdGVNZW51SXRlbShjb21tYW5kTmFtZSwgaXNF bmFibGVkLCBzdGF0ZSkpOworICAgIHNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6RGlkVmFs aWRhdGVDb21tYW5kKGNvbW1hbmROYW1lLCBpc0VuYWJsZWQsIHN0YXRlKSk7CiB9CiAKIHZvaWQg V2ViUGFnZTo6ZXhlY3V0ZUVkaXRDb21tYW5kKGNvbnN0IFN0cmluZyYgY29tbWFuZE5hbWUpCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgJKHJldmlz aW9uIDgwMTI0KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu aAkod29ya2luZyBjb3B5KQpAQCAtMzc5LDcgKzM3OSw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBz ZXRJbml0aWFsRm9jdXMoYm9vbCk7CiAgICAgdm9pZCBzZXRXaW5kb3dSZXNpemVyU2l6ZShjb25z dCBXZWJDb3JlOjpJbnRTaXplJik7CiAgICAgdm9pZCBzZXRJc0luV2luZG93KGJvb2wpOwotICAg IHZvaWQgdmFsaWRhdGVNZW51SXRlbShjb25zdCBTdHJpbmcmKTsKKyAgICB2b2lkIHZhbGlkYXRl Q29tbWFuZChjb25zdCBTdHJpbmcmKTsKICAgICB2b2lkIGV4ZWN1dGVFZGl0Q29tbWFuZChjb25z dCBTdHJpbmcmKTsKIAogICAgIHZvaWQgbW91c2VFdmVudChjb25zdCBXZWJNb3VzZUV2ZW50Jik7 CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNzYWdl cy5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5tZXNzYWdlcy5pbgkocmV2aXNpb24gODAxMjQpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNzYWdlcy5pbgkod29ya2luZyBjb3B5KQpAQCAtOTAs NyArOTAsNyBAQCBtZXNzYWdlcyAtPiBXZWJQYWdlIHsKICAgICBDbG9zZSgpCiAgICAgVHJ5Q2xv c2UoKQogCi0gICAgVmFsaWRhdGVNZW51SXRlbShXVEY6OlN0cmluZyBuYW1lKQorICAgIFZhbGlk YXRlQ29tbWFuZChXVEY6OlN0cmluZyBuYW1lKQogICAgIEV4ZWN1dGVFZGl0Q29tbWFuZChXVEY6 OlN0cmluZyBuYW1lKQogCiAgICAgRGlkUmVtb3ZlRWRpdENvbW1hbmQodWludDY0X3QgY29tbWFu ZElEKQo=