55602 2011-03-02 12:34:31 -0800 REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot 2011-03-03 05:46:09 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80149%20(15273)/DumpRenderTree2-leaks.txt InRadar, Regression P2 Normal --- 55611 1 aroben benjamin benjamin commit-queue darin hyatt mitz sam simon.fraser oldest_to_newest 360986 0 aroben 2011-03-02 12:34:31 -0800 The SnowLeopard Intel Leaks bot is showing lots of leaks of FloatingObjects. See the URL for an example. Maybe this is related to the recent work done in this area in r79817 and r79834? 360987 1 aroben 2011-03-02 12:35:00 -0800 <rdar://problem/9076342> 360990 2 aroben 2011-03-02 12:36:35 -0800 The number of leaks jumped from 409 in r79816: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15177 ...to 3641 in r79817: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15178 360992 3 aroben 2011-03-02 12:39:14 -0800 r79834 seems to have had no effect on the number of leaks: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15186 http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15187 360993 4 benjamin 2011-03-02 12:41:08 -0800 It is probably my fault. I have probably forgot at delete when the object are removed from the list. You can assign to me, I can have a look on Saturday. 361049 5 84459 benjamin 2011-03-02 13:52:37 -0800 Created attachment 84459 Patch 361057 6 benjamin 2011-03-02 13:56:27 -0800 I went over all the call removing objects of m_floatingObjects and found an instance were I forgot to call deleteAllValues(). I created https://bugs.webkit.org/show_bug.cgi?id=55611 to look for a better way to handle memory so we have a long term solution. 361470 7 84459 commit-queue 2011-03-03 02:44:55 -0800 Comment on attachment 84459 Patch Clearing flags on attachment: 84459 Committed r80221: <http://trac.webkit.org/changeset/80221> 361471 8 commit-queue 2011-03-03 02:45:00 -0800 All reviewed patches have been landed. Closing bug. 361537 9 aroben 2011-03-03 05:46:09 -0800 Great! Leaks went from 12434 in r80218: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15291 …to 10964 in r80226: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15292 Thanks, Benjamin! 84459 2011-03-02 13:52:37 -0800 2011-03-03 02:44:55 -0800 Patch bug-55602-20110302225234.patch text/plain 1720 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogODAxNjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNWE4OTQ5MGU4OGFmYjk1 MmNmOWFiNTdlMjFjZDEzZWY3MTIxNDI0Li5iMjUzNjNlNzhiZTExMTc2NjNlMzg0OWNlZmM1YTUz MzIwZjk4YmE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDMtMDIgIEJlbmph bWluIFBvdWxhaW4gIDxpa2lwb3VAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04gKHI3OTgxNyk6IExvdHMgb2YgbGVh a3Mgb2YgRmxvYXRpbmdPYmplY3RzIHNlZW4gb24gU25vd0xlb3BhcmQgSW50ZWwgTGVha3MgYm90 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTYwMgor CisgICAgICAgIERlbGV0ZSB0aGUgRmxvYXRpbmdPYmplY3QgcmVmZXJlbmNlZCBieSBtX2Zsb2F0 aW5nT2JqZWN0cyB3aGVuIGNsZWFyaW5nIHRoZSBmbG9hdHMuCisKKyAgICAgICAgVGhlIERlcHJl Y2F0ZWRQdHJMaXN0IHdhcyBkZWxldGluZyB0aGUgb2JqZWN0cyBhdXRvbWF0aWNhbGx5IGR1ZSB0 byBpdHMgYXV0b0RlbGV0ZSBiZWhhdmlvci4gVGhlCisgICAgICAgIG9iamVjdHMgbmVlZCB0byBi ZSBkZWxldGVkIG1hbnVhbGx5IHdpdGggTGlzdEhhc2hTZXQuCisKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmNsZWFy RmxvYXRzKToKKwogMjAxMS0wMy0wMiAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFVwZGF0ZSBsb2NhdGlvbiBvZiBtZWRpYS1maWxlLmpzLCB3aGlj aCB3YXMgbW92ZWQgaW4gcjc5NjMwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j ay5jcHAKaW5kZXggODM0ZmVjZGRjOGJhZDJkMDAxMDUyN2E5OTkzODlkMDA4YTRiZWU3Mi4uNzUx ZDdhY2ViMjRlMGFlNTY3OWZlMjA5OWQ0NmVmYmM4YzgwMzIwYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBAIC0zNTA4LDggKzM1MDgsMTAgQEAgdm9pZCBSZW5k ZXJCbG9jazo6Y2xlYXJGbG9hdHMoKQogewogICAgIC8vIElubGluZSBibG9ja3MgYXJlIGNvdmVy ZWQgYnkgdGhlIGlzUmVwbGFjZWQoKSBjaGVjayBpbiB0aGUgYXZvaWRGbG9hdHMgbWV0aG9kLgog ICAgIGlmIChhdm9pZHNGbG9hdHMoKSB8fCBpc1Jvb3QoKSB8fCBpc1JlbmRlclZpZXcoKSB8fCBp c0Zsb2F0aW5nT3JQb3NpdGlvbmVkKCkgfHwgaXNUYWJsZUNlbGwoKSkgewotICAgICAgICBpZiAo bV9mbG9hdGluZ09iamVjdHMpCisgICAgICAgIGlmIChtX2Zsb2F0aW5nT2JqZWN0cykgeworICAg ICAgICAgICAgZGVsZXRlQWxsVmFsdWVzKCptX2Zsb2F0aW5nT2JqZWN0cyk7CiAgICAgICAgICAg ICBtX2Zsb2F0aW5nT2JqZWN0cy0+Y2xlYXIoKTsKKyAgICAgICAgfQogICAgICAgICByZXR1cm47 CiAgICAgfQogCg==