55574 2011-03-02 06:48:13 -0800 Web Inspector: Gutter height should be 100% when few lines are displayed 2011-03-04 06:52:29 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 aandrey webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr podivilov rik timothy yurys oldest_to_newest 360768 0 aandrey 2011-03-02 06:48:13 -0800 Repro: open a small script in the Web Inspector, so that there is an empty space at the bottom of the viewer (i.e. no vertical scrollbar). The gutter's height should be 100% in this case. Also a small UI tweak: set gutter's min-width to 19px, which is the minimum width to display a breakpoint marker. 360775 1 84415 aandrey 2011-03-02 07:14:25 -0800 Created attachment 84415 Patch 362471 2 podivilov 2011-03-04 06:52:29 -0800 Committed r80348: <http://trac.webkit.org/changeset/80348> 84415 2011-03-02 07:14:25 -0800 2011-03-04 05:52:42 -0800 Patch bug-55574-20110302181423.patch text/plain 4897 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogODAxMjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiODIzMzY0M2I3Y2M1NzQ3 NzhmMTI3NTEyODBlNDY2NTIyMDM2YWFlLi44YmQ1MGY1MTVlMjJkMzUxZDJhNGVmYjUwNjdhZTc0 MWI1MzU2YWRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDMtMDIgIEFuZHJl eSBBZGFpa2luICA8YWFuZHJleUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEd1dHRlciBoZWlnaHQgc2hv dWxkIGJlIDEwMCUgd2hlbiBmZXcgbGluZXMgYXJlIGRpc3BsYXllZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU1NzQKKworICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291 cmNlRnJhbWUucHJvdG90eXBlLl9zdGFydEVkaXRpbmcpOgorICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvVGV4dFZpZXdlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0Vmlld2Vy LnByb3RvdHlwZS5fc3luY1Njcm9sbCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRv ckd1dHRlclBhbmVsLnByb3RvdHlwZS5fZXhwYW5kQ2h1bmtzKToKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5UZXh0RWRpdG9yR3V0dGVyUGFuZWwucHJvdG90eXBlLnRleHRDaGFuZ2VkKToKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yR3V0dGVyUGFuZWwucHJvdG90eXBlLnN5bmNDbGll bnRIZWlnaHQpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvdGV4dFZpZXdlci5jc3M6 CisgICAgICAgICgudGV4dC1lZGl0b3ItbGluZXMpOgorICAgICAgICAoLnRleHQtZWRpdG9yLWNv bnRlbnRzIC5pbm5lci1jb250YWluZXIpOgorICAgICAgICAoLndlYmtpdC1saW5lLW51bWJlcik6 CisKIDIwMTEtMDMtMDEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcwppbmRleCA0N2RmNjBjOWQ1YjMyMjlmNzk0NWNh ZTQwMjllYTAyOGM0NzNmNzI3Li4zNmNlYjAwN2M4NzY5YTY0MjY4ODJiY2EyMThjYTI0MjgwODFj ZTU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJj ZUZyYW1lLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNl RnJhbWUuanMKQEAgLTE3Niw3ICsxNzYsNyBAQCBXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJv dG90eXBlID0gewogCiAgICAgX3N0YXJ0RWRpdGluZzogZnVuY3Rpb24oKQogICAgIHsKLSAgICAg ICAgV2ViSW5zcGVjdG9yLmNhbmNlbFNlYXJjaCgpOworICAgICAgICBXZWJJbnNwZWN0b3Iuc2Vh cmNoQ29udHJvbGxlci5jYW5jZWxTZWFyY2goKTsKICAgICAgICAgdGhpcy5jbGVhck1lc3NhZ2Vz KCk7CiAgICAgfSwKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9UZXh0Vmlld2VyLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9U ZXh0Vmlld2VyLmpzCmluZGV4IDk4Y2QwZTE5OTk1MTIyNGIwZTRkMDkwMzAxZThkYmQ1YTI4OTE2 MGEuLjJjYzBlNzlmMDFiMGFhMDllYzNiMmVjNjFmZDkzMGRjNGU0YWUxNjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qcworKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRWaWV3ZXIuanMKQEAgLTIwMSwx MyArMjAxLDggQEAgV2ViSW5zcGVjdG9yLlRleHRWaWV3ZXIucHJvdG90eXBlID0gewogICAgICAg ICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgewogICAgICAgICAgICAgdmFyIG1haW5FbGVtZW50ID0g dGhpcy5fbWFpblBhbmVsLmVsZW1lbnQ7CiAgICAgICAgICAgICB2YXIgZ3V0dGVyRWxlbWVudCA9 IHRoaXMuX2d1dHRlclBhbmVsLmVsZW1lbnQ7Ci0KICAgICAgICAgICAgIC8vIEhhbmRsZSBob3Jp em9udGFsIHNjcm9sbCBiYXIgYXQgdGhlIGJvdHRvbSBvZiB0aGUgbWFpbiBwYW5lbC4KLSAgICAg ICAgICAgIGlmIChndXR0ZXJFbGVtZW50Lm9mZnNldEhlaWdodCA+IG1haW5FbGVtZW50LmNsaWVu dEhlaWdodCkKLSAgICAgICAgICAgICAgICB0aGlzLl9ndXR0ZXJQYW5lbC5fY29udGFpbmVyLnN0 eWxlLnNldFByb3BlcnR5KCJwYWRkaW5nLWJvdHRvbSIsIChndXR0ZXJFbGVtZW50Lm9mZnNldEhl aWdodCAtIG1haW5FbGVtZW50LmNsaWVudEhlaWdodCkgKyAicHgiKTsKLSAgICAgICAgICAgIGVs c2UKLSAgICAgICAgICAgICAgICB0aGlzLl9ndXR0ZXJQYW5lbC5fY29udGFpbmVyLnN0eWxlLnJl bW92ZVByb3BlcnR5KCJwYWRkaW5nLWJvdHRvbSIpOwotCisgICAgICAgICAgICB0aGlzLl9ndXR0 ZXJQYW5lbC5zeW5jQ2xpZW50SGVpZ2h0KG1haW5FbGVtZW50LmNsaWVudEhlaWdodCk7CiAgICAg ICAgICAgICBndXR0ZXJFbGVtZW50LnNjcm9sbFRvcCA9IG1haW5FbGVtZW50LnNjcm9sbFRvcDsK ICAgICAgICAgfS5iaW5kKHRoaXMpLCAwKTsKICAgICB9LApAQCAtNDk3LDcgKzQ5Miw2IEBAIFdl Ykluc3BlY3Rvci5UZXh0RWRpdG9yR3V0dGVyUGFuZWwucHJvdG90eXBlID0gewogICAgIHsKICAg ICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0aGlzLl90ZXh0Q2h1bmtzLmxlbmd0aDsgKytpKQog ICAgICAgICAgICAgdGhpcy5fdGV4dENodW5rc1tpXS5leHBhbmRlZCA9IChmcm9tSW5kZXggPD0g aSAmJiBpIDwgdG9JbmRleCk7Ci0gICAgICAgIHRoaXMuZWxlbWVudC5zdHlsZS5zZXRQcm9wZXJ0 eSgid2lkdGgiLCB0aGlzLl9jb250YWluZXIub2Zmc2V0V2lkdGggKyAicHgiKTsKICAgICB9LAog CiAgICAgdGV4dENoYW5nZWQ6IGZ1bmN0aW9uKG9sZFJhbmdlLCBuZXdSYW5nZSkKQEAgLTU0MSw2 ICs1MzUsMTQgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JHdXR0ZXJQYW5lbC5wcm90b3R5cGUg PSB7CiAgICAgICAgICAgICAgICAgY2h1bmsgPSB0aGlzLl90ZXh0Q2h1bmtzWysrY2h1bmtOdW1i ZXJdOwogICAgICAgICAgICAgfQogICAgICAgICB9CisgICAgfSwKKworICAgIHN5bmNDbGllbnRI ZWlnaHQ6IGZ1bmN0aW9uKGNsaWVudEhlaWdodCkKKyAgICB7CisgICAgICAgIGlmICh0aGlzLmVs ZW1lbnQub2Zmc2V0SGVpZ2h0ID4gY2xpZW50SGVpZ2h0KQorICAgICAgICAgICAgdGhpcy5fY29u dGFpbmVyLnN0eWxlLnNldFByb3BlcnR5KCJwYWRkaW5nLWJvdHRvbSIsICh0aGlzLmVsZW1lbnQu b2Zmc2V0SGVpZ2h0IC0gY2xpZW50SGVpZ2h0KSArICJweCIpOworICAgICAgICBlbHNlCisgICAg ICAgICAgICB0aGlzLl9jb250YWluZXIuc3R5bGUucmVtb3ZlUHJvcGVydHkoInBhZGRpbmctYm90 dG9tIik7CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL3RleHRWaWV3ZXIuY3NzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC90ZXh0Vmlld2VyLmNzcwppbmRleCBlNTg2YTFlNGRlY2Y1OTZhOThjMDU0MzJmN2UwMTcw OGEwMzI3NWU4Li41OWYyYTQzMGQ4MGQyMDFmNjI0YTEzYjI0OWM3Y2Y5OWEzYmY0MTU2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3RleHRWaWV3ZXIuY3Nz CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdGV4dFZpZXdlci5jc3MK QEAgLTE1LDE1ICsxNSw5IEBACiAgICAgYm90dG9tOiAwOwogICAgIG92ZXJmbG93OiBoaWRkZW47 CiAgICAgLXdlYmtpdC11c2VyLXNlbGVjdDogbm9uZTsKLX0KLQotLmlubmVyLWNvbnRhaW5lciB7 Ci0gICAgcG9zaXRpb246IGFic29sdXRlOwotICAgIHRvcDogMDsKLSAgICBsZWZ0OiAwOwotICAg IHJpZ2h0OiBhdXRvOwotICAgIGJvdHRvbTogYXV0bzsKLSAgICBtaW4td2lkdGg6IDEwMCU7Cisg ICAgYmFja2dyb3VuZC1jb2xvcjogcmdiKDI0MCwgMjQwLCAyNDApOworICAgIGJvcmRlci1yaWdo dDogMXB4IHNvbGlkIHJnYigxODcsIDE4NywgMTg3KTsKKyAgICBtaW4td2lkdGg6IDE5cHg7CiB9 CiAKIC50ZXh0LWVkaXRvci1jb250ZW50cyB7CkBAIC0zNiw2ICszMCwxNSBAQAogICAgIC13ZWJr aXQtdXNlci1zZWxlY3Q6IHRleHQ7CiB9CiAKKy50ZXh0LWVkaXRvci1jb250ZW50cyAuaW5uZXIt Y29udGFpbmVyIHsKKyAgICBwb3NpdGlvbjogYWJzb2x1dGU7CisgICAgdG9wOiAwOworICAgIGxl ZnQ6IDA7CisgICAgcmlnaHQ6IGF1dG87CisgICAgYm90dG9tOiBhdXRvOworICAgIG1pbi13aWR0 aDogMTAwJTsKK30KKwogLnRleHQtZWRpdG9yLWVkaXRhYmxlIHsKICAgICAtd2Via2l0LXVzZXIt bW9kaWZ5OiByZWFkLXdyaXRlLXBsYWludGV4dC1vbmx5OwogfQpAQCAtODksOCArOTIsNiBAQAog CiAud2Via2l0LWxpbmUtbnVtYmVyIHsKICAgICBjb2xvcjogcmdiKDEyOCwgMTI4LCAxMjgpOwot ICAgIGJhY2tncm91bmQtY29sb3I6IHJnYigyNDAsIDI0MCwgMjQwKTsKLSAgICBib3JkZXItcmln aHQ6IDFweCBzb2xpZCByZ2IoMTg3LCAxODcsIDE4Nyk7CiAgICAgdGV4dC1hbGlnbjogcmlnaHQ7 CiAgICAgdmVydGljYWwtYWxpZ246IHRvcDsKICAgICB3b3JkLWJyZWFrOiBub3JtYWw7Cg==