55572 2011-03-02 05:16:34 -0800 Check for spaces in names doesn't take into account non-alphanumeric characters 2011-06-18 12:33:44 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P1 Normal --- 1 skylined skylined darin dbates eric webkit.review.bot oldest_to_newest 360744 0 skylined 2011-03-02 05:16:34 -0800 /WebKit/Tools/Scripts/VCSUtils.pm@1671: changeLogNameError("'$name' does not contain a space! ChangeLogs should contain your full name.") unless ($name =~ /\w \w/); I had set my name to "B.J. Wever", and wasn't allowed to create a changelog because it "does not contain a space", which is incorrect. Since my full-full name is "Berend-Jan Wever", which also has non-alphameric characters, I'm fixing the check, rather than the message. 360748 1 84408 skylined 2011-03-02 05:19:26 -0800 Created attachment 84408 Patch 360761 2 84411 skylined 2011-03-02 06:19:46 -0800 Created attachment 84411 Better patch 360894 3 84411 eric 2011-03-02 10:25:59 -0800 Comment on attachment 84411 Better patch I'm confued. "B.J. Wever" has a space in it, doesn't it? What's it matching? Is it incorrectly picking up on ly part of your name? This change looks fine though, but I don't really understand how the old code failed for you. 360973 4 ap 2011-03-02 12:17:59 -0800 "B.J. Wever" obviously doesn't match /\w \w/ indeed - \w is letters, digits, and underscores. 360976 5 eric 2011-03-02 12:23:13 -0800 I see. the "." doesn't match the \w. Thank you ap. 423176 6 84411 webkit.review.bot 2011-06-18 12:33:40 -0700 Comment on attachment 84411 Better patch Clearing flags on attachment: 84411 Committed r89196: <http://trac.webkit.org/changeset/89196> 423177 7 webkit.review.bot 2011-06-18 12:33:44 -0700 All reviewed patches have been landed. Closing bug. 84408 2011-03-02 05:19:26 -0800 2011-03-02 06:19:46 -0800 Patch patch application/octet-stream 1409 skylined SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDgwMTE2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTEtMDMtMDIgIEJlcmVuZC1KYW4gV2V2ZXIgIDxza3lsaW5lZEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U29tZSBuYW1lcyB3aXRoIHNwYWNlcyBhcmUgaW5jb3JyZWN0bHkgcmVwb3J0ZWQgYXMgbm90IGNv bnRhaW5pbmcgc3BhY2VzCisgICAgICAgIHdoaWxlIHJ1bm5pbmcgcHJlcGFyZS1DaGFuZ2VMb2cK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1NTcyCisK KyAgICAgICAgKiBTY3JpcHRzL1ZDU1V0aWxzLnBtOiBVcGRhdGVkIENIQU5HRV9MT0dfTkFNRSBj aGVjayBmb3Igc3BhY2VzIHRvIGFsbG93CisgICAgICAgICAgbm9uLWFscGhhbnVtZXJpYyBjaGFy YWN0ZXJzIGluIG5hbWVzLgorCiAyMDExLTAzLTAxICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBU b29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvVkNT VXRpbHMucG0JKHJldmlzaW9uIDgwMTEyKQorKysgVG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQko d29ya2luZyBjb3B5KQpAQCAtMTY2OCw3ICsxNjY4LDcgQEAgc3ViIGNoYW5nZUxvZ05hbWUoKQog CiAgICAgY2hhbmdlTG9nTmFtZUVycm9yKCJGYWlsZWQgdG8gZGV0ZXJtaW5lIENoYW5nZUxvZyBu YW1lLiIpIHVubGVzcyAkbmFtZTsKICAgICAjIGdldHB3dWlkIHNlZW1zIHRvIGFsd2F5cyBzdWNj ZWVkIG9uIHdpbmRvd3MsIHJldHVybmluZyB0aGUgdXNlcm5hbWUgaW5zdGVhZCBvZiB0aGUgZnVs bCBuYW1lLiAgVGhpcyBjaGVjayB3aWxsIGNhdGNoIHRoYXQgY2FzZS4KLSAgICBjaGFuZ2VMb2dO YW1lRXJyb3IoIickbmFtZScgZG9lcyBub3QgY29udGFpbiBhIHNwYWNlISAgQ2hhbmdlTG9ncyBz aG91bGQgY29udGFpbiB5b3VyIGZ1bGwgbmFtZS4iKSB1bmxlc3MgKCRuYW1lID1+IC9cdyBcdy8p OworICAgIGNoYW5nZUxvZ05hbWVFcnJvcigiJyRuYW1lJyBkb2VzIG5vdCBjb250YWluIGEgc3Bh Y2UhICBDaGFuZ2VMb2dzIHNob3VsZCBjb250YWluIHlvdXIgZnVsbCBuYW1lLiIpIHVubGVzcyAo JG5hbWUgPX4gLy4gLi8pOwogCiAgICAgcmV0dXJuICRuYW1lOwogfQo= 84411 2011-03-02 06:19:46 -0800 2011-06-18 12:33:40 -0700 Better patch patch text/plain 1412 skylined SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDgwMTE2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTEtMDMtMDIgIEJlcmVuZC1KYW4gV2V2ZXIgIDxza3lsaW5lZEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U29tZSBuYW1lcyB3aXRoIHNwYWNlcyBhcmUgaW5jb3JyZWN0bHkgcmVwb3J0ZWQgYXMgbm90IGNv bnRhaW5pbmcgc3BhY2VzCisgICAgICAgIHdoaWxlIHJ1bm5pbmcgcHJlcGFyZS1DaGFuZ2VMb2cK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1NTcyCisK KyAgICAgICAgKiBTY3JpcHRzL1ZDU1V0aWxzLnBtOiBVcGRhdGVkIENIQU5HRV9MT0dfTkFNRSBj aGVjayBmb3Igc3BhY2VzIHRvIGFsbG93CisgICAgICAgICAgbm9uLWFscGhhbnVtZXJpYyBjaGFy YWN0ZXJzIGluIG5hbWVzLgorCiAyMDExLTAzLTAxICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBU b29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvVkNT VXRpbHMucG0JKHJldmlzaW9uIDgwMTEyKQorKysgVG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQko d29ya2luZyBjb3B5KQpAQCAtMTY2OCw3ICsxNjY4LDcgQEAgc3ViIGNoYW5nZUxvZ05hbWUoKQog CiAgICAgY2hhbmdlTG9nTmFtZUVycm9yKCJGYWlsZWQgdG8gZGV0ZXJtaW5lIENoYW5nZUxvZyBu YW1lLiIpIHVubGVzcyAkbmFtZTsKICAgICAjIGdldHB3dWlkIHNlZW1zIHRvIGFsd2F5cyBzdWNj ZWVkIG9uIHdpbmRvd3MsIHJldHVybmluZyB0aGUgdXNlcm5hbWUgaW5zdGVhZCBvZiB0aGUgZnVs bCBuYW1lLiAgVGhpcyBjaGVjayB3aWxsIGNhdGNoIHRoYXQgY2FzZS4KLSAgICBjaGFuZ2VMb2dO YW1lRXJyb3IoIickbmFtZScgZG9lcyBub3QgY29udGFpbiBhIHNwYWNlISAgQ2hhbmdlTG9ncyBz aG91bGQgY29udGFpbiB5b3VyIGZ1bGwgbmFtZS4iKSB1bmxlc3MgKCRuYW1lID1+IC9cdyBcdy8p OworICAgIGNoYW5nZUxvZ05hbWVFcnJvcigiJyRuYW1lJyBkb2VzIG5vdCBjb250YWluIGEgc3Bh Y2UhICBDaGFuZ2VMb2dzIHNob3VsZCBjb250YWluIHlvdXIgZnVsbCBuYW1lLiIpIHVubGVzcyAo JG5hbWUgPX4gL1xTXHNcUy8pOwogCiAgICAgcmV0dXJuICRuYW1lOwogfQo=