55566 2011-03-02 03:12:55 -0800 V8 version of JavaString should obtain string from JNI in UTF-16 encoding 2011-03-04 03:18:43 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 55567 1 steveblock webkit-unassigned abarth commit-queue eric jorlow steveblock webkit.review.bot oldest_to_newest 360693 0 steveblock 2011-03-02 03:12:55 -0800 Currently, the V8 version of JavaString obtains the string from JNI in modified UTF-8 encoding. This does not match the regular UTF-8 encoding. Instead, we should obtain the string from JNI in UTF-16 encoding and convert to UTF-8 using our own routines as required. This matches the behaviour of the JSC version of JavaString. 361002 1 84450 steveblock 2011-03-02 12:58:14 -0800 Created attachment 84450 Patch 362153 2 84450 jorlow 2011-03-03 17:58:42 -0800 Comment on attachment 84450 Patch r=me 362370 3 84450 commit-queue 2011-03-04 01:45:29 -0800 Comment on attachment 84450 Patch Clearing flags on attachment: 84450 Committed r80339: <http://trac.webkit.org/changeset/80339> 362371 4 commit-queue 2011-03-04 01:45:33 -0800 All reviewed patches have been landed. Closing bug. 362399 5 webkit.review.bot 2011-03-04 03:18:43 -0800 http://trac.webkit.org/changeset/80339 might have broken GTK Linux 64-bit Debug The following tests are not passing: fast/dom/HTMLDocument/hasFocus.html fast/events/standalone-image-drag-to-editable.html fast/files/apply-blob-url-to-img.html inspector/timeline/timeline-network-resource.html 84450 2011-03-02 12:58:14 -0800 2011-03-04 01:45:29 -0800 Patch bug-55566-20110302205812.patch text/plain 2759 steveblock U3VidmVyc2lvbiBSZXZpc2lvbjogODAxNTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1NTZlZjg0MjkwMWJiMDUy OWFlNDVlNzZkMjIyZjIzOTQ1ZTIzNDAyLi5hZjRjYTUxOGFkN2Q0MGUyNmE1MDhkODc0MzA4M2Yw NTIyYzNmNzZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMgQEAKIDIwMTEtMDMtMDIgIFN0ZXZl IEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFY4IHZlcnNpb24gb2YgSmF2YVN0cmluZyBzaG91bGQg b2J0YWluIHN0cmluZyBmcm9tIEpOSSBpbiBVVEYtMTYgZW5jb2RpbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1NTY2CisKKyAgICAgICAgV2Ugb2J0 YWluIHRoZSBzdHJpbmcgZnJvbSBKTkkgaW4gVVRGLTE2IGVuY29kaW5nIGFuZCBjb252ZXJ0Cisg ICAgICAgIHRvIFVURi04IHVzaW5nIG91ciBvd24gcm91dGluZXMgYXMgcmVxdWlyZWQuIFRoaXMg bWF0Y2hlcyB0aGUKKyAgICAgICAgYmVoYXZpb3VyIG9mIHRoZSBKU0MgdmVyc2lvbiBvZiBKYXZh U3RyaW5nLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIGluIGJlaGF2aW91ci4K KworICAgICAgICAqIGJyaWRnZS9qbmkvdjgvSmF2YVN0cmluZ1Y4Lmg6CisgICAgICAgIChKU0M6 OkJpbmRpbmdzOjpKYXZhU3RyaW5nSW1wbDo6aW5pdCk6CisgICAgICAgIChKU0M6OkJpbmRpbmdz OjpKYXZhU3RyaW5nSW1wbDo6dXRmOCk6CisgICAgICAgIChKU0M6OkJpbmRpbmdzOjpKYXZhU3Ry aW5nSW1wbDo6aW1wbCk6CisKKzIwMTEtMDMtMDIgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bn b29nbGUuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KIAogICAgICAg ICBKYXZhU3RyaW5nIEFQSSBzaG91bGQgYmUgaW1wbGVtZW50YWJsZSBieSBib3RoIEpTQyBhbmQg VjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9qbmkvdjgvSmF2YVN0cmluZ1Y4 LmggYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2Uvam5pL3Y4L0phdmFTdHJpbmdWOC5oCmluZGV4IGQ4 YzkwODQ4YWQwYjcyZWE4MzczNjAxYTBiZWE4Y2NmNTg5ZGY1MWUuLjY0ZGIzMzFlZGNjYmIzN2Nm YTI0OTY2YWI3ZGY2ZDI3YzUxNWY3OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JyaWRn ZS9qbmkvdjgvSmF2YVN0cmluZ1Y4LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYnJpZGdlL2puaS92 OC9KYXZhU3RyaW5nVjguaApAQCAtMjgsMTIgKzI4LDggQEAKIAogI2luY2x1ZGUgIkpOSVV0aWxp dHkuaCIKIAotI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQv Q1N0cmluZy5oPgotCi1uYW1lc3BhY2UgV1RGIHsKLWNsYXNzIFN0cmluZ0ltcGw7Ci19CisjaW5j bHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKIAogbmFtZXNwYWNlIEpTQyB7CkBAIC00NCwy MCArNDAsMjYgQEAgY2xhc3MgSmF2YVN0cmluZ0ltcGwgewogcHVibGljOgogICAgIHZvaWQgaW5p dCgpIHt9CiAKLSAgICB2b2lkIGluaXQoSk5JRW52KiBlLCBqc3RyaW5nIHMpCisgICAgdm9pZCBp bml0KEpOSUVudiogZW52LCBqc3RyaW5nIHN0cmluZykKICAgICB7Ci0gICAgICAgIGludCBzaXpl ID0gZS0+R2V0U3RyaW5nTGVuZ3RoKHMpOwotICAgICAgICBjb25zdCBjaGFyKiBjcyA9IGdldENo YXJhY3RlcnNGcm9tSlN0cmluZ0luRW52KGUsIHMpOwotICAgICAgICBtX3V0ZjhTdHJpbmcgPSBX VEY6OkNTdHJpbmcoY3MsIHNpemUpOwotICAgICAgICByZWxlYXNlQ2hhcmFjdGVyc0ZvckpTdHJp bmdJbkVudihlLCBzLCBjcyk7CisgICAgICAgIGludCBzaXplID0gZW52LT5HZXRTdHJpbmdMZW5n dGgoc3RyaW5nKTsKKyAgICAgICAgY29uc3QgamNoYXIqIGpDaGFycyA9IGdldFVDaGFyYWN0ZXJz RnJvbUpTdHJpbmdJbkVudihlbnYsIHN0cmluZyk7CisgICAgICAgIG1faW1wbCA9IFN0cmluZ0lt cGw6OmNyZWF0ZShqQ2hhcnMsIHNpemUpOworICAgICAgICByZWxlYXNlVUNoYXJhY3RlcnNGb3JK U3RyaW5nSW5FbnYoZW52LCBzdHJpbmcsIGpDaGFycyk7CiAgICAgfQogCi0gICAgY29uc3QgY2hh ciogdXRmOCgpIGNvbnN0IHsgcmV0dXJuIG1fdXRmOFN0cmluZy5kYXRhKCk7IH0KKyAgICBjb25z dCBjaGFyKiB1dGY4KCkgY29uc3QKKyAgICB7CisgICAgICAgIGlmICghbV91dGY4U3RyaW5nLmRh dGEoKSkKKyAgICAgICAgICAgIG1fdXRmOFN0cmluZyA9IFN0cmluZyhtX2ltcGwpLnV0ZjgoKTsK KyAgICAgICAgcmV0dXJuIG1fdXRmOFN0cmluZy5kYXRhKCk7CisgICAgfQogICAgIGludCBsZW5n dGgoKSBjb25zdCB7IHJldHVybiBtX3V0ZjhTdHJpbmcubGVuZ3RoKCk7IH0KLSAgICBTdHJpbmdJ bXBsKiBpbXBsKCkgY29uc3QgeyBBU1NFUlRfTk9UX1JFQUNIRUQoKTsgcmV0dXJuIDA7IH0KKyAg ICBTdHJpbmdJbXBsKiBpbXBsKCkgY29uc3QgeyByZXR1cm4gbV9pbXBsLmdldCgpOyB9CiAKIHBy aXZhdGU6Ci0gICAgV1RGOjpDU3RyaW5nIG1fdXRmOFN0cmluZzsKKyAgICBSZWZQdHI8U3RyaW5n SW1wbD4gbV9pbXBsOworICAgIG11dGFibGUgQ1N0cmluZyBtX3V0ZjhTdHJpbmc7CiB9OwogCiB9 IC8vIG5hbWVzcGFjZSBCaW5kaW5ncwo=