55558 2011-03-02 00:00:02 -0800 Web Inspector: inspector protocol should allow different domains to have methods with same name 2011-03-03 03:59:27 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 55584 0 yurys webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 360632 0 yurys 2011-03-02 00:00:02 -0800 Now we cannot have Debugger.enable and Profiler.enable methods as they both would be translated into "enable" command and break InspectorBackendDispatcher which maps each command name to a single agent+method pair. Also each protocol event results in a similarly named method on InspectorFrontend. 361362 1 84519 yurys 2011-03-02 22:25:25 -0800 Created attachment 84519 Patch 361510 2 yurys 2011-03-03 03:59:27 -0800 Committed r80230: <http://trac.webkit.org/changeset/80230> 84519 2011-03-02 22:25:25 -0800 2011-03-02 23:13:03 -0800 Patch bug-55558-20110303092522.patch text/plain 3174 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogODAyMDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5NDE0ZmRhMzY1ZWQ0OTdm MmI5ZWQ5YjJlOGQ3NTA4MWVmYzY0MjM4Li5jMjhiYTJhNDZiMmZjNmQ5MWRiYzExNWJiNDkyODI4 YzI4MDg0MDcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTEtMDMtMDIgIFl1cnkg U2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogaW5zcGVjdG9yIHByb3Rv Y29sIHNob3VsZCBhbGxvdyBkaWZmZXJlbnQgZG9tYWlucyB0byBoYXZlIG1ldGhvZHMgd2l0aCBz YW1lIG5hbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU1NTU4CisKKyAgICAgICAgKiBpbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5wbTog ZWFjaCBjb21tYW5kIGlzIG5vdyBpZGVudGlmaWVkIGJ5IGRvbWFpbiArIGNvbW1hbmQtbmFtZSh3 YXMgY29tbWFuZC1uYW1lIG9ubHkpLgorCisyMDExLTAzLTAyICBZdXJ5IFNlbWlraGF0c2t5ICA8 eXVyeXNAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4u CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogYnJlYWsgZG93biBJbnNwZWN0b3JGcm9udGVuZCBp bnRvIGRvbWFpbi1zcGVjaWZpYyBjbGFzc2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5wbSBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yLnBtCmluZGV4IDcyZjQ5NTg5NDZlN2Y1MzQwNjBm NGVhMjc5ZGIzN2QwZTBhMGE4NjIuLjJhNDA3YjliNTVjMWY2ODZiMjE3YTYwZWQ0NWU2Mzk1NTJl MDJlYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9Db2RlR2VuZXJhdG9y SW5zcGVjdG9yLnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9Db2RlR2VuZXJhdG9y SW5zcGVjdG9yLnBtCkBAIC00NTUsNyArNDU1LDcgQEAgc3ViIGdlbmVyYXRlQmFja2VuZEZ1bmN0 aW9uCiAgICAgbXkgJGZ1bGxRdWFsaWZpZWRGdW5jdGlvbk5hbWUgPSAkaW50ZXJmYWNlLT5uYW1l IC4gIl8iIC4gJGZ1bmN0aW9uLT5zaWduYXR1cmUtPm5hbWU7CiAKICAgICBwdXNoKEBiYWNrZW5k Q29uc3RhbnREZWNsYXJhdGlvbnMsICIgICAgc3RhdGljIGNvbnN0IGNoYXIqICR7ZnVsbFF1YWxp ZmllZEZ1bmN0aW9uTmFtZX1DbWQ7Iik7Ci0gICAgcHVzaChAYmFja2VuZENvbnN0YW50RGVmaW5p dGlvbnMsICJjb25zdCBjaGFyKiAke2JhY2tlbmRDbGFzc05hbWV9Ojoke2Z1bGxRdWFsaWZpZWRG dW5jdGlvbk5hbWV9Q21kID0gXCIke2Z1bmN0aW9uTmFtZX1cIjsiKTsKKyAgICBwdXNoKEBiYWNr ZW5kQ29uc3RhbnREZWZpbml0aW9ucywgImNvbnN0IGNoYXIqICR7YmFja2VuZENsYXNzTmFtZX06 OiR7ZnVsbFF1YWxpZmllZEZ1bmN0aW9uTmFtZX1DbWQgPSBcIiR7ZnVsbFF1YWxpZmllZEZ1bmN0 aW9uTmFtZX1cIjsiKTsKIAogICAgIG1hcCgkYmFja2VuZFR5cGVzeyRfLT50eXBlfSA9IDEsIEB7 JGZ1bmN0aW9uLT5wYXJhbWV0ZXJzfSk7ICMgcmVnaXN0ZXIgcmVxdWlyZWQgdHlwZXMKICAgICBt eSBAaW5BcmdzID0gZ3JlcCgkXy0+ZGlyZWN0aW9uIGVxICJpbiIgJiYgISgkXy0+bmFtZSBlcSAi Y2FsbElkIikgLCBAeyRmdW5jdGlvbi0+cGFyYW1ldGVyc30pOwpAQCAtNjg2LDYgKzY4NiwxOCBA QCAkbWFwRW50cmllcwogICAgICAgICByZXR1cm47CiAgICAgfQogCisgICAgUmVmUHRyPEluc3Bl Y3RvclZhbHVlPiBkb21haW5WYWx1ZSA9IG1lc3NhZ2VPYmplY3QtPmdldCgiZG9tYWluIik7Cisg ICAgaWYgKCFkb21haW5WYWx1ZSkgeworICAgICAgICByZXBvcnRQcm90b2NvbEVycm9yKGNhbGxJ ZCwgIlByb3RvY29sIEVycm9yOiBJbnZhbGlkIG1lc3NhZ2UgZm9ybWF0LiAnZG9tYWluJyBwcm9w ZXJ0eSB3YXNuJ3QgZm91bmQuIik7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBTdHJp bmcgZG9tYWluOworICAgIGlmICghZG9tYWluVmFsdWUtPmFzU3RyaW5nKCZkb21haW4pKSB7Cisg ICAgICAgIHJlcG9ydFByb3RvY29sRXJyb3IoY2FsbElkLCAiUHJvdG9jb2wgRXJyb3I6IEludmFs aWQgbWVzc2FnZSBmb3JtYXQuIFRoZSB0eXBlIG9mICdkb21haW4nIHByb3BlcnR5IHNob3VsZCBi ZSBzdHJpbmcuIik7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBSZWZQdHI8SW5zcGVj dG9yVmFsdWU+IGNhbGxJZFZhbHVlID0gbWVzc2FnZU9iamVjdC0+Z2V0KCJzZXEiKTsKICAgICBp ZiAoIWNhbGxJZFZhbHVlKSB7CiAgICAgICAgIHJlcG9ydFByb3RvY29sRXJyb3IoY2FsbElkLCAi UHJvdG9jb2wgRXJyb3I6IEludmFsaWQgbWVzc2FnZSBmb3JtYXQuICdzZXEnIHByb3BlcnR5IHdh cyBub3QgZm91bmQgaW4gdGhlIHJlcXVlc3QuIik7CkBAIC02OTcsOSArNzA5LDkgQEAgJG1hcEVu dHJpZXMKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIEhhc2hNYXA8U3RyaW5nLCBDYWxs SGFuZGxlcj46Oml0ZXJhdG9yIGl0ID0gZGlzcGF0Y2hNYXAuZmluZChjb21tYW5kKTsKKyAgICBI YXNoTWFwPFN0cmluZywgQ2FsbEhhbmRsZXI+OjppdGVyYXRvciBpdCA9IGRpc3BhdGNoTWFwLmZp bmQobWFrZVN0cmluZyhkb21haW4sICJfIiwgY29tbWFuZCkpOwogICAgIGlmIChpdCA9PSBkaXNw YXRjaE1hcC5lbmQoKSkgewotICAgICAgICByZXBvcnRQcm90b2NvbEVycm9yKGNhbGxJZCwgbWFr ZVN0cmluZygiUHJvdG9jb2wgRXJyb3I6IEludmFsaWQgY29tbWFuZCB3YXMgcmVjZWl2ZWQuICci LCBjb21tYW5kLCAiJyB3YXNuJ3QgZm91bmQuIikpOworICAgICAgICByZXBvcnRQcm90b2NvbEVy cm9yKGNhbGxJZCwgbWFrZVN0cmluZygiUHJvdG9jb2wgRXJyb3I6IEludmFsaWQgY29tbWFuZCB3 YXMgcmVjZWl2ZWQuICciLCBjb21tYW5kLCAiJyB3YXNuJ3QgZm91bmQgaW4gZG9tYWluICIsIGRv bWFpbiwgIi4iKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAK