55549 2011-03-01 20:26:53 -0800 Remove efl port style exception of Webcore/JavaScriptCore 2011-03-07 00:17:51 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue kenneth leandro tkent tonikitoo webkit.review.bot oldest_to_newest 360532 0 gyuyoung.kim 2011-03-01 20:26:53 -0800 As mentioned in Bug 55292 comment #3, WebCore and JavaScriptCore need to adhere WebKit coding style. 360534 1 84360 gyuyoung.kim 2011-03-01 20:28:47 -0800 Created attachment 84360 Patch 360536 2 webkit.review.bot 2011-03-01 20:30:53 -0800 Attachment 84360 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 52, in <module> import webkitpy.style.checker as checker File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 172 "-readability/parameter_name"]), ^ SyntaxError: invalid syntax If any of these errors are false positives, please file a bug against check-webkit-style. 360538 3 84360 tkent 2011-03-01 20:33:21 -0800 Comment on attachment 84360 Patch Looks good. 360539 4 84360 gyuyoung.kim 2011-03-01 20:35:26 -0800 Comment on attachment 84360 Patch There is a syntax problem. I'm going to upload new patch soon with your name. 360541 5 84361 gyuyoung.kim 2011-03-01 20:37:41 -0800 Created attachment 84361 Patch I fix style error. 360590 6 84361 commit-queue 2011-03-01 22:29:07 -0800 Comment on attachment 84361 Patch Clearing flags on attachment: 84361 Committed r80095: <http://trac.webkit.org/changeset/80095> 84360 2011-03-01 20:28:47 -0800 2011-03-01 20:35:26 -0800 Patch patch-styleerror.patch text/plain 1213 gyuyoung.kim ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4OGFh ZDA4Li43NTA1YjdkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDMtMDEgIEd5dXlvdW5nIEtpbSAgPGd5dXlv dW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW1vdmUgZWZsIHBvcnQgc3R5bGUgZXhjZXB0aW9uIG9mIFdlYmNvcmUv SmF2YVNjcmlwdENvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU1NTQ5CisKKyAgICAgICAgV2ViQ29yZSBhbmQgSmF2YVNjcmlwdENvcmUgbmVlZCB0 byBhZGhlcmUgV2ViS2l0IGNvZGluZyBzdHlsZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlci5weToKKwogMjAxMS0wMy0wMSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQu cmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjgwMDc5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CmluZGV4IDVmYTgz NTYuLjVhZDdhZGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKQEAg LTE2NywxMCArMTY3LDcgQEAgX1BBVEhfUlVMRVNfU1BFQ0lGSUVSID0gWwogICAgIChbIyBUaGUg RUZMIEFQSXMgdXNlIEVGTCBuYW1pbmcgc3R5bGUsIHdoaWNoIGluY2x1ZGVzCiAgICAgICAjIGJv dGggbG93ZXItY2FzZWQgYW5kIGNhbWVsLWNhc2VkLCB1bmRlcnNjb3JlLXNwYXJhdGVkCiAgICAg ICAjIHZhbHVlcy4KLSAgICAgICJTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwiLAotICAgICAg IlNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VmbCIsCiAgICAgICAiU291cmNlL1dl YktpdC9lZmwvZXdrLyIsCi0gICAgICAiU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9lZmwvIl0s CiAgICAgIFsiLXJlYWRhYmlsaXR5L25hbWluZyIsCiAgICAgICAiLXJlYWRhYmlsaXR5L3BhcmFt ZXRlcl9uYW1lIl0pLAogCg== 84361 2011-03-01 20:37:41 -0800 2011-03-01 22:29:07 -0800 Patch patch-styleerror.patch text/plain 1244 gyuyoung.kim ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4OGFh ZDA4Li5hYWExMmJiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDMtMDEgIEd5dXlvdW5nIEtpbSAgPGd5dXlv dW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4K KworICAgICAgICBSZW1vdmUgZWZsIHBvcnQgc3R5bGUgZXhjZXB0aW9uIG9mIFdlYmNvcmUvSmF2 YVNjcmlwdENvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU1NTQ5CisKKyAgICAgICAgV2ViQ29yZSBhbmQgSmF2YVNjcmlwdENvcmUgbmVlZCB0byBh ZGhlcmUgV2ViS2l0IGNvZGluZyBzdHlsZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlci5weToKKwogMjAxMS0wMy0wMSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2 aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjgw MDc5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CmluZGV4IDVmYTgzNTYu Ljk3NTQzMmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl ci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKQEAgLTE2 NywxMCArMTY3LDcgQEAgX1BBVEhfUlVMRVNfU1BFQ0lGSUVSID0gWwogICAgIChbIyBUaGUgRUZM IEFQSXMgdXNlIEVGTCBuYW1pbmcgc3R5bGUsIHdoaWNoIGluY2x1ZGVzCiAgICAgICAjIGJvdGgg bG93ZXItY2FzZWQgYW5kIGNhbWVsLWNhc2VkLCB1bmRlcnNjb3JlLXNwYXJhdGVkCiAgICAgICAj IHZhbHVlcy4KLSAgICAgICJTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwiLAotICAgICAgIlNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VmbCIsCi0gICAgICAiU291cmNlL1dlYktp dC9lZmwvZXdrLyIsCi0gICAgICAiU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9lZmwvIl0sCisg ICAgICAiU291cmNlL1dlYktpdC9lZmwvZXdrLyJdLAogICAgICBbIi1yZWFkYWJpbGl0eS9uYW1p bmciLAogICAgICAgIi1yZWFkYWJpbGl0eS9wYXJhbWV0ZXJfbmFtZSJdKSwKIAo=