55541 2011-03-01 18:28:09 -0800 Expose some selection state fields in WKPage 2011-03-02 07:37:22 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other Windows 7 RESOLVED FIXED P2 Normal --- 1 jeffm jeffm oldest_to_newest 360481 0 jeffm 2011-03-01 18:28:09 -0800 Expose some selection state fields in WKPage 360482 1 jeffm 2011-03-01 18:29:55 -0800 Adding WKPageCanDelete(), WKPageHasSelectedRange(), and WKPageIsContentEditable() so we can enable some Edit menu items properly on Windows. 360484 2 84347 jeffm 2011-03-01 18:34:45 -0800 Created attachment 84347 Patch 360573 3 84347 darin 2011-03-01 22:07:06 -0800 Comment on attachment 84347 Patch I’m not sure we really need WKPageCanDelete. 360770 4 jeffm 2011-03-02 06:54:40 -0800 Committed r80125: <http://trac.webkit.org/changeset/80125> 360788 5 jeffm 2011-03-02 07:37:22 -0800 (In reply to comment #3) > (From update of attachment 84347 [details]) > I’m not sure we really need WKPageCanDelete. I chose to leave this in to be explicit, and to match the WebKit1 API semantics better. 84347 2011-03-01 18:34:45 -0800 2011-03-01 22:07:05 -0800 Patch bug-55541-20110301183442.patch text/plain 3569 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwMDgwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDMtMDEgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEV4cG9zZSBzb21lIHNlbGVjdGlvbiBzdGF0ZSBmaWVsZHMgaW4gV0tQ YWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTU0 MQorICAgICAgICAKKyAgICAgICAgQWRkZWQgV0tQYWdlQ2FuRGVsZXRlKCksIFdLUGFnZUhhc1Nl bGVjdGVkUmFuZ2UoKSwgYW5kIFdLUGFnZUlzQ29udGVudEVkaXRhYmxlKCkgc28gd2UgY2FuIGVu YWJsZSBzb21lCisgICAgICAgIEVkaXQgbWVudSBpdGVtcyBwcm9wZXJseSBvbiBXaW5kb3dzIHdo ZW4gdXNpbmcgV2ViS2l0Mi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3Bw OgorICAgICAgICAoV0tQYWdlQ2FuRGVsZXRlKTogQWRkZWQuCisgICAgICAgIChXS1BhZ2VIYXNT ZWxlY3RlZFJhbmdlKTogQWRkZWQuCisgICAgICAgIChXS1BhZ2VJc0NvbnRlbnRFZGl0YWJsZSk6 IEFkZGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuaDogQWRkZWQgbmV3IGZ1 bmN0aW9ucy4KKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisgICAgICAgIChX ZWJLaXQ6OldlYlBhZ2VQcm94eTo6Y2FuRGVsZXRlKTogQWRkZWQuCisgICAgICAgIChXZWJLaXQ6 OldlYlBhZ2VQcm94eTo6aGFzU2VsZWN0ZWRSYW5nZSk6IEFkZGVkLgorICAgICAgICAoV2ViS2l0 OjpXZWJQYWdlUHJveHk6OmlzQ29udGVudEVkaXRhYmxlKTogQWRkZWQuCisKIDIwMTEtMDMtMDEg IE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0g V2VpbmlnLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAkocmV2 aXNpb24gODAwODApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgJ KHdvcmtpbmcgY29weSkKQEAgLTIwMiw2ICsyMDIsOSBAQCBwdWJsaWM6CiAgICAgdm9pZCB2YWxp ZGF0ZU1lbnVJdGVtKGNvbnN0IFN0cmluZyYgY29tbWFuZE5hbWUpOwogCiAgICAgY29uc3QgU2Vs ZWN0aW9uU3RhdGUmIHNlbGVjdGlvblN0YXRlKCkgY29uc3QgeyByZXR1cm4gbV9zZWxlY3Rpb25T dGF0ZTsgfQorICAgIGJvb2wgY2FuRGVsZXRlKCkgY29uc3QgeyByZXR1cm4gaGFzU2VsZWN0ZWRS YW5nZSgpICYmIGlzQ29udGVudEVkaXRhYmxlKCk7IH0KKyAgICBib29sIGhhc1NlbGVjdGVkUmFu Z2UoKSBjb25zdCB7IHJldHVybiBtX3NlbGVjdGlvblN0YXRlLnNlbGVjdGVkUmFuZ2VMZW5ndGg7 IH0KKyAgICBib29sIGlzQ29udGVudEVkaXRhYmxlKCkgY29uc3QgeyByZXR1cm4gbV9zZWxlY3Rp b25TdGF0ZS5pc0NvbnRlbnRFZGl0YWJsZTsgfQogCiAjaWYgUExBVEZPUk0oTUFDKQogICAgIHZv aWQgdXBkYXRlV2luZG93SXNWaXNpYmxlKGJvb2wgd2luZG93SXNWaXNpYmxlKTsKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCShyZXZpc2lvbiA4MDA4MCkK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zMTYsNiArMzE2LDIxIEBAIGJvb2wgV0tQYWdlSXNQaW5uZWRUb1JpZ2h0U2lkZShX S1BhZ2VSZWYKICAgICByZXR1cm4gdG9JbXBsKHBhZ2VSZWYpLT5pc1Bpbm5lZFRvUmlnaHRTaWRl KCk7CiB9CiAKK2Jvb2wgV0tQYWdlQ2FuRGVsZXRlKFdLUGFnZVJlZiBwYWdlUmVmKQoreworICAg IHJldHVybiB0b0ltcGwocGFnZVJlZiktPmNhbkRlbGV0ZSgpOworfQorCitib29sIFdLUGFnZUhh c1NlbGVjdGVkUmFuZ2UoV0tQYWdlUmVmIHBhZ2VSZWYpCit7CisgICAgcmV0dXJuIHRvSW1wbChw YWdlUmVmKS0+aGFzU2VsZWN0ZWRSYW5nZSgpOworfQorCitib29sIFdLUGFnZUlzQ29udGVudEVk aXRhYmxlKFdLUGFnZVJlZiBwYWdlUmVmKQoreworICAgIHJldHVybiB0b0ltcGwocGFnZVJlZikt PmlzQ29udGVudEVkaXRhYmxlKCk7Cit9CisKIHZvaWQgV0tQYWdlRmluZFN0cmluZyhXS1BhZ2VS ZWYgcGFnZVJlZiwgV0tTdHJpbmdSZWYgc3RyaW5nLCBXS0ZpbmRPcHRpb25zIG9wdGlvbnMsIHVu c2lnbmVkIG1heE1hdGNoQ291bnQpCiB7CiAgICAgdG9JbXBsKHBhZ2VSZWYpLT5maW5kU3RyaW5n KHRvSW1wbChzdHJpbmcpLT5zdHJpbmcoKSwgdG9GaW5kT3B0aW9ucyhvcHRpb25zKSwgbWF4TWF0 Y2hDb3VudCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5oCShy ZXZpc2lvbiA4MDA4MCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2Uu aAkod29ya2luZyBjb3B5KQpAQCAtMzIzLDYgKzMyMywxMCBAQCBXS19FWFBPUlQgYm9vbCBXS1Bh Z2VIYXNWZXJ0aWNhbFNjcm9sbGJhCiBXS19FWFBPUlQgYm9vbCBXS1BhZ2VJc1Bpbm5lZFRvTGVm dFNpZGUoV0tQYWdlUmVmIHBhZ2UpOwogV0tfRVhQT1JUIGJvb2wgV0tQYWdlSXNQaW5uZWRUb1Jp Z2h0U2lkZShXS1BhZ2VSZWYgcGFnZSk7CiAKK1dLX0VYUE9SVCBib29sIFdLUGFnZUNhbkRlbGV0 ZShXS1BhZ2VSZWYgcGFnZSk7CitXS19FWFBPUlQgYm9vbCBXS1BhZ2VIYXNTZWxlY3RlZFJhbmdl KFdLUGFnZVJlZiBwYWdlKTsKK1dLX0VYUE9SVCBib29sIFdLUGFnZUlzQ29udGVudEVkaXRhYmxl KFdLUGFnZVJlZiBwYWdlKTsKKwogV0tfRVhQT1JUIHZvaWQgV0tQYWdlRmluZFN0cmluZyhXS1Bh Z2VSZWYgcGFnZSwgV0tTdHJpbmdSZWYgc3RyaW5nLCBXS0ZpbmRPcHRpb25zIGZpbmRPcHRpb25z LCB1bnNpZ25lZCBtYXhNYXRjaENvdW50KTsKIFdLX0VYUE9SVCB2b2lkIFdLUGFnZUhpZGVGaW5k VUkoV0tQYWdlUmVmIHBhZ2UpOwogV0tfRVhQT1JUIHZvaWQgV0tQYWdlQ291bnRTdHJpbmdNYXRj aGVzKFdLUGFnZVJlZiBwYWdlLCBXS1N0cmluZ1JlZiBzdHJpbmcsIFdLRmluZE9wdGlvbnMgZmlu ZE9wdGlvbnMsIHVuc2lnbmVkIG1heE1hdGNoQ291bnQpOwo=