55512 2011-03-01 14:57:37 -0800 EventQueue needs to be ref counted 2011-03-01 16:18:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow jorlow abarth eric mihaip webkit.review.bot oldest_to_newest 360264 0 jorlow 2011-03-01 14:57:37 -0800 EventQueue needs to be ref counted 360273 1 84302 jorlow 2011-03-01 15:00:58 -0800 Created attachment 84302 Patch 360274 2 jorlow 2011-03-01 15:01:10 -0800 Please review. 360313 3 84302 mihaip 2011-03-01 15:35:05 -0800 Comment on attachment 84302 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84302&action=review > Source/WebCore/dom/EventQueue.cpp:94 > + RefPtr<EventQueue> m_keepAliveDuringIteration = this; RefPtr<EventQueue> protector(this) is a more common pattern for this: https://www.google.com/codesearch?as_q=refptr.*protector&vert=chromium Either way the name shouldn't start with m_ since it's not a member. 360322 4 jorlow 2011-03-01 15:49:24 -0800 (In reply to comment #3) > (From update of attachment 84302 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=84302&action=review > > > Source/WebCore/dom/EventQueue.cpp:94 > > + RefPtr<EventQueue> m_keepAliveDuringIteration = this; > > RefPtr<EventQueue> protector(this) is a more common pattern for this: > https://www.google.com/codesearch?as_q=refptr.*protector&vert=chromium > > Either way the name shouldn't start with m_ since it's not a member. Oops...fixed. 360324 5 84313 jorlow 2011-03-01 15:49:46 -0800 Created attachment 84313 Patch 360327 6 jorlow 2011-03-01 15:54:15 -0800 Committed r80054: <http://trac.webkit.org/changeset/80054> 360349 7 webkit.review.bot 2011-03-01 16:18:04 -0800 http://trac.webkit.org/changeset/80054 might have broken Chromium Win Release 84302 2011-03-01 15:00:58 -0800 2011-03-01 15:49:44 -0800 Patch bug-55512-20110301150057.patch text/plain 3372 jorlow U3VidmVyc2lvbiBSZXZpc2lvbjogODAwNDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxZTY1NjBkNmI4Yzk3NTVi ZThkYTdmMjZhY2QyNTBhZDFkMTdlZmQ3Li42OWU4YWU0ODE4ZmNjYTlkNmViODk1Y2VlNjg4Yzcw MmZiODdhODI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDMtMDEgIEplcmVt eSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRXZlbnRRdWV1ZSBuZWVkcyB0byBiZSByZWYgY291bnRl ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU1MTIK KworICAgICAgICBFdmVudFF1ZXVlIG5lZWRzIHRvIGJlIHJlZiBjb3VudGVkIGJlY2F1c2UgaXQn cyBwb3NzaWJsZSBmb3IgaXRzIGluc3RhbmNlCisgICAgICAgIHRvIGJlIGRlbGV0ZWQgd2hpbGUg aXQncyBkaXNwYXRjaGluZyBldmVudHMuIFRoaXMgaXMgdGhlIHJlYXNvbiB3aHkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0Nzg1IGhhZCB0byBiZSBy ZXZlcnRlZC4KKworICAgICAgICBObyBjaGFuZ2Ugb2YgYmVoYXZpb3IsIHNvIG5vIHRlc3RzLgor CisgICAgICAgICogZG9tL0RvY3VtZW50Lmg6CisgICAgICAgICogZG9tL0V2ZW50UXVldWUuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRRdWV1ZTo6Y3JlYXRlKToKKyAgICAgICAgKiBkb20v RXZlbnRRdWV1ZS5oOgorCiAyMDExLTAzLTAxICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcu Ym90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByODAwMzcu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5oCmluZGV4IGFmM2VmMzhmYzFlMGMwNWI4NDAyZGE4ODI4YWUyZTI5 MGI3OGNhZTEuLjgyYTNmYzg2OWY4YzVkN2Q1YzE0MGZlNTBjZWEwY2FiY2UxZTM1ZjkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5oCkBAIC0xMzkzLDcgKzEzOTMsNyBAQCBwcml2YXRlOgogCiAgICAgYm9v bCBtX3VzaW5nR2VvbG9jYXRpb247CiAgICAgCi0gICAgT3duUHRyPEV2ZW50UXVldWU+IG1fZXZl bnRRdWV1ZTsKKyAgICBSZWZQdHI8RXZlbnRRdWV1ZT4gbV9ldmVudFF1ZXVlOwogCiAjaWYgRU5B QkxFKFdNTCkKICAgICBib29sIG1fY29udGFpbnNXTUxDb250ZW50OwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZG9tL0V2ZW50UXVldWUuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50 UXVldWUuY3BwCmluZGV4IDVhMWFiZThhZDE1ZWI1Y2ZkZWFlNGMyYmI3Y2UxNDViMDAyNWI2MTMu LjQxMDkyZjU2OWU4YzA1ZjRhYzFjZTc4NWY4NzI5NmYzODdlNjVjMzYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9FdmVudFF1ZXVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RXZlbnRRdWV1ZS5jcHAKQEAgLTQ3LDYgKzQ3LDExIEBAIHByaXZhdGU6CiAgICAgRXZlbnRRdWV1 ZSogbV9ldmVudFF1ZXVlOyAgICAKIH07CiAKK1Bhc3NSZWZQdHI8RXZlbnRRdWV1ZT4gRXZlbnRR dWV1ZTo6Y3JlYXRlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQpCit7CisgICAgcmV0 dXJuIGFkb3B0UmVmKG5ldyBFdmVudFF1ZXVlKGNvbnRleHQpKTsKK30KKwogRXZlbnRRdWV1ZTo6 RXZlbnRRdWV1ZShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0KQogICAgIDogbV9wZW5k aW5nRXZlbnRUaW1lcihhZG9wdFB0cihuZXcgRXZlbnRRdWV1ZVRpbWVyKHRoaXMsIGNvbnRleHQp KSkKIHsKQEAgLTg2LDYgKzkxLDggQEAgdm9pZCBFdmVudFF1ZXVlOjpwZW5kaW5nRXZlbnRUaW1l ckZpcmVkKCkKICAgICAKICAgICBtX25vZGVzV2l0aFF1ZXVlZFNjcm9sbEV2ZW50cy5jbGVhcigp OwogCisgICAgUmVmUHRyPEV2ZW50UXVldWU+IG1fa2VlcEFsaXZlRHVyaW5nSXRlcmF0aW9uID0g dGhpczsKKwogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgcXVldWVkRXZlbnRzLnNpemUoKTsg aSsrKQogICAgICAgICBkaXNwYXRjaEV2ZW50KHF1ZXVlZEV2ZW50c1tpXS5yZWxlYXNlKCkpOwog fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50UXVldWUuaCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9FdmVudFF1ZXVlLmgKaW5kZXggYTU4OWVkODBmNWQ3YWIxM2E1YjBhMzBjYmI3 MzdjZmNkNmNkYzQ4OS4uYTY0Y2Y1MTlhYTk3ZmJjZjFmZmZiMmU4MGMyZGM5MTJmZDQzN2I4NyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50UXVldWUuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRXZlbnRRdWV1ZS5oCkBAIC0yOCw5ICsyOCw4IEBACiAjZGVmaW5lIEV2ZW50 UXVldWVfaAogCiAjaW5jbHVkZSA8d3RmL0hhc2hTZXQuaD4KLSNpbmNsdWRlIDx3dGYvTm9uY29w eWFibGUuaD4KICNpbmNsdWRlIDx3dGYvT3duUHRyLmg+Ci0jaW5jbHVkZSA8d3RmL1Bhc3NPd25Q dHIuaD4KKyNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIu aD4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAKQEAgLTQxLDIxICs0MCwxNCBAQCBjbGFzcyBF dmVudFF1ZXVlVGltZXI7CiBjbGFzcyBOb2RlOwogY2xhc3MgU2NyaXB0RXhlY3V0aW9uQ29udGV4 dDsKIAotY2xhc3MgRXZlbnRRdWV1ZSB7Ci0gICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoRXZlbnRR dWV1ZSk7Ci0KLSAgICAKK2NsYXNzIEV2ZW50UXVldWUgOiBwdWJsaWMgUmVmQ291bnRlZDxFdmVu dFF1ZXVlPiB7CiBwdWJsaWM6CiAgICAgZW51bSBTY3JvbGxFdmVudFRhcmdldFR5cGUgewogICAg ICAgICBTY3JvbGxFdmVudERvY3VtZW50VGFyZ2V0LAogICAgICAgICBTY3JvbGxFdmVudEVsZW1l bnRUYXJnZXQKICAgICB9OwogCi0gICAgc3RhdGljIFBhc3NPd25QdHI8RXZlbnRRdWV1ZT4gY3Jl YXRlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQpCi0gICAgewotICAgICAgICByZXR1 cm4gYWRvcHRQdHIobmV3IEV2ZW50UXVldWUoY29udGV4dCkpOwotICAgIH0KLQorICAgIHN0YXRp YyBQYXNzUmVmUHRyPEV2ZW50UXVldWU+IGNyZWF0ZShTY3JpcHRFeGVjdXRpb25Db250ZXh0Kik7 CiAgICAgfkV2ZW50UXVldWUoKTsKIAogICAgIHZvaWQgZW5xdWV1ZUV2ZW50KFBhc3NSZWZQdHI8 RXZlbnQ+KTsK 84313 2011-03-01 15:49:46 -0800 2011-03-01 15:51:27 -0800 Patch bug-55512-20110301154945.patch text/plain 3354 jorlow U3VidmVyc2lvbiBSZXZpc2lvbjogODAwNDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxZTY1NjBkNmI4Yzk3NTVi ZThkYTdmMjZhY2QyNTBhZDFkMTdlZmQ3Li42OWU4YWU0ODE4ZmNjYTlkNmViODk1Y2VlNjg4Yzcw MmZiODdhODI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDMtMDEgIEplcmVt eSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRXZlbnRRdWV1ZSBuZWVkcyB0byBiZSByZWYgY291bnRl ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU1MTIK KworICAgICAgICBFdmVudFF1ZXVlIG5lZWRzIHRvIGJlIHJlZiBjb3VudGVkIGJlY2F1c2UgaXQn cyBwb3NzaWJsZSBmb3IgaXRzIGluc3RhbmNlCisgICAgICAgIHRvIGJlIGRlbGV0ZWQgd2hpbGUg aXQncyBkaXNwYXRjaGluZyBldmVudHMuIFRoaXMgaXMgdGhlIHJlYXNvbiB3aHkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0Nzg1IGhhZCB0byBiZSBy ZXZlcnRlZC4KKworICAgICAgICBObyBjaGFuZ2Ugb2YgYmVoYXZpb3IsIHNvIG5vIHRlc3RzLgor CisgICAgICAgICogZG9tL0RvY3VtZW50Lmg6CisgICAgICAgICogZG9tL0V2ZW50UXVldWUuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRRdWV1ZTo6Y3JlYXRlKToKKyAgICAgICAgKiBkb20v RXZlbnRRdWV1ZS5oOgorCiAyMDExLTAzLTAxICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcu Ym90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByODAwMzcu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5oCmluZGV4IGFmM2VmMzhmYzFlMGMwNWI4NDAyZGE4ODI4YWUyZTI5 MGI3OGNhZTEuLjgyYTNmYzg2OWY4YzVkN2Q1YzE0MGZlNTBjZWEwY2FiY2UxZTM1ZjkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5oCkBAIC0xMzkzLDcgKzEzOTMsNyBAQCBwcml2YXRlOgogCiAgICAgYm9v bCBtX3VzaW5nR2VvbG9jYXRpb247CiAgICAgCi0gICAgT3duUHRyPEV2ZW50UXVldWU+IG1fZXZl bnRRdWV1ZTsKKyAgICBSZWZQdHI8RXZlbnRRdWV1ZT4gbV9ldmVudFF1ZXVlOwogCiAjaWYgRU5B QkxFKFdNTCkKICAgICBib29sIG1fY29udGFpbnNXTUxDb250ZW50OwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZG9tL0V2ZW50UXVldWUuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50 UXVldWUuY3BwCmluZGV4IDVhMWFiZThhZDE1ZWI1Y2ZkZWFlNGMyYmI3Y2UxNDViMDAyNWI2MTMu LmIwNzhhNzFiYzg5YzAxMzcxNWIwZTdlZWZhZjBiMzEyMGFkMDI0YTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9FdmVudFF1ZXVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RXZlbnRRdWV1ZS5jcHAKQEAgLTQ3LDYgKzQ3LDExIEBAIHByaXZhdGU6CiAgICAgRXZlbnRRdWV1 ZSogbV9ldmVudFF1ZXVlOyAgICAKIH07CiAKK1Bhc3NSZWZQdHI8RXZlbnRRdWV1ZT4gRXZlbnRR dWV1ZTo6Y3JlYXRlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQpCit7CisgICAgcmV0 dXJuIGFkb3B0UmVmKG5ldyBFdmVudFF1ZXVlKGNvbnRleHQpKTsKK30KKwogRXZlbnRRdWV1ZTo6 RXZlbnRRdWV1ZShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0KQogICAgIDogbV9wZW5k aW5nRXZlbnRUaW1lcihhZG9wdFB0cihuZXcgRXZlbnRRdWV1ZVRpbWVyKHRoaXMsIGNvbnRleHQp KSkKIHsKQEAgLTg2LDYgKzkxLDggQEAgdm9pZCBFdmVudFF1ZXVlOjpwZW5kaW5nRXZlbnRUaW1l ckZpcmVkKCkKICAgICAKICAgICBtX25vZGVzV2l0aFF1ZXVlZFNjcm9sbEV2ZW50cy5jbGVhcigp OwogCisgICAgUmVmUHRyPEV2ZW50UXVldWU+IHByb3RlY3Rvcih0aGlzKTsKKwogICAgIGZvciAo c2l6ZV90IGkgPSAwOyBpIDwgcXVldWVkRXZlbnRzLnNpemUoKTsgaSsrKQogICAgICAgICBkaXNw YXRjaEV2ZW50KHF1ZXVlZEV2ZW50c1tpXS5yZWxlYXNlKCkpOwogfQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZG9tL0V2ZW50UXVldWUuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFF1 ZXVlLmgKaW5kZXggYTU4OWVkODBmNWQ3YWIxM2E1YjBhMzBjYmI3MzdjZmNkNmNkYzQ4OS4uYTY0 Y2Y1MTlhYTk3ZmJjZjFmZmZiMmU4MGMyZGM5MTJmZDQzN2I4NyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZG9tL0V2ZW50UXVldWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRR dWV1ZS5oCkBAIC0yOCw5ICsyOCw4IEBACiAjZGVmaW5lIEV2ZW50UXVldWVfaAogCiAjaW5jbHVk ZSA8d3RmL0hhc2hTZXQuaD4KLSNpbmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KICNpbmNsdWRl IDx3dGYvT3duUHRyLmg+Ci0jaW5jbHVkZSA8d3RmL1Bhc3NPd25QdHIuaD4KKyNpbmNsdWRlIDx3 dGYvUmVmQ291bnRlZC5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYv VmVjdG9yLmg+CiAKQEAgLTQxLDIxICs0MCwxNCBAQCBjbGFzcyBFdmVudFF1ZXVlVGltZXI7CiBj bGFzcyBOb2RlOwogY2xhc3MgU2NyaXB0RXhlY3V0aW9uQ29udGV4dDsKIAotY2xhc3MgRXZlbnRR dWV1ZSB7Ci0gICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoRXZlbnRRdWV1ZSk7Ci0KLSAgICAKK2Ns YXNzIEV2ZW50UXVldWUgOiBwdWJsaWMgUmVmQ291bnRlZDxFdmVudFF1ZXVlPiB7CiBwdWJsaWM6 CiAgICAgZW51bSBTY3JvbGxFdmVudFRhcmdldFR5cGUgewogICAgICAgICBTY3JvbGxFdmVudERv Y3VtZW50VGFyZ2V0LAogICAgICAgICBTY3JvbGxFdmVudEVsZW1lbnRUYXJnZXQKICAgICB9Owog Ci0gICAgc3RhdGljIFBhc3NPd25QdHI8RXZlbnRRdWV1ZT4gY3JlYXRlKFNjcmlwdEV4ZWN1dGlv bkNvbnRleHQqIGNvbnRleHQpCi0gICAgewotICAgICAgICByZXR1cm4gYWRvcHRQdHIobmV3IEV2 ZW50UXVldWUoY29udGV4dCkpOwotICAgIH0KLQorICAgIHN0YXRpYyBQYXNzUmVmUHRyPEV2ZW50 UXVldWU+IGNyZWF0ZShTY3JpcHRFeGVjdXRpb25Db250ZXh0Kik7CiAgICAgfkV2ZW50UXVldWUo KTsKIAogICAgIHZvaWQgZW5xdWV1ZUV2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+KTsK