55504 2011-03-01 14:02:48 -0800 Use of uninitialized value in numeric lt (<) at Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash 2011-03-02 13:24:25 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned abarth ap aroben eric joepeck webkit.review.bot oldest_to_newest 360207 0 joepeck 2011-03-01 14:02:48 -0800 Perl old-run-webkit-tests issue seen on the build bots after a crash: Use of uninitialized value in numeric lt (<) at Tools/Scripts/old-run-webkit-tests line 1778. 360602 1 ap 2011-03-01 23:02:22 -0800 Line 1778: # The crash log must have been created after this script started running. $crashLog = $newestCrashLog if -M $newestCrashLog < 0; 360760 2 aroben 2011-03-02 06:18:57 -0800 A little more context: # We assume that the newest crash log in matching the glob is the one that corresponds to the crash that just occurred. if (my $newestCrashLog = findNewestFileMatchingGlob($glob)) { # The crash log must have been created after this script started running. $crashLog = $newestCrashLog if -M $newestCrashLog < 0; } So $newestCrashLog itself is defined. I guess -M is returning undefined. The docs say this will happen if the file doesn't exist. Maybe the file was deleted between when it was found by findNewestFileMatchingGlob and when we tested it with -M? Joe, which bot did this happen on? Do you have a link to the test output that shows the error? 360817 3 joepeck 2011-03-02 08:53:27 -0800 findNewestFileMatchingGlob can early return, which I think returns the undefined value. I saw this on the Qt bot. 360820 4 aroben 2011-03-02 08:56:47 -0800 Ah, that makes sense. Should be easy to fix then. 360822 5 aroben 2011-03-02 08:57:31 -0800 We should probably make captureSavedCrashLog bail if we don't have a $glob (which should be the case on Qt). 360824 6 aroben 2011-03-02 08:58:25 -0800 (In reply to comment #3) > findNewestFileMatchingGlob can early return, which I think returns the undefined value. I saw this on the Qt bot. Hm, but if findNewestFileMatchingGlob returns undefined, we shouldn't even get to line 1778, since $newestCrashLog will be undefined. 360825 7 aroben 2011-03-02 08:59:35 -0800 Ah, the "return unless @paths" check in findNewestFileMatchingGlob is buggy. 360826 8 84423 aroben 2011-03-02 09:03:12 -0800 Created attachment 84423 Don't try to capture crash logs on platforms that haven't implemented that feature 360945 9 84423 joepeck 2011-03-02 11:40:15 -0800 Comment on attachment 84423 Don't try to capture crash logs on platforms that haven't implemented that feature View in context: https://bugs.webkit.org/attachment.cgi?id=84423&action=review r=me with that fix! Thanks! > Tools/Scripts/old-run-webkit-tests:1793 > + return unless $#paths; "$#paths" returns the last index in the array. So if there is 1 item, the last index will be 0, and this might still bail. As you mentioned on IRC, an alternative to getting the size of the array is "scalar(@paths)". That seems better. 360951 10 aroben 2011-03-02 11:47:31 -0800 Committed r80152: <http://trac.webkit.org/changeset/80152> 361031 11 webkit.review.bot 2011-03-02 13:24:25 -0800 http://trac.webkit.org/changeset/80152 might have broken GTK Linux 64-bit Debug The following tests are not passing: fast/css-generated-content/005.html fast/css-generated-content/beforeAfter-interdocument.html fast/css-generated-content/no-openclose-quote.html fast/invalid/residual-style.html 84423 2011-03-02 09:03:12 -0800 2011-03-02 11:40:15 -0800 Don't try to capture crash logs on platforms that haven't implemented that feature bug-55504-20110302120312.patch text/plain 1881 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogODAxMzAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1MGUzNjI3YTUzODVkMWJkZjczZDE1OWJkMmRkZjM1MzFh NDY5NGE5Li5iZmY1YTNiOTQxOTUzMjM1NWI5ZDJhNzFkMTQyYWRmMTdlNGNjY2Q4IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDMtMDIgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgorCisgICAgICAg IERvbid0IHRyeSB0byBjYXB0dXJlIGNyYXNoIGxvZ3Mgb24gcGxhdGZvcm1zIHRoYXQgaGF2ZW4n dCBpbXBsZW1lbnRlZCB0aGF0IGZlYXR1cmUKKworICAgICAgICBGaXhlcyA8aHR0cDovL3dlYmtp dC5vcmcvYi81NTUwND4gVXNlIG9mIHVuaW5pdGlhbGl6ZWQgdmFsdWUgaW4gbnVtZXJpYyBsdCAo PCkgYXQKKyAgICAgICAgVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cyBsaW5lIDE3 Nzggc2VlbiBvbiBRdCBib3RzIGFmdGVyIGEgY3Jhc2gKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHM6 CisgICAgICAgIChjYXB0dXJlU2F2ZWRDcmFzaExvZyk6IEJhaWwgaWYgd2UgZG9uJ3QgaGF2ZSBh IGNyYXNoIGxvZyBnbG9iLgorICAgICAgICAoZmluZE5ld2VzdEZpbGVNYXRjaGluZ0dsb2IpOiBG aXggYSBidWdneSB0ZXN0IGZvciB3aGVuIG5vIHBhdGhzIG1hdGNoIHRoZSBnbG9iLiBUaGlzIGlz bid0CisgICAgICAgIHN0cmljdGx5IHJlcXVpcmVkIHRvIGZpeCBidWcgNTU1MDQsIGJ1dCBzZWVt cyB3b3J0aHdoaWxlLgorCiAyMDExLTAzLTAxICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9vbGQt cnVuLXdlYmtpdC10ZXN0cwppbmRleCAxZjNjYTgxNmViNTljZjRmYWY0Yjc2Nzc0ZTAxODY3NWIw M2FlNDFiLi41OGU0MDQwMjM5MzdiM2FkNjAxZDk3YTcxYTk3OTI0NDljYmU1OTE2IDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCisrKyBiL1Rvb2xzL1Njcmlw dHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKQEAgLTE3NzIsNiArMTc3Miw4IEBAIHN1YiBjYXB0dXJl U2F2ZWRDcmFzaExvZygkJCkKICAgICAgICAgfQogICAgIH0KIAorICAgIHJldHVybiB1bmxlc3Mg JGdsb2I7CisKICAgICAjIFdlIGFzc3VtZSB0aGF0IHRoZSBuZXdlc3QgY3Jhc2ggbG9nIGluIG1h dGNoaW5nIHRoZSBnbG9iIGlzIHRoZSBvbmUgdGhhdCBjb3JyZXNwb25kcyB0byB0aGUgY3Jhc2gg dGhhdCBqdXN0IG9jY3VycmVkLgogICAgIGlmIChteSAkbmV3ZXN0Q3Jhc2hMb2cgPSBmaW5kTmV3 ZXN0RmlsZU1hdGNoaW5nR2xvYigkZ2xvYikpIHsKICAgICAgICAgIyBUaGUgY3Jhc2ggbG9nIG11 c3QgaGF2ZSBiZWVuIGNyZWF0ZWQgYWZ0ZXIgdGhpcyBzY3JpcHQgc3RhcnRlZCBydW5uaW5nLgpA QCAtMTc4OCw3ICsxNzkwLDcgQEAgc3ViIGZpbmROZXdlc3RGaWxlTWF0Y2hpbmdHbG9iKCQpCiAg ICAgbXkgKCRnbG9iKSA9IEBfOwogCiAgICAgbXkgQHBhdGhzID0gZ2xvYiAkZ2xvYjsKLSAgICBy ZXR1cm4gdW5sZXNzIEBwYXRoczsKKyAgICByZXR1cm4gdW5sZXNzICQjcGF0aHM7CiAKICAgICBt eSBAcGF0aHNBbmRUaW1lcyA9IG1hcCB7IFskXywgLU0gJF9dIH0gQHBhdGhzOwogICAgIEBwYXRo c0FuZFRpbWVzID0gc29ydCB7ICRiLT5bMV0gPD0+ICRhLT5bMV0gfSBAcGF0aHNBbmRUaW1lczsK