55503 2011-03-01 13:44:02 -0800 Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations 2011-03-06 17:11:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates ddkilzer eric oldest_to_newest 360194 0 dbates 2011-03-01 13:44:02 -0800 It is unnecessary in Perl to explicitly write "()" in function prototypes for functions that take no arguments. So, we can remove the "()" from the function prototypes for writeCongrats(), checkForJavaSDK(), and unlinkZeroFiles(). Additionally, the word "download" is misspelled in the message printed in checkForJavaSDK(). 360195 1 84288 dbates 2011-03-01 13:45:32 -0800 Created attachment 84288 Patch 360452 2 84288 eric 2011-03-01 18:04:37 -0800 Comment on attachment 84288 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84288&action=review rs=me, assuming this is considered "good perl style". > Tools/Scripts/build-webkit:44 > +sub checkForJavaSDK; I guess this is good perl? Looks strange to a non-perl-er. 360839 3 ddkilzer 2011-03-02 09:21:31 -0800 (In reply to comment #2) > (From update of attachment 84288 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=84288&action=review > > rs=me, assuming this is considered "good perl style". > > > Tools/Scripts/build-webkit:44 > > +sub checkForJavaSDK; > > I guess this is good perl? Looks strange to a non-perl-er. I'm not particularly fond of this style. I like my functions to have parenthesis, even if it makes them more C-like. 360842 4 ddkilzer 2011-03-02 09:22:16 -0800 (In reply to comment #3) > I'm not particularly fond of this style. I like my functions to have parenthesis, even if it makes them more C-like. But not enough to oppose this change. (Which style is more prevalent in the tools Perl code?) 360892 5 dbates 2011-03-02 10:23:17 -0800 (In reply to comment #4) > (In reply to comment #3) > > I'm not particularly fond of this style. I like my functions to have parenthesis, even if it makes them more C-like. > > But not enough to oppose this change. (Which style is more prevalent in the tools Perl code?) Using some regular expressions against webkitdirs.pm and VCSUtils.pm (*), the empty parentheses notation is more prevalent than the no-parentheses notation (which is proposed in this patch). So, I can change this patch only be a spelling correction and sorting of the forward declarations. For completeness, the sentiment on #perl on freenode seems to be against all uses of prototypes. They referred me to the Usenet post <http://groups.google.com/group/comp.lang.perl.modules/msg/84484de5eb01085b?dmode=source&output=gplain>. (*) I used the following regular expressions. Match all prototypes: sub (.+)$ Match prototypes that don't contain "()": sub ([^($]+)$ Match prototypes that contain "()": sub (.+)\s*\(\) Match prototypes with at least one compile-time argument check: sub (.+)\s*\((.+)\) 362168 6 ddkilzer 2011-03-03 18:13:36 -0800 (In reply to comment #5) > For completeness, the sentiment on #perl on freenode seems to be against all uses of prototypes. They referred me to the Usenet post <http://groups.google.com/group/comp.lang.perl.modules/msg/84484de5eb01085b?dmode=source&output=gplain>. ZOMG. I didn't have the patience to read through the whole thing. My experience with prototypes has been generally good as they've caught issues when I didn't pass in the correct number of arguments, and I usually prefer to use parenthesis when calling methods (except for some built-in functions). I suppose we could also define some standard rules for Perl scripts, although Perl seems to be on its way out in the WebKit project in favor of Python or Ruby. As I said, I don't feel strongly enough to r- this, but it would be good to settle on a common way to define methods in Perl scripts, at least for the remaining ones. 363155 7 dbates 2011-03-06 17:09:38 -0800 (In reply to comment #6) > (In reply to comment #5) > [...] > As I said, I don't feel strongly enough to r- this, but it would be good to settle on a common way to define methods in Perl scripts, at least for the remaining ones. I decided to defer the no-parentheses notation change. I reduced the scope of this bug and its patch to just the misspelled word and sorting the forward declarations. We should consider standardizing on a notation for our existing Perl scripts. 363156 8 dbates 2011-03-06 17:11:57 -0800 Committed r80443: <http://trac.webkit.org/changeset/80443> 84288 2011-03-01 13:45:32 -0800 2011-03-01 18:04:36 -0800 Patch bug-55503-20110301134148.patch text/plain 2754 dbates SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDgwMDExKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTggQEAKKzIwMTEtMDMtMDEgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENsZWFudXA6IFJl bW92ZSB1bm5lY2Vzc2FyeSAiKCkiIGZyb20gZnVuY3Rpb24gcHJvdG90eXBlcyB0aGF0IHRha2Ug bm8KKyAgICAgICAgYXJndW1lbnRzIGluIGJ1aWxkLXdlYmtpdDsgQW5kIGZpeCBtaXNzcGVsbGVk IHdvcmQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NTUwMworCisgICAgICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6CisgICAgICAgICAgLSBSZW1v dmUgIigpIiBpbiBmdW5jdGlvbiB0eXBlIGZvciB3cml0ZUNvbmdyYXRzKCksIGNoZWNrRm9ySmF2 YVNESygpLAorICAgICAgICAgICAgYW5kIHVubGlua1plcm9GaWxlcygpLgorICAgICAgICAgIC0g U29ydCBmb3J3YXJkIGRlY2xhcmF0aW9ucy4KKyAgICAgICAgICAtIEZpeCBtaXNzcGVsbGVkIHdv cmQgIkRvd2xvYWRzIiBbc2ljXSBpbiB0aGUgbWVzc2FnZSBwcmludGVkIHRvIHN0YW5kYXJkIG91 dHB1dAorICAgICAgICAgICAgaW4gY2hlY2tGb3JKYXZhU0RLKCkuCisKIDIwMTEtMDMtMDEgIEFk YW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFNhdmUgYSBjcmFzaCBsb2cg d2hlbiB0aGUgd2ViIHByb2Nlc3MgY3Jhc2hlcwpJbmRleDogVG9vbHMvU2NyaXB0cy9idWlsZC13 ZWJraXQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQJKHJldmlzaW9u IDgwMDExKQorKysgVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQJKHdvcmtpbmcgY29weSkKQEAg LTQxLDkgKzQxLDkgQEAgdXNlIHdlYmtpdGRpcnM7CiB1c2Ugd2Via2l0cGVybDo6ZmVhdHVyZXM7 CiB1c2UgUE9TSVg7CiAKK3N1YiBjaGVja0ZvckphdmFTREs7CiBzdWIgZm9ybWF0QnVpbGRUaW1l KCQpOwotc3ViIHdyaXRlQ29uZ3JhdHMoKTsKLXN1YiBjaGVja0ZvckphdmFTREsoKTsKK3N1YiB3 cml0ZUNvbmdyYXRzOwogCiBteSAkb3JpZ2luYWxXb3JraW5nRGlyZWN0b3J5ID0gZ2V0Y3dkKCk7 CiBjaGRpcldlYktpdCgpOwpAQCAtMzg2LDcgKzM4Niw3IEBAIEZpbGU6OkZpbmQ6OmZpbmQoc3Vi IHt1bmxpbmsgJEZpbGU6OkZpbmQKICMgUmVtb3ZlIDAgYnl0ZSBzaXplZCBmaWxlcyBmcm9tIHBy b2R1Y3REaXIgYWZ0ZXIgc2xhdmUgbG9zdCBmb3IgUXQgYnVpbGRib3RzLgogRmlsZTo6RmluZDo6 ZmluZChcJnVubGlua1plcm9GaWxlcywgJHByb2R1Y3REaXIpIGlmIChpc1F0KCkgJiYgIWlzU3lt YmlhbigpICYmIC1lICRwcm9kdWN0RGlyKTsKIAotc3ViIHVubGlua1plcm9GaWxlcyAoKQorc3Vi IHVubGlua1plcm9GaWxlcwogewogICAgIG15ICRmaWxlID0gJEZpbGU6OkZpbmQ6Om5hbWU7CiAg ICAgaWYgKCEgLXMgJGZpbGUpIHsKQEAgLTYwOSw3ICs2MDksNyBAQCB3cml0ZUNvbmdyYXRzKCk7 CiAKIGV4aXQgMDsKIAotc3ViIGNoZWNrRm9ySmF2YVNESygpCitzdWIgY2hlY2tGb3JKYXZhU0RL CiB7CiAgICAgbXkgJGpuaUhlYWRlciA9ICIvU3lzdGVtL0xpYnJhcnkvRnJhbWV3b3Jrcy9KYXZh Vk0uZnJhbWV3b3JrL0hlYWRlcnMvam5pLmgiOwogICAgIGlmICgtZSAkam5pSGVhZGVyKSB7CkBA IC02MTcsNyArNjE3LDcgQEAgc3ViIGNoZWNrRm9ySmF2YVNESygpCiAgICAgfQogICAgIHByaW50 ICJcbkNhbid0IGZpbmQgcmVxdWlyZWQgJGpuaUhlYWRlciwgYnVpbGQgd2lsbCBmYWlsLlxuXG4i OwogICAgIHByaW50ICJBZnRlciBpbnN0YWxsaW5nIFwiSmF2YSBmb3IgTWFjIE9TIFggMTAuNiBV cGRhdGUgM1wiLCB0aGUgSmF2YSBEZXZlbG9wZXIgUGFja2FnZSBpcyByZXF1aXJlZCB0byBidWls ZCBXZWJLaXQuXG4iOwotICAgIHByaW50ICJQbGVhc2UgaW5zdGFsbCB0aGUgcGFja2FnZSBmcm9t IGh0dHA6Ly9jb25uZWN0LmFwcGxlLmNvbSAoZm91bmQgdW5kZXIgRG93bG9hZHMgPiBKYXZhKS5c blxuIjsKKyAgICBwcmludCAiUGxlYXNlIGluc3RhbGwgdGhlIHBhY2thZ2UgZnJvbSBodHRwOi8v Y29ubmVjdC5hcHBsZS5jb20gKGZvdW5kIHVuZGVyIERvd25sb2FkcyA+IEphdmEpLlxuXG4iOwog ICAgIHByaW50ICJGb3IgbW9yZSBpbmZvcm1hdGlvbiwgc2VlOlxuIjsKICAgICBwcmludCAiaHR0 cHM6Ly9saXN0cy53ZWJraXQub3JnL3BpcGVybWFpbC93ZWJraXQtZGV2LzIwMTAtT2N0b2Jlci8w MTQ4NjcuaHRtbFxuIjsKICAgICBwcmludCAiaHR0cHM6Ly93ZWJraXQub3JnL2J1aWxkaW5nL3Rv b2xzLmh0bWxcblxuIjsKQEAgLTYzOCw3ICs2MzgsNyBAQCBzdWIgZm9ybWF0QnVpbGRUaW1lKCQp CiAgICAgcmV0dXJuIHNwcmludGYoIiUwMmRtOiUwMmRzIiwgJGJ1aWxkTWlucywgJGJ1aWxkU2Vj cyk7CiB9CiAKLXN1YiB3cml0ZUNvbmdyYXRzKCkKK3N1YiB3cml0ZUNvbmdyYXRzCiB7CiAgICAg bXkgJGxhdW5jaGVyUGF0aCA9IGxhdW5jaGVyUGF0aCgpOwogICAgIG15ICRsYXVuY2hlck5hbWUg PSBsYXVuY2hlck5hbWUoKTsK