55468 2011-03-01 07:37:08 -0800 New .png files added by commit-queue bots are not marked as binary 2013-02-28 15:50:35 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW P2 Normal --- 107724 1 aroben webkit-unassigned abarth alancutter cbiesinger eric mitz oldest_to_newest 359882 0 aroben 2011-03-01 07:37:08 -0800 Whenever the commit-queue commits a patch that adds new .png files, the .pngs aren't marked as binary. The effect of this most noticeable to me is that the webkit-changes email generated for these patches includes a bunch of PNG-as-ASCII junk which significantly bloats the email. 359883 1 aroben 2011-03-01 07:38:09 -0800 One way to fix this would be to turn on Subversion auto-props on the commit-queue bots. To do that, you just need to uncomment the following lines in ~/.subversion/config enable-auto-props = yes ...and later... *.png = svn:mime-type=image/png 359885 2 aroben 2011-03-01 07:38:42 -0800 Note that auto-props are respected even when committing via git-svn. 359957 3 eric 2011-03-01 09:45:01 -0800 Very easy to do. (Especially if there is a svn config command to do that.) 359960 4 eric 2011-03-01 09:48:04 -0800 I suspect we should create the perfect config file for the commit-queue, and then copy it into the svn repository. Then the commit bots can either install it automatically, or use --config-dir. It doesn't appear that svn has a "config" command like git does for editing its config files. 359961 5 eric 2011-03-01 09:49:14 -0800 Basically if someone tells me exactly what commands to run on the bots, I'm happy to make that happen. Even better would be pointing towards the exact desired config file, which I'm happy to make sure all of the bots use. 359987 6 aroben 2011-03-01 10:15:12 -0800 I think putting this in ~/.subversion/config will do what we want (and nothing more): [miscellany] enable-auto-props = yes [auto-props] *.png = svn:mime-type=image/png 844563 7 alancutter 2013-02-28 15:44:50 -0800 bug 107724 addresses this issue and has a patch to amend future bots, pending a cq+.