55442 2011-02-28 19:27:04 -0800 webarchives don't contain subframe content 2011-02-28 20:28:35 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 alice.barraclough alice.barraclough oldest_to_newest 359603 0 alice.barraclough 2011-02-28 19:27:04 -0800 WebPage::getWebArchiveOfFrame doesn't seem to generate any content for subframes in the resulting webarchive. This is because we're calling the wrong LegacyWebArchive::create() function (there are 7). We're calling the one that takes a Frame* whereas we should be calling the one that takes a Node*. Doing so will match old WebKit behaviour in -[DOMNode(WebDOMNodeOperations) webArchive] steps to repro: 1) create a webarchive for your facebook.com (logged in) homepage. <rdar://problem/8994125> 359608 1 84175 alice.barraclough 2011-02-28 19:32:11 -0800 Created attachment 84175 patch Brady Eidson (beidson) has approved this change in-person. 359610 2 84175 barraclough 2011-02-28 19:39:27 -0800 Comment on attachment 84175 patch r+ since this changes behaviour to match webkit1. But it seems like LegacyWebArchive::create should have the same behaviour whether it is passed the frame or the document I think this is likely either a bug, or a case for a function to be renamed to make this clearer. We should probably open a new bug to track this issue. 359635 3 alice.barraclough 2011-02-28 20:25:24 -0800 I filed https://bugs.webkit.org/show_bug.cgi?id=55445 359637 4 alice.barraclough 2011-02-28 20:28:35 -0800 committed http://trac.webkit.org/changeset/79965 84175 2011-02-28 19:32:11 -0800 2011-02-28 19:39:27 -0800 patch patchbug55442.txt text/plain 1569 alice.barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5OTYwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDItMjggIEFsaWNlIExp dSAgPGFsaWNlLmxpdUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU1NDQyCisgICAgICAgIFdlYmFyY2hpdmVzIGRvbid0IGNvbnRhaW4gc3ViZnJhbWUgY29udGVu dAorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlOjpnZXRXZWJBcmNoaXZlT2ZGcmFtZSk6CisgICAgICAgIFBhc3MgdGhl IGZyYW1lJ3MgZG9jdW1lbnQgaW5zdGVhZCBvZiBqdXN0IHRoZSBmcmFtZSwgdG8gdXNlIGEgZGlm ZmVyZW50IExlZ2FjeVdlYkFyY2hpdmU6OmNyZWF0ZSBmdW5jdGlvbi4KKwogMjAxMS0wMi0yOCAg QmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpJbmRleDogU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkocmV2aXNpb24gNzkxNDgp CisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTEyOTYsNyArMTI5Niw3IEBAIHZvaWQgV2ViUGFnZTo6Z2V0V2ViQXJjaGl2 ZU9mRnJhbWUodWludDYKICNpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKFdJTikKICAgICBS ZXRhaW5QdHI8Q0ZEYXRhUmVmPiBkYXRhOwogICAgIGlmIChXZWJGcmFtZSogZnJhbWUgPSBXZWJQ cm9jZXNzOjpzaGFyZWQoKS53ZWJGcmFtZShmcmFtZUlEKSkgewotICAgICAgICBpZiAoUmVmUHRy PExlZ2FjeVdlYkFyY2hpdmU+IGFyY2hpdmUgPSBMZWdhY3lXZWJBcmNoaXZlOjpjcmVhdGUoZnJh bWUtPmNvcmVGcmFtZSgpKSkgeworICAgICAgICBpZiAoUmVmUHRyPExlZ2FjeVdlYkFyY2hpdmU+ IGFyY2hpdmUgPSBMZWdhY3lXZWJBcmNoaXZlOjpjcmVhdGUoZnJhbWUtPmNvcmVGcmFtZSgpLT5k b2N1bWVudCgpKSkgewogICAgICAgICAgICAgaWYgKChkYXRhID0gYXJjaGl2ZS0+cmF3RGF0YVJl cHJlc2VudGF0aW9uKCkpKQogICAgICAgICAgICAgICAgIGRhdGFSZWZlcmVuY2UgPSBDb3JlSVBD OjpEYXRhUmVmZXJlbmNlKENGRGF0YUdldEJ5dGVQdHIoZGF0YS5nZXQoKSksIENGRGF0YUdldExl bmd0aChkYXRhLmdldCgpKSk7CiAgICAgICAgIH0K